Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/129312/?format=api
{ "id": 129312, "url": "https://patches.dpdk.org/api/patches/129312/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20230705180233.880203-2-kamalakshitha.aligeri@arm.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230705180233.880203-2-kamalakshitha.aligeri@arm.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20230705180233.880203-2-kamalakshitha.aligeri@arm.com", "date": "2023-07-05T18:02:33", "name": "[v11,2/2] net/i40e: replace put function", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "64fd22c650b60b4893655c8bd21ef6cf6bb28df7", "submitter": { "id": 2887, "url": "https://patches.dpdk.org/api/people/2887/?format=api", "name": "Kamalakshitha Aligeri", "email": "kamalakshitha.aligeri@arm.com" }, "delegate": { "id": 1, "url": "https://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20230705180233.880203-2-kamalakshitha.aligeri@arm.com/mbox/", "series": [ { "id": 28844, "url": "https://patches.dpdk.org/api/series/28844/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=28844", "date": "2023-07-05T18:02:32", "name": "[v11,1/2] mempool cache: add zero-copy get and put functions", "version": 11, "mbox": "https://patches.dpdk.org/series/28844/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/129312/comments/", "check": "fail", "checks": "https://patches.dpdk.org/api/patches/129312/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id B37FD42DDB;\n\tWed, 5 Jul 2023 20:02:54 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 8DE1142D4D;\n\tWed, 5 Jul 2023 20:02:48 +0200 (CEST)", "from foss.arm.com (foss.arm.com [217.140.110.172])\n by mails.dpdk.org (Postfix) with ESMTP id 904DA4021F\n for <dev@dpdk.org>; Wed, 5 Jul 2023 20:02:45 +0200 (CEST)", "from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])\n by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 2ECEA176A;\n Wed, 5 Jul 2023 11:03:27 -0700 (PDT)", "from ampere-altra-2-2.usa.Arm.com (unknown [10.118.91.160])\n by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 0234D3F762;\n Wed, 5 Jul 2023 11:02:45 -0700 (PDT)" ], "From": "Kamalakshitha Aligeri <kamalakshitha.aligeri@arm.com>", "To": "honnappa.nagarahalli@arm.com, bruce.richardson@intel.com,\n beilei.xing@intel.com, Ruifeng.Wang@arm.com, Feifei.Wang2@arm.com,\n mb@smartsharesystems.com, konstantin.ananyev@huawei.com,\n thomas@monjalon.net, olivier.matz@6wind.com, andrew.rybchenko@oktetlabs.ru", "Cc": "dev@dpdk.org, nd@arm.com,\n Kamalakshitha Aligeri <kamalakshitha.aligeri@arm.com>,\n Ruifeng Wang <ruifeng.wang@arm.com>, Feifei Wang <feifei.wang2@arm.com>", "Subject": "[PATCH v11 2/2] net/i40e: replace put function", "Date": "Wed, 5 Jul 2023 18:02:33 +0000", "Message-Id": "<20230705180233.880203-2-kamalakshitha.aligeri@arm.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20230705180233.880203-1-kamalakshitha.aligeri@arm.com>", "References": "<20230224181059.338206-2-kamalakshitha.aligeri@arm.com>\n <20230705180233.880203-1-kamalakshitha.aligeri@arm.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Integrated zero-copy put API in mempool cache in i40e PMD.\nOn Ampere Altra server, l3fwd single core's performance improves by 5%\nwith the new API\n\nSigned-off-by: Kamalakshitha Aligeri <kamalakshitha.aligeri@arm.com>\nReviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>\nReviewed-by: Feifei Wang <feifei.wang2@arm.com>\n---\n drivers/net/i40e/i40e_rxtx_vec_common.h | 27 ++++++++++++++++++++-----\n 1 file changed, 22 insertions(+), 5 deletions(-)\n\n--\n2.25.1", "diff": "diff --git a/drivers/net/i40e/i40e_rxtx_vec_common.h b/drivers/net/i40e/i40e_rxtx_vec_common.h\nindex fe1a6ec75e..35cdb31b2e 100644\n--- a/drivers/net/i40e/i40e_rxtx_vec_common.h\n+++ b/drivers/net/i40e/i40e_rxtx_vec_common.h\n@@ -95,18 +95,35 @@ i40e_tx_free_bufs(struct i40e_tx_queue *txq)\n\n \tn = txq->tx_rs_thresh;\n\n-\t /* first buffer to free from S/W ring is at index\n-\t * tx_next_dd - (tx_rs_thresh-1)\n-\t */\n+\t/* first buffer to free from S/W ring is at index\n+\t * tx_next_dd - (tx_rs_thresh-1)\n+\t */\n \ttxep = &txq->sw_ring[txq->tx_next_dd - (n - 1)];\n\n \tif (txq->offloads & RTE_ETH_TX_OFFLOAD_MBUF_FAST_FREE) {\n+\t\tstruct rte_mempool *mp = txep[0].mbuf->pool;\n+\t\tstruct rte_mempool_cache *cache = rte_mempool_default_cache(mp, rte_lcore_id());\n+\t\tvoid **cache_objs;\n+\n+\t\tif (unlikely(!cache))\n+\t\t\tgoto fallback;\n+\n+\t\tcache_objs = rte_mempool_cache_zc_put_bulk(cache, mp, n);\n+\t\tif (unlikely(!cache_objs))\n+\t\t\tgoto fallback;\n+\n \t\tfor (i = 0; i < n; i++) {\n-\t\t\tfree[i] = txep[i].mbuf;\n+\t\t\tcache_objs[i] = txep[i].mbuf;\n \t\t\t/* no need to reset txep[i].mbuf in vector path */\n \t\t}\n-\t\trte_mempool_put_bulk(free[0]->pool, (void **)free, n);\n \t\tgoto done;\n+\n+fallback:\n+\t\tfor (i = 0; i < n; i++)\n+\t\t\tfree[i] = txep[i].mbuf;\n+\t\trte_mempool_generic_put(mp, (void **)free, n, cache);\n+\t\tgoto done;\n+\n \t}\n\n \tm = rte_pktmbuf_prefree_seg(txep[0].mbuf);\n", "prefixes": [ "v11", "2/2" ] }