Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/129261/?format=api
{ "id": 129261, "url": "https://patches.dpdk.org/api/patches/129261/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20230704214339.244271-1-mattias.ronnblom@ericsson.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230704214339.244271-1-mattias.ronnblom@ericsson.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20230704214339.244271-1-mattias.ronnblom@ericsson.com", "date": "2023-07-04T21:43:39", "name": "service: avoid worker lcore exit deadlock", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "f012a6ad59ee9ec7ae679fbcd91aa1c8ff453985", "submitter": { "id": 1077, "url": "https://patches.dpdk.org/api/people/1077/?format=api", "name": "Mattias Rönnblom", "email": "mattias.ronnblom@ericsson.com" }, "delegate": { "id": 1, "url": "https://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20230704214339.244271-1-mattias.ronnblom@ericsson.com/mbox/", "series": [ { "id": 28814, "url": "https://patches.dpdk.org/api/series/28814/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=28814", "date": "2023-07-04T21:43:39", "name": "service: avoid worker lcore exit deadlock", "version": 1, "mbox": "https://patches.dpdk.org/series/28814/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/129261/comments/", "check": "fail", "checks": "https://patches.dpdk.org/api/patches/129261/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id CDFCE42DAB;\n\tTue, 4 Jul 2023 23:49:55 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 738A840A4B;\n\tTue, 4 Jul 2023 23:49:55 +0200 (CEST)", "from EUR05-VI1-obe.outbound.protection.outlook.com\n (mail-vi1eur05on2076.outbound.protection.outlook.com [40.107.21.76])\n by mails.dpdk.org (Postfix) with ESMTP id 5EA5A406B7;\n Tue, 4 Jul 2023 23:49:53 +0200 (CEST)", "from AS9PR06CA0214.eurprd06.prod.outlook.com (2603:10a6:20b:45e::19)\n by PR3PR07MB8291.eurprd07.prod.outlook.com (2603:10a6:102:17e::14)\n with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6544.24; Tue, 4 Jul\n 2023 21:49:52 +0000", "from AM0EUR02FT054.eop-EUR02.prod.protection.outlook.com\n (2603:10a6:20b:45e:cafe::c6) by AS9PR06CA0214.outlook.office365.com\n (2603:10a6:20b:45e::19) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6565.18 via Frontend\n Transport; Tue, 4 Jul 2023 21:49:52 +0000", "from oa.msg.ericsson.com (192.176.1.74) by\n AM0EUR02FT054.mail.protection.outlook.com (10.13.55.248) with Microsoft SMTP\n Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id\n 15.20.6565.18 via Frontend Transport; Tue, 4 Jul 2023 21:49:51 +0000", "from ESESBMB505.ericsson.se (153.88.183.172) by\n ESESSMB501.ericsson.se (153.88.183.162) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id\n 15.1.2507.27; Tue, 4 Jul 2023 23:49:51 +0200", "from seliicinfr00049.seli.gic.ericsson.se (153.88.183.153) by\n smtp.internal.ericsson.com (153.88.183.188) with Microsoft SMTP Server id\n 15.1.2507.27 via Frontend Transport; Tue, 4 Jul 2023 23:49:51 +0200", "from breslau.. (seliicwb00002.seli.gic.ericsson.se [10.156.25.100])\n by seliicinfr00049.seli.gic.ericsson.se (Postfix) with ESMTP id\n 6DF03380061; Tue, 4 Jul 2023 23:49:51 +0200 (CEST)" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=EFCdHeznpV/dcSeaN7JGI547Ev74nHZ8EzyiMpbLCj1osO7ebp2IjQh1pSAUuMG/j+dPHR4ETVHIQEf7SfxTA2kJKU2PTsydXWheD0Jhp8ht6r2Uge83b6CSD6xjJkBZcixXqWCci0t9UMXgRLZQ/i+eBwZEATcfA+TrSgy7S7yJjtKQZqsK+5lwMk+Hhl6LkRChkalskz80wRe1Fh4xmVG19c362J07PikFrnUYb1JpWLV1QMWEVRo3Lch8gAhGw1j0mhSye4jkXZwJeJYJfExbs/UXUtXNjdEIbney9XsbQmePuKnjCHkPUsglHuNH/WqTj47v6FaEaiawP/H9FA==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=niZXTGS6L0EyGe/DU5WtpHT4uUh1OdsQSzJRUvb+bos=;\n b=CR+vAAf0nU0zWFNB9E6Eihr+dWDkl/YxFK3HAUxGfIZSnVYpkfkdQ2rIQ1DAE0oHzx1DqMQe6s3wt/Et5HzCUR2KtkjxJB235j9V7ujHf27L7tcgpgFpdocO3zhKETb90OKeCZspXX+RE+BVtPTbfYyty7DqV2t3wtFoZMeLppPL0e8MtMp5b7W4yW7DDAuEgQUtScGAkEE8fTJ+8ueXTHo7gXdF52k2yx/l2908LCx9YNWkiErYlv9oeV8R6nCp8c2W6WqQiQX6+wrvaTnhZCLnkqfc3kPrtlCDIFww965g4q2FTpQDaxp8be7JnqXI+p3eiacuUR7MTrFyM5PVLQ==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass (sender ip is\n 192.176.1.74) smtp.rcpttodomain=dpdk.org smtp.mailfrom=ericsson.com;\n dmarc=pass (p=reject sp=reject pct=100) action=none header.from=ericsson.com;\n dkim=none (message not signed); arc=none", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=ericsson.com;\n s=selector1;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=niZXTGS6L0EyGe/DU5WtpHT4uUh1OdsQSzJRUvb+bos=;\n b=P8njRmg+dL0w6BGu9cuLbmYaw2gyCZ23Dg8sgDBXi4gjsoNf0Kgha3SmY/grXS05r0rwYCnXNIlrRrJ7JZwqRw/4C5ZuBYqepE4cNgdTqeFscEs32MNHpUJ8821C+XfnT2f/FTo/Z58uWbNBluCE+FxT/Kmbyn3xh2RhldBOO0M=", "X-MS-Exchange-Authentication-Results": "spf=pass (sender IP is 192.176.1.74)\n smtp.mailfrom=ericsson.com; dkim=none (message not signed)\n header.d=none;dmarc=pass action=none header.from=ericsson.com;", "Received-SPF": "Pass (protection.outlook.com: domain of ericsson.com designates\n 192.176.1.74 as permitted sender)\n receiver=protection.outlook.com;\n client-ip=192.176.1.74; helo=oa.msg.ericsson.com; pr=C", "From": "=?utf-8?q?Mattias_R=C3=B6nnblom?= <mattias.ronnblom@ericsson.com>", "To": "Harry van Haaren <harry.van.haaren@intel.com>, Stephen Hemminger\n <stephen@networkplumber.org>", "CC": "<hofors@lysator.liu.se>, <dev@dpdk.org>,\n Suanming Mou <suanmingm@nvidia.com>, <thomas@monjalon.net>,\n <david.marchand@redhat.com>,\n =?utf-8?q?Mattias_R=C3=B6nnblom?= <mattias.ronnblom@ericsson.com>,\n <stable@dpdk.org>", "Subject": "[PATCH] service: avoid worker lcore exit deadlock", "Date": "Tue, 4 Jul 2023 23:43:39 +0200", "Message-ID": "<20230704214339.244271-1-mattias.ronnblom@ericsson.com>", "X-Mailer": "git-send-email 2.34.1", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"UTF-8\"", "Content-Transfer-Encoding": "8bit", "X-EOPAttributedMessage": "0", "X-MS-PublicTrafficType": "Email", "X-MS-TrafficTypeDiagnostic": "AM0EUR02FT054:EE_|PR3PR07MB8291:EE_", "X-MS-Office365-Filtering-Correlation-Id": "18a36844-f9a2-45d9-cb42-08db7cd898b0", "X-MS-Exchange-SenderADCheck": "1", "X-MS-Exchange-AntiSpam-Relay": "0", "X-Microsoft-Antispam": "BCL:0;", "X-Microsoft-Antispam-Message-Info": "\n QxrNU7iFd9h0krHkRRCxMYDQ0FtiFZRJZVz6mjUgjpMCgWUbviseeytdX4wZCWggHAlNypuPJn1SD39x6p9gpuRGth5Q/Rngt66sUt6aifdq5wD+7wVYlPgQHoRc9lEzkI2dGeBQED6vLI4nDEoodqpmBZc0wsy/hoMQ6tPqpne3AgMmHCT/xlKjX0ahoiPTTlDQU8NShdBUWIjsNwGqf41izu0t4QMpW2WSH9BhLQBexnjb1UsU4fFhfPR3Jwp2pR/o2vHGKHLIqGqaf1Wk2wkA83S3J+HMclb0MKVKFuLRBbmqjMBKPoT4cCBRILkrkYUb7eWdhP5U4la0LEp/nuXaHMI0gGSVUF40wtbzrEMtHT1+hQgtbvqFcSF1oSZ92hHj/OfJVDNpq0lHRBHiWKxDcHrLveLO2sz/KdMw+0xGCs0czqlOklyLgJg2OCgkyx3QEd3okQ2yaU+aczOviCzb2usQNtXwrynjxEFT9nyzdbsXceJUa1pDb/69PeSzUrzjsCJik0yp8+mDWVqZWj+8Re9HRjO258yOOtShCzTlz4pygHHblLjuvNFMICkrEGtj7u/xSqEUFvSNIEUKI8iOB35VsnqMCFiQA4xdWGewNhcqyQf1+miS5wudXj0xXY8BFTSlwpNIQ/20TQRUIrSJx3qQqwzMuLVOz1i6cPFFyhChbMzbJZMecK1AlZbavpdzjyXAVCjxljeDSol6AVzOxdstjhFOzLwr0R5ErmEmZuo9JNbK5R34phXHEPf4mQgE6TiyKfC0BLQ7obq5ElIoBgZh84AbxDjcI12neEg=", "X-Forefront-Antispam-Report": "CIP:192.176.1.74; CTRY:SE; LANG:en; SCL:1; SRV:;\n IPV:NLI; SFV:NSPM; H:oa.msg.ericsson.com; PTR:office365.se.ericsson.net;\n CAT:NONE;\n SFS:(13230028)(4636009)(136003)(39860400002)(396003)(376002)(346002)(451199021)(40470700004)(36840700001)(46966006)(1076003)(40480700001)(82960400001)(82740400003)(356005)(7636003)(40460700003)(6266002)(316002)(4326008)(70586007)(70206006)(36860700001)(2616005)(47076005)(336012)(83380400001)(82310400005)(186003)(26005)(478600001)(110136005)(54906003)(2906002)(8936002)(8676002)(36756003)(5660300002)(86362001)(41300700001)(6666004);\n DIR:OUT; SFP:1101;", "X-OriginatorOrg": "ericsson.com", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "04 Jul 2023 21:49:51.8935 (UTC)", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n 18a36844-f9a2-45d9-cb42-08db7cd898b0", "X-MS-Exchange-CrossTenant-Id": "92e84ceb-fbfd-47ab-be52-080c6b87953f", "X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp": "\n TenantId=92e84ceb-fbfd-47ab-be52-080c6b87953f; Ip=[192.176.1.74];\n Helo=[oa.msg.ericsson.com]", "X-MS-Exchange-CrossTenant-AuthSource": "\n AM0EUR02FT054.eop-EUR02.prod.protection.outlook.com", "X-MS-Exchange-CrossTenant-AuthAs": "Anonymous", "X-MS-Exchange-CrossTenant-FromEntityHeader": "HybridOnPrem", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "PR3PR07MB8291", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Reply-To": "20230629203720.682f90c3@hermes.local", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Calling rte_exit() from a worker lcore thread causes a deadlock in\nrte_service_finalize().\n\nThis patch makes rte_service_finalize() deadlock-free by avoiding the\nneed to synchronize with service lcore threads, which in turn is\nachieved by moving service and per-lcore state from the heap to being\nstatically allocated.\n\nThe BSS segment increases with ~156 kB (on x86_64 with default\nRTE_MAX_LCORE and RTE_SERVICE_NUM_MAX).\n\nAccording to the service perf autotest, this change also results in a\nslight reduction of service framework overhead.\n\nFixes: 33666b448f15 (\"service: fix crash on exit\")\nCc: harry.van.haaren@intel.com\nCc: stable@dpdk.org\n\nSigned-off-by: Mattias Rönnblom <mattias.ronnblom@ericsson.com>\n---\n lib/eal/common/rte_service.c | 28 ++--------------------------\n 1 file changed, 2 insertions(+), 26 deletions(-)", "diff": "diff --git a/lib/eal/common/rte_service.c b/lib/eal/common/rte_service.c\nindex 94e872a08a..2ea0c0c0d9 100644\n--- a/lib/eal/common/rte_service.c\n+++ b/lib/eal/common/rte_service.c\n@@ -15,7 +15,6 @@\n #include <rte_common.h>\n #include <rte_cycles.h>\n #include <rte_atomic.h>\n-#include <rte_malloc.h>\n #include <rte_spinlock.h>\n #include <rte_trace_point.h>\n \n@@ -74,8 +73,8 @@ struct core_state {\n } __rte_cache_aligned;\n \n static uint32_t rte_service_count;\n-static struct rte_service_spec_impl *rte_services;\n-static struct core_state *lcore_states;\n+static struct rte_service_spec_impl rte_services[RTE_SERVICE_NUM_MAX];\n+static struct core_state lcore_states[RTE_MAX_LCORE];\n static uint32_t rte_service_library_initialized;\n \n int32_t\n@@ -93,21 +92,6 @@ rte_service_init(void)\n \t\treturn -EALREADY;\n \t}\n \n-\trte_services = rte_calloc(\"rte_services\", RTE_SERVICE_NUM_MAX,\n-\t\t\tsizeof(struct rte_service_spec_impl),\n-\t\t\tRTE_CACHE_LINE_SIZE);\n-\tif (!rte_services) {\n-\t\tRTE_LOG(ERR, EAL, \"error allocating rte services array\\n\");\n-\t\tgoto fail_mem;\n-\t}\n-\n-\tlcore_states = rte_calloc(\"rte_service_core_states\", RTE_MAX_LCORE,\n-\t\t\tsizeof(struct core_state), RTE_CACHE_LINE_SIZE);\n-\tif (!lcore_states) {\n-\t\tRTE_LOG(ERR, EAL, \"error allocating core states array\\n\");\n-\t\tgoto fail_mem;\n-\t}\n-\n \tint i;\n \tstruct rte_config *cfg = rte_eal_get_configuration();\n \tfor (i = 0; i < RTE_MAX_LCORE; i++) {\n@@ -120,10 +104,6 @@ rte_service_init(void)\n \n \trte_service_library_initialized = 1;\n \treturn 0;\n-fail_mem:\n-\trte_free(rte_services);\n-\trte_free(lcore_states);\n-\treturn -ENOMEM;\n }\n \n void\n@@ -133,10 +113,6 @@ rte_service_finalize(void)\n \t\treturn;\n \n \trte_service_lcore_reset_all();\n-\trte_eal_mp_wait_lcore();\n-\n-\trte_free(rte_services);\n-\trte_free(lcore_states);\n \n \trte_service_library_initialized = 0;\n }\n", "prefixes": [] }