Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/129218/?format=api
{ "id": 129218, "url": "https://patches.dpdk.org/api/patches/129218/?format=api", "web_url": "https://patches.dpdk.org/project/dts/patch/20230703192542.36809-3-niklas.soderlund@corigine.com/", "project": { "id": 3, "url": "https://patches.dpdk.org/api/projects/3/?format=api", "name": "DTS", "link_name": "dts", "list_id": "dts.dpdk.org", "list_email": "dts@dpdk.org", "web_url": "", "scm_url": "git://dpdk.org/tools/dts", "webscm_url": "http://git.dpdk.org/tools/dts/", "list_archive_url": "https://inbox.dpdk.org/dts", "list_archive_url_format": "https://inbox.dpdk.org/dts/{}", "commit_url_format": "" }, "msgid": "<20230703192542.36809-3-niklas.soderlund@corigine.com>", "list_archive_url": "https://inbox.dpdk.org/dts/20230703192542.36809-3-niklas.soderlund@corigine.com", "date": "2023-07-03T19:25:42", "name": "[2/2] tests/speed_capabilities: optimize code sequence of test case", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "41bc965bd845f9c23d23656f986cfd600d4afe56", "submitter": { "id": 2665, "url": "https://patches.dpdk.org/api/people/2665/?format=api", "name": "Niklas Söderlund", "email": "niklas.soderlund@corigine.com" }, "delegate": null, "mbox": "https://patches.dpdk.org/project/dts/patch/20230703192542.36809-3-niklas.soderlund@corigine.com/mbox/", "series": [ { "id": 28791, "url": "https://patches.dpdk.org/api/series/28791/?format=api", "web_url": "https://patches.dpdk.org/project/dts/list/?series=28791", "date": "2023-07-03T19:25:40", "name": "tests/speed_capabilities: Document and convert to a common speed unit", "version": 1, "mbox": "https://patches.dpdk.org/series/28791/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/129218/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/129218/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dts-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 98F9142DC7;\n\tMon, 3 Jul 2023 21:26:21 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 16FC842C54;\n\tMon, 3 Jul 2023 21:26:21 +0200 (CEST)", "from NAM11-BN8-obe.outbound.protection.outlook.com\n (mail-bn8nam11on2100.outbound.protection.outlook.com [40.107.236.100])\n by mails.dpdk.org (Postfix) with ESMTP id 7E38A40ED5\n for <dts@dpdk.org>; Mon, 3 Jul 2023 21:26:19 +0200 (CEST)", "from BY3PR13MB4804.namprd13.prod.outlook.com (2603:10b6:a03:355::13)\n by MW5PR13MB5464.namprd13.prod.outlook.com (2603:10b6:303:191::11)\n with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6544.24; Mon, 3 Jul\n 2023 19:26:18 +0000", "from BY3PR13MB4804.namprd13.prod.outlook.com\n ([fe80::5ae7:eda4:3881:4f4f]) by BY3PR13MB4804.namprd13.prod.outlook.com\n ([fe80::5ae7:eda4:3881:4f4f%4]) with mapi id 15.20.6544.024; Mon, 3 Jul 2023\n 19:26:18 +0000" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=IZTtuR1L0ez1tpCzXEtx6bbH1Lf9fh9DOtB1JXi27wH/oo7Ns8/DwTf8uug6Q+rcpKLjTRo8o8Ts+/4RCN3HieHPLp+UoLceoj61mws5I7rJWVHMgCFfqT65QLZPOewG1LGHhhSBqzemswLGHoEJ7ia3Vg6cXfjnF5qlUGeONMs4db2EfeLeogEBbc7S11FT8/TD7qBdg7zxm6Xx8XsWcwmH1MNjjFlOK+KP5eggi0lssbva3ISuO29bM0I24B5qDuN+rH/44zbK0/cf4XvjTbB5BukaJ59nARnHzSsz1z+eRvJp11Wl7IxgIBueUP0LAC53O7cpyh94NMGOOVblSg==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=wqPXvQh42E9X3Cf6hn+eD98hd0NVlZCHH61Yo2t6IB0=;\n b=n+cTdDVoh+JikcP7RheaFKuSe9+0wYuK0iCGfjwyrz9jmkX8Yuw4DDO2hZ9I3LQ7pq1kzi7p8qXre/G2lDq6E7Y2NFyPA1Ax62H3jDGHgCrqf+sc4NnYgRSbdjJ5I7cfPu6cd6JvL9H2u+lzUrW0HpwsNvF2aT3IHsSfiUqwwClqf6Z2J3ac2twUImhnMZ5/72xg7/I5SnfRHWFtzBB5Qa8zHKlaOdZbAyiMZbqg5k0MY0bfICW5M4Fvz9MDNiDpqYsXVUfDzCBq9BJlbray7mJ5mdWoCyv0iH5WOCjQisMgYTQEm1eNfR3yVU+65qsmCOYQrA63dHNwfPzoNKSDkQ==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass\n smtp.mailfrom=corigine.com; dmarc=pass action=none header.from=corigine.com;\n dkim=pass header.d=corigine.com; arc=none", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=corigine.onmicrosoft.com; s=selector2-corigine-onmicrosoft-com;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=wqPXvQh42E9X3Cf6hn+eD98hd0NVlZCHH61Yo2t6IB0=;\n b=BH2vheoolJvuXxJSFJNPo1ptt1jRcZC1ZhxtEcSuiFUxmrqNk10XBH6ZLG+i21+qsa5ozFEQ8F04sS7qqBeqOaEyEjw50AKx1KsEJoLL0cyzCV123GevtULaBDOJPc3VS5fbl2e/s0BIoIOC2yMHIxuc5LaxxgMfCpc61QzuIjU=", "Authentication-Results": "dkim=none (message not signed)\n header.d=none;dmarc=none action=none header.from=corigine.com;", "From": "=?utf-8?q?Niklas_S=C3=B6derlund?= <niklas.soderlund@corigine.com>", "To": "dts@dpdk.org", "Cc": "oss-drivers@corigine.com, Qin Ke <qin.ke@corigine.com>, =?utf-8?q?Niklas?=\n\t=?utf-8?q?_S=C3=B6derlund?= <niklas.soderlund@corigine.com>", "Subject": "[PATCH 2/2] tests/speed_capabilities: optimize code sequence of test\n case", "Date": "Mon, 3 Jul 2023 21:25:42 +0200", "Message-ID": "<20230703192542.36809-3-niklas.soderlund@corigine.com>", "X-Mailer": "git-send-email 2.41.0", "In-Reply-To": "<20230703192542.36809-1-niklas.soderlund@corigine.com>", "References": "<20230703192542.36809-1-niklas.soderlund@corigine.com>", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-ClientProxiedBy": "BE1P281CA0095.DEUP281.PROD.OUTLOOK.COM\n (2603:10a6:b10:79::10) To BY3PR13MB4804.namprd13.prod.outlook.com\n (2603:10b6:a03:355::13)", "MIME-Version": "1.0", "X-MS-PublicTrafficType": "Email", "X-MS-TrafficTypeDiagnostic": "BY3PR13MB4804:EE_|MW5PR13MB5464:EE_", "X-MS-Office365-Filtering-Correlation-Id": "fcd41035-e82c-4351-cf92-08db7bfb5fe8", "X-MS-Exchange-SenderADCheck": "1", "X-MS-Exchange-AntiSpam-Relay": "0", "X-Microsoft-Antispam": "BCL:0;", "X-Microsoft-Antispam-Message-Info": "\n x6xLQpUBRSTsl0iM1kEvkKxMHBUZE1Y/f1dZSnm5uqxKSAlTmvgOhS3h7fK8JXer0EuJa0+Tu6clf/278P1ErxpWEztBD1+Z65k4uLAiWbL4cQanLkdCxKv5WNabTFLCPnQJfPglzqbqfQTkzVSVrHbrnPtnz/H+QJIp3EMy7510vqEACeBD/uBsMoICj0n5LpKy9wutMwap83JbSu8FENdgNeRvxxqLiFsGexqIQ+AB3QuRhQgkovuGjb+YK6ikZrH8mLsH/cx7j4WZyLlEQK0YmO59cSgIOPB7OMRyHCy7uEQoYhwEaraCzF2GJmeAmRwBETKXPzoJtdShYE/VQlWV+V/A50AtvVCeYhtWPldxOkVxIk3+h4c8sj4VdCjgKitQeKQBT2potwqy8onp9WCUbgJUfafgQatnPF6SOdanQbnr+oRZGed/POyW5qmsTQ/POWwT/AU0Vllf5wm3glf3GzRqMLQFZ3JEJQsQfJPDPgesPGvuOL3ggg1qxMpWgt5uN0moo7SqmQx0gUt8tZnQ5aTEWXL1vOMM8mvNuhKId0PIC8TNMksr7E0nPoeOOaLP1S1UxCZFpMHHXTGnbYP8UMs0x6AurvU6k/OIw9nqBxPuB9/uVUq0nLxhrIZO", "X-Forefront-Antispam-Report": "CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;\n IPV:NLI; SFV:NSPM; H:BY3PR13MB4804.namprd13.prod.outlook.com; PTR:; CAT:NONE;\n SFS:(13230028)(4636009)(396003)(376002)(39840400004)(136003)(346002)(366004)(451199021)(54906003)(2906002)(478600001)(26005)(41300700001)(6666004)(6486002)(86362001)(36756003)(52116002)(8936002)(8676002)(5660300002)(316002)(6512007)(66946007)(66556008)(66476007)(38350700002)(4326008)(38100700002)(6916009)(1076003)(6506007)(2616005)(186003)(66574015)(83380400001)(107886003);\n DIR:OUT; SFP:1102;", "X-MS-Exchange-AntiSpam-MessageData-ChunkCount": "1", "X-MS-Exchange-AntiSpam-MessageData-0": "=?utf-8?q?t4bWh1IEkpBE+g3KAAs2hHS2c+5X?=\n\t=?utf-8?q?8z3MT51/x5gntUnGzFYBSPLshL9yd7h2lBY+qmRKuWPNYuZ9Xr9CKDZnXiV5OS/xQ?=\n\t=?utf-8?q?ogQIWdbAOLkwynQIQeFrK0rvfcmpJu2Jc/vqo7MCfiJnQ9ODsaeHMaSnsZRbNW3Oh?=\n\t=?utf-8?q?9GfOSwMw4R6y8HUZfTutF/Hd2uETflVCE2l3d7eAB6zmYFaPPHWXXYR4S80bCSqQy?=\n\t=?utf-8?q?A7rrciF5T/WLk824CEzKKoozqoxSO/p8x5UsjTIpTrQ+CdEgVZvQQIoUzGB/ooiXH?=\n\t=?utf-8?q?FpcR4u7TK3ImbcxBO4lQBqDgbKHoADi6STOotxqxvAkHFeQjnTVPNShPNkNouwkkf?=\n\t=?utf-8?q?5Ancsrs/u+WaFqGAlY22rP4/mSBgHxX/hwMwxjigfTgbReStAcgGloAFw29KfKR4u?=\n\t=?utf-8?q?62GbNtq2E0ng27MBKNgZyZJBiZXaLlL9Uu8p7R5jC9UW4+hoVO4t2L/ze4c7pKflx?=\n\t=?utf-8?q?bHXZBptJA9DtywqGE4XfqXXABh39HLp0dkWMo/7DNe9HnMXyq/K99Rv3YTP4AXsm4?=\n\t=?utf-8?q?jv/j7agc/KUh3IgPwFv2vDQfj65VkcdtRqlJEQ0VFo2l2TFhDIIUJifI6h9qzABdx?=\n\t=?utf-8?q?9gtj7ztRrEy4A+XIGslMfp8ZrW9Qij9a5ECFQ5PcpRsJcTp+40/VELL4S/WUqHOz6?=\n\t=?utf-8?q?vEkzQuTKtvN9YdjN6nCusRSSQYjOl85QCrT31YXxKDDyMjitDDrrKRIZQay37SBPE?=\n\t=?utf-8?q?S2J57lxAFLGapPYbU3nhyahLwcHDhMw8/2SkrQ59ay3995CeaTacfIlqj2/Fii2Ud?=\n\t=?utf-8?q?9+33mVQwYb5x86r2pWagImDRCvW/4mA2jcSWJsD9Uh0dXnmGY2seojLVynMG4+GOz?=\n\t=?utf-8?q?oYg7Xb1uOCR4qtsrALBJsv5w2BfZ1Y2z73Tjxn6LampS7PKjxfGYI3Q2JY1Vk13lT?=\n\t=?utf-8?q?jGRwgiOTgSWvXTc0GUrGQKSm6S95jO/IjMU1B+6ZdDcA0m81TVr8qrLNdZqe4EdF3?=\n\t=?utf-8?q?EcQcE2A0pzoOog/+B2tpOCUPctoxXdzc8SNjvGvyCMHj7M/mX1KA1sSsoihlVti/I?=\n\t=?utf-8?q?vCN3vYQG3ZTZHaEFSoz5UOicntv1C6s/wdhhfMmaux8swZpkqJ5P3hYQIda2Rt76/?=\n\t=?utf-8?q?IfNSNpkD9Nq/k1LU84vT3ogu2ej2r9SWzEbvEFCwYf1dtVpMEdiW3N4GnrquPskoZ?=\n\t=?utf-8?q?L8MAGZLouptEZQY6fdLKbJT79xui3oZe7o2zVOICA3dx659V/32/uLorW21GlbaJX?=\n\t=?utf-8?q?30tbVUu4Ar/CCLFiJqNQKHwjcI9wzzg6i4NGEYbVEVPmfoCwGayooX2jX9CWfwSZi?=\n\t=?utf-8?q?Bg34yYjyA7MIgR5f0XjlfZlTIVpUyxOvjEJgtBUXXcDqbRctkGBqOsnTqK/Lzdu3h?=\n\t=?utf-8?q?vCPSPOTT6i6HWTKXA2jM7lrhxqcqho6vz6MAZkugqmwkYIbc9LB0bhc1SD9003Ork?=\n\t=?utf-8?q?5A0u3ZyE6M5jhoVFbduhttj17mQfcWP8Fm9AKA+6b9bEuVdbPXICqyr604uPGQIS1?=\n\t=?utf-8?q?psok+bgbCnQXlbwnNUyVYiQL4h1kCt8iP91lG7BwHQyLY0eeCb5HYvhKH9jfIBWrp?=\n\t=?utf-8?q?SjQ0RAuW4Jb1WEtlNM/7Dmp5+l4BK+/neA=3D=3D?=", "X-OriginatorOrg": "corigine.com", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n fcd41035-e82c-4351-cf92-08db7bfb5fe8", "X-MS-Exchange-CrossTenant-AuthSource": "BY3PR13MB4804.namprd13.prod.outlook.com", "X-MS-Exchange-CrossTenant-AuthAs": "Internal", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "03 Jul 2023 19:26:18.0667 (UTC)", "X-MS-Exchange-CrossTenant-FromEntityHeader": "Hosted", "X-MS-Exchange-CrossTenant-Id": "fe128f2c-073b-4c20-818e-7246a585940c", "X-MS-Exchange-CrossTenant-MailboxType": "HOSTED", "X-MS-Exchange-CrossTenant-UserPrincipalName": "\n uZqeWgbhwANoNKpYoe1ZfRG9zo4refRjnRRhSvRONU6RAVAR6tzaQQobcTNeTYBzSMLyxD1BQYymWOXh7ZOl9AThtOCB3FL2/C3Y2M31QDs=", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "MW5PR13MB5464", "X-BeenThere": "dts@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "test suite reviews and discussions <dts.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dts>,\n <mailto:dts-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dts/>", "List-Post": "<mailto:dts@dpdk.org>", "List-Help": "<mailto:dts-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dts>,\n <mailto:dts-request@dpdk.org?subject=subscribe>", "Errors-To": "dts-bounces@dpdk.org" }, "content": "From: Qin Ke <qin.ke@corigine.com>\n\nThe verification code of interface_name and interface_speed can be\nmoved forward, it can reduce unnecessary code execution if the\nverification failed.\n\nAdjust the code sequence of related code.\n\nSigned-off-by: Qin Ke <qin.ke@corigine.com>\nReviewed-by: Niklas Söderlund <niklas.soderlund@corigine.com>\n---\n tests/TestSuite_speed_capabilities.py | 16 ++++++++--------\n 1 file changed, 8 insertions(+), 8 deletions(-)", "diff": "diff --git a/tests/TestSuite_speed_capabilities.py b/tests/TestSuite_speed_capabilities.py\nindex 3bda904e8a81..2b950a541e7c 100644\n--- a/tests/TestSuite_speed_capabilities.py\n+++ b/tests/TestSuite_speed_capabilities.py\n@@ -39,15 +39,20 @@ class TestSpeedCapabilities(TestCase):\n for port in self.ports:\n interface_name = self.tester.get_interface(self.tester.get_local_port(port))\n \n- # Gives the speed in Mb/s\n- interface_speed = self.pmdout.get_port_link_speed(port)\n-\n self.verify(\n interface_name in expected_speeds,\n f\"The interface {interface_name} does not have an expected \"\n f\"speed associated with it.\",\n )\n \n+ # Gives the speed in Mb/s\n+ interface_speed = self.pmdout.get_port_link_speed(port)\n+\n+ self.verify(\n+ len(interface_speed) > 0,\n+ f\"A valid speed could not be read for the interface {interface_name}.\",\n+ )\n+\n detected_interfaces.append(interface_name)\n \n expected_speed = expected_speeds[interface_name]\n@@ -58,11 +63,6 @@ class TestSpeedCapabilities(TestCase):\n # Removes the unit from the speed\n expected_speed = \"\".join(i for i in expected_speed if i.isdigit())\n \n- self.verify(\n- len(interface_speed) > 0,\n- f\"A valid speed could not be read for the interface {interface_name}.\",\n- )\n-\n # Converts Gb/s to Mb/s for consistent comparison\n if expected_speed_unit == \"G\":\n expected_speed += \"000\"\n", "prefixes": [ "2/2" ] }