Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/129167/?format=api
{ "id": 129167, "url": "https://patches.dpdk.org/api/patches/129167/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20230630170927.32829-1-vladimir.medvedkin@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230630170927.32829-1-vladimir.medvedkin@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20230630170927.32829-1-vladimir.medvedkin@intel.com", "date": "2023-06-30T17:09:26", "name": "[v2,1/2] hash: fix reading unaligned bits implementation", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "d63fde649b5fca7b4676c90feb0fa86057830494", "submitter": { "id": 1216, "url": "https://patches.dpdk.org/api/people/1216/?format=api", "name": "Vladimir Medvedkin", "email": "vladimir.medvedkin@intel.com" }, "delegate": { "id": 1, "url": "https://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20230630170927.32829-1-vladimir.medvedkin@intel.com/mbox/", "series": [ { "id": 28752, "url": "https://patches.dpdk.org/api/series/28752/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=28752", "date": "2023-06-30T17:09:26", "name": "[v2,1/2] hash: fix reading unaligned bits implementation", "version": 2, "mbox": "https://patches.dpdk.org/series/28752/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/129167/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/129167/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id EA81B42D98;\n\tFri, 30 Jun 2023 19:09:38 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 71EDA410FC;\n\tFri, 30 Jun 2023 19:09:38 +0200 (CEST)", "from mga01.intel.com (mga01.intel.com [192.55.52.88])\n by mails.dpdk.org (Postfix) with ESMTP id 8B90240EDB;\n Fri, 30 Jun 2023 19:09:36 +0200 (CEST)", "from fmsmga008.fm.intel.com ([10.253.24.58])\n by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 30 Jun 2023 10:09:30 -0700", "from silpixa00401176.ir.intel.com (HELO\n silpixa00401176.ger.corp.intel.com) ([10.237.222.204])\n by fmsmga008.fm.intel.com with ESMTP; 30 Jun 2023 10:09:29 -0700" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1688144976; x=1719680976;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=GsYjua5r7ri6HlIuw35cI82xdCZM+acSIyPBen5XEIk=;\n b=ahHbfV2jQ2FosHiTnU4IKl4pY0Oe1rSwsfVSh+GPheVzkW4Utb4oXYSc\n psQ1+02+Hbzqf2jbj4BryrnPfpUmSZjXs2o5gPnEab13lO58vC7YZn31w\n h5QP+UqLlX+O53g34ss3nXavhBqRSV9ksYDHsEKerTKX+/lReFZNoiJSR\n 7jhTeNB9rDN0tqoGuJMRYavPrrLp4bFzju259CVa68M/cMGKraWso51MI\n KV6bHjcZWR33OJR2GWFb/GPjqvvUFAWF30g5vuW6+eitmbrCDAIH4uVtu\n 4vcluNhbiK+hcCVvGvoCHtYJWQJodub57/1S8FGhfw+olrnWhGdQzNfIW A==;", "X-IronPort-AV": [ "E=McAfee;i=\"6600,9927,10757\"; a=\"393168800\"", "E=Sophos;i=\"6.01,171,1684825200\"; d=\"scan'208\";a=\"393168800\"", "E=McAfee;i=\"6600,9927,10757\"; a=\"783151842\"", "E=Sophos;i=\"6.01,171,1684825200\"; d=\"scan'208\";a=\"783151842\"" ], "X-ExtLoop1": "1", "From": "Vladimir Medvedkin <vladimir.medvedkin@intel.com>", "To": "dev@dpdk.org", "Cc": "konstantin.v.ananyev@yandex.ru,\n\tstable@dpdk.org", "Subject": "[PATCH v2 1/2] hash: fix reading unaligned bits implementation", "Date": "Fri, 30 Jun 2023 17:09:26 +0000", "Message-Id": "<20230630170927.32829-1-vladimir.medvedkin@intel.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20230628191219.78753-1-vladimir.medvedkin@intel.com>", "References": "<20230628191219.78753-1-vladimir.medvedkin@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Fixes: 28ebff11c2dc (\"hash: add predictable RSS\")\nCc: stable@dpdk.org\n\nAcked-by: Konstantin Ananyev <konstantin.v.ananyev@yandex.ru>\nTested-by: Konstantin Ananyev <konstantin.v.ananyev@yandex.ru>\nSigned-off-by: Vladimir Medvedkin <vladimir.medvedkin@intel.com>\n---\n lib/hash/rte_thash.c | 12 +++++++-----\n 1 file changed, 7 insertions(+), 5 deletions(-)", "diff": "diff --git a/lib/hash/rte_thash.c b/lib/hash/rte_thash.c\nindex 0249883b8d..2228af576b 100644\n--- a/lib/hash/rte_thash.c\n+++ b/lib/hash/rte_thash.c\n@@ -670,7 +670,7 @@ rte_thash_get_gfni_matrices(struct rte_thash_ctx *ctx)\n }\n \n static inline uint8_t\n-read_unaligned_byte(uint8_t *ptr, unsigned int len, unsigned int offset)\n+read_unaligned_byte(uint8_t *ptr, unsigned int offset)\n {\n \tuint8_t ret = 0;\n \n@@ -681,13 +681,14 @@ read_unaligned_byte(uint8_t *ptr, unsigned int len, unsigned int offset)\n \t\t\t(CHAR_BIT - (offset % CHAR_BIT));\n \t}\n \n-\treturn ret >> (CHAR_BIT - len);\n+\treturn ret;\n }\n \n static inline uint32_t\n read_unaligned_bits(uint8_t *ptr, int len, int offset)\n {\n \tuint32_t ret = 0;\n+\tint shift;\n \n \tlen = RTE_MAX(len, 0);\n \tlen = RTE_MIN(len, (int)(sizeof(uint32_t) * CHAR_BIT));\n@@ -695,13 +696,14 @@ read_unaligned_bits(uint8_t *ptr, int len, int offset)\n \twhile (len > 0) {\n \t\tret <<= CHAR_BIT;\n \n-\t\tret |= read_unaligned_byte(ptr, RTE_MIN(len, CHAR_BIT),\n-\t\t\toffset);\n+\t\tret |= read_unaligned_byte(ptr, offset);\n \t\toffset += CHAR_BIT;\n \t\tlen -= CHAR_BIT;\n \t}\n \n-\treturn ret;\n+\tshift = (len == 0) ? 0 :\n+\t\t(CHAR_BIT - ((len + CHAR_BIT) % CHAR_BIT));\n+\treturn ret >> shift;\n }\n \n /* returns mask for len bits with given offset inside byte */\n", "prefixes": [ "v2", "1/2" ] }