Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1290/?format=api
{ "id": 1290, "url": "https://patches.dpdk.org/api/patches/1290/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1416067424-31699-6-git-send-email-helin.zhang@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1416067424-31699-6-git-send-email-helin.zhang@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1416067424-31699-6-git-send-email-helin.zhang@intel.com", "date": "2014-11-15T16:03:41", "name": "[dpdk-dev,v6,5/8] ixgbe: implement ops of 'dev_infos_get' for PF and VF respectively", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "726711e65581ae3ecada0eac9d6f216b510d82d2", "submitter": { "id": 14, "url": "https://patches.dpdk.org/api/people/14/?format=api", "name": "Zhang, Helin", "email": "helin.zhang@intel.com" }, "delegate": null, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1416067424-31699-6-git-send-email-helin.zhang@intel.com/mbox/", "series": [], "comments": "https://patches.dpdk.org/api/patches/1290/comments/", "check": "pending", "checks": "https://patches.dpdk.org/api/patches/1290/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 45CB87FBC;\n\tSat, 15 Nov 2014 16:54:08 +0100 (CET)", "from mga01.intel.com (mga01.intel.com [192.55.52.88])\n\tby dpdk.org (Postfix) with ESMTP id 8FCDD7F80\n\tfor <dev@dpdk.org>; Sat, 15 Nov 2014 16:53:57 +0100 (CET)", "from fmsmga002.fm.intel.com ([10.253.24.26])\n\tby fmsmga101.fm.intel.com with ESMTP; 15 Nov 2014 08:04:04 -0800", "from shvmail01.sh.intel.com ([10.239.29.42])\n\tby fmsmga002.fm.intel.com with ESMTP; 15 Nov 2014 08:04:03 -0800", "from shecgisg004.sh.intel.com (shecgisg004.sh.intel.com\n\t[10.239.29.89])\n\tby shvmail01.sh.intel.com with ESMTP id sAFG40Ld022253;\n\tSun, 16 Nov 2014 00:04:00 +0800", "from shecgisg004.sh.intel.com (localhost [127.0.0.1])\n\tby shecgisg004.sh.intel.com (8.13.6/8.13.6/SuSE Linux 0.8) with ESMTP\n\tid sAFG3wDc031769; Sun, 16 Nov 2014 00:04:00 +0800", "(from hzhan75@localhost)\n\tby shecgisg004.sh.intel.com (8.13.6/8.13.6/Submit) id sAFG3w3T031765; \n\tSun, 16 Nov 2014 00:03:58 +0800" ], "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.07,391,1413270000\"; d=\"scan'208\";a=\"632472623\"", "From": "Helin Zhang <helin.zhang@intel.com>", "To": "dev@dpdk.org", "Date": "Sun, 16 Nov 2014 00:03:41 +0800", "Message-Id": "<1416067424-31699-6-git-send-email-helin.zhang@intel.com>", "X-Mailer": "git-send-email 1.7.4.1", "In-Reply-To": "<1416067424-31699-1-git-send-email-helin.zhang@intel.com>", "References": "<1415283932-20724-1-git-send-email-helin.zhang@intel.com>\n\t<1416067424-31699-1-git-send-email-helin.zhang@intel.com>", "Subject": "[dpdk-dev] [PATCH v6 5/8] ixgbe: implement ops of 'dev_infos_get'\n\tfor PF and VF respectively", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "As more and more information are different between PF and VF, ops\nof 'dev_infos_get' has been implemented respectively. In addition,\nreturning redirection table size has been supported in it.\n\nSigned-off-by: Helin Zhang <helin.zhang@intel.com>\n---\n lib/librte_pmd_ixgbe/ixgbe_ethdev.c | 90 +++++++++++++++++++++++++++++--------\n 1 file changed, 71 insertions(+), 19 deletions(-)\n\nv2 changes:\n* Added new function for ops of 'dev_infos_get' specifically for ixgbe VF.\n\nv3 changes:\n* Returning default RX/TX configurations has been added in ops of\n 'dev_infos_get' for VF, as it was added recently in that for PF.", "diff": "diff --git a/lib/librte_pmd_ixgbe/ixgbe_ethdev.c b/lib/librte_pmd_ixgbe/ixgbe_ethdev.c\nindex 2eb609c..099dfb0 100644\n--- a/lib/librte_pmd_ixgbe/ixgbe_ethdev.c\n+++ b/lib/librte_pmd_ixgbe/ixgbe_ethdev.c\n@@ -132,8 +132,9 @@ static int ixgbe_dev_queue_stats_mapping_set(struct rte_eth_dev *eth_dev,\n \t\t\t\t\t uint8_t stat_idx,\n \t\t\t\t\t uint8_t is_rx);\n static void ixgbe_dev_info_get(struct rte_eth_dev *dev,\n-\t\t\t\tstruct rte_eth_dev_info *dev_info);\n-\n+\t\t\t struct rte_eth_dev_info *dev_info);\n+static void ixgbevf_dev_info_get(struct rte_eth_dev *dev,\n+\t\t\t\t struct rte_eth_dev_info *dev_info);\n static int ixgbe_dev_mtu_set(struct rte_eth_dev *dev, uint16_t mtu);\n \n static int ixgbe_vlan_filter_set(struct rte_eth_dev *dev,\n@@ -391,7 +392,7 @@ static struct eth_dev_ops ixgbevf_eth_dev_ops = {\n \t.stats_get = ixgbevf_dev_stats_get,\n \t.stats_reset = ixgbevf_dev_stats_reset,\n \t.dev_close = ixgbevf_dev_close,\n-\t.dev_infos_get = ixgbe_dev_info_get,\n+\t.dev_infos_get = ixgbevf_dev_info_get,\n \t.mtu_set = ixgbevf_dev_set_mtu,\n \t.vlan_filter_set = ixgbevf_vlan_filter_set,\n \t.vlan_strip_queue_set = ixgbevf_vlan_strip_queue_set,\n@@ -1967,25 +1968,76 @@ ixgbe_dev_info_get(struct rte_eth_dev *dev, struct rte_eth_dev_info *dev_info)\n \t\tDEV_TX_OFFLOAD_SCTP_CKSUM;\n \n \tdev_info->default_rxconf = (struct rte_eth_rxconf) {\n-\t\t\t.rx_thresh = {\n-\t\t\t\t.pthresh = IXGBE_DEFAULT_RX_PTHRESH,\n-\t\t\t\t.hthresh = IXGBE_DEFAULT_RX_HTHRESH,\n-\t\t\t\t.wthresh = IXGBE_DEFAULT_RX_WTHRESH,\n-\t\t\t},\n-\t\t\t.rx_free_thresh = IXGBE_DEFAULT_RX_FREE_THRESH,\n-\t\t\t.rx_drop_en = 0,\n+\t\t.rx_thresh = {\n+\t\t\t.pthresh = IXGBE_DEFAULT_RX_PTHRESH,\n+\t\t\t.hthresh = IXGBE_DEFAULT_RX_HTHRESH,\n+\t\t\t.wthresh = IXGBE_DEFAULT_RX_WTHRESH,\n+\t\t},\n+\t\t.rx_free_thresh = IXGBE_DEFAULT_RX_FREE_THRESH,\n+\t\t.rx_drop_en = 0,\n+\t};\n+\n+\tdev_info->default_txconf = (struct rte_eth_txconf) {\n+\t\t.tx_thresh = {\n+\t\t\t.pthresh = IXGBE_DEFAULT_TX_PTHRESH,\n+\t\t\t.hthresh = IXGBE_DEFAULT_TX_HTHRESH,\n+\t\t\t.wthresh = IXGBE_DEFAULT_TX_WTHRESH,\n+\t\t},\n+\t\t.tx_free_thresh = IXGBE_DEFAULT_TX_FREE_THRESH,\n+\t\t.tx_rs_thresh = IXGBE_DEFAULT_TX_RSBIT_THRESH,\n+\t\t.txq_flags = ETH_TXQ_FLAGS_NOMULTSEGS |\n+\t\t\t\tETH_TXQ_FLAGS_NOOFFLOADS,\n \t};\n+\tdev_info->reta_size = ETH_RSS_RETA_SIZE_128;\n+}\n \n+static void\n+ixgbevf_dev_info_get(struct rte_eth_dev *dev,\n+\t\t struct rte_eth_dev_info *dev_info)\n+{\n+\tstruct ixgbe_hw *hw = IXGBE_DEV_PRIVATE_TO_HW(dev->data->dev_private);\n+\n+\tdev_info->max_rx_queues = (uint16_t)hw->mac.max_rx_queues;\n+\tdev_info->max_tx_queues = (uint16_t)hw->mac.max_tx_queues;\n+\tdev_info->min_rx_bufsize = 1024; /* cf BSIZEPACKET in SRRCTL reg */\n+\tdev_info->max_rx_pktlen = 15872; /* includes CRC, cf MAXFRS reg */\n+\tdev_info->max_mac_addrs = hw->mac.num_rar_entries;\n+\tdev_info->max_hash_mac_addrs = IXGBE_VMDQ_NUM_UC_MAC;\n+\tdev_info->max_vfs = dev->pci_dev->max_vfs;\n+\tif (hw->mac.type == ixgbe_mac_82598EB)\n+\t\tdev_info->max_vmdq_pools = ETH_16_POOLS;\n+\telse\n+\t\tdev_info->max_vmdq_pools = ETH_64_POOLS;\n+\tdev_info->rx_offload_capa = DEV_RX_OFFLOAD_VLAN_STRIP |\n+\t\t\t\tDEV_RX_OFFLOAD_IPV4_CKSUM |\n+\t\t\t\tDEV_RX_OFFLOAD_UDP_CKSUM |\n+\t\t\t\tDEV_RX_OFFLOAD_TCP_CKSUM;\n+\tdev_info->tx_offload_capa = DEV_TX_OFFLOAD_VLAN_INSERT |\n+\t\t\t\tDEV_TX_OFFLOAD_IPV4_CKSUM |\n+\t\t\t\tDEV_TX_OFFLOAD_UDP_CKSUM |\n+\t\t\t\tDEV_TX_OFFLOAD_TCP_CKSUM |\n+\t\t\t\tDEV_TX_OFFLOAD_SCTP_CKSUM;\n+\n+\tdev_info->default_rxconf = (struct rte_eth_rxconf) {\n+\t\t.rx_thresh = {\n+\t\t\t.pthresh = IXGBE_DEFAULT_RX_PTHRESH,\n+\t\t\t.hthresh = IXGBE_DEFAULT_RX_HTHRESH,\n+\t\t\t.wthresh = IXGBE_DEFAULT_RX_WTHRESH,\n+\t\t},\n+\t\t.rx_free_thresh = IXGBE_DEFAULT_RX_FREE_THRESH,\n+\t\t.rx_drop_en = 0,\n+\t};\n \n-\t dev_info->default_txconf = (struct rte_eth_txconf) {\n-\t\t\t.tx_thresh = {\n-\t\t\t\t.pthresh = IXGBE_DEFAULT_TX_PTHRESH,\n-\t\t\t\t.hthresh = IXGBE_DEFAULT_TX_HTHRESH,\n-\t\t\t\t.wthresh = IXGBE_DEFAULT_TX_WTHRESH,\n-\t\t\t},\n-\t\t\t.tx_free_thresh = IXGBE_DEFAULT_TX_FREE_THRESH,\n-\t\t\t.tx_rs_thresh = IXGBE_DEFAULT_TX_RSBIT_THRESH,\n-\t\t\t.txq_flags = ETH_TXQ_FLAGS_NOMULTSEGS | ETH_TXQ_FLAGS_NOOFFLOADS,\n+\tdev_info->default_txconf = (struct rte_eth_txconf) {\n+\t\t.tx_thresh = {\n+\t\t\t.pthresh = IXGBE_DEFAULT_TX_PTHRESH,\n+\t\t\t.hthresh = IXGBE_DEFAULT_TX_HTHRESH,\n+\t\t\t.wthresh = IXGBE_DEFAULT_TX_WTHRESH,\n+\t\t},\n+\t\t.tx_free_thresh = IXGBE_DEFAULT_TX_FREE_THRESH,\n+\t\t.tx_rs_thresh = IXGBE_DEFAULT_TX_RSBIT_THRESH,\n+\t\t.txq_flags = ETH_TXQ_FLAGS_NOMULTSEGS |\n+\t\t\t\tETH_TXQ_FLAGS_NOOFFLOADS,\n \t};\n }\n \n", "prefixes": [ "dpdk-dev", "v6", "5/8" ] }