Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1289/?format=api
{ "id": 1289, "url": "https://patches.dpdk.org/api/patches/1289/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1416067424-31699-7-git-send-email-helin.zhang@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1416067424-31699-7-git-send-email-helin.zhang@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1416067424-31699-7-git-send-email-helin.zhang@intel.com", "date": "2014-11-15T16:03:42", "name": "[dpdk-dev,v6,6/8] i40e: rework of ops of 'dev_infos_get' for both PF and VF", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "1eb68957a224461d3fd87c4905bb423e198009fc", "submitter": { "id": 14, "url": "https://patches.dpdk.org/api/people/14/?format=api", "name": "Zhang, Helin", "email": "helin.zhang@intel.com" }, "delegate": null, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1416067424-31699-7-git-send-email-helin.zhang@intel.com/mbox/", "series": [], "comments": "https://patches.dpdk.org/api/patches/1289/comments/", "check": "pending", "checks": "https://patches.dpdk.org/api/patches/1289/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 8AEF57FB1;\n\tSat, 15 Nov 2014 16:54:07 +0100 (CET)", "from mga11.intel.com (mga11.intel.com [192.55.52.93])\n\tby dpdk.org (Postfix) with ESMTP id ADC157F84\n\tfor <dev@dpdk.org>; Sat, 15 Nov 2014 16:53:58 +0100 (CET)", "from fmsmga001.fm.intel.com ([10.253.24.23])\n\tby fmsmga102.fm.intel.com with ESMTP; 15 Nov 2014 08:04:06 -0800", "from shvmail01.sh.intel.com ([10.239.29.42])\n\tby fmsmga001.fm.intel.com with ESMTP; 15 Nov 2014 08:04:05 -0800", "from shecgisg004.sh.intel.com (shecgisg004.sh.intel.com\n\t[10.239.29.89])\n\tby shvmail01.sh.intel.com with ESMTP id sAFG43G4022318;\n\tSun, 16 Nov 2014 00:04:03 +0800", "from shecgisg004.sh.intel.com (localhost [127.0.0.1])\n\tby shecgisg004.sh.intel.com (8.13.6/8.13.6/SuSE Linux 0.8) with ESMTP\n\tid sAFG40Sw031779; Sun, 16 Nov 2014 00:04:02 +0800", "(from hzhan75@localhost)\n\tby shecgisg004.sh.intel.com (8.13.6/8.13.6/Submit) id sAFG40BF031772; \n\tSun, 16 Nov 2014 00:04:00 +0800" ], "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.07,391,1413270000\"; d=\"scan'208\";a=\"622898413\"", "From": "Helin Zhang <helin.zhang@intel.com>", "To": "dev@dpdk.org", "Date": "Sun, 16 Nov 2014 00:03:42 +0800", "Message-Id": "<1416067424-31699-7-git-send-email-helin.zhang@intel.com>", "X-Mailer": "git-send-email 1.7.4.1", "In-Reply-To": "<1416067424-31699-1-git-send-email-helin.zhang@intel.com>", "References": "<1415283932-20724-1-git-send-email-helin.zhang@intel.com>\n\t<1416067424-31699-1-git-send-email-helin.zhang@intel.com>", "Subject": "[dpdk-dev] [PATCH v6 6/8] i40e: rework of ops of 'dev_infos_get'\n\tfor both PF and VF", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Returning redirection table size has been supported in ops of\n'dev_infos_get' for both PF and VF. Default RX/TX configurations\nof VF can be returned in ops of 'dev_infos_get', while it was\nmissed before.\n\nSigned-off-by: Helin Zhang <helin.zhang@intel.com>\n---\n lib/librte_pmd_i40e/i40e_ethdev.c | 15 +++------------\n lib/librte_pmd_i40e/i40e_ethdev.h | 11 +++++++++++\n lib/librte_pmd_i40e/i40e_ethdev_vf.c | 23 +++++++++++++++++++++++\n 3 files changed, 37 insertions(+), 12 deletions(-)\n\nv2 changes:\n* Put getting reta size of both i40e PF and VF into a single patch.\n\nv3 changes:\n* Returning default RX/TX configurations has been added in ops of\n 'dev_infos_get' for VF, as it was added recently in that for PF.", "diff": "diff --git a/lib/librte_pmd_i40e/i40e_ethdev.c b/lib/librte_pmd_i40e/i40e_ethdev.c\nindex d90718e..279ef52 100644\n--- a/lib/librte_pmd_i40e/i40e_ethdev.c\n+++ b/lib/librte_pmd_i40e/i40e_ethdev.c\n@@ -59,17 +59,6 @@\n #include \"i40e_rxtx.h\"\n #include \"i40e_pf.h\"\n \n-#define I40E_DEFAULT_RX_FREE_THRESH 32\n-#define I40E_DEFAULT_RX_PTHRESH 8\n-#define I40E_DEFAULT_RX_HTHRESH 8\n-#define I40E_DEFAULT_RX_WTHRESH 0\n-\n-#define I40E_DEFAULT_TX_FREE_THRESH 32\n-#define I40E_DEFAULT_TX_PTHRESH 32\n-#define I40E_DEFAULT_TX_HTHRESH 0\n-#define I40E_DEFAULT_TX_WTHRESH 0\n-#define I40E_DEFAULT_TX_RSBIT_THRESH 32\n-\n /* Maximun number of MAC addresses */\n #define I40E_NUM_MACADDR_MAX 64\n #define I40E_CLEAR_PXE_WAIT_MS 200\n@@ -1443,6 +1432,7 @@ i40e_dev_info_get(struct rte_eth_dev *dev, struct rte_eth_dev_info *dev_info)\n \t\tDEV_TX_OFFLOAD_UDP_CKSUM |\n \t\tDEV_TX_OFFLOAD_TCP_CKSUM |\n \t\tDEV_TX_OFFLOAD_SCTP_CKSUM;\n+\tdev_info->reta_size = pf->hash_lut_size;\n \n \tdev_info->default_rxconf = (struct rte_eth_rxconf) {\n \t\t.rx_thresh = {\n@@ -1462,7 +1452,8 @@ i40e_dev_info_get(struct rte_eth_dev *dev, struct rte_eth_dev_info *dev_info)\n \t\t},\n \t\t.tx_free_thresh = I40E_DEFAULT_TX_FREE_THRESH,\n \t\t.tx_rs_thresh = I40E_DEFAULT_TX_RSBIT_THRESH,\n-\t\t.txq_flags = ETH_TXQ_FLAGS_NOMULTSEGS | ETH_TXQ_FLAGS_NOOFFLOADS,\n+\t\t.txq_flags = ETH_TXQ_FLAGS_NOMULTSEGS |\n+\t\t\t\tETH_TXQ_FLAGS_NOOFFLOADS,\n \t};\n \n \tif (pf->flags | I40E_FLAG_VMDQ) {\ndiff --git a/lib/librte_pmd_i40e/i40e_ethdev.h b/lib/librte_pmd_i40e/i40e_ethdev.h\nindex c7ad384..dcb2adb 100644\n--- a/lib/librte_pmd_i40e/i40e_ethdev.h\n+++ b/lib/librte_pmd_i40e/i40e_ethdev.h\n@@ -56,6 +56,17 @@\n /* Always assign pool 0 to main VSI, VMDQ will start from 1 */\n #define I40E_VMDQ_POOL_BASE 1\n \n+#define I40E_DEFAULT_RX_FREE_THRESH 32\n+#define I40E_DEFAULT_RX_PTHRESH 8\n+#define I40E_DEFAULT_RX_HTHRESH 8\n+#define I40E_DEFAULT_RX_WTHRESH 0\n+\n+#define I40E_DEFAULT_TX_FREE_THRESH 32\n+#define I40E_DEFAULT_TX_PTHRESH 32\n+#define I40E_DEFAULT_TX_HTHRESH 0\n+#define I40E_DEFAULT_TX_WTHRESH 0\n+#define I40E_DEFAULT_TX_RSBIT_THRESH 32\n+\n /* i40e flags */\n #define I40E_FLAG_RSS (1ULL << 0)\n #define I40E_FLAG_DCB (1ULL << 1)\ndiff --git a/lib/librte_pmd_i40e/i40e_ethdev_vf.c b/lib/librte_pmd_i40e/i40e_ethdev_vf.c\nindex 11f25cc..24a930f 100644\n--- a/lib/librte_pmd_i40e/i40e_ethdev_vf.c\n+++ b/lib/librte_pmd_i40e/i40e_ethdev_vf.c\n@@ -1637,6 +1637,29 @@ i40evf_dev_info_get(struct rte_eth_dev *dev, struct rte_eth_dev_info *dev_info)\n \tdev_info->max_tx_queues = vf->vsi_res->num_queue_pairs;\n \tdev_info->min_rx_bufsize = I40E_BUF_SIZE_MIN;\n \tdev_info->max_rx_pktlen = I40E_FRAME_SIZE_MAX;\n+\tdev_info->reta_size = ETH_RSS_RETA_SIZE_64;\n+\n+\tdev_info->default_rxconf = (struct rte_eth_rxconf) {\n+\t\t.rx_thresh = {\n+\t\t\t.pthresh = I40E_DEFAULT_RX_PTHRESH,\n+\t\t\t.hthresh = I40E_DEFAULT_RX_HTHRESH,\n+\t\t\t.wthresh = I40E_DEFAULT_RX_WTHRESH,\n+\t\t},\n+\t\t.rx_free_thresh = I40E_DEFAULT_RX_FREE_THRESH,\n+\t\t.rx_drop_en = 0,\n+\t};\n+\n+\tdev_info->default_txconf = (struct rte_eth_txconf) {\n+\t\t.tx_thresh = {\n+\t\t\t.pthresh = I40E_DEFAULT_TX_PTHRESH,\n+\t\t\t.hthresh = I40E_DEFAULT_TX_HTHRESH,\n+\t\t\t.wthresh = I40E_DEFAULT_TX_WTHRESH,\n+\t\t},\n+\t\t.tx_free_thresh = I40E_DEFAULT_TX_FREE_THRESH,\n+\t\t.tx_rs_thresh = I40E_DEFAULT_TX_RSBIT_THRESH,\n+\t\t.txq_flags = ETH_TXQ_FLAGS_NOMULTSEGS |\n+\t\t\t\tETH_TXQ_FLAGS_NOOFFLOADS,\n+\t};\n }\n \n static void\n", "prefixes": [ "dpdk-dev", "v6", "6/8" ] }