Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/128749/?format=api
{ "id": 128749, "url": "https://patches.dpdk.org/api/patches/128749/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20230615143854.374384-1-bruce.richardson@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230615143854.374384-1-bruce.richardson@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20230615143854.374384-1-bruce.richardson@intel.com", "date": "2023-06-15T14:38:54", "name": "[v5] build: prevent accidentally building without NUMA support", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "686c880a7ec167d26c0103d93466e3518bd27b68", "submitter": { "id": 20, "url": "https://patches.dpdk.org/api/people/20/?format=api", "name": "Bruce Richardson", "email": "bruce.richardson@intel.com" }, "delegate": { "id": 1, "url": "https://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20230615143854.374384-1-bruce.richardson@intel.com/mbox/", "series": [ { "id": 28541, "url": "https://patches.dpdk.org/api/series/28541/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=28541", "date": "2023-06-15T14:38:54", "name": "[v5] build: prevent accidentally building without NUMA support", "version": 5, "mbox": "https://patches.dpdk.org/series/28541/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/128749/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/128749/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id D960442CC7;\n\tThu, 15 Jun 2023 16:39:03 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id B63A140EE3;\n\tThu, 15 Jun 2023 16:39:03 +0200 (CEST)", "from mga01.intel.com (mga01.intel.com [192.55.52.88])\n by mails.dpdk.org (Postfix) with ESMTP id 169C740E0F\n for <dev@dpdk.org>; Thu, 15 Jun 2023 16:39:01 +0200 (CEST)", "from fmsmga001.fm.intel.com ([10.253.24.23])\n by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 15 Jun 2023 07:39:01 -0700", "from silpixa00401385.ir.intel.com ([10.237.214.11])\n by fmsmga001.fm.intel.com with ESMTP; 15 Jun 2023 07:39:00 -0700" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1686839942; x=1718375942;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=nKhSBjX90vL5IFZX/PQUg3JILL8kyQKf999I9F9fXXg=;\n b=k3j9wPdGFfnul/DeWB3ojf2RUgx4idKFA5nvHsGEXFmFrZ8ro/VlP3Zl\n UpsHaHCkcGfZWH5CkIHFIwUcH/ykC6J1ZnMZpZcnvg2lP/RVfVIMqbl0H\n CrxpgR4vk/pWI818EYPSHGri2FAUknTChZdygrVzdFqdQgy42sDO0ft4y\n El/B0GYSJvNlqps31D9NstnRaClqmpb/uiZnaxye+ynhBkJnlByrsGqac\n l+dIwox+yoBRJXweKaV3d9S5roe5MLaGBsOQh5ayxLKM7dZ8/gaHxgFzH\n Im517tMkSfyUvyshhwO4qJ9rYAeOYYYbdG/o9ZeEUMSRlVH9WYo3DFlxM w==;", "X-IronPort-AV": [ "E=McAfee;i=\"6600,9927,10742\"; a=\"387426546\"", "E=Sophos;i=\"6.00,245,1681196400\"; d=\"scan'208\";a=\"387426546\"", "E=McAfee;i=\"6600,9927,10742\"; a=\"856979489\"", "E=Sophos;i=\"6.00,245,1681196400\"; d=\"scan'208\";a=\"856979489\"" ], "X-ExtLoop1": "1", "From": "Bruce Richardson <bruce.richardson@intel.com>", "To": "dev@dpdk.org", "Cc": "Bruce Richardson <bruce.richardson@intel.com>,\n David Marchand <david.marchand@redhat.com>", "Subject": "[PATCH v5] build: prevent accidentally building without NUMA support", "Date": "Thu, 15 Jun 2023 15:38:54 +0100", "Message-Id": "<20230615143854.374384-1-bruce.richardson@intel.com>", "X-Mailer": "git-send-email 2.39.2", "In-Reply-To": "<20230613165839.165887-1-bruce.richardson@intel.com>", "References": "<20230613165839.165887-1-bruce.richardson@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "When libnuma development package is missing on a system, DPDK can still\nbe built but will be missing much-needed support for NUMA memory\nmanagement. This may later cause issues at runtime if the resulting\nbinary is run on a NUMA system.\n\nWe can reduce the incidence of such runtime errors by ensuring that, for\nnative builds*, libnuma is present - unless the user actually specifies\nvia \"max_numa_nodes\" that they don't require NUMA support. Having this\nas an error condition is also in keeping with what is documented in the\nLinux GSG doc, where libnuma is listed as a requirement for building\nDPDK [1].\n\n* NOTE: cross-compilation builds have a different logic set, with a\n separate \"numa\" value indicating if numa support is necessary.\n\n[1] https://doc.dpdk.org/guides-23.03/linux_gsg/sys_reqs.html\n\nSigned-off-by: Bruce Richardson <bruce.richardson@intel.com>\nSigned-off-by: David Marchand <david.marchand@redhat.com>\n\n---\nV5: Rebase on main, since dependencies merged\n\nV4: Add Depends-on tag so CI picks up dependency\n\nV3:\n- install 32-bit libnuma packages on CI systems [thanks to David\n for the changes]\n- split the patch out of the previous patchset, so it can be tracked\n separately from the more minor fixup changes.\n\nV2: Limit check to linux only\n---\n .github/workflows/build.yml | 5 ++++-\n config/meson.build | 9 +++++++++\n 2 files changed, 13 insertions(+), 1 deletion(-)", "diff": "diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml\nindex 3b629fcdbd..a479783bbc 100644\n--- a/.github/workflows/build.yml\n+++ b/.github/workflows/build.yml\n@@ -91,6 +91,9 @@ jobs:\n with:\n path: reference\n key: ${{ steps.get_ref_keys.outputs.abi }}\n+ - name: Configure i386 architecture\n+ if: env.BUILD_32BIT == 'true'\n+ run: sudo dpkg --add-architecture i386\n - name: Update APT cache\n run: sudo apt update || true\n - name: Install packages\n@@ -104,7 +107,7 @@ jobs:\n pkg-config\n - name: Install i386 cross compiling packages\n if: env.BUILD_32BIT == 'true'\n- run: sudo apt install -y gcc-multilib g++-multilib\n+ run: sudo apt install -y gcc-multilib g++-multilib libnuma-dev:i386\n - name: Install aarch64 cross compiling packages\n if: env.AARCH64 == 'true'\n run: sudo apt install -y crossbuild-essential-arm64\ndiff --git a/config/meson.build b/config/meson.build\nindex 22d7d908b7..d8223718e4 100644\n--- a/config/meson.build\n+++ b/config/meson.build\n@@ -381,6 +381,15 @@ endif\n if not dpdk_conf.has('RTE_MAX_NUMA_NODES')\n error('Number of NUMA nodes not specified.')\n endif\n+if (is_linux and\n+ dpdk_conf.get('RTE_MAX_NUMA_NODES') > 1 and\n+ not meson.is_cross_build() and\n+ not has_libnuma)\n+ error('''\n+No NUMA library (development package) found, yet DPDK configured for multiple NUMA nodes.\n+Please install libnuma, or set 'max_numa_nodes' option to '1' to build without NUMA support.\n+''')\n+endif\n \n # set the install path for the drivers\n dpdk_conf.set_quoted('RTE_EAL_PMD_PATH', eal_pmd_path)\n", "prefixes": [ "v5" ] }