Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/128516/?format=api
{ "id": 128516, "url": "https://patches.dpdk.org/api/patches/128516/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20230612194716.1050379-2-wathsala.vithanage@arm.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230612194716.1050379-2-wathsala.vithanage@arm.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20230612194716.1050379-2-wathsala.vithanage@arm.com", "date": "2023-06-12T19:47:16", "name": "[RFC] ring: remove unnecessary fences in C11 ring for performance", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "83494bbe1f1347b2e9ea2092f2cba796bec1f8f5", "submitter": { "id": 2969, "url": "https://patches.dpdk.org/api/people/2969/?format=api", "name": "Wathsala Wathawana Vithanage", "email": "wathsala.vithanage@arm.com" }, "delegate": { "id": 1, "url": "https://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20230612194716.1050379-2-wathsala.vithanage@arm.com/mbox/", "series": [ { "id": 28461, "url": "https://patches.dpdk.org/api/series/28461/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=28461", "date": "2023-06-12T19:47:16", "name": "[RFC] ring: remove unnecessary fences in C11 ring for performance", "version": 1, "mbox": "https://patches.dpdk.org/series/28461/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/128516/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/128516/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id A037442C99;\n\tMon, 12 Jun 2023 21:48:08 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 8F85A410F9;\n\tMon, 12 Jun 2023 21:48:08 +0200 (CEST)", "from foss.arm.com (foss.arm.com [217.140.110.172])\n by mails.dpdk.org (Postfix) with ESMTP id 87F7C40689\n for <dev@dpdk.org>; Mon, 12 Jun 2023 21:48:07 +0200 (CEST)", "from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])\n by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 1D90D1FB;\n Mon, 12 Jun 2023 12:48:52 -0700 (PDT)", "from ampere-altra-2-1.usa.Arm.com (ampere-altra-2-1.usa.arm.com\n [10.118.91.158])\n by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 0133E3F5A1;\n Mon, 12 Jun 2023 12:48:06 -0700 (PDT)" ], "From": "Wathsala Vithanage <wathsala.vithanage@arm.com>", "To": "honnappa.nagarahalli@arm.com, konstantin.v.ananyev@yandex.ru,\n thomas@monjalon.net, ruifeng.wang@arm.com", "Cc": "dev@dpdk.org, nd@arm.com, Wathsala Vithanage <wathsala.vithanage@arm.com>", "Subject": "[RFC] ring: remove unnecessary fences in C11 ring for performance", "Date": "Mon, 12 Jun 2023 19:47:16 +0000", "Message-Id": "<20230612194716.1050379-2-wathsala.vithanage@arm.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20230612194716.1050379-1-wathsala.vithanage@arm.com>", "References": "<20230612194716.1050379-1-wathsala.vithanage@arm.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "For improved performance over the current C11 based ring\nimplementation, two ACQUIRE fences between the load of the old_head\nand the load of the const_tail in __rte_ring_move_prod_head and the\nload of old_head and load of the prod_tail in\n__rte_ring_move_cons_head functions have been removed. These two\nfences are not required for the safety of the ring library.\n\nSigned-off-by: Wathsala Vithanage <wathsala.vithanage@arm.com>\nReviewed-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>\nReviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>\n---\n .mailmap | 1 +\n lib/ring/rte_ring_c11_pvt.h | 6 ------\n 2 files changed, 1 insertion(+), 6 deletions(-)", "diff": "diff --git a/.mailmap b/.mailmap\nindex 4018f0fc47..367115d134 100644\n--- a/.mailmap\n+++ b/.mailmap\n@@ -1430,6 +1430,7 @@ Walter Heymans <walter.heymans@corigine.com>\n Wang Sheng-Hui <shhuiw@gmail.com>\n Wangyu (Eric) <seven.wangyu@huawei.com>\n Waterman Cao <waterman.cao@intel.com>\n+Wathsala Vithanage <wathsala.vithanage@arm.com>\n Weichun Chen <weichunx.chen@intel.com>\n Wei Dai <wei.dai@intel.com>\n Weifeng Li <liweifeng96@126.com>\ndiff --git a/lib/ring/rte_ring_c11_pvt.h b/lib/ring/rte_ring_c11_pvt.h\nindex f895950df4..eb59c61b6a 100644\n--- a/lib/ring/rte_ring_c11_pvt.h\n+++ b/lib/ring/rte_ring_c11_pvt.h\n@@ -66,9 +66,6 @@ __rte_ring_move_prod_head(struct rte_ring *r, unsigned int is_sp,\n \t\t/* Reset n to the initial burst count */\n \t\tn = max;\n \n-\t\t/* Ensure the head is read before tail */\n-\t\t__atomic_thread_fence(__ATOMIC_ACQUIRE);\n-\n \t\t/* load-acquire synchronize with store-release of ht->tail\n \t\t * in update_tail.\n \t\t */\n@@ -142,9 +139,6 @@ __rte_ring_move_cons_head(struct rte_ring *r, int is_sc,\n \t\t/* Restore n as it may change every loop */\n \t\tn = max;\n \n-\t\t/* Ensure the head is read before tail */\n-\t\t__atomic_thread_fence(__ATOMIC_ACQUIRE);\n-\n \t\t/* this load-acquire synchronize with store-release of ht->tail\n \t\t * in update_tail.\n \t\t */\n", "prefixes": [ "RFC" ] }