Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/128513/?format=api
https://patches.dpdk.org/api/patches/128513/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20230612171456.173378-2-bruce.richardson@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230612171456.173378-2-bruce.richardson@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20230612171456.173378-2-bruce.richardson@intel.com", "date": "2023-06-12T17:14:56", "name": "[v2,2/2] build: prevent accidentally building without NUMA support", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "0d88c7a22f24f39a0bee6c41052e2cccdc57ea05", "submitter": { "id": 20, "url": "https://patches.dpdk.org/api/people/20/?format=api", "name": "Bruce Richardson", "email": "bruce.richardson@intel.com" }, "delegate": { "id": 1, "url": "https://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20230612171456.173378-2-bruce.richardson@intel.com/mbox/", "series": [ { "id": 28458, "url": "https://patches.dpdk.org/api/series/28458/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=28458", "date": "2023-06-12T17:14:55", "name": "[v2,1/2] build: change flag variable type to boolean", "version": 2, "mbox": "https://patches.dpdk.org/series/28458/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/128513/comments/", "check": "fail", "checks": "https://patches.dpdk.org/api/patches/128513/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 8BA1B42C50;\n\tMon, 12 Jun 2023 19:15:13 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id C3ACD41138;\n\tMon, 12 Jun 2023 19:15:09 +0200 (CEST)", "from mga02.intel.com (mga02.intel.com [134.134.136.20])\n by mails.dpdk.org (Postfix) with ESMTP id 3ECBC410FC\n for <dev@dpdk.org>; Mon, 12 Jun 2023 19:15:07 +0200 (CEST)", "from orsmga001.jf.intel.com ([10.7.209.18])\n by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 12 Jun 2023 10:15:06 -0700", "from silpixa00401385.ir.intel.com ([10.237.214.11])\n by orsmga001.jf.intel.com with ESMTP; 12 Jun 2023 10:15:06 -0700" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1686590107; x=1718126107;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=/VNnxFS7dbjThQrOzuXykQhWnt2GbS1HokebkIfxCtc=;\n b=LL3ac52//JsakdlQaYdZ6GV97cBnnzm7LceJWbRT7l7+fMTE30UXmuJf\n 5+XlwWJqR3ZXLgQdGIjsxrGcgZQsqTNeSAvEzooBgoQjos7l9it+y4pSD\n 8y9w/kHFMiQ+aoKis4lt4XlSywEFOgkxb8vrEovEaMC7Y6s6krTyzKLEt\n tAsYlAYtFKGG44WHhOlnJSXLfDUhN7c7sZbSInOXhxcGG8Qgxky/cgxc0\n UF8GHga5pPNAGGIrOzvtMiHR231Zv4X3Ibfmh1bmMILgUznlgiKJhFnLt\n 3mW957qJL+3mmy6atq2zOExLrRAzquLVgj7UvFYQEVbMDk6ZR8kCuYuyw g==;", "X-IronPort-AV": [ "E=McAfee;i=\"6600,9927,10739\"; a=\"347760967\"", "E=Sophos;i=\"6.00,236,1681196400\"; d=\"scan'208\";a=\"347760967\"", "E=McAfee;i=\"6600,9927,10739\"; a=\"744392370\"", "E=Sophos;i=\"6.00,236,1681196400\"; d=\"scan'208\";a=\"744392370\"" ], "X-ExtLoop1": "1", "From": "Bruce Richardson <bruce.richardson@intel.com>", "To": "dev@dpdk.org", "Cc": "Bruce Richardson <bruce.richardson@intel.com>", "Subject": "[PATCH v2 2/2] build: prevent accidentally building without NUMA\n support", "Date": "Mon, 12 Jun 2023 18:14:56 +0100", "Message-Id": "<20230612171456.173378-2-bruce.richardson@intel.com>", "X-Mailer": "git-send-email 2.39.2", "In-Reply-To": "<20230612171456.173378-1-bruce.richardson@intel.com>", "References": "<20230612162104.170749-1-bruce.richardson@intel.com>\n <20230612171456.173378-1-bruce.richardson@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "When libnuma development package is missing on a system, DPDK can still\nbe built but will be missing much-needed support for NUMA memory\nmanagement. This may later cause issues at runtime if the resulting\nbinary is run on a NUMA system.\n\nWe can reduce the incidence of such runtime error by ensuring that, for\nnative builds*, libnuma is present - unless the user actually specifies\nvia \"max_numa_nodes\" that they don't require NUMA support. Having this\nas an error condition is also in keeping with what is documented in the\nLinux GSG doc, where libnuma is listed as a requirement for building\nDPDK [1].\n\n* NOTE: cross-compilation builds have a different logic set, with a\n separate \"numa\" value indicating if numa support is necessary.\n\n[1] https://doc.dpdk.org/guides-23.03/linux_gsg/sys_reqs.html\n\nSigned-off-by: Bruce Richardson <bruce.richardson@intel.com>\n\n---\nV2: Limit check to linux only\n---\n config/meson.build | 9 +++++++++\n 1 file changed, 9 insertions(+)", "diff": "diff --git a/config/meson.build b/config/meson.build\nindex 8aebccbbdc..00812976ba 100644\n--- a/config/meson.build\n+++ b/config/meson.build\n@@ -381,6 +381,15 @@ endif\n if not dpdk_conf.has('RTE_MAX_NUMA_NODES')\n error('Number of NUMA nodes not specified.')\n endif\n+if (is_linux and\n+ dpdk_conf.get('RTE_MAX_NUMA_NODES') > 1 and\n+ not meson.is_cross_build() and\n+ not has_libnuma)\n+ error('''\n+No NUMA library (development package) found, yet DPDK configured for multiple NUMA nodes.\n+Please install libnuma, or set 'max_numa_nodes' option to '1' to build without NUMA support.\n+''')\n+endif\n \n # set the install path for the drivers\n dpdk_conf.set_quoted('RTE_EAL_PMD_PATH', eal_pmd_path)\n", "prefixes": [ "v2", "2/2" ] }{ "id": 128513, "url": "