Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/128472/?format=api
{ "id": 128472, "url": "https://patches.dpdk.org/api/patches/128472/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20230609145107.144593-1-bruce.richardson@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230609145107.144593-1-bruce.richardson@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20230609145107.144593-1-bruce.richardson@intel.com", "date": "2023-06-09T14:51:08", "name": "[v3] doc: prefer installing using meson rather than ninja", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "4df2bf0821fce67cc0b2978686221afacaa525b7", "submitter": { "id": 20, "url": "https://patches.dpdk.org/api/people/20/?format=api", "name": "Bruce Richardson", "email": "bruce.richardson@intel.com" }, "delegate": { "id": 1, "url": "https://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20230609145107.144593-1-bruce.richardson@intel.com/mbox/", "series": [ { "id": 28440, "url": "https://patches.dpdk.org/api/series/28440/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=28440", "date": "2023-06-09T14:51:08", "name": "[v3] doc: prefer installing using meson rather than ninja", "version": 3, "mbox": "https://patches.dpdk.org/series/28440/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/128472/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/128472/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 952F742C6F;\n\tFri, 9 Jun 2023 16:51:30 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 7105242FC4;\n\tFri, 9 Jun 2023 16:51:30 +0200 (CEST)", "from mga05.intel.com (mga05.intel.com [192.55.52.43])\n by mails.dpdk.org (Postfix) with ESMTP id DD33142D8F\n for <dev@dpdk.org>; Fri, 9 Jun 2023 16:51:28 +0200 (CEST)", "from fmsmga004.fm.intel.com ([10.253.24.48])\n by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 09 Jun 2023 07:51:27 -0700", "from silpixa00401385.ir.intel.com ([10.237.214.152])\n by fmsmga004.fm.intel.com with ESMTP; 09 Jun 2023 07:51:26 -0700" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1686322289; x=1717858289;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=9SgCsgFzfNeqvgSaEuKZucxlLWgIksvQAEDwEBJT6K0=;\n b=S9AZORmS4ywX/XBW3R4xD+iWuMruQVbF338T4FWaJ7pwnhOb+6wYjJ33\n qovMjvH7s2vWGD559t3kTjFPF02EjATCZkJWVznAnvaV0BL7gw8K/ds4Y\n /DnAPDJo5tJHlOabhU0WMQYdz63+jMS93TwgPcDzqR+53kXvfVto/x960\n m108ikCqtDJXlJjIC1t1bZjljJyna0fZhj8o+Sr/uPD5+VwQhnENnp+EZ\n 6IfA7874IAaCo+ton34g2Yq8Hq+tQnFu3XmSiZmAHMzLJSeguqnRZoBA8\n 6h8Jj9jqrwXZEZrrx+AyHP40Dq/r7v1DAv90Lk4He0mbYUAlKSx/sh3XL Q==;", "X-IronPort-AV": [ "E=McAfee;i=\"6600,9927,10736\"; a=\"443982937\"", "E=Sophos;i=\"6.00,229,1681196400\"; d=\"scan'208\";a=\"443982937\"", "E=McAfee;i=\"6600,9927,10736\"; a=\"780341568\"", "E=Sophos;i=\"6.00,229,1681196400\"; d=\"scan'208\";a=\"780341568\"" ], "X-ExtLoop1": "1", "From": "Bruce Richardson <bruce.richardson@intel.com>", "To": "dev@dpdk.org", "Cc": "david.marchand@redhat.com,\n\tBruce Richardson <bruce.richardson@intel.com>", "Subject": "[PATCH v3] doc: prefer installing using meson rather than ninja", "Date": "Fri, 9 Jun 2023 15:51:08 +0100", "Message-Id": "<20230609145107.144593-1-bruce.richardson@intel.com>", "X-Mailer": "git-send-email 2.39.2", "In-Reply-To": "<20230609105139.76239-1-bruce.richardson@intel.com>", "References": "<20230609105139.76239-1-bruce.richardson@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "After doing a build, to install DPDK system-wide our documentation\nrecommended using the \"ninja install\" command. However, for anyone\nbuilding as a non-root user and only installing as root, the \"meson\ninstall\" command is a better alternative, as it provides for\nautomatically dropping or elevating privileges as necessary in more\nrecent meson releases [1].\n\n[1] https://mesonbuild.com/Installing.html#installing-as-the-superuser\n\nSigned-off-by: Bruce Richardson <bruce.richardson@intel.com>\n\n---\nV3:\n* correct order of arguments to meson in CI scripts. The \"-C\" option\n must follow the meson \"install\" command. [This is consistent with\n other uses e.g. meson compile -C ..., meson test -C ...]\n\nV2:\n* Fix one missed reference to \"ninja install\" in Linux GSG\n* Changed CI scripts to use \"meson install\" to ensure step is properly\n tested.\n---\n .ci/linux-build.sh | 4 ++--\n doc/guides/contributing/coding_style.rst | 2 +-\n doc/guides/cryptodevs/uadk.rst | 2 +-\n doc/guides/freebsd_gsg/build_dpdk.rst | 2 +-\n doc/guides/freebsd_gsg/build_sample_apps.rst | 2 +-\n doc/guides/linux_gsg/build_dpdk.rst | 4 ++--\n doc/guides/prog_guide/build-sdk-meson.rst | 4 ++--\n 7 files changed, 10 insertions(+), 10 deletions(-)", "diff": "diff --git a/.ci/linux-build.sh b/.ci/linux-build.sh\nindex 9631e342b5..76d3e776af 100755\n--- a/.ci/linux-build.sh\n+++ b/.ci/linux-build.sh\n@@ -150,14 +150,14 @@ if [ \"$ABI_CHECKS\" = \"true\" ]; then\n git clone --single-branch -b \"$REF_GIT_TAG\" $REF_GIT_REPO $refsrcdir\n meson setup $OPTS -Dexamples= $refsrcdir $refsrcdir/build\n ninja -C $refsrcdir/build\n- DESTDIR=$(pwd)/reference ninja -C $refsrcdir/build install\n+ DESTDIR=$(pwd)/reference meson install -C $refsrcdir/build\n find reference/usr/local -name '*.a' -delete\n rm -rf reference/usr/local/bin\n rm -rf reference/usr/local/share\n echo $REF_GIT_TAG > reference/VERSION\n fi\n \n- DESTDIR=$(pwd)/install ninja -C build install\n+ DESTDIR=$(pwd)/install meson install -C build\n devtools/check-abi.sh reference install ${ABI_CHECKS_WARN_ONLY:-}\n fi\n \ndiff --git a/doc/guides/contributing/coding_style.rst b/doc/guides/contributing/coding_style.rst\nindex 89db6260cf..00d6270624 100644\n--- a/doc/guides/contributing/coding_style.rst\n+++ b/doc/guides/contributing/coding_style.rst\n@@ -956,7 +956,7 @@ ext_deps\n headers\n \t**Default Value = []**.\n \tUsed to return the list of header files for the library that should be\n-\tinstalled to $PREFIX/include when ``ninja install`` is run. As with\n+\tinstalled to $PREFIX/include when ``meson install`` is run. As with\n \tsource files, these should be specified using the meson ``files()``\n \tfunction.\n \tWhen ``check_includes`` build option is set to ``true``, each header file\ndiff --git a/doc/guides/cryptodevs/uadk.rst b/doc/guides/cryptodevs/uadk.rst\nindex 9af6b88a5a..136ab4be6a 100644\n--- a/doc/guides/cryptodevs/uadk.rst\n+++ b/doc/guides/cryptodevs/uadk.rst\n@@ -90,7 +90,7 @@ Test steps\n meson setup build (--reconfigure)\n cd build\n ninja\n- sudo ninja install\n+ sudo meson install\n \n #. Prepare hugepages for DPDK (see also :doc:`../tools/hugepages`)\n \ndiff --git a/doc/guides/freebsd_gsg/build_dpdk.rst b/doc/guides/freebsd_gsg/build_dpdk.rst\nindex 514d18c870..86e8e5a805 100644\n--- a/doc/guides/freebsd_gsg/build_dpdk.rst\n+++ b/doc/guides/freebsd_gsg/build_dpdk.rst\n@@ -47,7 +47,7 @@ The final, install, step generally needs to be run as root::\n meson setup build\n cd build\n ninja\n- ninja install\n+ meson install\n \n This will install the DPDK libraries and drivers to `/usr/local/lib` with a\n pkg-config file `libdpdk.pc` installed to `/usr/local/lib/pkgconfig`. The\ndiff --git a/doc/guides/freebsd_gsg/build_sample_apps.rst b/doc/guides/freebsd_gsg/build_sample_apps.rst\nindex c87e982759..b1ab7545b1 100644\n--- a/doc/guides/freebsd_gsg/build_sample_apps.rst\n+++ b/doc/guides/freebsd_gsg/build_sample_apps.rst\n@@ -22,7 +22,7 @@ the system when DPDK is installed, and so can be built using GNU make.\n on the FreeBSD system.\n \n The following shows how to compile the helloworld example app, following\n-the installation of DPDK using `ninja install` as described previously::\n+the installation of DPDK using `meson install` as described previously::\n \n $ export PKG_CONFIG_PATH=/usr/local/lib/pkgconfig\n \ndiff --git a/doc/guides/linux_gsg/build_dpdk.rst b/doc/guides/linux_gsg/build_dpdk.rst\nindex bbd2efc9d8..9c0dd9daf6 100644\n--- a/doc/guides/linux_gsg/build_dpdk.rst\n+++ b/doc/guides/linux_gsg/build_dpdk.rst\n@@ -68,11 +68,11 @@ Once configured, to build and then install DPDK system-wide use:\n \n cd build\n ninja\n- ninja install\n+ meson install\n ldconfig\n \n The last two commands above generally need to be run as root,\n-with the `ninja install` step copying the built objects to their final system-wide locations,\n+with the `meson install` step copying the built objects to their final system-wide locations,\n and the last step causing the dynamic loader `ld.so` to update its cache to take account of the new objects.\n \n .. note::\ndiff --git a/doc/guides/prog_guide/build-sdk-meson.rst b/doc/guides/prog_guide/build-sdk-meson.rst\nindex 5deabbe54c..93aa1f80e3 100644\n--- a/doc/guides/prog_guide/build-sdk-meson.rst\n+++ b/doc/guides/prog_guide/build-sdk-meson.rst\n@@ -12,7 +12,7 @@ following set of commands::\n \tmeson setup build\n \tcd build\n \tninja\n-\tninja install\n+\tmeson install\n \n This will compile DPDK in the ``build`` subdirectory, and then install the\n resulting libraries, drivers and header files onto the system - generally\n@@ -165,7 +165,7 @@ printing each command on a new line as it runs.\n Installing the Compiled Files\n ------------------------------\n \n-Use ``ninja install`` to install the required DPDK files onto the system.\n+Use ``meson install`` to install the required DPDK files onto the system.\n The install prefix defaults to ``/usr/local`` but can be used as with other\n options above. The environment variable ``DESTDIR`` can be used to adjust\n the root directory for the install, for example when packaging.\n", "prefixes": [ "v3" ] }