Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/128449/?format=api
{ "id": 128449, "url": "https://patches.dpdk.org/api/patches/128449/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20230609060100.1306648-4-chaoyong.he@corigine.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230609060100.1306648-4-chaoyong.he@corigine.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20230609060100.1306648-4-chaoyong.he@corigine.com", "date": "2023-06-09T06:01:00", "name": "[3/3] net/nfp: fix flow hash table creation failed", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "efa03f8e1bb989552c7b65e46d3063c4c002922c", "submitter": { "id": 2554, "url": "https://patches.dpdk.org/api/people/2554/?format=api", "name": "Chaoyong He", "email": "chaoyong.he@corigine.com" }, "delegate": { "id": 319, "url": "https://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20230609060100.1306648-4-chaoyong.he@corigine.com/mbox/", "series": [ { "id": 28426, "url": "https://patches.dpdk.org/api/series/28426/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=28426", "date": "2023-06-09T06:00:57", "name": "support using several cards in one host", "version": 1, "mbox": "https://patches.dpdk.org/series/28426/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/128449/comments/", "check": "fail", "checks": "https://patches.dpdk.org/api/patches/128449/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id D1D3042C69;\n\tFri, 9 Jun 2023 08:01:54 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 8656542D38;\n\tFri, 9 Jun 2023 08:01:38 +0200 (CEST)", "from NAM11-BN8-obe.outbound.protection.outlook.com\n (mail-bn8nam11on2100.outbound.protection.outlook.com [40.107.236.100])\n by mails.dpdk.org (Postfix) with ESMTP id 93B9D40A84;\n Fri, 9 Jun 2023 08:01:36 +0200 (CEST)", "from SJ0PR13MB5545.namprd13.prod.outlook.com (2603:10b6:a03:424::5)\n by CO1PR13MB5046.namprd13.prod.outlook.com (2603:10b6:303:f4::22)\n with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6455.33; Fri, 9 Jun\n 2023 06:01:32 +0000", "from SJ0PR13MB5545.namprd13.prod.outlook.com\n ([fe80::d2cb:a650:e1ce:2174]) by SJ0PR13MB5545.namprd13.prod.outlook.com\n ([fe80::d2cb:a650:e1ce:2174%3]) with mapi id 15.20.6455.030; Fri, 9 Jun 2023\n 06:01:32 +0000" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=mHdjpEhh4+dc1RMEgvzRBxd8SMXmgyv8fSk+24LKcd+eg3TU4IflKdunfszBIPKEMlT8FJSjAZfHgRNF+BVFkMw912vpN2mv+sF3uY+q9m5tjSsecXrMx+5o11e49nKcqiL5b2+vxI6AGqdfjoesSnxCJNxpYtR7VoA3+ISiTy/BefbIfRN09xV0xWbhLWR0B9PzFRwTYOuNztMIJEPvwmshCL0hNYAW+EPExsfdvfWQgfyIz+LDGosK3fgsvA7000yfL+AgY6k63/XivD9hioedUxH0CuH58CAOBS+g+k3HF4XIBthUbzO1xZJMgM/U44slKsArND/mwCaAakGyiA==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=cYMHJtrF/r6qD0GfIDmmzqZZNpoIfY3WxDF7fybqL70=;\n b=CzdNdgAZTbDlVydfYjen3iOnkdrhkMyoTlKDOtoaNKP3qju7fqLlcKDD9lU0Js3Oy6vF0SjDk4j9r0QvsB7syhPqxKcOA2y6U1TeJUMliHsP/HsqC5ZO7R4B/Buwt7Tk9J/Dpp2UWe2mlpxKao8oR8pcaPI/Rarfanuf9weO2dBfWXrnFhJIuyzpghiLO0CnRnQ0rOpJPDOwquJJu4Z4p5tNbvQfRp/ACNCZmYT1Ak9E9m5LlBwl9moT8rvtbgX1LpM2EBJJMBwkJ6IKhFwskapkrigDW+CsjvqycRApuvaROwgiN6isRPMFjCcK67CvQsnieghA0Eu1QYlrQPav/A==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass\n smtp.mailfrom=corigine.com; dmarc=pass action=none header.from=corigine.com;\n dkim=pass header.d=corigine.com; arc=none", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=corigine.onmicrosoft.com; s=selector2-corigine-onmicrosoft-com;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=cYMHJtrF/r6qD0GfIDmmzqZZNpoIfY3WxDF7fybqL70=;\n b=Zr0291PXGxgT/ZXkuNHpmaBWNOroXyzL/f6nHT59kUa049H6ReEb04kLmipmQ2Zr69h2/1n1dKbyRvT8R2Kr5QmsbCP1llrKRcvZHvdOsOzbjslYPzB5nUnJI8FsOA7Y7X/R2b01MBufHmVTrx7PxTyVT6ZeVhVrwBfCvOkW2IA=", "Authentication-Results": "dkim=none (message not signed)\n header.d=none;dmarc=none action=none header.from=corigine.com;", "From": "Chaoyong He <chaoyong.he@corigine.com>", "To": "dev@dpdk.org", "Cc": "oss-drivers@corigine.com, niklas.soderlund@corigine.com,\n Long Wu <long.wu@corigine.com>, chaoyong.he@corigine.com, stable@dpdk.org", "Subject": "[PATCH 3/3] net/nfp: fix flow hash table creation failed", "Date": "Fri, 9 Jun 2023 14:01:00 +0800", "Message-Id": "<20230609060100.1306648-4-chaoyong.he@corigine.com>", "X-Mailer": "git-send-email 2.39.1", "In-Reply-To": "<20230609060100.1306648-1-chaoyong.he@corigine.com>", "References": "<20230609060100.1306648-1-chaoyong.he@corigine.com>", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-ClientProxiedBy": "SG2P153CA0035.APCP153.PROD.OUTLOOK.COM (2603:1096:4:c7::22)\n To SJ0PR13MB5545.namprd13.prod.outlook.com\n (2603:10b6:a03:424::5)", "MIME-Version": "1.0", "X-MS-PublicTrafficType": "Email", "X-MS-TrafficTypeDiagnostic": "SJ0PR13MB5545:EE_|CO1PR13MB5046:EE_", "X-MS-Office365-Filtering-Correlation-Id": "3394cd2c-d2a8-4718-4370-08db68aef944", "X-MS-Exchange-SenderADCheck": "1", "X-MS-Exchange-AntiSpam-Relay": "0", "X-Microsoft-Antispam": "BCL:0;", "X-Microsoft-Antispam-Message-Info": "\n JFnILvS5tv/i2+FmlV92RDWW4YHqOdjddkFa3UFLjPPzMp7wRo+Jp+LLle7rasvtfqpSz72zQDtwuU7xgbi5vCJI4czp21zUhqSEDIz/Sn1HAdaeKj5TIdAm+hyCtgArkZWSS68h/nJ7+CrSDGGi2qpKwaX5L5+W0borTB57vJRgdz8qY3aPgwJ3WICcec58Uf7vZCVpkn7jfogcKzyfOTZYad6sgtF2amTNBnIJsjMW/edyvrF13ZP4hQ6TyNnKPBw0M+ZnNaCpXpZH/HGhO0hzBGq9pshvebJekxd95sPGLmUfSvo0de9SUaD6atdUAawYCZOUyLXqoojmUqB1rlwa8CnfQq2IiPDXH4oQ4JJJOi/qpphYLJjtzvO861h7TM9XoQ+9OBRhWDq0Gsc+kJ2Df1Bx/Gw+L4uM1K2lzHd3+cph+feAAZSrkl3/lIHiI+lOut7WEjMGndyaGQ7eaGQBWfE/XHx/SXsapuA2l6kjCGuMu93gIk86j8kYtvRQmLeOP2D5Oo/vCG/nWDwXUZf+2DglZglK/RLzAPhCRftine16YN7qC3zhjjeYY3nIfPDTTjTPmSqntlh6I/kyX/Ad6v+hwfW4IW16MEhfuz/QMVqn80iGM5V6Z1YNj5d3", "X-Forefront-Antispam-Report": "CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;\n IPV:NLI; SFV:NSPM; H:SJ0PR13MB5545.namprd13.prod.outlook.com; PTR:; CAT:NONE;\n SFS:(13230028)(4636009)(396003)(39840400004)(136003)(346002)(376002)(366004)(451199021)(41300700001)(4326008)(66946007)(450100002)(66556008)(8676002)(478600001)(8936002)(6916009)(66476007)(2906002)(316002)(6666004)(44832011)(5660300002)(6486002)(52116002)(6506007)(6512007)(1076003)(26005)(186003)(2616005)(83380400001)(36756003)(38100700002)(38350700002)(86362001);\n DIR:OUT; SFP:1102;", "X-MS-Exchange-AntiSpam-MessageData-ChunkCount": "1", "X-MS-Exchange-AntiSpam-MessageData-0": "=?utf-8?q?N0VMtm5QrW26FcBK/TcFhOJ8uZGe?=\n\t=?utf-8?q?6MFbYvaLoTpUpL07mWPzZlKbShqijoBOu8Q6aCche9Y2MFmvQcmkTMzr/Iw8IWiX7?=\n\t=?utf-8?q?KsEX66zkfGyBEGOcIcvOa+cUOWiXtG5oDPw0dgA0kPS16fgYVzp8Qn5CNyaTco7m1?=\n\t=?utf-8?q?35QzNKQNsHDFiDjc8hX/SI+jw4OKFTtqqiTRo2FgGEdvP2/wHF0tKy4p2xJzTmPoW?=\n\t=?utf-8?q?4MrZw6NO8AnYJY70h/7iIZZ1D9bm2ntvVW7w+w2U/hhCze+rw8E98jZUZmYgsrr/d?=\n\t=?utf-8?q?va/wOUNvW91ott/AympjI5opeVDAdZz06NLfUf6tzTxS3RN+baCS4fZm5zI2D2OgW?=\n\t=?utf-8?q?okLdRpCFmDVAp7G909xeWUS188ATksYyzeajZp9tq+tzxzbqcHoIR//sUhucN63T6?=\n\t=?utf-8?q?kPI8T7lcT8Hcfb7uCyzZQegPzYBjlzJItH36y5kr77kMuLfOt4Zo34uvnqYjKiR/F?=\n\t=?utf-8?q?CrCnGJ1GbZeUQYqZ0XEnnNbOd8mYtBYOgEULJwRUCXZLf83DD/ScbqTwH1HAiTiyN?=\n\t=?utf-8?q?BGHSaJaktEGNrlYEznGIUHj0sSnuzTgiseaXCv516sp64jIiwU4XqeCAv7i/zKgNw?=\n\t=?utf-8?q?V0DSEHwTqeOLptZbxeCDkII+6yfog80lUlf1+aJ3Zp+ZtQHrMyLbEwmNOS2GDwLiX?=\n\t=?utf-8?q?Ne5ecUpgnDw5jx6CcPrbPAtsmbDTUtKDx2q8tXEqsfWebMNxHICz0u3e+yv0P/GT5?=\n\t=?utf-8?q?WJVATAbiORrYdxnvEQCR9Y6VyDWTfqL6Lpci1vwJkjgkBsTA5/CxaUjBtNTGSNXBm?=\n\t=?utf-8?q?7JfwCT2Oj94Jr61VNDG/eqjj4F8rWhu9mA4zy3Kh/BSw4gvw377RY/mLn2OqlMlIz?=\n\t=?utf-8?q?evKUqRiqJ1wiInKiTbZ82wBK4c8cAYvSG7m32dkwrlPYgiAfpnQown65kq6kCztBl?=\n\t=?utf-8?q?YqVXu+i4kPimSnKTiFse2aT4h/97jpZ7ysPTcig+0/4cCJH8/XfJVBWkutM9fL4ys?=\n\t=?utf-8?q?6NvCmTwmeYjS01MXtlJtKCMOSdWLfYvrg3t8vmvGkD8MmGvELCOBp9WXFZw8kaO81?=\n\t=?utf-8?q?b5d1vDVEZKhLvMLCvlDj4DgNNj/Zxeyr1T4cQOzFl1X7xyf8yEOm33omFfrN6PhvF?=\n\t=?utf-8?q?UaRWMfs1COIGjlibFPLMUPU7jcZV+0Z5HhgGmbBLR/63vSfledcYlRIo7RQ7rv4ZP?=\n\t=?utf-8?q?o/TMoXQOrElY7ssLfH6CgldjtYUvYLs/0ZNInu3id33oRgjNjBZCrrSHPL5jPFyhO?=\n\t=?utf-8?q?TmfU7yxMy2zPN/w4cSuxy73oqLZGmlI8lsZ5qghl0OksQ4zWAI7rucCWvX5wEGmXJ?=\n\t=?utf-8?q?Iz9vifmPzHF2+OV+aOMQg3Heq8EyAA4VZgWpknAfsWSg/yLvsqmvbYAg2B8IMc9Uy?=\n\t=?utf-8?q?4VQut53/oxpYu0Ym8SLXgkbgiG9ZD7+pQQIMEjay3LS+U3sAWzwX5pP7Jci9O7gCn?=\n\t=?utf-8?q?pW3olH1ShxctQoj3PfSVaT6ldIKnThO92U67jtNZ5E4AfAx4meQcWlfHwy9g0enR9?=\n\t=?utf-8?q?U98lX3QOpFuq6hFXDQ/4304lSX+Sz6g/AX1NTqlAtCBmNWIdK41Jlw8ZZ1SIClNlI?=\n\t=?utf-8?q?wuol5EA8ajeCZL/N1+VkStEZUA0nXjLb2g=3D=3D?=", "X-OriginatorOrg": "corigine.com", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n 3394cd2c-d2a8-4718-4370-08db68aef944", "X-MS-Exchange-CrossTenant-AuthSource": "SJ0PR13MB5545.namprd13.prod.outlook.com", "X-MS-Exchange-CrossTenant-AuthAs": "Internal", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "09 Jun 2023 06:01:32.0757 (UTC)", "X-MS-Exchange-CrossTenant-FromEntityHeader": "Hosted", "X-MS-Exchange-CrossTenant-Id": "fe128f2c-073b-4c20-818e-7246a585940c", "X-MS-Exchange-CrossTenant-MailboxType": "HOSTED", "X-MS-Exchange-CrossTenant-UserPrincipalName": "\n mWAk5Kd8yQKMwvhLUWkkp1uOlX63QzrRJ+zzaUZ0TRehdeyocCzj4pEcag9JIye3WpBoznOYqe5ceFnDsV1rWRwvhOYBKxfnHWOh8gsL01s=", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "CO1PR13MB5046", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "From: Long Wu <long.wu@corigine.com>\n\nThe former logic does not consider the simultaneous initialization of\nseveral NICs using flower firmware. The reason the initialization\nfailed was because several NICs use the same name parameter when we\ncall rte_hash_create().\n\nWe use the PCI address to give each NIC a unique name parameter and let\nthe initializtion succeed.\n\nFixes: ac09376096d8 (\"net/nfp: add structures and functions for flow offload\")\nCc: chaoyong.he@corigine.com\nCc: stable@dpdk.org\n\nSigned-off-by: Long Wu <long.wu@corigine.com>\nReviewed-by: Niklas Söderlund <niklas.soderlund@corigine.com>\nReviewed-by: Chaoyong He <chaoyong.he@corigine.com>\n---\n drivers/net/nfp/nfp_flow.c | 16 +++++++++++++---\n 1 file changed, 13 insertions(+), 3 deletions(-)", "diff": "diff --git a/drivers/net/nfp/nfp_flow.c b/drivers/net/nfp/nfp_flow.c\nindex cb7073f361..d392f9c77b 100644\n--- a/drivers/net/nfp/nfp_flow.c\n+++ b/drivers/net/nfp/nfp_flow.c\n@@ -4105,11 +4105,21 @@ nfp_flow_priv_init(struct nfp_pf_dev *pf_dev)\n \tsize_t stats_size;\n \tuint64_t ctx_count;\n \tuint64_t ctx_split;\n+\tchar mask_name[RTE_HASH_NAMESIZE];\n+\tchar flow_name[RTE_HASH_NAMESIZE];\n+\tchar pretun_name[RTE_HASH_NAMESIZE];\n \tstruct nfp_flow_priv *priv;\n \tstruct nfp_app_fw_flower *app_fw_flower;\n \n+\tsnprintf(mask_name, sizeof(mask_name), \"%s_mask\",\n+\t\t\tpf_dev->pci_dev->device.name);\n+\tsnprintf(flow_name, sizeof(flow_name), \"%s_flow\",\n+\t\t\tpf_dev->pci_dev->device.name);\n+\tsnprintf(pretun_name, sizeof(pretun_name), \"%s_pretun\",\n+\t\t\tpf_dev->pci_dev->device.name);\n+\n \tstruct rte_hash_parameters mask_hash_params = {\n-\t\t.name = \"mask_hash_table\",\n+\t\t.name = mask_name,\n \t\t.entries = NFP_MASK_TABLE_ENTRIES,\n \t\t.hash_func = rte_jhash,\n \t\t.socket_id = rte_socket_id(),\n@@ -4118,7 +4128,7 @@ nfp_flow_priv_init(struct nfp_pf_dev *pf_dev)\n \t};\n \n \tstruct rte_hash_parameters flow_hash_params = {\n-\t\t.name = \"flow_hash_table\",\n+\t\t.name = flow_name,\n \t\t.hash_func = rte_jhash,\n \t\t.socket_id = rte_socket_id(),\n \t\t.key_len = sizeof(uint32_t),\n@@ -4126,7 +4136,7 @@ nfp_flow_priv_init(struct nfp_pf_dev *pf_dev)\n \t};\n \n \tstruct rte_hash_parameters pre_tun_hash_params = {\n-\t\t.name = \"pre_tunnel_table\",\n+\t\t.name = pretun_name,\n \t\t.entries = 32,\n \t\t.hash_func = rte_jhash,\n \t\t.socket_id = rte_socket_id(),\n", "prefixes": [ "3/3" ] }