Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/128447/?format=api
{ "id": 128447, "url": "https://patches.dpdk.org/api/patches/128447/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20230609060100.1306648-2-chaoyong.he@corigine.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230609060100.1306648-2-chaoyong.he@corigine.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20230609060100.1306648-2-chaoyong.he@corigine.com", "date": "2023-06-09T06:00:58", "name": "[1/3] net/nfp: fix control mempool creation failed", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "dd65b54283aa15bc359c7a18c0ae6310752a7337", "submitter": { "id": 2554, "url": "https://patches.dpdk.org/api/people/2554/?format=api", "name": "Chaoyong He", "email": "chaoyong.he@corigine.com" }, "delegate": { "id": 319, "url": "https://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20230609060100.1306648-2-chaoyong.he@corigine.com/mbox/", "series": [ { "id": 28426, "url": "https://patches.dpdk.org/api/series/28426/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=28426", "date": "2023-06-09T06:00:57", "name": "support using several cards in one host", "version": 1, "mbox": "https://patches.dpdk.org/series/28426/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/128447/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/128447/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 49FD142C69;\n\tFri, 9 Jun 2023 08:01:34 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id A98F241153;\n\tFri, 9 Jun 2023 08:01:31 +0200 (CEST)", "from NAM11-BN8-obe.outbound.protection.outlook.com\n (mail-bn8nam11on2100.outbound.protection.outlook.com [40.107.236.100])\n by mails.dpdk.org (Postfix) with ESMTP id 13A6540EDB;\n Fri, 9 Jun 2023 08:01:28 +0200 (CEST)", "from SJ0PR13MB5545.namprd13.prod.outlook.com (2603:10b6:a03:424::5)\n by CO1PR13MB5046.namprd13.prod.outlook.com (2603:10b6:303:f4::22)\n with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6455.33; Fri, 9 Jun\n 2023 06:01:27 +0000", "from SJ0PR13MB5545.namprd13.prod.outlook.com\n ([fe80::d2cb:a650:e1ce:2174]) by SJ0PR13MB5545.namprd13.prod.outlook.com\n ([fe80::d2cb:a650:e1ce:2174%3]) with mapi id 15.20.6455.030; Fri, 9 Jun 2023\n 06:01:26 +0000" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=SBL9DPTIXSN2gfTufYekJoSXjRrdQzOyn80LZ3RLgQ/Yb3JtggKshOIxCYhVOgTcvPjekpYFiOAt/pGoRcig/y3TQfk/3LLnGlup9LhFCqw4NGg4PwV+p57dZP3F4RqXC5tH40KEI3JIk7PDe5lcsIQkchBM/5yg0ZQndRV4+kGGoqPLI+ATk6KwXKsxdI1GT4XwzyWEVzcEnR15+ho6RnVM4nE/5gJRK9k89eAHM55YWHfQC+tavYTeN6lTvuNtFCNOCmJF+qQDZx783KTVTHMT/qYP5p6/6NXpQkSzcuNmgod7BDGLKxvtE16MkOg8DL4e78EgO7yf8KOGQizy3g==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=HCaOtTtT0hTnlGkIBAhqFT31hzzAs4KwZ5bdHw+1dS0=;\n b=PPrwAVnaGUftgE50VpUK4nnwD0hD4UqDAVhXBgwkm7yqEdMIQAHYyIYJKtsP9huXawNCpxhQqWwbaiH5j/QNcrXKnaC1ZNDnHgF0pGscAHIqoEG2d4oWpGTUbqnWKXRA1ufk9I87x1ip9FWG33rez+XF52ny0EWgIZPwsWNZJYaV1TuTz1qcqfRWEe8rUMnngzUjxe/Ok44N93CFyfhrYKEpQUvEojQxMFt48pY2BjNza0hg1pjqayWoHOemvemha/cW7wBpqt083BWZ60dpxz08A4PiRNXg0KUAJXPIigjo9HWa7AU/9LUoa2LRW6ZDOIYvff349/ZKxQ0SJwLDsg==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass\n smtp.mailfrom=corigine.com; dmarc=pass action=none header.from=corigine.com;\n dkim=pass header.d=corigine.com; arc=none", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=corigine.onmicrosoft.com; s=selector2-corigine-onmicrosoft-com;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=HCaOtTtT0hTnlGkIBAhqFT31hzzAs4KwZ5bdHw+1dS0=;\n b=PQkdw9C5UtSf6UrNa2mdlLbbxcY/ry48Kd7jj5whzeFUtFhr/oIVDg/CC3mwoBbwmWzocNPJYyex/UbgmGBLIOziHpmxFgAyY+iAgFNbwRrhLHZNEy3ll07QLLmn9VpvOPCjS0ncj+DdR7Z1zoOOSOWv03awdZZRhtZxvrPMrOk=", "Authentication-Results": "dkim=none (message not signed)\n header.d=none;dmarc=none action=none header.from=corigine.com;", "From": "Chaoyong He <chaoyong.he@corigine.com>", "To": "dev@dpdk.org", "Cc": "oss-drivers@corigine.com, niklas.soderlund@corigine.com,\n Long Wu <long.wu@corigine.com>, chaoyong.he@corigine.com, stable@dpdk.org", "Subject": "[PATCH 1/3] net/nfp: fix control mempool creation failed", "Date": "Fri, 9 Jun 2023 14:00:58 +0800", "Message-Id": "<20230609060100.1306648-2-chaoyong.he@corigine.com>", "X-Mailer": "git-send-email 2.39.1", "In-Reply-To": "<20230609060100.1306648-1-chaoyong.he@corigine.com>", "References": "<20230609060100.1306648-1-chaoyong.he@corigine.com>", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-ClientProxiedBy": "SG2P153CA0035.APCP153.PROD.OUTLOOK.COM (2603:1096:4:c7::22)\n To SJ0PR13MB5545.namprd13.prod.outlook.com\n (2603:10b6:a03:424::5)", "MIME-Version": "1.0", "X-MS-PublicTrafficType": "Email", "X-MS-TrafficTypeDiagnostic": "SJ0PR13MB5545:EE_|CO1PR13MB5046:EE_", "X-MS-Office365-Filtering-Correlation-Id": "ce698a9f-01dd-4250-f163-08db68aef620", "X-MS-Exchange-SenderADCheck": "1", "X-MS-Exchange-AntiSpam-Relay": "0", "X-Microsoft-Antispam": "BCL:0;", "X-Microsoft-Antispam-Message-Info": "\n u6kOtANFwr+2jMGl/qSG0nF9vc17foDfNPmw/+BY7VaEYbZrpSHXNiTLfik4YFNHIuOE+qv9tSVPFzPWrYTZ4po8S5Lq834vNgESmBkcRaQEKlSlkdfb21oPyP+vlpkg1fNvtuDKSwr2jOWmF/B4diOObUhi6lrVawJTrh7iXwPZ4b0eyZiSVJ9R7rnod64fKDA007Kil1a39g6zk7tZ0ZUC2xFYoeAM0mueLRS2T241vOby1CtpoBN0+OYuNzS6b5gOQ5p/bB5DKbMOXxaHkN3NcylPge7s1kV4xTZjSb/YVHmgUv9Llr1UIxO4tbsADdpU45rSucs9doJF3YiLw9VRVj7jKR0UjXhVMKvuNrkhKoOtbOzLQfjjX3LE3Rm9iyYB9AXSPXQa4dqDOyn9AUJKdQOMyAcpXspc5tIk/dcgbaghR2AxzV/X0GU6lRF9Py/JTVK9GcVu4Z9BjLYw0bXxsNpNw4RKSXCCyimIMXVjF/UW7IQ2MLvzT+39szXO/0Gck02Cv0LVXqpQkYmo4LNLUuzzt73rKxAATza4lfe3VcZ2sSuGxeIufhmdG5tC0w5DY9r/jarahFJc8LWK1mI4bZKEKB6DmgQWNLUA9AItFbbkDKHrqKcvzF5cpo6H", "X-Forefront-Antispam-Report": "CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;\n IPV:NLI; SFV:NSPM; H:SJ0PR13MB5545.namprd13.prod.outlook.com; PTR:; CAT:NONE;\n SFS:(13230028)(4636009)(396003)(39840400004)(136003)(346002)(376002)(366004)(451199021)(41300700001)(4326008)(66946007)(450100002)(66556008)(8676002)(478600001)(8936002)(6916009)(66476007)(2906002)(316002)(6666004)(44832011)(5660300002)(6486002)(52116002)(6506007)(6512007)(1076003)(26005)(186003)(2616005)(83380400001)(66574015)(36756003)(38100700002)(38350700002)(86362001);\n DIR:OUT; SFP:1102;", "X-MS-Exchange-AntiSpam-MessageData-ChunkCount": "1", "X-MS-Exchange-AntiSpam-MessageData-0": "=?utf-8?q?HvRN3omzv77W7J3K2XlnzfOceo8A?=\n\t=?utf-8?q?aymlrgHzsSs0UUpg3x+WkrYvMbYQwTJlNAle271izK8mmsvQxwzHJJO43Hws6jCdi?=\n\t=?utf-8?q?GzEdqRB45uL3r4p5RCVcFZDClPKQ7oKThNJMaDZjwAwjh+vxXMFzf0hLCbjHHdqRH?=\n\t=?utf-8?q?+Cv5caVL007OWaVcX3eQSDGsm7fN1kuQVr5+NEPCkOvtuh+1SZX5VwQJZjjKobqv3?=\n\t=?utf-8?q?AaYJ3i1RH2s7IuXnzsTWU5Hmv1u8ySRoFzJptQ5mQ+B3v939ZxYXdD9WV779oF/+R?=\n\t=?utf-8?q?BJuteKNeIM8lAb4AC/Mc6nlujNZkAbCDeZ1RIq0hPRVQorSiXkbN1oI/bIEu2Ruqm?=\n\t=?utf-8?q?3Vw626VOW5UpbxqI2rL5FVRXecEwLHjwkYhLBZE/lhWW+XQalDoRuSNEseDsPo6W+?=\n\t=?utf-8?q?wXwcLGMxeRleteD991csOGvGiy3+gf7Rj1eQIr0l9D6vwZp0TuRHhrdEUmv5fxm00?=\n\t=?utf-8?q?Tu7kensXZemRbejRgFuvfkhL9D5VSG6Lvi0yQOFpvjLM+QivOky4aSS0IjNUiPC0h?=\n\t=?utf-8?q?pBJCl5zBE/KX13BQLigs0Wxg2DGJVP+qPjSudBKj47Or6IVp/Asf7FkKFRLtFfvzQ?=\n\t=?utf-8?q?Z+pWyQb5el7KzK2sdIS6I811CAXzo0Cs5iRQAVM3wDqUvE4gGRMEjY7N6VRF5pzwE?=\n\t=?utf-8?q?ecADtHMkxvwrW74y03P+8XPm57jZXGuDw+kILaSDdzHeRZdw6N4YpL4so7aWrZsZU?=\n\t=?utf-8?q?LU9PbaJw2oVIcaov6Dd0RsXOr4V0FV89UQc0S+djDxWczrYoBohcuqdcUbLqzS9jb?=\n\t=?utf-8?q?ytkTvbSIss/SliEAFxLZTqQ9tIB9LaUeFvDgZ2Vop3pj2+Q3tN+UF21JCBcyGTpwB?=\n\t=?utf-8?q?bs4VuO5X3dXoLeFKrs8quDAlks4SXUwijjgsal+BA09iAXXhQU4Va+iPI6AQJkPmU?=\n\t=?utf-8?q?RfrPT2dzAlleU454kyVzAaltsLdmSx7wDHYSTVOg/2Rs5isp2sd+kTU55Jspt/dxz?=\n\t=?utf-8?q?xyQMkAw94ejy0W87sErze1ajkfyyUGoDCtprGwDtd+jCbQYaM48mR66EL7oSzxP2r?=\n\t=?utf-8?q?znuRSxgxh+W4HlVf/5rTto3PJjNmpjlB0R/mENgK5S9n2r3Dz1xHjTFAFR9tdrywL?=\n\t=?utf-8?q?7tIB8mLkEW1rN53GkoAi452nxfojAUZOa9rJ47SMGjZEXjMtyqHEoVrTOMWmunpWK?=\n\t=?utf-8?q?YcPAiVBSFWfg46vpUrl9/luJZUufc+GsZ2IQE93qFP+Nd5SEJaCjwEDVLj7OS7p89?=\n\t=?utf-8?q?ydkM+5dlfsCi6owNM36N21jz4QBeR9Bg0H5JIOBIfMUiNez3Ne+K8O+7jJrf4qbVJ?=\n\t=?utf-8?q?gH7A0Ez8HhjE5hzENLuvVFrAtSM1XtcFAo31UBNcwKpBBLs1yskqF6MMOVE1rM/9a?=\n\t=?utf-8?q?tbQHp31oWxEy3ckg/RTgKGmR393wM/XhOadkdQYbSiYU6Ywsht0g3CydRYnCb9ZdW?=\n\t=?utf-8?q?Z9YhJJNIoCk0qcIMZs5fSvk7mqUwphdO1lD7428mPBYvygUty9bbVo08lAxK9UwgT?=\n\t=?utf-8?q?33eUqcxzUplwurzO9wMENDWVAPE3OhZZUTH/FY9CUBeHViksOf1PdUpKnzBiEZgzk?=\n\t=?utf-8?q?RlIcjIvBFHGhPIwYr0GgfrLia1s3E5ngHA=3D=3D?=", "X-OriginatorOrg": "corigine.com", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n ce698a9f-01dd-4250-f163-08db68aef620", "X-MS-Exchange-CrossTenant-AuthSource": "SJ0PR13MB5545.namprd13.prod.outlook.com", "X-MS-Exchange-CrossTenant-AuthAs": "Internal", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "09 Jun 2023 06:01:26.8552 (UTC)", "X-MS-Exchange-CrossTenant-FromEntityHeader": "Hosted", "X-MS-Exchange-CrossTenant-Id": "fe128f2c-073b-4c20-818e-7246a585940c", "X-MS-Exchange-CrossTenant-MailboxType": "HOSTED", "X-MS-Exchange-CrossTenant-UserPrincipalName": "\n 3mVKqQsRwgZWYszN4e+vxoDmxjKzIt3YJ45YCUZws9F76c45V4qRIbPyRmPav2x1SXcZRb51+c310IYPi9JEhYwEL0VdLQmFydBfCPS7LFM=", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "CO1PR13MB5046", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "From: Long Wu <long.wu@corigine.com>\n\nThe former logic does not consider the simultaneous initialization of\nseveral NICs using flower firmware. The reason the initialization\nfailed was because several NICs use the same name parameter when we\ncall rte_pktmbuf_pool_create().\n\nWe use the PCI address to give each NIC a unique name parameter and let\nthe initializtion succeed.\n\nFixes: 945441ebdb9c (\"net/nfp: add flower ctrl VNIC\")\nCc: chaoyong.he@corigine.com\nCc: stable@dpdk.org\n\nSigned-off-by: Long Wu <long.wu@corigine.com>\nReviewed-by: Niklas Söderlund <niklas.soderlund@corigine.com>\nReviewed-by: Chaoyong He <chaoyong.he@corigine.com>\n---\n drivers/net/nfp/flower/nfp_flower.c | 6 +++++-\n 1 file changed, 5 insertions(+), 1 deletion(-)", "diff": "diff --git a/drivers/net/nfp/flower/nfp_flower.c b/drivers/net/nfp/flower/nfp_flower.c\nindex 8e1bc22747..53ee936f4c 100644\n--- a/drivers/net/nfp/flower/nfp_flower.c\n+++ b/drivers/net/nfp/flower/nfp_flower.c\n@@ -421,6 +421,7 @@ nfp_flower_init_ctrl_vnic(struct nfp_net_hw *hw)\n \tstruct rte_eth_dev *eth_dev;\n \tconst struct rte_memzone *tz;\n \tstruct nfp_app_fw_flower *app_fw_flower;\n+\tchar ctrl_pktmbuf_pool_name[RTE_MEMZONE_NAMESIZE];\n \n \t/* Set up some pointers here for ease of use */\n \tpf_dev = hw->pf_dev;\n@@ -454,7 +455,10 @@ nfp_flower_init_ctrl_vnic(struct nfp_net_hw *hw)\n \n \t/* Create a mbuf pool for the ctrl vNIC */\n \tnuma_node = rte_socket_id();\n-\tapp_fw_flower->ctrl_pktmbuf_pool = rte_pktmbuf_pool_create(\"ctrl_mbuf_pool\",\n+\tsnprintf(ctrl_pktmbuf_pool_name, sizeof(ctrl_pktmbuf_pool_name),\n+\t\t\t\"%s_ctrlmp\", pf_dev->pci_dev->device.name);\n+\tapp_fw_flower->ctrl_pktmbuf_pool =\n+\t\t\trte_pktmbuf_pool_create(ctrl_pktmbuf_pool_name,\n \t\t\t4 * CTRL_VNIC_NB_DESC, 64, 0, 9216, numa_node);\n \tif (app_fw_flower->ctrl_pktmbuf_pool == NULL) {\n \t\tPMD_INIT_LOG(ERR, \"Create mbuf pool for ctrl vnic failed\");\n", "prefixes": [ "1/3" ] }