Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 128280,
    "url": "https://patches.dpdk.org/api/patches/128280/?format=api",
    "web_url": "https://patches.dpdk.org/project/dpdk/patch/20230607074209.4798-3-haijie1@huawei.com/",
    "project": {
        "id": 1,
        "url": "https://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20230607074209.4798-3-haijie1@huawei.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20230607074209.4798-3-haijie1@huawei.com",
    "date": "2023-06-07T07:41:57",
    "name": "[v2,02/13] ethdev: extract telemetry codes to a file",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "7dedcbd8d379ec8a96571a55a3978dddcf6589e4",
    "submitter": {
        "id": 2935,
        "url": "https://patches.dpdk.org/api/people/2935/?format=api",
        "name": "Jie Hai",
        "email": "haijie1@huawei.com"
    },
    "delegate": {
        "id": 319,
        "url": "https://patches.dpdk.org/api/users/319/?format=api",
        "username": "fyigit",
        "first_name": "Ferruh",
        "last_name": "Yigit",
        "email": "ferruh.yigit@amd.com"
    },
    "mbox": "https://patches.dpdk.org/project/dpdk/patch/20230607074209.4798-3-haijie1@huawei.com/mbox/",
    "series": [
        {
            "id": 28386,
            "url": "https://patches.dpdk.org/api/series/28386/?format=api",
            "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=28386",
            "date": "2023-06-07T07:41:55",
            "name": "support telemetry query ethdev info",
            "version": 2,
            "mbox": "https://patches.dpdk.org/series/28386/mbox/"
        }
    ],
    "comments": "https://patches.dpdk.org/api/patches/128280/comments/",
    "check": "success",
    "checks": "https://patches.dpdk.org/api/patches/128280/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@inbox.dpdk.org",
        "Delivered-To": "patchwork@inbox.dpdk.org",
        "Received": [
            "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 42A2942C4A;\n\tWed,  7 Jun 2023 09:46:14 +0200 (CEST)",
            "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id B3DF742D20;\n\tWed,  7 Jun 2023 09:45:35 +0200 (CEST)",
            "from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188])\n by mails.dpdk.org (Postfix) with ESMTP id 14BB24113F\n for <dev@dpdk.org>; Wed,  7 Jun 2023 09:45:27 +0200 (CEST)",
            "from kwepemi500020.china.huawei.com (unknown [172.30.72.57])\n by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4QbfSX6ZqdzLqhN;\n Wed,  7 Jun 2023 15:42:20 +0800 (CST)",
            "from localhost.localdomain (10.69.192.56) by\n kwepemi500020.china.huawei.com (7.221.188.8) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id\n 15.1.2507.23; Wed, 7 Jun 2023 15:45:22 +0800"
        ],
        "From": "Jie Hai <haijie1@huawei.com>",
        "To": "Thomas Monjalon <thomas@monjalon.net>, Ferruh Yigit\n <ferruh.yigit@amd.com>, Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>",
        "CC": "<dev@dpdk.org>, <liudongdong3@huawei.com>",
        "Subject": "[PATCH v2 02/13] ethdev: extract telemetry codes to a file",
        "Date": "Wed, 7 Jun 2023 15:41:57 +0800",
        "Message-ID": "<20230607074209.4798-3-haijie1@huawei.com>",
        "X-Mailer": "git-send-email 2.33.0",
        "In-Reply-To": "<20230607074209.4798-1-haijie1@huawei.com>",
        "References": "<20230530090510.56812-1-haijie1@huawei.com>\n <20230607074209.4798-1-haijie1@huawei.com>",
        "MIME-Version": "1.0",
        "Content-Transfer-Encoding": "8bit",
        "Content-Type": "text/plain",
        "X-Originating-IP": "[10.69.192.56]",
        "X-ClientProxiedBy": "dggems704-chm.china.huawei.com (10.3.19.181) To\n kwepemi500020.china.huawei.com (7.221.188.8)",
        "X-CFilter-Loop": "Reflected",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.29",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org"
    },
    "content": "This patch extracts telemetry related codes in rte_ethdev.c\nto a new file rte_ethdev_telemetry.c.\n\nSigned-off-by: Jie Hai <haijie1@huawei.com>\n---\n lib/ethdev/meson.build            |   1 +\n lib/ethdev/rte_ethdev.c           | 332 ----------------------------\n lib/ethdev/rte_ethdev_telemetry.c | 344 ++++++++++++++++++++++++++++++\n 3 files changed, 345 insertions(+), 332 deletions(-)\n create mode 100644 lib/ethdev/rte_ethdev_telemetry.c",
    "diff": "diff --git a/lib/ethdev/meson.build b/lib/ethdev/meson.build\nindex 1ba0fac5c0f0..3497aa154844 100644\n--- a/lib/ethdev/meson.build\n+++ b/lib/ethdev/meson.build\n@@ -9,6 +9,7 @@ sources = files(\n         'rte_class_eth.c',\n         'rte_ethdev.c',\n         'rte_ethdev_cman.c',\n+        'rte_ethdev_telemetry.c',\n         'rte_flow.c',\n         'rte_mtr.c',\n         'rte_tm.c',\ndiff --git a/lib/ethdev/rte_ethdev.c b/lib/ethdev/rte_ethdev.c\nindex 503d500429c0..47a757a8fa93 100644\n--- a/lib/ethdev/rte_ethdev.c\n+++ b/lib/ethdev/rte_ethdev.c\n@@ -6380,317 +6380,6 @@ rte_eth_dev_pool_ops_supported(uint16_t port_id, const char *pool)\n \treturn ret;\n }\n \n-static int\n-eth_dev_handle_port_list(const char *cmd __rte_unused,\n-\t\tconst char *params __rte_unused,\n-\t\tstruct rte_tel_data *d)\n-{\n-\tint port_id;\n-\n-\trte_tel_data_start_array(d, RTE_TEL_INT_VAL);\n-\tRTE_ETH_FOREACH_DEV(port_id)\n-\t\trte_tel_data_add_array_int(d, port_id);\n-\treturn 0;\n-}\n-\n-static void\n-eth_dev_add_port_queue_stats(struct rte_tel_data *d, uint64_t *q_stats,\n-\t\tconst char *stat_name)\n-{\n-\tint q;\n-\tstruct rte_tel_data *q_data = rte_tel_data_alloc();\n-\tif (q_data == NULL)\n-\t\treturn;\n-\trte_tel_data_start_array(q_data, RTE_TEL_UINT_VAL);\n-\tfor (q = 0; q < RTE_ETHDEV_QUEUE_STAT_CNTRS; q++)\n-\t\trte_tel_data_add_array_uint(q_data, q_stats[q]);\n-\trte_tel_data_add_dict_container(d, stat_name, q_data, 0);\n-}\n-\n-#define ADD_DICT_STAT(stats, s) rte_tel_data_add_dict_uint(d, #s, stats.s)\n-\n-static int\n-eth_dev_handle_port_stats(const char *cmd __rte_unused,\n-\t\tconst char *params,\n-\t\tstruct rte_tel_data *d)\n-{\n-\tstruct rte_eth_stats stats;\n-\tint port_id, ret;\n-\n-\tif (params == NULL || strlen(params) == 0 || !isdigit(*params))\n-\t\treturn -1;\n-\n-\tport_id = atoi(params);\n-\tif (!rte_eth_dev_is_valid_port(port_id))\n-\t\treturn -1;\n-\n-\tret = rte_eth_stats_get(port_id, &stats);\n-\tif (ret < 0)\n-\t\treturn -1;\n-\n-\trte_tel_data_start_dict(d);\n-\tADD_DICT_STAT(stats, ipackets);\n-\tADD_DICT_STAT(stats, opackets);\n-\tADD_DICT_STAT(stats, ibytes);\n-\tADD_DICT_STAT(stats, obytes);\n-\tADD_DICT_STAT(stats, imissed);\n-\tADD_DICT_STAT(stats, ierrors);\n-\tADD_DICT_STAT(stats, oerrors);\n-\tADD_DICT_STAT(stats, rx_nombuf);\n-\teth_dev_add_port_queue_stats(d, stats.q_ipackets, \"q_ipackets\");\n-\teth_dev_add_port_queue_stats(d, stats.q_opackets, \"q_opackets\");\n-\teth_dev_add_port_queue_stats(d, stats.q_ibytes, \"q_ibytes\");\n-\teth_dev_add_port_queue_stats(d, stats.q_obytes, \"q_obytes\");\n-\teth_dev_add_port_queue_stats(d, stats.q_errors, \"q_errors\");\n-\n-\treturn 0;\n-}\n-\n-static int\n-eth_dev_parse_hide_zero(const char *key, const char *value, void *extra_args)\n-{\n-\tRTE_SET_USED(key);\n-\n-\tif (value == NULL)\n-\t\treturn -1;\n-\n-\tif (strcmp(value, \"true\") == 0)\n-\t\t*(bool *)extra_args = true;\n-\telse if (strcmp(value, \"false\") == 0)\n-\t\t*(bool *)extra_args = false;\n-\telse\n-\t\treturn -1;\n-\n-\treturn 0;\n-}\n-\n-static int\n-eth_dev_handle_port_xstats(const char *cmd __rte_unused,\n-\t\tconst char *params,\n-\t\tstruct rte_tel_data *d)\n-{\n-\tconst char *const valid_keys[] = { \"hide_zero\", NULL };\n-\tstruct rte_eth_xstat *eth_xstats;\n-\tstruct rte_eth_xstat_name *xstat_names;\n-\tstruct rte_kvargs *kvlist;\n-\tint port_id, num_xstats;\n-\tbool hide_zero = false;\n-\tchar *end_param;\n-\tint i, ret;\n-\n-\tif (params == NULL || strlen(params) == 0 || !isdigit(*params))\n-\t\treturn -1;\n-\n-\tport_id = strtoul(params, &end_param, 0);\n-\tif (!rte_eth_dev_is_valid_port(port_id))\n-\t\treturn -1;\n-\n-\tif (*end_param != '\\0') {\n-\t\tkvlist = rte_kvargs_parse(end_param, valid_keys);\n-\t\tret = rte_kvargs_process(kvlist, NULL, eth_dev_parse_hide_zero, &hide_zero);\n-\t\tif (kvlist == NULL || ret != 0)\n-\t\t\tRTE_ETHDEV_LOG(NOTICE,\n-\t\t\t\t\"Unknown extra parameters passed to ethdev telemetry command, ignoring\\n\");\n-\t\trte_kvargs_free(kvlist);\n-\t}\n-\n-\tnum_xstats = rte_eth_xstats_get(port_id, NULL, 0);\n-\tif (num_xstats < 0)\n-\t\treturn -1;\n-\n-\t/* use one malloc for both names and stats */\n-\teth_xstats = malloc((sizeof(struct rte_eth_xstat) +\n-\t\t\tsizeof(struct rte_eth_xstat_name)) * num_xstats);\n-\tif (eth_xstats == NULL)\n-\t\treturn -1;\n-\txstat_names = (void *)&eth_xstats[num_xstats];\n-\n-\tret = rte_eth_xstats_get_names(port_id, xstat_names, num_xstats);\n-\tif (ret < 0 || ret > num_xstats) {\n-\t\tfree(eth_xstats);\n-\t\treturn -1;\n-\t}\n-\n-\tret = rte_eth_xstats_get(port_id, eth_xstats, num_xstats);\n-\tif (ret < 0 || ret > num_xstats) {\n-\t\tfree(eth_xstats);\n-\t\treturn -1;\n-\t}\n-\n-\trte_tel_data_start_dict(d);\n-\tfor (i = 0; i < num_xstats; i++) {\n-\t\tif (hide_zero && eth_xstats[i].value == 0)\n-\t\t\tcontinue;\n-\t\trte_tel_data_add_dict_uint(d, xstat_names[i].name,\n-\t\t\t\t\t   eth_xstats[i].value);\n-\t}\n-\tfree(eth_xstats);\n-\treturn 0;\n-}\n-\n-#ifndef RTE_EXEC_ENV_WINDOWS\n-static int\n-eth_dev_handle_port_dump_priv(const char *cmd __rte_unused,\n-\t\t\tconst char *params,\n-\t\t\tstruct rte_tel_data *d)\n-{\n-\tchar *buf, *end_param;\n-\tint port_id, ret;\n-\tFILE *f;\n-\n-\tif (params == NULL || strlen(params) == 0 || !isdigit(*params))\n-\t\treturn -EINVAL;\n-\n-\tport_id = strtoul(params, &end_param, 0);\n-\tif (*end_param != '\\0')\n-\t\tRTE_ETHDEV_LOG(NOTICE,\n-\t\t\t\"Extra parameters passed to ethdev telemetry command, ignoring\");\n-\tif (!rte_eth_dev_is_valid_port(port_id))\n-\t\treturn -EINVAL;\n-\n-\tbuf = calloc(RTE_TEL_MAX_SINGLE_STRING_LEN, sizeof(char));\n-\tif (buf == NULL)\n-\t\treturn -ENOMEM;\n-\n-\tf = fmemopen(buf, RTE_TEL_MAX_SINGLE_STRING_LEN - 1, \"w+\");\n-\tif (f == NULL) {\n-\t\tfree(buf);\n-\t\treturn -EINVAL;\n-\t}\n-\n-\tret = rte_eth_dev_priv_dump(port_id, f);\n-\tfclose(f);\n-\tif (ret == 0) {\n-\t\trte_tel_data_start_dict(d);\n-\t\trte_tel_data_string(d, buf);\n-\t}\n-\n-\tfree(buf);\n-\treturn 0;\n-}\n-#endif /* !RTE_EXEC_ENV_WINDOWS */\n-\n-static int\n-eth_dev_handle_port_link_status(const char *cmd __rte_unused,\n-\t\tconst char *params,\n-\t\tstruct rte_tel_data *d)\n-{\n-\tstatic const char *status_str = \"status\";\n-\tint ret, port_id;\n-\tstruct rte_eth_link link;\n-\tchar *end_param;\n-\n-\tif (params == NULL || strlen(params) == 0 || !isdigit(*params))\n-\t\treturn -1;\n-\n-\tport_id = strtoul(params, &end_param, 0);\n-\tif (*end_param != '\\0')\n-\t\tRTE_ETHDEV_LOG(NOTICE,\n-\t\t\t\"Extra parameters passed to ethdev telemetry command, ignoring\");\n-\tif (!rte_eth_dev_is_valid_port(port_id))\n-\t\treturn -1;\n-\n-\tret = rte_eth_link_get_nowait(port_id, &link);\n-\tif (ret < 0)\n-\t\treturn -1;\n-\n-\trte_tel_data_start_dict(d);\n-\tif (!link.link_status) {\n-\t\trte_tel_data_add_dict_string(d, status_str, \"DOWN\");\n-\t\treturn 0;\n-\t}\n-\trte_tel_data_add_dict_string(d, status_str, \"UP\");\n-\trte_tel_data_add_dict_uint(d, \"speed\", link.link_speed);\n-\trte_tel_data_add_dict_string(d, \"duplex\",\n-\t\t\t(link.link_duplex == RTE_ETH_LINK_FULL_DUPLEX) ?\n-\t\t\t\t\"full-duplex\" : \"half-duplex\");\n-\treturn 0;\n-}\n-\n-static int\n-eth_dev_handle_port_info(const char *cmd __rte_unused,\n-\t\tconst char *params,\n-\t\tstruct rte_tel_data *d)\n-{\n-\tstruct rte_tel_data *rxq_state, *txq_state;\n-\tchar mac_addr[RTE_ETHER_ADDR_FMT_SIZE];\n-\tstruct rte_eth_dev *eth_dev;\n-\tchar *end_param;\n-\tint port_id, i;\n-\n-\tif (params == NULL || strlen(params) == 0 || !isdigit(*params))\n-\t\treturn -1;\n-\n-\tport_id = strtoul(params, &end_param, 0);\n-\tif (*end_param != '\\0')\n-\t\tRTE_ETHDEV_LOG(NOTICE,\n-\t\t\t\"Extra parameters passed to ethdev telemetry command, ignoring\");\n-\n-\tif (!rte_eth_dev_is_valid_port(port_id))\n-\t\treturn -EINVAL;\n-\n-\teth_dev = &rte_eth_devices[port_id];\n-\n-\trxq_state = rte_tel_data_alloc();\n-\tif (!rxq_state)\n-\t\treturn -ENOMEM;\n-\n-\ttxq_state = rte_tel_data_alloc();\n-\tif (!txq_state) {\n-\t\trte_tel_data_free(rxq_state);\n-\t\treturn -ENOMEM;\n-\t}\n-\n-\trte_tel_data_start_dict(d);\n-\trte_tel_data_add_dict_string(d, \"name\", eth_dev->data->name);\n-\trte_tel_data_add_dict_int(d, \"state\", eth_dev->state);\n-\trte_tel_data_add_dict_int(d, \"nb_rx_queues\",\n-\t\t\teth_dev->data->nb_rx_queues);\n-\trte_tel_data_add_dict_int(d, \"nb_tx_queues\",\n-\t\t\teth_dev->data->nb_tx_queues);\n-\trte_tel_data_add_dict_int(d, \"port_id\", eth_dev->data->port_id);\n-\trte_tel_data_add_dict_int(d, \"mtu\", eth_dev->data->mtu);\n-\trte_tel_data_add_dict_uint(d, \"rx_mbuf_size_min\",\n-\t\t\teth_dev->data->min_rx_buf_size);\n-\trte_ether_format_addr(mac_addr, sizeof(mac_addr),\n-\t\t\teth_dev->data->mac_addrs);\n-\trte_tel_data_add_dict_string(d, \"mac_addr\", mac_addr);\n-\trte_tel_data_add_dict_int(d, \"promiscuous\",\n-\t\t\teth_dev->data->promiscuous);\n-\trte_tel_data_add_dict_int(d, \"scattered_rx\",\n-\t\t\teth_dev->data->scattered_rx);\n-\trte_tel_data_add_dict_int(d, \"all_multicast\",\n-\t\t\teth_dev->data->all_multicast);\n-\trte_tel_data_add_dict_int(d, \"dev_started\", eth_dev->data->dev_started);\n-\trte_tel_data_add_dict_int(d, \"lro\", eth_dev->data->lro);\n-\trte_tel_data_add_dict_int(d, \"dev_configured\",\n-\t\t\teth_dev->data->dev_configured);\n-\n-\trte_tel_data_start_array(rxq_state, RTE_TEL_INT_VAL);\n-\tfor (i = 0; i < eth_dev->data->nb_rx_queues; i++)\n-\t\trte_tel_data_add_array_int(rxq_state,\n-\t\t\t\teth_dev->data->rx_queue_state[i]);\n-\n-\trte_tel_data_start_array(txq_state, RTE_TEL_INT_VAL);\n-\tfor (i = 0; i < eth_dev->data->nb_tx_queues; i++)\n-\t\trte_tel_data_add_array_int(txq_state,\n-\t\t\t\teth_dev->data->tx_queue_state[i]);\n-\n-\trte_tel_data_add_dict_container(d, \"rxq_state\", rxq_state, 0);\n-\trte_tel_data_add_dict_container(d, \"txq_state\", txq_state, 0);\n-\trte_tel_data_add_dict_int(d, \"numa_node\", eth_dev->data->numa_node);\n-\trte_tel_data_add_dict_uint_hex(d, \"dev_flags\",\n-\t\t\teth_dev->data->dev_flags, 0);\n-\trte_tel_data_add_dict_uint_hex(d, \"rx_offloads\",\n-\t\t\teth_dev->data->dev_conf.rxmode.offloads, 0);\n-\trte_tel_data_add_dict_uint_hex(d, \"tx_offloads\",\n-\t\t\teth_dev->data->dev_conf.txmode.offloads, 0);\n-\trte_tel_data_add_dict_uint_hex(d, \"ethdev_rss_hf\",\n-\t\t\teth_dev->data->dev_conf.rx_adv_conf.rss_conf.rss_hf, 0);\n-\n-\treturn 0;\n-}\n-\n int\n rte_eth_representor_info_get(uint16_t port_id,\n \t\t\t     struct rte_eth_representor_info *info)\n@@ -7033,24 +6722,3 @@ int rte_eth_dev_map_aggr_tx_affinity(uint16_t port_id, uint16_t tx_queue_id,\n }\n \n RTE_LOG_REGISTER_DEFAULT(rte_eth_dev_logtype, INFO);\n-\n-RTE_INIT(ethdev_init_telemetry)\n-{\n-\trte_telemetry_register_cmd(\"/ethdev/list\", eth_dev_handle_port_list,\n-\t\t\t\"Returns list of available ethdev ports. Takes no parameters\");\n-\trte_telemetry_register_cmd(\"/ethdev/stats\", eth_dev_handle_port_stats,\n-\t\t\t\"Returns the common stats for a port. Parameters: int port_id\");\n-\trte_telemetry_register_cmd(\"/ethdev/xstats\", eth_dev_handle_port_xstats,\n-\t\t\t\"Returns the extended stats for a port. Parameters: int port_id,hide_zero=true|false(Optional for indicates hide zero xstats)\");\n-#ifndef RTE_EXEC_ENV_WINDOWS\n-\trte_telemetry_register_cmd(\"/ethdev/dump_priv\", eth_dev_handle_port_dump_priv,\n-\t\t\t\"Returns dump private information for a port. Parameters: int port_id\");\n-#endif\n-\trte_telemetry_register_cmd(\"/ethdev/link_status\",\n-\t\t\teth_dev_handle_port_link_status,\n-\t\t\t\"Returns the link status for a port. Parameters: int port_id\");\n-\trte_telemetry_register_cmd(\"/ethdev/info\", eth_dev_handle_port_info,\n-\t\t\t\"Returns the device info for a port. Parameters: int port_id\");\n-\trte_telemetry_register_cmd(\"/ethdev/module_eeprom\", eth_dev_handle_port_module_eeprom,\n-\t\t\t\"Returns module EEPROM info with SFF specs. Parameters: int port_id\");\n-}\ndiff --git a/lib/ethdev/rte_ethdev_telemetry.c b/lib/ethdev/rte_ethdev_telemetry.c\nnew file mode 100644\nindex 000000000000..ec8e48877187\n--- /dev/null\n+++ b/lib/ethdev/rte_ethdev_telemetry.c\n@@ -0,0 +1,344 @@\n+/* SPDX-License-Identifier: BSD-3-Clause\n+ * Copyright(c) 2010-2017 Intel Corporation\n+ */\n+#include <ctype.h>\n+#include <stdlib.h>\n+\n+#include <rte_kvargs.h>\n+#include <rte_telemetry.h>\n+\n+#include \"rte_ethdev.h\"\n+#include \"ethdev_driver.h\"\n+#include \"sff_telemetry.h\"\n+\n+static int\n+eth_dev_handle_port_list(const char *cmd __rte_unused,\n+\t\tconst char *params __rte_unused,\n+\t\tstruct rte_tel_data *d)\n+{\n+\tint port_id;\n+\n+\trte_tel_data_start_array(d, RTE_TEL_INT_VAL);\n+\tRTE_ETH_FOREACH_DEV(port_id)\n+\t\trte_tel_data_add_array_int(d, port_id);\n+\treturn 0;\n+}\n+\n+static void\n+eth_dev_add_port_queue_stats(struct rte_tel_data *d, uint64_t *q_stats,\n+\t\tconst char *stat_name)\n+{\n+\tint q;\n+\tstruct rte_tel_data *q_data = rte_tel_data_alloc();\n+\tif (q_data == NULL)\n+\t\treturn;\n+\trte_tel_data_start_array(q_data, RTE_TEL_UINT_VAL);\n+\tfor (q = 0; q < RTE_ETHDEV_QUEUE_STAT_CNTRS; q++)\n+\t\trte_tel_data_add_array_uint(q_data, q_stats[q]);\n+\trte_tel_data_add_dict_container(d, stat_name, q_data, 0);\n+}\n+\n+static int\n+eth_dev_parse_hide_zero(const char *key, const char *value, void *extra_args)\n+{\n+\tRTE_SET_USED(key);\n+\n+\tif (value == NULL)\n+\t\treturn -1;\n+\n+\tif (strcmp(value, \"true\") == 0)\n+\t\t*(bool *)extra_args = true;\n+\telse if (strcmp(value, \"false\") == 0)\n+\t\t*(bool *)extra_args = false;\n+\telse\n+\t\treturn -1;\n+\n+\treturn 0;\n+}\n+\n+#define ADD_DICT_STAT(stats, s) rte_tel_data_add_dict_uint(d, #s, stats.s)\n+\n+static int\n+eth_dev_handle_port_stats(const char *cmd __rte_unused,\n+\t\tconst char *params,\n+\t\tstruct rte_tel_data *d)\n+{\n+\tstruct rte_eth_stats stats;\n+\tint port_id, ret;\n+\n+\tif (params == NULL || strlen(params) == 0 || !isdigit(*params))\n+\t\treturn -1;\n+\n+\tport_id = atoi(params);\n+\tif (!rte_eth_dev_is_valid_port(port_id))\n+\t\treturn -1;\n+\n+\tret = rte_eth_stats_get(port_id, &stats);\n+\tif (ret < 0)\n+\t\treturn -1;\n+\n+\trte_tel_data_start_dict(d);\n+\tADD_DICT_STAT(stats, ipackets);\n+\tADD_DICT_STAT(stats, opackets);\n+\tADD_DICT_STAT(stats, ibytes);\n+\tADD_DICT_STAT(stats, obytes);\n+\tADD_DICT_STAT(stats, imissed);\n+\tADD_DICT_STAT(stats, ierrors);\n+\tADD_DICT_STAT(stats, oerrors);\n+\tADD_DICT_STAT(stats, rx_nombuf);\n+\teth_dev_add_port_queue_stats(d, stats.q_ipackets, \"q_ipackets\");\n+\teth_dev_add_port_queue_stats(d, stats.q_opackets, \"q_opackets\");\n+\teth_dev_add_port_queue_stats(d, stats.q_ibytes, \"q_ibytes\");\n+\teth_dev_add_port_queue_stats(d, stats.q_obytes, \"q_obytes\");\n+\teth_dev_add_port_queue_stats(d, stats.q_errors, \"q_errors\");\n+\n+\treturn 0;\n+}\n+\n+static int\n+eth_dev_handle_port_xstats(const char *cmd __rte_unused,\n+\t\tconst char *params,\n+\t\tstruct rte_tel_data *d)\n+{\n+\tconst char *const valid_keys[] = { \"hide_zero\", NULL };\n+\tstruct rte_eth_xstat *eth_xstats;\n+\tstruct rte_eth_xstat_name *xstat_names;\n+\tstruct rte_kvargs *kvlist;\n+\tint port_id, num_xstats;\n+\tbool hide_zero = false;\n+\tchar *end_param;\n+\tint i, ret;\n+\n+\tif (params == NULL || strlen(params) == 0 || !isdigit(*params))\n+\t\treturn -1;\n+\n+\tport_id = strtoul(params, &end_param, 0);\n+\tif (!rte_eth_dev_is_valid_port(port_id))\n+\t\treturn -1;\n+\n+\tif (*end_param != '\\0') {\n+\t\tkvlist = rte_kvargs_parse(end_param, valid_keys);\n+\t\tret = rte_kvargs_process(kvlist, NULL, eth_dev_parse_hide_zero, &hide_zero);\n+\t\tif (kvlist == NULL || ret != 0)\n+\t\t\tRTE_ETHDEV_LOG(NOTICE,\n+\t\t\t\t\"Unknown extra parameters passed to ethdev telemetry command, ignoring\\n\");\n+\t\trte_kvargs_free(kvlist);\n+\t}\n+\n+\tnum_xstats = rte_eth_xstats_get(port_id, NULL, 0);\n+\tif (num_xstats < 0)\n+\t\treturn -1;\n+\n+\t/* use one malloc for both names and stats */\n+\teth_xstats = malloc((sizeof(struct rte_eth_xstat) +\n+\t\t\tsizeof(struct rte_eth_xstat_name)) * num_xstats);\n+\tif (eth_xstats == NULL)\n+\t\treturn -1;\n+\txstat_names = (void *)&eth_xstats[num_xstats];\n+\n+\tret = rte_eth_xstats_get_names(port_id, xstat_names, num_xstats);\n+\tif (ret < 0 || ret > num_xstats) {\n+\t\tfree(eth_xstats);\n+\t\treturn -1;\n+\t}\n+\n+\tret = rte_eth_xstats_get(port_id, eth_xstats, num_xstats);\n+\tif (ret < 0 || ret > num_xstats) {\n+\t\tfree(eth_xstats);\n+\t\treturn -1;\n+\t}\n+\n+\trte_tel_data_start_dict(d);\n+\tfor (i = 0; i < num_xstats; i++) {\n+\t\tif (hide_zero && eth_xstats[i].value == 0)\n+\t\t\tcontinue;\n+\t\trte_tel_data_add_dict_uint(d, xstat_names[i].name,\n+\t\t\t\t\t   eth_xstats[i].value);\n+\t}\n+\tfree(eth_xstats);\n+\treturn 0;\n+}\n+\n+#ifndef RTE_EXEC_ENV_WINDOWS\n+static int\n+eth_dev_handle_port_dump_priv(const char *cmd __rte_unused,\n+\t\t\tconst char *params,\n+\t\t\tstruct rte_tel_data *d)\n+{\n+\tchar *buf, *end_param;\n+\tint port_id, ret;\n+\tFILE *f;\n+\n+\tif (params == NULL || strlen(params) == 0 || !isdigit(*params))\n+\t\treturn -EINVAL;\n+\n+\tport_id = strtoul(params, &end_param, 0);\n+\tif (*end_param != '\\0')\n+\t\tRTE_ETHDEV_LOG(NOTICE,\n+\t\t\t\"Extra parameters passed to ethdev telemetry command, ignoring\");\n+\tif (!rte_eth_dev_is_valid_port(port_id))\n+\t\treturn -EINVAL;\n+\n+\tbuf = calloc(RTE_TEL_MAX_SINGLE_STRING_LEN, sizeof(char));\n+\tif (buf == NULL)\n+\t\treturn -ENOMEM;\n+\n+\tf = fmemopen(buf, RTE_TEL_MAX_SINGLE_STRING_LEN - 1, \"w+\");\n+\tif (f == NULL) {\n+\t\tfree(buf);\n+\t\treturn -EINVAL;\n+\t}\n+\n+\tret = rte_eth_dev_priv_dump(port_id, f);\n+\tfclose(f);\n+\tif (ret == 0) {\n+\t\trte_tel_data_start_dict(d);\n+\t\trte_tel_data_string(d, buf);\n+\t}\n+\n+\tfree(buf);\n+\treturn 0;\n+}\n+#endif /* !RTE_EXEC_ENV_WINDOWS */\n+\n+static int\n+eth_dev_handle_port_link_status(const char *cmd __rte_unused,\n+\t\tconst char *params,\n+\t\tstruct rte_tel_data *d)\n+{\n+\tstatic const char *status_str = \"status\";\n+\tint ret, port_id;\n+\tstruct rte_eth_link link;\n+\tchar *end_param;\n+\n+\tif (params == NULL || strlen(params) == 0 || !isdigit(*params))\n+\t\treturn -1;\n+\n+\tport_id = strtoul(params, &end_param, 0);\n+\tif (*end_param != '\\0')\n+\t\tRTE_ETHDEV_LOG(NOTICE,\n+\t\t\t\"Extra parameters passed to ethdev telemetry command, ignoring\");\n+\tif (!rte_eth_dev_is_valid_port(port_id))\n+\t\treturn -1;\n+\n+\tret = rte_eth_link_get_nowait(port_id, &link);\n+\tif (ret < 0)\n+\t\treturn -1;\n+\n+\trte_tel_data_start_dict(d);\n+\tif (!link.link_status) {\n+\t\trte_tel_data_add_dict_string(d, status_str, \"DOWN\");\n+\t\treturn 0;\n+\t}\n+\trte_tel_data_add_dict_string(d, status_str, \"UP\");\n+\trte_tel_data_add_dict_uint(d, \"speed\", link.link_speed);\n+\trte_tel_data_add_dict_string(d, \"duplex\",\n+\t\t\t(link.link_duplex == RTE_ETH_LINK_FULL_DUPLEX) ?\n+\t\t\t\t\"full-duplex\" : \"half-duplex\");\n+\treturn 0;\n+}\n+\n+static int\n+eth_dev_handle_port_info(const char *cmd __rte_unused,\n+\t\tconst char *params,\n+\t\tstruct rte_tel_data *d)\n+{\n+\tstruct rte_tel_data *rxq_state, *txq_state;\n+\tchar mac_addr[RTE_ETHER_ADDR_FMT_SIZE];\n+\tstruct rte_eth_dev *eth_dev;\n+\tchar *end_param;\n+\tint port_id, i;\n+\n+\tif (params == NULL || strlen(params) == 0 || !isdigit(*params))\n+\t\treturn -1;\n+\n+\tport_id = strtoul(params, &end_param, 0);\n+\tif (*end_param != '\\0')\n+\t\tRTE_ETHDEV_LOG(NOTICE,\n+\t\t\t\"Extra parameters passed to ethdev telemetry command, ignoring\");\n+\n+\tif (!rte_eth_dev_is_valid_port(port_id))\n+\t\treturn -EINVAL;\n+\n+\teth_dev = &rte_eth_devices[port_id];\n+\n+\trxq_state = rte_tel_data_alloc();\n+\tif (!rxq_state)\n+\t\treturn -ENOMEM;\n+\n+\ttxq_state = rte_tel_data_alloc();\n+\tif (!txq_state) {\n+\t\trte_tel_data_free(rxq_state);\n+\t\treturn -ENOMEM;\n+\t}\n+\n+\trte_tel_data_start_dict(d);\n+\trte_tel_data_add_dict_string(d, \"name\", eth_dev->data->name);\n+\trte_tel_data_add_dict_int(d, \"state\", eth_dev->state);\n+\trte_tel_data_add_dict_int(d, \"nb_rx_queues\",\n+\t\t\teth_dev->data->nb_rx_queues);\n+\trte_tel_data_add_dict_int(d, \"nb_tx_queues\",\n+\t\t\teth_dev->data->nb_tx_queues);\n+\trte_tel_data_add_dict_int(d, \"port_id\", eth_dev->data->port_id);\n+\trte_tel_data_add_dict_int(d, \"mtu\", eth_dev->data->mtu);\n+\trte_tel_data_add_dict_uint(d, \"rx_mbuf_size_min\",\n+\t\t\teth_dev->data->min_rx_buf_size);\n+\trte_ether_format_addr(mac_addr, sizeof(mac_addr),\n+\t\t\teth_dev->data->mac_addrs);\n+\trte_tel_data_add_dict_string(d, \"mac_addr\", mac_addr);\n+\trte_tel_data_add_dict_int(d, \"promiscuous\",\n+\t\t\teth_dev->data->promiscuous);\n+\trte_tel_data_add_dict_int(d, \"scattered_rx\",\n+\t\t\teth_dev->data->scattered_rx);\n+\trte_tel_data_add_dict_int(d, \"all_multicast\",\n+\t\t\teth_dev->data->all_multicast);\n+\trte_tel_data_add_dict_int(d, \"dev_started\", eth_dev->data->dev_started);\n+\trte_tel_data_add_dict_int(d, \"lro\", eth_dev->data->lro);\n+\trte_tel_data_add_dict_int(d, \"dev_configured\",\n+\t\t\teth_dev->data->dev_configured);\n+\n+\trte_tel_data_start_array(rxq_state, RTE_TEL_INT_VAL);\n+\tfor (i = 0; i < eth_dev->data->nb_rx_queues; i++)\n+\t\trte_tel_data_add_array_int(rxq_state,\n+\t\t\t\teth_dev->data->rx_queue_state[i]);\n+\n+\trte_tel_data_start_array(txq_state, RTE_TEL_INT_VAL);\n+\tfor (i = 0; i < eth_dev->data->nb_tx_queues; i++)\n+\t\trte_tel_data_add_array_int(txq_state,\n+\t\t\t\teth_dev->data->tx_queue_state[i]);\n+\n+\trte_tel_data_add_dict_container(d, \"rxq_state\", rxq_state, 0);\n+\trte_tel_data_add_dict_container(d, \"txq_state\", txq_state, 0);\n+\trte_tel_data_add_dict_int(d, \"numa_node\", eth_dev->data->numa_node);\n+\trte_tel_data_add_dict_uint_hex(d, \"dev_flags\",\n+\t\t\teth_dev->data->dev_flags, 0);\n+\trte_tel_data_add_dict_uint_hex(d, \"rx_offloads\",\n+\t\t\teth_dev->data->dev_conf.rxmode.offloads, 0);\n+\trte_tel_data_add_dict_uint_hex(d, \"tx_offloads\",\n+\t\t\teth_dev->data->dev_conf.txmode.offloads, 0);\n+\trte_tel_data_add_dict_uint_hex(d, \"ethdev_rss_hf\",\n+\t\t\teth_dev->data->dev_conf.rx_adv_conf.rss_conf.rss_hf, 0);\n+\n+\treturn 0;\n+}\n+\n+RTE_INIT(ethdev_init_telemetry)\n+{\n+\trte_telemetry_register_cmd(\"/ethdev/list\", eth_dev_handle_port_list,\n+\t\t\t\"Returns list of available ethdev ports. Takes no parameters\");\n+\trte_telemetry_register_cmd(\"/ethdev/stats\", eth_dev_handle_port_stats,\n+\t\t\t\"Returns the common stats for a port. Parameters: int port_id\");\n+\trte_telemetry_register_cmd(\"/ethdev/xstats\", eth_dev_handle_port_xstats,\n+\t\t\t\"Returns the extended stats for a port. Parameters: int port_id,hide_zero=true|false(Optional for indicates hide zero xstats)\");\n+#ifndef RTE_EXEC_ENV_WINDOWS\n+\trte_telemetry_register_cmd(\"/ethdev/dump_priv\", eth_dev_handle_port_dump_priv,\n+\t\t\t\"Returns dump private information for a port. Parameters: int port_id\");\n+#endif\n+\trte_telemetry_register_cmd(\"/ethdev/link_status\",\n+\t\t\teth_dev_handle_port_link_status,\n+\t\t\t\"Returns the link status for a port. Parameters: int port_id\");\n+\trte_telemetry_register_cmd(\"/ethdev/info\", eth_dev_handle_port_info,\n+\t\t\t\"Returns the device info for a port. Parameters: int port_id\");\n+\trte_telemetry_register_cmd(\"/ethdev/module_eeprom\", eth_dev_handle_port_module_eeprom,\n+\t\t\t\"Returns module EEPROM info with SFF specs. Parameters: int port_id\");\n+}\n",
    "prefixes": [
        "v2",
        "02/13"
    ]
}