Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 12797,
    "url": "https://patches.dpdk.org/api/patches/12797/?format=api",
    "web_url": "https://patches.dpdk.org/project/dpdk/patch/1463468749-22097-1-git-send-email-thomas.monjalon@6wind.com/",
    "project": {
        "id": 1,
        "url": "https://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<1463468749-22097-1-git-send-email-thomas.monjalon@6wind.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/1463468749-22097-1-git-send-email-thomas.monjalon@6wind.com",
    "date": "2016-05-17T07:05:49",
    "name": "[dpdk-dev,v2] app/test: fix log check when default level is high",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "049ca51816d388add69d71e12c48379572febc77",
    "submitter": {
        "id": 1,
        "url": "https://patches.dpdk.org/api/people/1/?format=api",
        "name": "Thomas Monjalon",
        "email": "thomas.monjalon@6wind.com"
    },
    "delegate": {
        "id": 1,
        "url": "https://patches.dpdk.org/api/users/1/?format=api",
        "username": "tmonjalo",
        "first_name": "Thomas",
        "last_name": "Monjalon",
        "email": "thomas@monjalon.net"
    },
    "mbox": "https://patches.dpdk.org/project/dpdk/patch/1463468749-22097-1-git-send-email-thomas.monjalon@6wind.com/mbox/",
    "series": [],
    "comments": "https://patches.dpdk.org/api/patches/12797/comments/",
    "check": "pending",
    "checks": "https://patches.dpdk.org/api/patches/12797/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id DA82E5AB3;\n\tTue, 17 May 2016 09:06:08 +0200 (CEST)",
            "from mail-wm0-f49.google.com (mail-wm0-f49.google.com\n\t[74.125.82.49]) by dpdk.org (Postfix) with ESMTP id C3FD85AAB\n\tfor <dev@dpdk.org>; Tue, 17 May 2016 09:06:07 +0200 (CEST)",
            "by mail-wm0-f49.google.com with SMTP id n129so127102700wmn.1\n\tfor <dev@dpdk.org>; Tue, 17 May 2016 00:06:07 -0700 (PDT)",
            "from XPS13.localdomain ([37.160.16.188])\n\tby smtp.gmail.com with ESMTPSA id\n\tb12sm22284056wmb.0.2016.05.17.00.06.05\n\tfor <dev@dpdk.org> (version=TLSv1/SSLv3 cipher=OTHER);\n\tTue, 17 May 2016 00:06:06 -0700 (PDT)"
        ],
        "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=6wind-com.20150623.gappssmtp.com; s=20150623;\n\th=from:to:subject:date:message-id:in-reply-to:references;\n\tbh=x98lmwe5uZTpKxJUjAnaOjX0unXhHtzkFLhDkFb9bxk=;\n\tb=ehzaFJtU55GK8dqBtRBvvqY9BpoPSUvx5lpCrhynBpJ/4c3wWIf0//gXv0dYi/uar2\n\tNHhnCHA69RLk2//0hzW+SQo88f0vAjoYMBuEfaMlrPQpSbpMltnxwN0YOVC7SSWG4HBF\n\tAk5I4cPVfYdpHO4PsnqGUSm/q+JB9Nw2R8FD/y116TvKZ8YEO0JxelJzo5slv/Ex7iCc\n\t2Ix6/o2BWxpQesWFvUtBA11NBkX4GT6HQdgEQp9pengnngWRGO3zSfAwhzwY+lugB0VE\n\t+OAkRhBu+pRFxg3oe+nsHdPwTMP+zIgaGbbVkTYbfc4sVb89N+JSsaYXZQC2evcHola5\n\tSNoQ==",
        "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20130820;\n\th=x-gm-message-state:from:to:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=x98lmwe5uZTpKxJUjAnaOjX0unXhHtzkFLhDkFb9bxk=;\n\tb=BOB3EbVZR/eYNOcH+8ujIBHEpPoVvMvSxkgAZy5IvWwmzY56ZH09ttbq+QgBqEeilg\n\tC8o59WILNExpCdFhZ4FI2hiQhGBUCYfls60v29XkijpDtowkl6yxkw84/rcAxQMe36Ck\n\tQf8hjjKbZpOO1JcF42m9NG+6scniLNCR61Dli3EMnK1yZ9N69KnsQbHY76U4bBOirdFL\n\t/8PUYD3w4u3bn4nErBtJ/peFNjuRnRd/l3fxj6cuEQB7pXwPJUvPuzLps45NplY0Eg+8\n\trpFjdSQEGVPpwiketaSgZ0zPFu2cBcRin9bAOeW4HWSdbezC8WS3dDRnLjWm9seOp6Jg\n\tKQVA==",
        "X-Gm-Message-State": "AOPr4FWadomaOP1aR8ef5r3a6+JPXCljX6XMAP8Vf9iFC9RXOHtXvUI8oXAcpUw6oDDl+gib",
        "X-Received": "by 10.28.194.69 with SMTP id s66mr22906359wmf.88.1463468767602; \n\tTue, 17 May 2016 00:06:07 -0700 (PDT)",
        "From": "Thomas Monjalon <thomas.monjalon@6wind.com>",
        "To": "dev@dpdk.org",
        "Date": "Tue, 17 May 2016 09:05:49 +0200",
        "Message-Id": "<1463468749-22097-1-git-send-email-thomas.monjalon@6wind.com>",
        "X-Mailer": "git-send-email 2.7.0",
        "In-Reply-To": "<CALwxeUu_ina5L=cN0=4eO0PzV4zF7YC24kHKoE4ycm=UJ-zTKQ@mail.gmail.com>",
        "References": "<CALwxeUu_ina5L=cN0=4eO0PzV4zF7YC24kHKoE4ycm=UJ-zTKQ@mail.gmail.com>",
        "Subject": "[dpdk-dev] [PATCH v2] app/test: fix log check when default level is\n\thigh",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "patches and discussions about DPDK <dev.dpdk.org>",
        "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://dpdk.org/ml/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "The log unit test was checking display of low priority messages.\nIt was not working if RTE_LOG_LEVEL is not RTE_LOG_DEBUG.\nIt is even easier to see since the default level is INFO (9b9d7ca).\n\nNow the test use ERR and CRIT levels which should be always enabled\nwhile not trigerring syslog output on the console.\n\nSigned-off-by: Thomas Monjalon <thomas.monjalon@6wind.com>\n---\nv2:\n- fix comments for the log levels\n- add comments to explain the test\n\n app/test/autotest_test_funcs.py | 21 +++++++++------------\n app/test/test_logs.c            | 27 +++++++++++++--------------\n 2 files changed, 22 insertions(+), 26 deletions(-)",
    "diff": "diff --git a/app/test/autotest_test_funcs.py b/app/test/autotest_test_funcs.py\nindex 0f012f6..adbd8c9 100644\n--- a/app/test/autotest_test_funcs.py\n+++ b/app/test/autotest_test_funcs.py\n@@ -144,19 +144,16 @@ def logs_autotest(child, test_name):\n \ti = 0\n \tchild.sendline(test_name)\n \n+\t# logs sequence is printed twice because of history dump\n \tlog_list = [\n-\t\t\"TESTAPP1: this is a debug level message\",\n-\t\t\"TESTAPP1: this is a info level message\",\n-\t\t\"TESTAPP1: this is a warning level message\",\n-\t\t\"TESTAPP2: this is a info level message\",\n-\t\t\"TESTAPP2: this is a warning level message\",\n-\t\t\"TESTAPP1: this is a debug level message\",\n-\t\t\"TESTAPP1: this is a debug level message\",\n-\t\t\"TESTAPP1: this is a info level message\",\n-\t\t\"TESTAPP1: this is a warning level message\",\n-\t\t\"TESTAPP2: this is a info level message\",\n-\t\t\"TESTAPP2: this is a warning level message\",\n-\t\t\"TESTAPP1: this is a debug level message\",\n+\t\t\"TESTAPP1: error message\",\n+\t\t\"TESTAPP1: critical message\",\n+\t\t\"TESTAPP2: critical message\",\n+\t\t\"TESTAPP1: error message\",\n+\t\t\"TESTAPP1: error message\",\n+\t\t\"TESTAPP1: critical message\",\n+\t\t\"TESTAPP2: critical message\",\n+\t\t\"TESTAPP1: error message\",\n \t]\n \n \tfor log_msg in log_list:\ndiff --git a/app/test/test_logs.c b/app/test/test_logs.c\nindex 18a3b6a..05aa862 100644\n--- a/app/test/test_logs.c\n+++ b/app/test/test_logs.c\n@@ -65,26 +65,25 @@ test_logs(void)\n \trte_set_log_type(RTE_LOGTYPE_TESTAPP1, 1);\n \trte_set_log_type(RTE_LOGTYPE_TESTAPP2, 1);\n \n-\t/* log in debug level */\n-\trte_set_log_level(RTE_LOG_DEBUG);\n-\tRTE_LOG(DEBUG, TESTAPP1, \"this is a debug level message\\n\");\n-\tRTE_LOG(INFO, TESTAPP1, \"this is a info level message\\n\");\n-\tRTE_LOG(WARNING, TESTAPP1, \"this is a warning level message\\n\");\n+\t/* log in error level */\n+\trte_set_log_level(RTE_LOG_ERR);\n+\tRTE_LOG(ERR, TESTAPP1, \"error message\\n\");\n+\tRTE_LOG(CRIT, TESTAPP1, \"critical message\\n\");\n \n-\t/* log in info level */\n-\trte_set_log_level(RTE_LOG_INFO);\n-\tRTE_LOG(DEBUG, TESTAPP2, \"debug level message (not displayed)\\n\");\n-\tRTE_LOG(INFO, TESTAPP2, \"this is a info level message\\n\");\n-\tRTE_LOG(WARNING, TESTAPP2, \"this is a warning level message\\n\");\n+\t/* log in critical level */\n+\trte_set_log_level(RTE_LOG_CRIT);\n+\tRTE_LOG(ERR, TESTAPP2, \"error message (not displayed)\\n\");\n+\tRTE_LOG(CRIT, TESTAPP2, \"critical message\\n\");\n \n \t/* disable one log type */\n \trte_set_log_type(RTE_LOGTYPE_TESTAPP2, 0);\n \n-\t/* log in debug level */\n-\trte_set_log_level(RTE_LOG_DEBUG);\n-\tRTE_LOG(DEBUG, TESTAPP1, \"this is a debug level message\\n\");\n-\tRTE_LOG(DEBUG, TESTAPP2, \"debug level message (not displayed)\\n\");\n+\t/* log in error level */\n+\trte_set_log_level(RTE_LOG_ERR);\n+\tRTE_LOG(ERR, TESTAPP1, \"error message\\n\");\n+\tRTE_LOG(ERR, TESTAPP2, \"error message (not displayed)\\n\");\n \n+\t/* print again the previous logs */\n \trte_log_dump_history(stdout);\n \n \treturn 0;\n",
    "prefixes": [
        "dpdk-dev",
        "v2"
    ]
}