Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/127955/?format=api
{ "id": 127955, "url": "https://patches.dpdk.org/api/patches/127955/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/98CBD80474FA8B44BF855DF32C47DC35D8798A@smartserver.smartshare.dk/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<98CBD80474FA8B44BF855DF32C47DC35D8798A@smartserver.smartshare.dk>", "list_archive_url": "https://inbox.dpdk.org/dev/98CBD80474FA8B44BF855DF32C47DC35D8798A@smartserver.smartshare.dk", "date": "2023-06-02T10:15:45", "name": "[v7,1/4] net/bnx2x: fix warnings about rte_memcpy lengths", "commit_ref": null, "pull_url": null, "state": "not-applicable", "archived": true, "hash": "38ff21c9ee9d1b7dc8f05f8e114e18d13ae52cbb", "submitter": { "id": 591, "url": "https://patches.dpdk.org/api/people/591/?format=api", "name": "Morten Brørup", "email": "mb@smartsharesystems.com" }, "delegate": null, "mbox": "https://patches.dpdk.org/project/dpdk/patch/98CBD80474FA8B44BF855DF32C47DC35D8798A@smartserver.smartshare.dk/mbox/", "series": [ { "id": 28323, "url": "https://patches.dpdk.org/api/series/28323/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=28323", "date": "2023-06-02T10:15:45", "name": "[v7,1/4] net/bnx2x: fix warnings about rte_memcpy lengths", "version": 7, "mbox": "https://patches.dpdk.org/series/28323/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/127955/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/127955/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 6711842BC3;\n\tFri, 2 Jun 2023 12:15:50 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 6E2B340ED8;\n\tFri, 2 Jun 2023 12:15:49 +0200 (CEST)", "from dkmailrelay1.smartsharesystems.com\n (smartserver.smartsharesystems.com [77.243.40.215])\n by mails.dpdk.org (Postfix) with ESMTP id 34EF2406B8\n for <dev@dpdk.org>; Fri, 2 Jun 2023 12:15:48 +0200 (CEST)", "from smartserver.smartsharesystems.com\n (smartserver.smartsharesys.local [192.168.4.10])\n by dkmailrelay1.smartsharesystems.com (Postfix) with ESMTP id 350BD20955;\n Fri, 2 Jun 2023 12:15:47 +0200 (CEST)" ], "Content-class": "urn:content-classes:message", "MIME-Version": "1.0", "Content-Type": "text/plain;\n\tcharset=\"UTF-8\"", "Content-Transfer-Encoding": "base64", "Subject": "FW: [PATCH v7 1/4] net/bnx2x: fix warnings about rte_memcpy lengths", "X-MimeOLE": "Produced By Microsoft Exchange V6.5", "Date": "Fri, 2 Jun 2023 12:15:45 +0200", "Message-ID": "<98CBD80474FA8B44BF855DF32C47DC35D8798A@smartserver.smartshare.dk>", "X-MS-Has-Attach": "", "X-MS-TNEF-Correlator": "", "Thread-Topic": "[PATCH v7 1/4] net/bnx2x: fix warnings about rte_memcpy lengths", "Thread-Index": "Adkpq3rrB18hK2LhRyOdgd/No9Pynhrj0gtA", "From": "=?utf-8?q?Morten_Br=C3=B8rup?= <mb@smartsharesystems.com>", "To": "\"Julien Aube\" <julien_dpdk@jaube.fr>", "Cc": "<dev@dpdk.org>", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Julien, welcome aboard as the new bnx2x maintainer. Can you please review this patch?\n\nMed venlig hilsen / Kind regards,\n-Morten Brørup\n\n-----Original Message-----\nFrom: Morten Brørup [mailto:mb@smartsharesystems.com] \nSent: Monday, 16 January 2023 14.07\nTo: dev@dpdk.org; roretzla@linux.microsoft.com; rmody@marvell.com; timothy.mcdaniel@intel.com; matan@nvidia.com; viacheslavo@nvidia.com\nCc: ruifeng.wang@arm.com; zhoumin@loongson.cn; drc@linux.vnet.ibm.com; kda@semihalf.com; bruce.richardson@intel.com; konstantin.v.ananyev@yandex.ru; Morten Brørup; stephen@networkplumber.org; shshaikh@marvell.com\nSubject: [PATCH v7 1/4] net/bnx2x: fix warnings about rte_memcpy lengths\n\nBugfix: The vlan in the bulletin does not contain a VLAN header, only the\nVLAN ID, so only copy 2 byte, not 4. The target structure has padding\nafter the field, so copying 2 byte too many is effectively harmless.\nThere is no need to backport this patch.\n\nUse RTE_PTR_ADD where copying arrays to the offset of a first field in a\nstructure holding multiple fields, to avoid compiler warnings with\ndecorated rte_memcpy.\n\nBugzilla ID: 1146\n\nFixes: 540a211084a7695a1c7bc43068934c140d6989be (\"bnx2x: driver core\")\nCc: stephen@networkplumber.org\nCc: rmody@marvell.com\nCc: shshaikh@marvell.com\n\nSigned-off-by: Morten Brørup <mb@smartsharesystems.com>\n---\nv7:\n* No changes.\nv6:\n* Add Fixes to patch description.\n* Fix checkpatch warnings.\nv5:\n* No changes.\nv4:\n* Type casting did not fix the warnings, so use RTE_PTR_ADD instead.\nv3:\n* First patch in series.\n---\n drivers/net/bnx2x/bnx2x_stats.c | 11 +++++++----\n drivers/net/bnx2x/bnx2x_vfpf.c | 2 +-\n 2 files changed, 8 insertions(+), 5 deletions(-)", "diff": "diff --git a/drivers/net/bnx2x/bnx2x_stats.c b/drivers/net/bnx2x/bnx2x_stats.c\r\nindex c07b01510a..bc4a8b8e71 100644\r\n--- a/drivers/net/bnx2x/bnx2x_stats.c\r\n+++ b/drivers/net/bnx2x/bnx2x_stats.c\r\n@@ -819,8 +819,9 @@ bnx2x_hw_stats_update(struct bnx2x_softc *sc)\r\n \r\n rte_memcpy(old, new, sizeof(struct nig_stats));\r\n \r\n- rte_memcpy(&(estats->rx_stat_ifhcinbadoctets_hi), &(pstats->mac_stx[1]),\r\n-\t sizeof(struct mac_stx));\r\n+\trte_memcpy(RTE_PTR_ADD(estats,\r\n+\t\t\toffsetof(struct bnx2x_eth_stats, rx_stat_ifhcinbadoctets_hi)),\r\n+\t\t\t&pstats->mac_stx[1], sizeof(struct mac_stx));\r\n estats->brb_drop_hi = pstats->brb_drop_hi;\r\n estats->brb_drop_lo = pstats->brb_drop_lo;\r\n \r\n@@ -1492,9 +1493,11 @@ bnx2x_stats_init(struct bnx2x_softc *sc)\r\n \t\tREG_RD(sc, NIG_REG_STAT0_BRB_TRUNCATE + port*0x38);\r\n \tif (!CHIP_IS_E3(sc)) {\r\n \t\tREG_RD_DMAE(sc, NIG_REG_STAT0_EGRESS_MAC_PKT0 + port*0x50,\r\n-\t\t\t\t&(sc->port.old_nig_stats.egress_mac_pkt0_lo), 2);\r\n+\t\t\t\tRTE_PTR_ADD(&sc->port.old_nig_stats,\r\n+\t\t\t\toffsetof(struct nig_stats, egress_mac_pkt0_lo)), 2);\r\n \t\tREG_RD_DMAE(sc, NIG_REG_STAT0_EGRESS_MAC_PKT1 + port*0x50,\r\n-\t\t\t\t&(sc->port.old_nig_stats.egress_mac_pkt1_lo), 2);\r\n+\t\t\t\tRTE_PTR_ADD(&sc->port.old_nig_stats,\r\n+\t\t\t\toffsetof(struct nig_stats, egress_mac_pkt1_lo)), 2);\r\n \t}\r\n \r\n \t/* function stats */\r\ndiff --git a/drivers/net/bnx2x/bnx2x_vfpf.c b/drivers/net/bnx2x/bnx2x_vfpf.c\r\nindex 63953c2979..87631c76ca 100644\r\n--- a/drivers/net/bnx2x/bnx2x_vfpf.c\r\n+++ b/drivers/net/bnx2x/bnx2x_vfpf.c\r\n@@ -54,7 +54,7 @@ bnx2x_check_bull(struct bnx2x_softc *sc)\r\n \tif (valid_bitmap & (1 << MAC_ADDR_VALID) && memcmp(bull->mac, sc->old_bulletin.mac, ETH_ALEN))\r\n \t\trte_memcpy(&sc->link_params.mac_addr, bull->mac, ETH_ALEN);\r\n \tif (valid_bitmap & (1 << VLAN_VALID))\r\n-\t\trte_memcpy(&bull->vlan, &sc->old_bulletin.vlan, RTE_VLAN_HLEN);\r\n+\t\trte_memcpy(&bull->vlan, &sc->old_bulletin.vlan, sizeof(bull->vlan));\r\n \r\n \tsc->old_bulletin = *bull;\r\n \r\n", "prefixes": [ "v7", "1/4" ] }