Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/127864/?format=api
{ "id": 127864, "url": "https://patches.dpdk.org/api/patches/127864/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20230601150106.18375-25-stephen@networkplumber.org/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230601150106.18375-25-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20230601150106.18375-25-stephen@networkplumber.org", "date": "2023-06-01T15:01:05", "name": "[24/25] net/qede: replace snprintf with strlcpy", "commit_ref": null, "pull_url": null, "state": "rejected", "archived": true, "hash": "eb597fa757b45485f4e6d776ba201ea861703805", "submitter": { "id": 27, "url": "https://patches.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": { "id": 1, "url": "https://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20230601150106.18375-25-stephen@networkplumber.org/mbox/", "series": [ { "id": 28302, "url": "https://patches.dpdk.org/api/series/28302/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=28302", "date": "2023-06-01T15:00:41", "name": "replace snprintf with strlcpy", "version": 1, "mbox": "https://patches.dpdk.org/series/28302/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/127864/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/127864/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id EDA3C42C04;\n\tThu, 1 Jun 2023 17:05:45 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 6E87D42B8B;\n\tThu, 1 Jun 2023 17:01:43 +0200 (CEST)", "from mail-pg1-f173.google.com (mail-pg1-f173.google.com\n [209.85.215.173])\n by mails.dpdk.org (Postfix) with ESMTP id 82A6542FB0\n for <dev@dpdk.org>; Thu, 1 Jun 2023 17:01:40 +0200 (CEST)", "by mail-pg1-f173.google.com with SMTP id\n 41be03b00d2f7-52c30fa5271so381933a12.0\n for <dev@dpdk.org>; Thu, 01 Jun 2023 08:01:40 -0700 (PDT)", "from hermes.local (204-195-120-218.wavecable.com. [204.195.120.218])\n by smtp.gmail.com with ESMTPSA id\n ij9-20020a170902ab4900b001ac40488620sm3661955plb.92.2023.06.01.08.01.38\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Thu, 01 Jun 2023 08:01:38 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=networkplumber-org.20221208.gappssmtp.com; s=20221208; t=1685631699;\n x=1688223699;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=cqMUF35ogrk7JxGsEvY3cD/eBWCmp0e7y14xdvFfCuI=;\n b=RBt8VPD/Ssq4dtekJQS6KQ+fUNYIzJNlVHEWXqBmmsY/8GIjLAFgw3ZXjDaWoxU/E3\n mhC+zu+7ZB54cqkPyXvs2WBeoPv2JI/7lHY/uPH0kZTXoH2DrCSeapABkKTwXuPL0TVQ\n 1uWV4+PnOQhtEXcylboMxMPSJSoJI1ap1E0oQ7oLmuwRPhdcCrrYK8qkjS+Z8GD33Jgb\n vtWbw1tLyQXUh2pF2HGy8bUeEbhpxGwU/DLOaIjKA1+BVB4/0M8x9ouSAQYWhjQojfb6\n +KcoO/oIo9GSut7M5nrO5kZgoCjcoMAx9SoSiszEwLEjNsGahT9z5NPmtN8ruN6sL2xY\n qYwA==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20221208; t=1685631699; x=1688223699;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=cqMUF35ogrk7JxGsEvY3cD/eBWCmp0e7y14xdvFfCuI=;\n b=Q1JTzrIUdwmD6qfUIrgTo+yQRCyLTk/bc8cFPLBu5uEImVeTwOcZ4+KRNCEKuXrffG\n tYsw7s6DfZwCLF9v8iLH2feqsxYUHc25Xxy8oI6RCa80+iz748WqsN3/f/TPdn34OmOm\n KgLezOPGt4JnX93ikOajHBm1UdCeimehn4Oo2iCvTvjEalaD/lOj4u1NSAIXTytlTO0x\n lodqJan36Ij0pv6SDblFqCKmJt0bnxvnOZPcyKu8HqjPwr6xUHN9zLF5MpTcpDy+TAuk\n ymNo0eMlWVgOyfCxuQMRH8yNdTiGz9wWE2Uk8TOTfNSSYA7VPn85Ciz1oow4NT2A4amJ\n PvfA==", "X-Gm-Message-State": "AC+VfDzjocinTPxFs8tseSgUC2UNM+wRuvXDphXWmSFJc8Ks1x09gYww\n hYHuuEZMTAzUM1+ke8A10/z3a2mHTxUJP4/62+++Xw==", "X-Google-Smtp-Source": "\n ACHHUZ4hTKdnXvZ5zBmsjDSaomNqAbHCRsNrgjy/CaycKwip651Fq/dBELQKlGeT70nqgox7ljYV9Q==", "X-Received": "by 2002:a17:902:bb8f:b0:1af:daf4:b6f1 with SMTP id\n m15-20020a170902bb8f00b001afdaf4b6f1mr5365964pls.38.1685631699384;\n Thu, 01 Jun 2023 08:01:39 -0700 (PDT)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "dev@dpdk.org", "Cc": "Stephen Hemminger <stephen@networkplumber.org>,\n Devendra Singh Rawat <dsinghrawat@marvell.com>,\n Alok Prasad <palok@marvell.com>", "Subject": "[PATCH 24/25] net/qede: replace snprintf with strlcpy", "Date": "Thu, 1 Jun 2023 08:01:05 -0700", "Message-Id": "<20230601150106.18375-25-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.39.2", "In-Reply-To": "<20230601150106.18375-1-stephen@networkplumber.org>", "References": "<20230601150106.18375-1-stephen@networkplumber.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Suggested by devtools/cocci/strlcpy-with-header.cocci\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n drivers/net/qede/qede_ethdev.c | 10 ++++------\n 1 file changed, 4 insertions(+), 6 deletions(-)", "diff": "diff --git a/drivers/net/qede/qede_ethdev.c b/drivers/net/qede/qede_ethdev.c\nindex a4923670d6ba..7429ec3e8773 100644\n--- a/drivers/net/qede/qede_ethdev.c\n+++ b/drivers/net/qede/qede_ethdev.c\n@@ -238,8 +238,8 @@ qede_fw_version_get(struct rte_eth_dev *dev, char *fw_ver, size_t fw_size)\n \tsize_t size;\n \n \tif (IS_PF(edev))\n-\t\tsnprintf(ver_str, QEDE_PMD_DRV_VER_STR_SIZE, \"%s\",\n-\t\t\t QEDE_PMD_FW_VERSION);\n+\t\tstrlcpy(ver_str, QEDE_PMD_FW_VERSION,\n+\t\t\tQEDE_PMD_DRV_VER_STR_SIZE);\n \telse\n \t\tsnprintf(ver_str, QEDE_PMD_DRV_VER_STR_SIZE, \"%d.%d.%d.%d\",\n \t\t\t info->fw_major, info->fw_minor,\n@@ -374,11 +374,9 @@ static void qede_print_adapter_info(struct rte_eth_dev *dev)\n \t\t ECORE_IS_BB(edev) ? \"BB\" : \"AH\",\n \t\t 'A' + edev->chip_rev,\n \t\t (int)edev->chip_metal);\n-\tsnprintf(ver_str, QEDE_PMD_DRV_VER_STR_SIZE, \"%s\",\n-\t\t QEDE_PMD_DRV_VERSION);\n+\tstrlcpy(ver_str, QEDE_PMD_DRV_VERSION, QEDE_PMD_DRV_VER_STR_SIZE);\n \tDP_INFO(edev, \" %-20s: %s\\n\", \"Driver version\", ver_str);\n-\tsnprintf(ver_str, QEDE_PMD_DRV_VER_STR_SIZE, \"%s\",\n-\t\t QEDE_PMD_BASE_VERSION);\n+\tstrlcpy(ver_str, QEDE_PMD_BASE_VERSION, QEDE_PMD_DRV_VER_STR_SIZE);\n \tDP_INFO(edev, \" %-20s: %s\\n\", \"Base version\", ver_str);\n \tqede_fw_version_get(dev, ver_str, sizeof(ver_str));\n \tDP_INFO(edev, \" %-20s: %s\\n\", \"Firmware version\", ver_str);\n", "prefixes": [ "24/25" ] }