Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/127858/?format=api
{ "id": 127858, "url": "https://patches.dpdk.org/api/patches/127858/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20230601150106.18375-19-stephen@networkplumber.org/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230601150106.18375-19-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20230601150106.18375-19-stephen@networkplumber.org", "date": "2023-06-01T15:00:59", "name": "[18/25] net/hns3: replace snprint with strlcpy", "commit_ref": null, "pull_url": null, "state": "rejected", "archived": true, "hash": "efcde8def69a87905bf3863cacfdfa64ea7d0fc4", "submitter": { "id": 27, "url": "https://patches.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": { "id": 1, "url": "https://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20230601150106.18375-19-stephen@networkplumber.org/mbox/", "series": [ { "id": 28302, "url": "https://patches.dpdk.org/api/series/28302/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=28302", "date": "2023-06-01T15:00:41", "name": "replace snprintf with strlcpy", "version": 1, "mbox": "https://patches.dpdk.org/series/28302/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/127858/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/127858/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 1588442C04;\n\tThu, 1 Jun 2023 17:04:26 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 940C742DCF;\n\tThu, 1 Jun 2023 17:01:36 +0200 (CEST)", "from mail-pl1-f172.google.com (mail-pl1-f172.google.com\n [209.85.214.172])\n by mails.dpdk.org (Postfix) with ESMTP id 84F6242DAE\n for <dev@dpdk.org>; Thu, 1 Jun 2023 17:01:33 +0200 (CEST)", "by mail-pl1-f172.google.com with SMTP id\n d9443c01a7336-1b025d26f4fso8144505ad.1\n for <dev@dpdk.org>; Thu, 01 Jun 2023 08:01:33 -0700 (PDT)", "from hermes.local (204-195-120-218.wavecable.com. [204.195.120.218])\n by smtp.gmail.com with ESMTPSA id\n ij9-20020a170902ab4900b001ac40488620sm3661955plb.92.2023.06.01.08.01.31\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Thu, 01 Jun 2023 08:01:32 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=networkplumber-org.20221208.gappssmtp.com; s=20221208; t=1685631692;\n x=1688223692;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=H+qK5KLsp4zBm++ghShYmDp9X/nFOGl4xmclx72bFbk=;\n b=VBj8ebd25hV20JjQMA2lXo2p8ia4KxkbPGtRj1cuyCaCrLW0+b371i6xJHBUOv9NuI\n 0euH2qgaPfCsKIZum3wrah6fRENpYL1mdxdwf6GaW9/N4fB08k3wSEhMPkAS+dHYrerN\n xCs1f3A1a8upHIM0yD6ESm7dBx5ltFgpc4mGW/yge17OB1kIdjVYL8eNC7ULgD8T9oIc\n B8SnQOEujfQJLi85mSJiovI4KzFD8H3C+8e5ztnsyIGdzq2/xOzJV/MnHZ2SKR6TrVsZ\n GGqFpop4rn+xXN2Bwqq5f4hIdTIhAVHPXHKzPFn9dkO1yupt13ZVSwhCh4KUeWExd1gn\n M1Gw==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20221208; t=1685631692; x=1688223692;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=H+qK5KLsp4zBm++ghShYmDp9X/nFOGl4xmclx72bFbk=;\n b=I1opJudbbsM/IqPnEYMmccQX5mQuPJ1RnpG2kA6UsPOI4uOwgsQzfWWLC3aeo6q82T\n e5iBLlDIMK/b9BeBr0XZjr5qCiVXBJqD2cnJ914Jh34X5sqD4HDdzlim9ZbkatdPcrQJ\n cvs12zBUf36xAQjOiZJv+BzT+hPREeMIuQ0AYcFoi4L8uL0LQllFns0M315ZyOn2aGlA\n jBPmjMqlodTw7oForxvKV5slbg1NQ5+OhKADVVMv9PXcmN925zHve3dCpC9kf/2c3tjX\n 3+CMO5Ra3N3zYJbx6+5w/4CP+JmDnWIeeCr8Q9NcdoTDFlQ8/1qoDxGqWlIVKJW2r2sj\n QoxA==", "X-Gm-Message-State": "AC+VfDxRjeOK7ylFTlAnxtytaonoCNnaMSy0EeFmsEpT692jQqQDCSGd\n GVY4Il8SwXBiu80OyjuHO9u7RkolmbJhHsKeDWmeFw==", "X-Google-Smtp-Source": "\n ACHHUZ45KWbY5lqwrVyBOjWZjVN3DgdxRlfZ0VQRWLhrq8KkPkRZTXolSMvLmxPktgEDbttwyvmcCw==", "X-Received": "by 2002:a17:902:ea0c:b0:1ac:84dd:6d1f with SMTP id\n s12-20020a170902ea0c00b001ac84dd6d1fmr10281086plg.1.1685631692468;\n Thu, 01 Jun 2023 08:01:32 -0700 (PDT)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "dev@dpdk.org", "Cc": "Stephen Hemminger <stephen@networkplumber.org>,\n Dongdong Liu <liudongdong3@huawei.com>,\n Yisen Zhuang <yisen.zhuang@huawei.com>", "Subject": "[PATCH 18/25] net/hns3: replace snprint with strlcpy", "Date": "Thu, 1 Jun 2023 08:00:59 -0700", "Message-Id": "<20230601150106.18375-19-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.39.2", "In-Reply-To": "<20230601150106.18375-1-stephen@networkplumber.org>", "References": "<20230601150106.18375-1-stephen@networkplumber.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Suggested by devtools/cocci/strlcpy-with-header.cocci\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n drivers/net/hns3/hns3_fdir.c | 2 +-\n drivers/net/hns3/hns3_rxtx.c | 8 ++++----\n drivers/net/hns3/hns3_stats.c | 22 +++++++++++-----------\n 3 files changed, 16 insertions(+), 16 deletions(-)", "diff": "diff --git a/drivers/net/hns3/hns3_fdir.c b/drivers/net/hns3/hns3_fdir.c\nindex 48a91fb517de..766416432c57 100644\n--- a/drivers/net/hns3/hns3_fdir.c\n+++ b/drivers/net/hns3/hns3_fdir.c\n@@ -843,7 +843,7 @@ int hns3_fdir_filter_init(struct hns3_adapter *hns)\n \n \tfdir_hash_params.socket_id = rte_socket_id();\n \tTAILQ_INIT(&fdir_info->fdir_list);\n-\tsnprintf(fdir_hash_name, RTE_HASH_NAMESIZE, \"%s\", hns->hw.data->name);\n+\tstrlcpy(fdir_hash_name, hns->hw.data->name, RTE_HASH_NAMESIZE);\n \tfdir_info->hash_handle = rte_hash_create(&fdir_hash_params);\n \tif (fdir_info->hash_handle == NULL) {\n \t\tPMD_INIT_LOG(ERR, \"Create FDIR hash handle fail!\");\ndiff --git a/drivers/net/hns3/hns3_rxtx.c b/drivers/net/hns3/hns3_rxtx.c\nindex 4065c519c329..78921edcc9ab 100644\n--- a/drivers/net/hns3/hns3_rxtx.c\n+++ b/drivers/net/hns3/hns3_rxtx.c\n@@ -2795,8 +2795,8 @@ hns3_rx_burst_mode_get(struct rte_eth_dev *dev, __rte_unused uint16_t queue_id,\n \n \tfor (i = 0; i < RTE_DIM(burst_infos); i++) {\n \t\tif (pkt_burst == burst_infos[i].pkt_burst) {\n-\t\t\tsnprintf(mode->info, sizeof(mode->info), \"%s\",\n-\t\t\t\t burst_infos[i].info);\n+\t\t\tstrlcpy(mode->info, burst_infos[i].info,\n+\t\t\t\tsizeof(mode->info));\n \t\t\tret = 0;\n \t\t\tbreak;\n \t\t}\n@@ -4290,8 +4290,8 @@ hns3_tx_burst_mode_get(struct rte_eth_dev *dev, __rte_unused uint16_t queue_id,\n \n \tfor (i = 0; i < RTE_DIM(burst_infos); i++) {\n \t\tif (pkt_burst == burst_infos[i].pkt_burst) {\n-\t\t\tsnprintf(mode->info, sizeof(mode->info), \"%s\",\n-\t\t\t\t burst_infos[i].info);\n+\t\t\tstrlcpy(mode->info, burst_infos[i].info,\n+\t\t\t\tsizeof(mode->info));\n \t\t\tret = 0;\n \t\t\tbreak;\n \t\t}\ndiff --git a/drivers/net/hns3/hns3_stats.c b/drivers/net/hns3/hns3_stats.c\nindex bad65fcbed8b..2fd460813919 100644\n--- a/drivers/net/hns3/hns3_stats.c\n+++ b/drivers/net/hns3/hns3_stats.c\n@@ -1176,9 +1176,9 @@ hns3_imissed_stats_name_get(struct rte_eth_dev *dev,\n \timissed_stats_num = hns3_get_imissed_stats_num(hns);\n \n \tfor (i = 0; i < imissed_stats_num; i++) {\n-\t\tsnprintf(xstats_names[cnt].name,\n-\t\t\t sizeof(xstats_names[cnt].name),\n-\t\t\t \"%s\", hns3_imissed_stats_strings[i].name);\n+\t\tstrlcpy(xstats_names[cnt].name,\n+\t\t\thns3_imissed_stats_strings[i].name,\n+\t\t\tsizeof(xstats_names[cnt].name));\n \t\tcnt++;\n \t}\n \n@@ -1228,9 +1228,9 @@ hns3_dev_xstats_get_names(struct rte_eth_dev *dev,\n \tif (!hns->is_vf) {\n \t\t/* Get MAC name from hw->hw_xstats.mac_stats struct */\n \t\tfor (i = 0; i < HNS3_NUM_MAC_STATS; i++) {\n-\t\t\tsnprintf(xstats_names[count].name,\n-\t\t\t\t sizeof(xstats_names[count].name),\n-\t\t\t\t \"%s\", hns3_mac_strings[i].name);\n+\t\t\tstrlcpy(xstats_names[count].name,\n+\t\t\t\thns3_mac_strings[i].name,\n+\t\t\t\tsizeof(xstats_names[count].name));\n \t\t\tcount++;\n \t\t}\n \t}\n@@ -1238,9 +1238,9 @@ hns3_dev_xstats_get_names(struct rte_eth_dev *dev,\n \thns3_imissed_stats_name_get(dev, xstats_names, &count);\n \n \tfor (i = 0; i < HNS3_NUM_RESET_XSTATS; i++) {\n-\t\tsnprintf(xstats_names[count].name,\n-\t\t\t sizeof(xstats_names[count].name),\n-\t\t\t \"%s\", hns3_reset_stats_strings[i].name);\n+\t\tstrlcpy(xstats_names[count].name,\n+\t\t\thns3_reset_stats_strings[i].name,\n+\t\t\tsizeof(xstats_names[count].name));\n \t\tcount++;\n \t}\n \n@@ -1418,8 +1418,8 @@ hns3_dev_xstats_get_names_by_id(struct rte_eth_dev *dev,\n \t\t\trte_free(names_copy);\n \t\t\treturn -EINVAL;\n \t\t}\n-\t\tsnprintf(xstats_names[i].name, sizeof(xstats_names[i].name),\n-\t\t\t \"%s\", names_copy[ids[i]].name);\n+\t\tstrlcpy(xstats_names[i].name, names_copy[ids[i]].name,\n+\t\t\tsizeof(xstats_names[i].name));\n \t}\n \n \trte_free(names_copy);\n", "prefixes": [ "18/25" ] }