Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/127856/?format=api
https://patches.dpdk.org/api/patches/127856/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20230601150106.18375-17-stephen@networkplumber.org/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230601150106.18375-17-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20230601150106.18375-17-stephen@networkplumber.org", "date": "2023-06-01T15:00:57", "name": "[16/25] net/dpaa*: replace snprintf with strlcpy", "commit_ref": null, "pull_url": null, "state": "rejected", "archived": true, "hash": "ab679f2a289dabb921fafbf09ccfa99d88d7cf58", "submitter": { "id": 27, "url": "https://patches.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": { "id": 1, "url": "https://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20230601150106.18375-17-stephen@networkplumber.org/mbox/", "series": [ { "id": 28302, "url": "https://patches.dpdk.org/api/series/28302/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=28302", "date": "2023-06-01T15:00:41", "name": "replace snprintf with strlcpy", "version": 1, "mbox": "https://patches.dpdk.org/series/28302/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/127856/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/127856/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 11D2242C04;\n\tThu, 1 Jun 2023 17:04:07 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 8DB7C42DB9;\n\tThu, 1 Jun 2023 17:01:34 +0200 (CEST)", "from mail-pl1-f171.google.com (mail-pl1-f171.google.com\n [209.85.214.171])\n by mails.dpdk.org (Postfix) with ESMTP id 56AA242D93\n for <dev@dpdk.org>; Thu, 1 Jun 2023 17:01:31 +0200 (CEST)", "by mail-pl1-f171.google.com with SMTP id\n d9443c01a7336-1b024e29657so4264485ad.3\n for <dev@dpdk.org>; Thu, 01 Jun 2023 08:01:31 -0700 (PDT)", "from hermes.local (204-195-120-218.wavecable.com. [204.195.120.218])\n by smtp.gmail.com with ESMTPSA id\n ij9-20020a170902ab4900b001ac40488620sm3661955plb.92.2023.06.01.08.01.29\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Thu, 01 Jun 2023 08:01:30 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=networkplumber-org.20221208.gappssmtp.com; s=20221208; t=1685631690;\n x=1688223690;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=70HxSvyY6cwn3irxYhJzEh4895TjypQ8oU2O13BnGGo=;\n b=Y9M5rqyZGLeMy2rHZGJa7Yq1znf++MhYwwflGcs9fRR2yOPW/aEdH0pZ0klOlGGhM8\n newnh7VRZqgnV4HS+0OFrS+mG+lfnulN/X52mKFo3cImVtK42XErLLG8sRkAdXjnJq5A\n 6w+uoOs4QOe9KCxv7C2pmVk5AJDXh9WODD4J+jS3+UPP7WkyKTguk9VWlu+2GUMLoult\n 4cZWRqjC8ISrIaC/7jwofeYh2iVUfjwYfnkJMILu5Vxz6Pp9eaxvZsYjJ5vVRavIIErK\n 3bwI92irgwR69Z381DrbLQlbmLZzoD5ci4hLTcQqIeYHHH7yex9GbAwnHOSfFRGjzSnz\n 8CQA==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20221208; t=1685631690; x=1688223690;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=70HxSvyY6cwn3irxYhJzEh4895TjypQ8oU2O13BnGGo=;\n b=HUoH2f48Z+Ztci14dK7J2VvmAiTHwmUBtPLv7rXTtqwyU1FD4NqyOSuEET0e+QawRT\n FRTuZcc/03sgQMeiXxK0jb8q7/UMOlXEHX8/e8PRp0VFUkoJrycnAZvL7bY+hR1yfLOC\n zVfBXCEbIhPS3/Oecu3QBmmapqG9d2e97LHhU7o70Qozcj539e7mn+WdYmkwDyqzeIp4\n QWU8s525HY9rACUso/GyYvDEEW20+LGP600J48Fow7MAyPWMCbXsaxHADV9UtmzIfw29\n J6SUMoH02F53jBjcBJjdq0En2MAuYsO6idvbW53ZUfUegMWsa+0avjj/SUBXGJPXWj/1\n CXQQ==", "X-Gm-Message-State": "AC+VfDyYtxsq8sspHRTX7OJXe8lqLLBTjmzCEu31piNSS5AfooVaUTv9\n 5XpuIUpzvDVI6Xvg52QfO+Ozaqe/5f9F8r6L7aETAw==", "X-Google-Smtp-Source": "\n ACHHUZ6Af407cHEJWo4Q9vh7UeDUhzfiYWo6/vzL/HKBCs1z9VF9ifOIisHec1Q8q6oVt1o9WHZQvw==", "X-Received": "by 2002:a17:902:a60c:b0:1b1:95ac:a4da with SMTP id\n u12-20020a170902a60c00b001b195aca4damr1677471plq.8.1685631690657;\n Thu, 01 Jun 2023 08:01:30 -0700 (PDT)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "dev@dpdk.org", "Cc": "Stephen Hemminger <stephen@networkplumber.org>,\n Hemant Agrawal <hemant.agrawal@nxp.com>,\n Sachin Saxena <sachin.saxena@nxp.com>", "Subject": "[PATCH 16/25] net/dpaa*: replace snprintf with strlcpy", "Date": "Thu, 1 Jun 2023 08:00:57 -0700", "Message-Id": "<20230601150106.18375-17-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.39.2", "In-Reply-To": "<20230601150106.18375-1-stephen@networkplumber.org>", "References": "<20230601150106.18375-1-stephen@networkplumber.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Suggested by devtools/cocci/strlcpy-with-header.cocci\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n drivers/net/dpaa/dpaa_ethdev.c | 8 ++++----\n drivers/net/dpaa2/dpaa2_ethdev.c | 8 ++++----\n 2 files changed, 8 insertions(+), 8 deletions(-)", "diff": "diff --git a/drivers/net/dpaa/dpaa_ethdev.c b/drivers/net/dpaa/dpaa_ethdev.c\nindex a6c86113d125..0076a531005b 100644\n--- a/drivers/net/dpaa/dpaa_ethdev.c\n+++ b/drivers/net/dpaa/dpaa_ethdev.c\n@@ -620,8 +620,8 @@ dpaa_dev_rx_burst_mode_get(struct rte_eth_dev *dev,\n \t/* Update Rx offload info */\n \tfor (i = 0; i < RTE_DIM(rx_offload_map); i++) {\n \t\tif (eth_conf->rxmode.offloads & rx_offload_map[i].flags) {\n-\t\t\tsnprintf(mode->info, sizeof(mode->info), \"%s\",\n-\t\t\t\trx_offload_map[i].output);\n+\t\t\tstrlcpy(mode->info, rx_offload_map[i].output,\n+\t\t\t\tsizeof(mode->info));\n \t\t\tret = 0;\n \t\t\tbreak;\n \t\t}\n@@ -654,8 +654,8 @@ dpaa_dev_tx_burst_mode_get(struct rte_eth_dev *dev,\n \t/* Update Tx offload info */\n \tfor (i = 0; i < RTE_DIM(tx_offload_map); i++) {\n \t\tif (eth_conf->txmode.offloads & tx_offload_map[i].flags) {\n-\t\t\tsnprintf(mode->info, sizeof(mode->info), \"%s\",\n-\t\t\t\ttx_offload_map[i].output);\n+\t\t\tstrlcpy(mode->info, tx_offload_map[i].output,\n+\t\t\t\tsizeof(mode->info));\n \t\t\tret = 0;\n \t\t\tbreak;\n \t\t}\ndiff --git a/drivers/net/dpaa2/dpaa2_ethdev.c b/drivers/net/dpaa2/dpaa2_ethdev.c\nindex 679f33ae1a08..baa1c2d1ea0f 100644\n--- a/drivers/net/dpaa2/dpaa2_ethdev.c\n+++ b/drivers/net/dpaa2/dpaa2_ethdev.c\n@@ -313,8 +313,8 @@ dpaa2_dev_rx_burst_mode_get(struct rte_eth_dev *dev,\n \t/* Update Rx offload info */\n \tfor (i = 0; i < RTE_DIM(rx_offload_map); i++) {\n \t\tif (eth_conf->rxmode.offloads & rx_offload_map[i].flags) {\n-\t\t\tsnprintf(mode->info, sizeof(mode->info), \"%s\",\n-\t\t\t\trx_offload_map[i].output);\n+\t\t\tstrlcpy(mode->info, rx_offload_map[i].output,\n+\t\t\t\tsizeof(mode->info));\n \t\t\tret = 0;\n \t\t\tbreak;\n \t\t}\n@@ -348,8 +348,8 @@ dpaa2_dev_tx_burst_mode_get(struct rte_eth_dev *dev,\n \t/* Update Tx offload info */\n \tfor (i = 0; i < RTE_DIM(tx_offload_map); i++) {\n \t\tif (eth_conf->txmode.offloads & tx_offload_map[i].flags) {\n-\t\t\tsnprintf(mode->info, sizeof(mode->info), \"%s\",\n-\t\t\t\ttx_offload_map[i].output);\n+\t\t\tstrlcpy(mode->info, tx_offload_map[i].output,\n+\t\t\t\tsizeof(mode->info));\n \t\t\tret = 0;\n \t\t\tbreak;\n \t\t}\n", "prefixes": [ "16/25" ] }{ "id": 127856, "url": "