Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/127846/?format=api
{ "id": 127846, "url": "https://patches.dpdk.org/api/patches/127846/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20230601150106.18375-7-stephen@networkplumber.org/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230601150106.18375-7-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20230601150106.18375-7-stephen@networkplumber.org", "date": "2023-06-01T15:00:47", "name": "[06/25] common/mlx5: replace snprintf with strlcpy", "commit_ref": null, "pull_url": null, "state": "rejected", "archived": true, "hash": "bb2c3c74e9e5304592b9e1e550dd9e615f36d776", "submitter": { "id": 27, "url": "https://patches.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": { "id": 1, "url": "https://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20230601150106.18375-7-stephen@networkplumber.org/mbox/", "series": [ { "id": 28302, "url": "https://patches.dpdk.org/api/series/28302/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=28302", "date": "2023-06-01T15:00:41", "name": "replace snprintf with strlcpy", "version": 1, "mbox": "https://patches.dpdk.org/series/28302/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/127846/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/127846/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 5FC5D42C04;\n\tThu, 1 Jun 2023 17:02:20 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 3842C42D59;\n\tThu, 1 Jun 2023 17:01:23 +0200 (CEST)", "from mail-pf1-f181.google.com (mail-pf1-f181.google.com\n [209.85.210.181])\n by mails.dpdk.org (Postfix) with ESMTP id AAF2742D55\n for <dev@dpdk.org>; Thu, 1 Jun 2023 17:01:21 +0200 (CEST)", "by mail-pf1-f181.google.com with SMTP id\n d2e1a72fcca58-64d5f65a2f7so649384b3a.1\n for <dev@dpdk.org>; Thu, 01 Jun 2023 08:01:21 -0700 (PDT)", "from hermes.local (204-195-120-218.wavecable.com. [204.195.120.218])\n by smtp.gmail.com with ESMTPSA id\n ij9-20020a170902ab4900b001ac40488620sm3661955plb.92.2023.06.01.08.01.18\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Thu, 01 Jun 2023 08:01:19 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=networkplumber-org.20221208.gappssmtp.com; s=20221208; t=1685631680;\n x=1688223680;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=9BATqt2tO/9/EDDw5Lf9l06MYHtgzXoYUTBgmOoOGsQ=;\n b=l7O3bW6J9Qr3pA07CJK4/X6m22E7gBxBLtFvOFJj//PW96TQrhj+fij/jGbtyZB+VK\n ufpzIvzZcy9otHukFW+1QEucYui5+6k/9r/oIqWmTt6J6dWhJzGlt/kSNblWMv1z/j3t\n uJfwYXhkJg0Mi2pyMdLCNKO6H6FbyZ9lXAXRIvQ82OW6JVruZmF3f7yM1mPPJVkd0z2t\n ZsI2XAnVQCrED0uu7msTdoWGLP/KTrQf4ErHaZuS3xRnX+s9ocqn98TDWZvg+9mVb3SM\n XvF6l4pQEVEMlaPD8Y/WAAawsPUIeuzTd4sqblk8gZgFLvd9elD1qeHhn1YSCLFvQO4j\n 3lNA==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20221208; t=1685631680; x=1688223680;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=9BATqt2tO/9/EDDw5Lf9l06MYHtgzXoYUTBgmOoOGsQ=;\n b=QG/wMYBHVQUDENMSqs5FLF4sWie94jlRjJ8SSdLsjwllzqSDdcUMCqZyzFyfOs5lwe\n e65Rte0JthcM7ZfZnb3QygDGiFRNqu9j4kZrgsYZpkKayu1udODdN1SCE93DSga6ZSy7\n D6zJctS92qW5L5ju1D8B4VRuihDEGDUhYMhCuihWSTLpB6bU8dPm78V10n2YfD0CkNDr\n +3x5dt95W9+kZvN2bY+IhD7mU4XYsoH/nriRP9P7Zj/2CDpe6/5PwzTCNAULg6/O/LIK\n +xUi55YsfqWV6X2Qsxq/6QLG2zOfQVhL6IrioQV3hq17p4WAMDDy6/LQKOHNRIRp4WpF\n eWsg==", "X-Gm-Message-State": "AC+VfDypQtWC0DNopIxZdqapqfenYNRF1xKlpLb2MBYOsubDzp12TJhI\n p82Lp2K7oHMm8NyKdnHBnLoKtPHxmUwckmC5vKt0lA==", "X-Google-Smtp-Source": "\n ACHHUZ4Mff9MjrB28hQIgHP6Rc4PeUPTmpgx5itDWL2OfjH7IbuHaYp8JlVi7cnFmow3pNH9ohpP8A==", "X-Received": "by 2002:a17:902:d50c:b0:1b0:663e:4b3f with SMTP id\n b12-20020a170902d50c00b001b0663e4b3fmr5738915plg.37.1685631680543;\n Thu, 01 Jun 2023 08:01:20 -0700 (PDT)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "dev@dpdk.org", "Cc": "Stephen Hemminger <stephen@networkplumber.org>,\n Matan Azrad <matan@nvidia.com>,\n Viacheslav Ovsiienko <viacheslavo@nvidia.com>, Ori Kam <orika@nvidia.com>,\n Suanming Mou <suanmingm@nvidia.com>", "Subject": "[PATCH 06/25] common/mlx5: replace snprintf with strlcpy", "Date": "Thu, 1 Jun 2023 08:00:47 -0700", "Message-Id": "<20230601150106.18375-7-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.39.2", "In-Reply-To": "<20230601150106.18375-1-stephen@networkplumber.org>", "References": "<20230601150106.18375-1-stephen@networkplumber.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Suggested by devtools/cocci/strlcpy-with-header.cocci\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n drivers/common/mlx5/linux/mlx5_common_os.c | 2 +-\n drivers/common/mlx5/mlx5_common_utils.c | 5 ++---\n 2 files changed, 3 insertions(+), 4 deletions(-)", "diff": "diff --git a/drivers/common/mlx5/linux/mlx5_common_os.c b/drivers/common/mlx5/linux/mlx5_common_os.c\nindex aafff60eeb38..c4ceeccf3825 100644\n--- a/drivers/common/mlx5/linux/mlx5_common_os.c\n+++ b/drivers/common/mlx5/linux/mlx5_common_os.c\n@@ -897,7 +897,7 @@ mlx5_get_device_guid(const struct rte_pci_addr *dev, uint8_t *guid, size_t len)\n \t\t}\n \t} while (strchr(ptr->d_name, '.') || strchr(ptr->d_name, '_') ||\n \t\t strchr(ptr->d_name, 'v'));\n-\tsnprintf(cur_ifname, sizeof(cur_ifname), \"%s\", ptr->d_name);\n+\tstrlcpy(cur_ifname, ptr->d_name, sizeof(cur_ifname));\n \tclosedir(dir);\n \tsnprintf(tmp + strlen(tmp), sizeof(tmp) - strlen(tmp),\n \t\t\t\"/%s/phys_switch_id\", cur_ifname);\ndiff --git a/drivers/common/mlx5/mlx5_common_utils.c b/drivers/common/mlx5/mlx5_common_utils.c\nindex e69d06878c2e..3e809b409854 100644\n--- a/drivers/common/mlx5/mlx5_common_utils.c\n+++ b/drivers/common/mlx5/mlx5_common_utils.c\n@@ -49,8 +49,7 @@ mlx5_list_create(const char *name, void *ctx, bool lcores_share,\n \tif (!list)\n \t\treturn NULL;\n \tif (name)\n-\t\tsnprintf(list->l_const.name,\n-\t\t\t sizeof(list->l_const.name), \"%s\", name);\n+\t\tstrlcpy(list->l_const.name, name, sizeof(list->l_const.name));\n \tlist->l_const.ctx = ctx;\n \tlist->l_const.lcores_share = lcores_share;\n \tlist->l_const.cb_create = cb_create;\n@@ -422,7 +421,7 @@ mlx5_hlist_create(const char *name, uint32_t size, bool direct_key,\n \t\treturn NULL;\n \t}\n \tif (name)\n-\t\tsnprintf(h->l_const.name, sizeof(h->l_const.name), \"%s\", name);\n+\t\tstrlcpy(h->l_const.name, name, sizeof(h->l_const.name));\n \th->l_const.ctx = ctx;\n \th->l_const.lcores_share = lcores_share;\n \th->l_const.cb_create = cb_create;\n", "prefixes": [ "06/25" ] }