Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/127729/?format=api
https://patches.dpdk.org/api/patches/127729/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20230528143734.145326-1-user@sklga/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230528143734.145326-1-user@sklga>", "list_archive_url": "https://inbox.dpdk.org/dev/20230528143734.145326-1-user@sklga", "date": "2023-05-28T14:37:34", "name": "drivers: fix vmxnet3 return wrong error code in initializing", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "ba32d2646310fc659750d6f8fcc8d474ae9dcaee", "submitter": { "id": 3079, "url": "https://patches.dpdk.org/api/people/3079/?format=api", "name": "Kaijun Zeng", "email": "corezeng@gmail.com" }, "delegate": { "id": 319, "url": "https://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20230528143734.145326-1-user@sklga/mbox/", "series": [ { "id": 28255, "url": "https://patches.dpdk.org/api/series/28255/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=28255", "date": "2023-05-28T14:37:34", "name": "drivers: fix vmxnet3 return wrong error code in initializing", "version": 1, "mbox": "https://patches.dpdk.org/series/28255/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/127729/comments/", "check": "warning", "checks": "https://patches.dpdk.org/api/patches/127729/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 4B6DB42BE6;\n\tTue, 30 May 2023 17:41:16 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 1BDFD427F2;\n\tTue, 30 May 2023 17:41:12 +0200 (CEST)", "from mail-qk1-f193.google.com (mail-qk1-f193.google.com\n [209.85.222.193])\n by mails.dpdk.org (Postfix) with ESMTP id 06DCF40A81\n for <dev@dpdk.org>; Sun, 28 May 2023 16:37:52 +0200 (CEST)", "by mail-qk1-f193.google.com with SMTP id\n af79cd13be357-75b2a2bf757so147555685a.2\n for <dev@dpdk.org>; Sun, 28 May 2023 07:37:51 -0700 (PDT)", "from localhost.localdomain ([2001:19f0:5:3fd8:5400:3ff:fe7e:6d40])\n by smtp.gmail.com with ESMTPSA id\n p9-20020a05620a112900b0075ca4cd03d4sm2570205qkk.64.2023.05.28.07.37.50\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Sun, 28 May 2023 07:37:51 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20221208; t=1685284671; x=1687876671;\n h=content-transfer-encoding:mime-version:message-id:date:subject:cc\n :to:from:from:to:cc:subject:date:message-id:reply-to;\n bh=jIalYn11NwRwUEjz8zBIoxHRP0cbLJKpmQu/FOdWCPg=;\n b=p226XTLWoaP0PYdC2UyZVXMoV3xjLsHz8/sga5pbWTATrskXbaS7w7PFAKVJgv4gp4\n 54gbMYnB5pXlnxZ/eVC0wmBgfrwE/XxHUHig7h/Tk9N8HVtgiS7Gu6TY3p5sBL9goPbu\n lGifjB1oXjJMmjhLI3Bk1UiqZo9Ul6P0CgtNfsvwiQ/1ErFTPYu1Fyuol8+QzApyU2LT\n dKuCjSw3ollyqQ5DmzHZVjyOdGEqH+UefhOpJcmvIeF7wTB5x2eZCY3U9UFBIRVqVB90\n NKlOMAQKn9yDIQnJIXaX3r3D16blhCenKl2pnBMccbZPgdiC85XiIgXWeJD4qQD4GQV/\n ENxA==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20221208; t=1685284671; x=1687876671;\n h=content-transfer-encoding:mime-version:message-id:date:subject:cc\n :to:from:x-gm-message-state:from:to:cc:subject:date:message-id\n :reply-to;\n bh=jIalYn11NwRwUEjz8zBIoxHRP0cbLJKpmQu/FOdWCPg=;\n b=a/a3eLsSrJQGucY/TZkns5uf0wi+QPqyifvkMwYLnbEXj8GKqW3rPlTyWLTfG1FLd3\n hT6mcLZj2PvewRaZBJUcXks1gCrEo+3+IwFBTcC30IJ1/UcPjDvkSDgtP8odHMQelOrk\n u8psbMRClumaoRK473VVdFPz9XcqDHxJDj9vUUpJpGAWdlu6z2Kea8FQYL1rYJRtBIV0\n sGB6y+o+y+YfGkkFY/xt0pX2WRprqndaYvjUbB+Zu1B3SFgSJYWqCg/Cqfen89Cr+OEU\n X+DKNx++Suf+b0VF1IndfKSZnmx8hlxo61FmrtZHewvlf+7Z73rrZeHf4s2kCH5pFoXb\n s6ww==", "X-Gm-Message-State": "AC+VfDzAyOiZjxZD3dJX0Ziv3IMiByWdJ3ptH65UyfFchhZK4OQ4ew3E\n BRHug7tOJl2oNkktBg6Iokc/6Bh9yuQ1hK0vL8UGLg==", "X-Google-Smtp-Source": "\n ACHHUZ4bWfsCE1KbbWVQ41rQ26Ff/YikCYwXQtYZysdO0HUZDXY1iTHh5phDBebXXJlhfoeRWDIm1g==", "X-Received": "by 2002:a37:a91:0:b0:75b:23a1:3665 with SMTP id\n 139-20020a370a91000000b0075b23a13665mr4472730qkk.38.1685284671285;\n Sun, 28 May 2023 07:37:51 -0700 (PDT)", "From": "root <corezeng@gmail.com>", "X-Google-Original-From": "root <root@sklga>", "To": "dev@dpdk.org", "Cc": "corezeng@gmail.com,\n\tjbehrens@vmware.com", "Subject": "[PATCH] drivers: fix vmxnet3 return wrong error code in initializing", "Date": "Sun, 28 May 2023 10:37:34 -0400", "Message-Id": "<20230528143734.145326-1-user@sklga>", "X-Mailer": "git-send-email 2.30.2", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-Mailman-Approved-At": "Tue, 30 May 2023 17:41:09 +0200", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "From: Kaijun Zeng <corezeng@gmail.com>\n\nIn vmxnet3_dev_rxtx_init(), a wrong error code may be thrown after it invokes\nvmxnet3_post_rx_bufs() because it negates the error code before returning it.\nIt causes rte_eth_dev_start() to give a positive number to the invoker, but it\nshould be a negative number, as described in the comments.\n\nBugzilla ID: 1239\n\nSigned-off-by: Kaijun Zeng <corezeng@gmail.com>\n---\n drivers/net/vmxnet3/vmxnet3_rxtx.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/drivers/net/vmxnet3/vmxnet3_rxtx.c b/drivers/net/vmxnet3/vmxnet3_rxtx.c\nindex a875ffec07..73ec1e4727 100644\n--- a/drivers/net/vmxnet3/vmxnet3_rxtx.c\n+++ b/drivers/net/vmxnet3/vmxnet3_rxtx.c\n@@ -1315,7 +1315,7 @@ vmxnet3_dev_rxtx_init(struct rte_eth_dev *dev)\n \t\t\t\tPMD_INIT_LOG(ERR,\n \t\t\t\t\t \"ERROR: Posting Rxq: %d buffers ring: %d\",\n \t\t\t\t\t i, j);\n-\t\t\t\treturn -ret;\n+\t\t\t\treturn ret;\n \t\t\t}\n \t\t\t/*\n \t\t\t * Updating device with the index:next2fill to fill the\n", "prefixes": [] }{ "id": 127729, "url": "