Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/127695/?format=api
{ "id": 127695, "url": "https://patches.dpdk.org/api/patches/127695/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20230530090510.56812-8-haijie1@huawei.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230530090510.56812-8-haijie1@huawei.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20230530090510.56812-8-haijie1@huawei.com", "date": "2023-05-30T09:05:07", "name": "[07/10] ethdev: support telemetry query DCB info", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "e249824db0cfecb60e119ce71a494f1ed96f3e70", "submitter": { "id": 2935, "url": "https://patches.dpdk.org/api/people/2935/?format=api", "name": "Jie Hai", "email": "haijie1@huawei.com" }, "delegate": { "id": 319, "url": "https://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20230530090510.56812-8-haijie1@huawei.com/mbox/", "series": [ { "id": 28245, "url": "https://patches.dpdk.org/api/series/28245/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=28245", "date": "2023-05-30T09:05:00", "name": "support telemetry query ethdev info", "version": 1, "mbox": "https://patches.dpdk.org/series/28245/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/127695/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/127695/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id B857042BE1;\n\tTue, 30 May 2023 11:08:16 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 60BFE42D43;\n\tTue, 30 May 2023 11:07:48 +0200 (CEST)", "from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188])\n by mails.dpdk.org (Postfix) with ESMTP id 21DA542D20\n for <dev@dpdk.org>; Tue, 30 May 2023 11:07:43 +0200 (CEST)", "from kwepemi500020.china.huawei.com (unknown [172.30.72.55])\n by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4QVmkY1hWbzSqX8;\n Tue, 30 May 2023 17:07:33 +0800 (CST)", "from localhost.localdomain (10.69.192.56) by\n kwepemi500020.china.huawei.com (7.221.188.8) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id\n 15.1.2507.23; Tue, 30 May 2023 17:07:41 +0800" ], "From": "Jie Hai <haijie1@huawei.com>", "To": "Thomas Monjalon <thomas@monjalon.net>, Ferruh Yigit\n <ferruh.yigit@amd.com>, Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>", "CC": "<dev@dpdk.org>, <liudongdong3@huawei.com>", "Subject": "[PATCH 07/10] ethdev: support telemetry query DCB info", "Date": "Tue, 30 May 2023 17:05:07 +0800", "Message-ID": "<20230530090510.56812-8-haijie1@huawei.com>", "X-Mailer": "git-send-email 2.33.0", "In-Reply-To": "<20230530090510.56812-1-haijie1@huawei.com>", "References": "<20230530090510.56812-1-haijie1@huawei.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Originating-IP": "[10.69.192.56]", "X-ClientProxiedBy": "dggems705-chm.china.huawei.com (10.3.19.182) To\n kwepemi500020.china.huawei.com (7.221.188.8)", "X-CFilter-Loop": "Reflected", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "This patch supports querying DCB info.\n\nThe command is like:\n--> /ethdev/dcb,0\n{\n \"/ethdev/dcb\": {\n \"tc_num\": 1,\n \"tc0\": {\n \"priority\": 0,\n \"bw_percent\": \"100%\",\n \"rxq_base\": 0,\n \"txq_base\": 0,\n \"nb_rxq\": 4,\n \"nb_txq\": 4\n }\n }\n}\n\nSigned-off-by: Jie Hai <haijie1@huawei.com>\n---\n lib/ethdev/rte_ethdev.c | 85 +++++++++++++++++++++++++++++++++++++++++\n 1 file changed, 85 insertions(+)", "diff": "diff --git a/lib/ethdev/rte_ethdev.c b/lib/ethdev/rte_ethdev.c\nindex d906cc66d2f9..dad9c5538149 100644\n--- a/lib/ethdev/rte_ethdev.c\n+++ b/lib/ethdev/rte_ethdev.c\n@@ -7349,6 +7349,89 @@ eth_dev_handle_port_txq(const char *cmd __rte_unused,\n \treturn 0;\n }\n \n+static int\n+eth_dev_add_dcb_tc(struct rte_eth_dcb_info *dcb_info, struct rte_tel_data *d)\n+{\n+\tstruct rte_tel_data *tcds[RTE_ETH_DCB_NUM_TCS] = {NULL};\n+\tstruct rte_eth_dcb_tc_queue_mapping *tcq;\n+\tchar bw_percent[RTE_TEL_MAX_STRING_LEN];\n+\tchar name[RTE_TEL_MAX_STRING_LEN];\n+\tstruct rte_tel_data *tcd;\n+\tuint32_t i;\n+\n+\tfor (i = 0; i < dcb_info->nb_tcs; i++) {\n+\t\ttcd = rte_tel_data_alloc();\n+\t\tif (tcd == NULL) {\n+\t\t\twhile (i-- > 0)\n+\t\t\t\trte_tel_data_free(tcds[i]);\n+\t\t\treturn -ENOMEM;\n+\t\t}\n+\n+\t\ttcds[i] = tcd;\n+\t\trte_tel_data_start_dict(tcd);\n+\n+\t\trte_tel_data_add_dict_uint(tcd, \"priority\", dcb_info->prio_tc[i]);\n+\t\tsnprintf(bw_percent, RTE_TEL_MAX_STRING_LEN,\n+\t\t\t\"%u%%\", dcb_info->tc_bws[i]);\n+\t\trte_tel_data_add_dict_string(tcd, \"bw_percent\", bw_percent);\n+\n+\t\ttcq = &dcb_info->tc_queue;\n+\t\trte_tel_data_add_dict_uint(tcd, \"rxq_base\", tcq->tc_rxq[0][i].base);\n+\t\trte_tel_data_add_dict_uint(tcd, \"txq_base\", tcq->tc_txq[0][i].base);\n+\t\trte_tel_data_add_dict_uint(tcd, \"nb_rxq\", tcq->tc_rxq[0][i].nb_queue);\n+\t\trte_tel_data_add_dict_uint(tcd, \"nb_txq\", tcq->tc_txq[0][i].nb_queue);\n+\n+\t\tsnprintf(name, RTE_TEL_MAX_STRING_LEN, \"tc%u\", i);\n+\t\trte_tel_data_add_dict_container(d, name, tcd, 0);\n+\t}\n+\n+\treturn 0;\n+}\n+\n+static int\n+eth_dev_add_dcb_info(uint16_t port_id, struct rte_tel_data *d)\n+{\n+\tstruct rte_eth_dcb_info dcb_info;\n+\tint ret;\n+\n+\tret = rte_eth_dev_get_dcb_info(port_id, &dcb_info);\n+\tif (ret != 0) {\n+\t\tRTE_ETHDEV_LOG(ERR,\n+\t\t\t\"Failed to get dcb info, ret = %d\\n\", ret);\n+\t\treturn ret;\n+\t}\n+\n+\trte_tel_data_start_dict(d);\n+\trte_tel_data_add_dict_uint(d, \"tc_num\", dcb_info.nb_tcs);\n+\n+\tif (dcb_info.nb_tcs > 0)\n+\t\treturn eth_dev_add_dcb_tc(&dcb_info, d);\n+\n+\treturn 0;\n+}\n+\n+static int\n+eth_dev_handle_port_dcb(const char *cmd __rte_unused,\n+\t\tconst char *params,\n+\t\tstruct rte_tel_data *d)\n+{\n+\tunsigned long port_id;\n+\tchar *end_param;\n+\n+\tif (params == NULL || strlen(params) == 0 || !isdigit(*params))\n+\t\treturn -EINVAL;\n+\n+\tport_id = strtoul(params, &end_param, 0);\n+\tif (*end_param != '\\0')\n+\t\tRTE_ETHDEV_LOG(NOTICE,\n+\t\t\t\"Extra parameters passed to ethdev telemetry command, ignoring\\n\");\n+\n+\tif (port_id >= UINT16_MAX || !rte_eth_dev_is_valid_port(port_id))\n+\t\treturn -EINVAL;\n+\n+\treturn eth_dev_add_dcb_info(port_id, d);\n+}\n+\n RTE_LOG_REGISTER_DEFAULT(rte_eth_dev_logtype, INFO);\n \n RTE_INIT(ethdev_init_telemetry)\n@@ -7378,4 +7461,6 @@ RTE_INIT(ethdev_init_telemetry)\n \t\t\t\"Returns Rx queue info for a port. Parameters: unsigned port_id, unsigned queue_id (Optional if only one queue)\");\n \trte_telemetry_register_cmd(\"/ethdev/tx_queue\", eth_dev_handle_port_txq,\n \t\t\t\"Returns Tx queue info for a port. Parameters: unsigned port_id, unsigned queue_id (Optional if only one queue)\");\n+\trte_telemetry_register_cmd(\"/ethdev/dcb\", eth_dev_handle_port_dcb,\n+\t\t\t\"Returns DCB info for a port. Parameters: unsigned port_id\");\n }\n", "prefixes": [ "07/10" ] }