Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/127692/?format=api
{ "id": 127692, "url": "https://patches.dpdk.org/api/patches/127692/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20230530090510.56812-4-haijie1@huawei.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230530090510.56812-4-haijie1@huawei.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20230530090510.56812-4-haijie1@huawei.com", "date": "2023-05-30T09:05:03", "name": "[03/10] ethdev: support telemetry query flow ctrl info", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "24951ba45ae895ab5fdddf668cf9867aed86a109", "submitter": { "id": 2935, "url": "https://patches.dpdk.org/api/people/2935/?format=api", "name": "Jie Hai", "email": "haijie1@huawei.com" }, "delegate": { "id": 319, "url": "https://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20230530090510.56812-4-haijie1@huawei.com/mbox/", "series": [ { "id": 28245, "url": "https://patches.dpdk.org/api/series/28245/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=28245", "date": "2023-05-30T09:05:00", "name": "support telemetry query ethdev info", "version": 1, "mbox": "https://patches.dpdk.org/series/28245/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/127692/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/127692/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 682C742BE1;\n\tTue, 30 May 2023 11:07:57 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id F232742D33;\n\tTue, 30 May 2023 11:07:44 +0200 (CEST)", "from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188])\n by mails.dpdk.org (Postfix) with ESMTP id D4B4442D0D\n for <dev@dpdk.org>; Tue, 30 May 2023 11:07:41 +0200 (CEST)", "from kwepemi500020.china.huawei.com (unknown [172.30.72.55])\n by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4QVmkW3k9MzSqQt;\n Tue, 30 May 2023 17:07:31 +0800 (CST)", "from localhost.localdomain (10.69.192.56) by\n kwepemi500020.china.huawei.com (7.221.188.8) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id\n 15.1.2507.23; Tue, 30 May 2023 17:07:39 +0800" ], "From": "Jie Hai <haijie1@huawei.com>", "To": "Thomas Monjalon <thomas@monjalon.net>, Ferruh Yigit\n <ferruh.yigit@amd.com>, Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>", "CC": "<dev@dpdk.org>, <liudongdong3@huawei.com>", "Subject": "[PATCH 03/10] ethdev: support telemetry query flow ctrl info", "Date": "Tue, 30 May 2023 17:05:03 +0800", "Message-ID": "<20230530090510.56812-4-haijie1@huawei.com>", "X-Mailer": "git-send-email 2.33.0", "In-Reply-To": "<20230530090510.56812-1-haijie1@huawei.com>", "References": "<20230530090510.56812-1-haijie1@huawei.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Originating-IP": "[10.69.192.56]", "X-ClientProxiedBy": "dggems705-chm.china.huawei.com (10.3.19.182) To\n kwepemi500020.china.huawei.com (7.221.188.8)", "X-CFilter-Loop": "Reflected", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "This patch supports telemetry querying flow control info.\nThe command is like:\n--> /ethdev/flow_ctrl,0\n{\n \"/ethdev/flow_ctrl\": {\n \"high_waterline\": \"0x0\",\n \"low_waterline\": \"0x0\",\n \"pause_time\": \"0xffff\",\n \"send_xon\": \"off\",\n \"mac_ctrl_frame_fwd\": \"off\",\n \"rx_pause\": \"off\",\n \"tx_pause\": \"off\",\n \"autoneg\": \"off\"\n }\n}\n\nSigned-off-by: Jie Hai <haijie1@huawei.com>\n---\n lib/ethdev/rte_ethdev.c | 51 +++++++++++++++++++++++++++++++++++++++++\n 1 file changed, 51 insertions(+)", "diff": "diff --git a/lib/ethdev/rte_ethdev.c b/lib/ethdev/rte_ethdev.c\nindex 3207b3177256..5cdb310ca979 100644\n--- a/lib/ethdev/rte_ethdev.c\n+++ b/lib/ethdev/rte_ethdev.c\n@@ -7121,6 +7121,55 @@ eth_dev_handle_port_macs(const char *cmd __rte_unused,\n \treturn 0;\n }\n \n+static int\n+eth_dev_handle_port_flow_ctrl(const char *cmd __rte_unused,\n+\t\tconst char *params,\n+\t\tstruct rte_tel_data *d)\n+{\n+\tstruct rte_eth_fc_conf fc_conf;\n+\tunsigned long port_id;\n+\tchar *end_param;\n+\tbool rx_fc_en;\n+\tbool tx_fc_en;\n+\tint ret;\n+\n+\tif (params == NULL || strlen(params) == 0 || !isdigit(*params))\n+\t\treturn -EINVAL;\n+\n+\tport_id = strtoul(params, &end_param, 0);\n+\tif (*end_param != '\\0')\n+\t\tRTE_ETHDEV_LOG(NOTICE,\n+\t\t\t\"Extra parameters passed to ethdev telemetry command, ignoring\\n\");\n+\n+\tif (port_id >= UINT16_MAX || !rte_eth_dev_is_valid_port(port_id))\n+\t\treturn -EINVAL;\n+\n+\tret = rte_eth_dev_flow_ctrl_get(port_id, &fc_conf);\n+\tif (ret != 0) {\n+\t\tRTE_ETHDEV_LOG(ERR,\n+\t\t\t\"Failed to get flow ctrl info, ret = %d\\n\", ret);\n+\t\treturn ret;\n+\t}\n+\n+\trx_fc_en = fc_conf.mode == RTE_ETH_FC_RX_PAUSE ||\n+\t\t fc_conf.mode == RTE_ETH_FC_FULL;\n+\ttx_fc_en = fc_conf.mode == RTE_ETH_FC_TX_PAUSE ||\n+\t\t fc_conf.mode == RTE_ETH_FC_FULL;\n+\n+\trte_tel_data_start_dict(d);\n+\trte_tel_data_add_dict_uint_hex(d, \"high_waterline\", fc_conf.high_water, 0);\n+\trte_tel_data_add_dict_uint_hex(d, \"low_waterline\", fc_conf.low_water, 0);\n+\trte_tel_data_add_dict_uint_hex(d, \"pause_time\", fc_conf.pause_time, 0);\n+\trte_tel_data_add_dict_string(d, \"send_xon\", fc_conf.send_xon ? \"on\" : \"off\");\n+\trte_tel_data_add_dict_string(d, \"mac_ctrl_frame_fwd\",\n+\t\t\tfc_conf.mac_ctrl_frame_fwd ? \"on\" : \"off\");\n+\trte_tel_data_add_dict_string(d, \"rx_pause\", rx_fc_en ? \"on\" : \"off\");\n+\trte_tel_data_add_dict_string(d, \"tx_pause\", tx_fc_en ? \"on\" : \"off\");\n+\trte_tel_data_add_dict_string(d, \"autoneg\", fc_conf.autoneg ? \"on\" : \"off\");\n+\n+\treturn 0;\n+}\n+\n RTE_LOG_REGISTER_DEFAULT(rte_eth_dev_logtype, INFO);\n \n RTE_INIT(ethdev_init_telemetry)\n@@ -7144,4 +7193,6 @@ RTE_INIT(ethdev_init_telemetry)\n \t\t\t\"Returns module EEPROM info with SFF specs. Parameters: int port_id\");\n \trte_telemetry_register_cmd(\"/ethdev/macs\", eth_dev_handle_port_macs,\n \t\t\t\"Returns the MAC addresses for a port. Parameters: int port_id\");\n+\trte_telemetry_register_cmd(\"/ethdev/flow_ctrl\", eth_dev_handle_port_flow_ctrl,\n+\t\t\t\"Returns flow ctrl info for a port. Parameters: unsigned port_id\");\n }\n", "prefixes": [ "03/10" ] }