Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/127691/?format=api
{ "id": 127691, "url": "https://patches.dpdk.org/api/patches/127691/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20230530090510.56812-5-haijie1@huawei.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230530090510.56812-5-haijie1@huawei.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20230530090510.56812-5-haijie1@huawei.com", "date": "2023-05-30T09:05:04", "name": "[04/10] ethdev: support telemetry query Rx queue info", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "3c4a1c5ab9b9068642a5673f2dc86409f69a148c", "submitter": { "id": 2935, "url": "https://patches.dpdk.org/api/people/2935/?format=api", "name": "Jie Hai", "email": "haijie1@huawei.com" }, "delegate": { "id": 319, "url": "https://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20230530090510.56812-5-haijie1@huawei.com/mbox/", "series": [ { "id": 28245, "url": "https://patches.dpdk.org/api/series/28245/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=28245", "date": "2023-05-30T09:05:00", "name": "support telemetry query ethdev info", "version": 1, "mbox": "https://patches.dpdk.org/series/28245/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/127691/comments/", "check": "warning", "checks": "https://patches.dpdk.org/api/patches/127691/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id D6AC642BE1;\n\tTue, 30 May 2023 11:07:49 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id CB93242D32;\n\tTue, 30 May 2023 11:07:43 +0200 (CEST)", "from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187])\n by mails.dpdk.org (Postfix) with ESMTP id CB93C42BDA\n for <dev@dpdk.org>; Tue, 30 May 2023 11:07:41 +0200 (CEST)", "from kwepemi500020.china.huawei.com (unknown [172.30.72.56])\n by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4QVmh66X4bzsSdb;\n Tue, 30 May 2023 17:05:26 +0800 (CST)", "from localhost.localdomain (10.69.192.56) by\n kwepemi500020.china.huawei.com (7.221.188.8) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id\n 15.1.2507.23; Tue, 30 May 2023 17:07:40 +0800" ], "From": "Jie Hai <haijie1@huawei.com>", "To": "Thomas Monjalon <thomas@monjalon.net>, Ferruh Yigit\n <ferruh.yigit@amd.com>, Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>", "CC": "<dev@dpdk.org>, <liudongdong3@huawei.com>", "Subject": "[PATCH 04/10] ethdev: support telemetry query Rx queue info", "Date": "Tue, 30 May 2023 17:05:04 +0800", "Message-ID": "<20230530090510.56812-5-haijie1@huawei.com>", "X-Mailer": "git-send-email 2.33.0", "In-Reply-To": "<20230530090510.56812-1-haijie1@huawei.com>", "References": "<20230530090510.56812-1-haijie1@huawei.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Originating-IP": "[10.69.192.56]", "X-ClientProxiedBy": "dggems705-chm.china.huawei.com (10.3.19.182) To\n kwepemi500020.china.huawei.com (7.221.188.8)", "X-CFilter-Loop": "Reflected", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "This patch support querying information of Rx queues.\nThe command is like:\n--> /ethdev/rx_queue,0,0\n{\n \"/ethdev/rx_queue\": {\n \"mempool_name\": \"mb_pool_0\",\n \"socket_id\": 0,\n \"host_threshold\": 0,\n \"prefetch_threshold\": 0,\n \"writeback_threshold\": 0,\n \"free_threshold\": 32,\n \"rx_drop_en\": \"on\",\n \"deferred_start\": \"off\",\n \"rx_nseg\": 0,\n \"share_group\": 0,\n \"share_qid\": 0,\n \"offloads\": [\n \"RSS_HASH\"\n ],\n \"rx_nmempool\": 0,\n \"scattered_rx\": \"off\",\n \"queue_state\": 1,\n \"nb_desc\": 1024,\n \"rx_buf_size\": 2048,\n \"avail_thresh\": 0,\n \"burst_flags\": 0,\n \"burst_mode\": \"Vector Neon\"\n }\n}\n\nSigned-off-by: Jie Hai <haijie1@huawei.com>\n---\n lib/ethdev/rte_ethdev.c | 127 ++++++++++++++++++++++++++++++++++++++++\n 1 file changed, 127 insertions(+)", "diff": "diff --git a/lib/ethdev/rte_ethdev.c b/lib/ethdev/rte_ethdev.c\nindex 5cdb310ca979..35c13df1c110 100644\n--- a/lib/ethdev/rte_ethdev.c\n+++ b/lib/ethdev/rte_ethdev.c\n@@ -7170,6 +7170,131 @@ eth_dev_handle_port_flow_ctrl(const char *cmd __rte_unused,\n \treturn 0;\n }\n \n+static int\n+parse_queue_params(const char *params, bool is_rx,\n+\t\tunsigned long *port_id, unsigned long *queue_id)\n+{\n+\tstruct rte_eth_dev *dev;\n+\tconst char *qid_param;\n+\tuint16_t nb_queues;\n+\tchar *end_param;\n+\n+\tif (params == NULL || strlen(params) == 0 || !isdigit(*params))\n+\t\treturn -EINVAL;\n+\n+\t*port_id = strtoul(params, &end_param, 0);\n+\tif (*port_id >= UINT16_MAX || !rte_eth_dev_is_valid_port(*port_id))\n+\t\treturn -EINVAL;\n+\n+\tdev = &rte_eth_devices[*port_id];\n+\tnb_queues = is_rx ? dev->data->nb_rx_queues : dev->data->nb_tx_queues;\n+\tif (nb_queues == 1 && *end_param == '\\0')\n+\t\t*queue_id = 0;\n+\telse {\n+\t\tqid_param = strtok(end_param, \",\");\n+\t\tif (!qid_param || strlen(qid_param) == 0 || !isdigit(*qid_param))\n+\t\t\treturn -EINVAL;\n+\n+\t\t*queue_id = strtoul(qid_param, &end_param, 0);\n+\t}\n+\tif (*end_param != '\\0')\n+\t\tRTE_ETHDEV_LOG(NOTICE,\n+\t\t\t\"Extra parameters passed to ethdev telemetry command, ignoring\\n\");\n+\n+\tif (*queue_id >= UINT16_MAX)\n+\t\treturn -EINVAL;\n+\n+\treturn 0;\n+}\n+\n+static int\n+eth_dev_add_burst_mode(unsigned long port_id, unsigned long queue_id,\n+\t\t\tbool is_rx, struct rte_tel_data *d)\n+{\n+\tstruct rte_eth_burst_mode mode;\n+\tint ret;\n+\n+\tif (is_rx)\n+\t\tret = rte_eth_rx_burst_mode_get(port_id, queue_id, &mode);\n+\telse\n+\t\tret = rte_eth_tx_burst_mode_get(port_id, queue_id, &mode);\n+\n+\tif (ret == -ENOTSUP)\n+\t\treturn 0;\n+\n+\tif (ret != 0) {\n+\t\tRTE_ETHDEV_LOG(ERR,\n+\t\t\t\"Failed to get burst mode for port %lu\\n\", port_id);\n+\t\treturn ret;\n+\t}\n+\n+\trte_tel_data_add_dict_uint(d, \"burst_flags\", mode.flags);\n+\trte_tel_data_add_dict_string(d, \"burst_mode\", mode.info);\n+\treturn 0;\n+}\n+\n+static int\n+eth_dev_handle_port_rxq(const char *cmd __rte_unused,\n+\t\tconst char *params,\n+\t\tstruct rte_tel_data *d)\n+{\n+\tstruct rte_eth_thresh *rx_thresh;\n+\tunsigned long port_id, queue_id;\n+\tstruct rte_eth_rxconf *rxconf;\n+\tstruct rte_eth_rxq_info qinfo;\n+\tstruct rte_tel_data *offload;\n+\tint ret;\n+\n+\tret = parse_queue_params(params, true, &port_id, &queue_id);\n+\tif (ret != 0)\n+\t\treturn ret;\n+\n+\tret = rte_eth_rx_queue_info_get(port_id, queue_id, &qinfo);\n+\tif (ret != 0)\n+\t\treturn ret;\n+\n+\trte_tel_data_start_dict(d);\n+\trte_tel_data_add_dict_string(d, \"mempool_name\", qinfo.mp->name);\n+\trte_tel_data_add_dict_uint(d, \"socket_id\", qinfo.mp->socket_id);\n+\n+\trx_thresh = &qinfo.conf.rx_thresh;\n+\trte_tel_data_add_dict_uint(d, \"host_threshold\", rx_thresh->hthresh);\n+\trte_tel_data_add_dict_uint(d, \"prefetch_threshold\", rx_thresh->pthresh);\n+\trte_tel_data_add_dict_uint(d, \"writeback_threshold\", rx_thresh->wthresh);\n+\n+\trxconf = &qinfo.conf;\n+\trte_tel_data_add_dict_uint(d, \"free_threshold\", rxconf->rx_free_thresh);\n+\trte_tel_data_add_dict_string(d, \"rx_drop_en\",\n+\t\t\trxconf->rx_drop_en == 0 ? \"off\" : \"on\");\n+\trte_tel_data_add_dict_string(d, \"deferred_start\",\n+\t\t\trxconf->rx_deferred_start == 0 ? \"off\" : \"on\");\n+\trte_tel_data_add_dict_uint(d, \"rx_nseg\", rxconf->rx_nseg);\n+\trte_tel_data_add_dict_uint(d, \"share_group\", rxconf->share_group);\n+\trte_tel_data_add_dict_uint(d, \"share_qid\", rxconf->share_qid);\n+\n+\toffload = rte_tel_data_alloc();\n+\tif (offload == NULL)\n+\t\treturn -ENOMEM;\n+\n+\teth_dev_parse_rx_offloads(rxconf->offloads, offload);\n+\trte_tel_data_add_dict_container(d, \"offloads\", offload, 0);\n+\n+\trte_tel_data_add_dict_uint(d, \"rx_nmempool\", rxconf->rx_nmempool);\n+\n+\trte_tel_data_add_dict_string(d, \"scattered_rx\",\n+\t\t\tqinfo.scattered_rx == 0 ? \"off\" : \"on\");\n+\trte_tel_data_add_dict_uint(d, \"queue_state\", qinfo.queue_state);\n+\trte_tel_data_add_dict_uint(d, \"nb_desc\", qinfo.nb_desc);\n+\trte_tel_data_add_dict_uint(d, \"rx_buf_size\", qinfo.rx_buf_size);\n+\trte_tel_data_add_dict_uint(d, \"avail_thresh\", qinfo.avail_thresh);\n+\n+\tret = eth_dev_add_burst_mode(port_id, queue_id, true, d);\n+\tif (ret != 0)\n+\t\trte_tel_data_free(offload);\n+\n+\treturn ret;\n+}\n+\n RTE_LOG_REGISTER_DEFAULT(rte_eth_dev_logtype, INFO);\n \n RTE_INIT(ethdev_init_telemetry)\n@@ -7195,4 +7320,6 @@ RTE_INIT(ethdev_init_telemetry)\n \t\t\t\"Returns the MAC addresses for a port. Parameters: int port_id\");\n \trte_telemetry_register_cmd(\"/ethdev/flow_ctrl\", eth_dev_handle_port_flow_ctrl,\n \t\t\t\"Returns flow ctrl info for a port. Parameters: unsigned port_id\");\n+\trte_telemetry_register_cmd(\"/ethdev/rx_queue\", eth_dev_handle_port_rxq,\n+\t\t\t\"Returns Rx queue info for a port. Parameters: unsigned port_id, unsigned queue_id (Optional if only one queue)\");\n }\n", "prefixes": [ "04/10" ] }