Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/127501/?format=api
https://patches.dpdk.org/api/patches/127501/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20230525182812.152907-3-hernan.vargas@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230525182812.152907-3-hernan.vargas@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20230525182812.152907-3-hernan.vargas@intel.com", "date": "2023-05-25T18:28:08", "name": "[v2,2/6] baseband/fpga_5gnr_fec: fix seg fault unconf queue", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "9ce496ce941aa36c5cb40bfdbdcbb19749804a56", "submitter": { "id": 2659, "url": "https://patches.dpdk.org/api/people/2659/?format=api", "name": "Hernan Vargas", "email": "hernan.vargas@intel.com" }, "delegate": { "id": 2642, "url": "https://patches.dpdk.org/api/users/2642/?format=api", "username": "mcoquelin", "first_name": "Maxime", "last_name": "Coquelin", "email": "maxime.coquelin@redhat.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20230525182812.152907-3-hernan.vargas@intel.com/mbox/", "series": [ { "id": 28189, "url": "https://patches.dpdk.org/api/series/28189/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=28189", "date": "2023-05-25T18:28:06", "name": "changes for 23.07", "version": 2, "mbox": "https://patches.dpdk.org/series/28189/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/127501/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/127501/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id E3A2A42B9E;\n\tThu, 25 May 2023 20:31:31 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 6939A42D32;\n\tThu, 25 May 2023 20:31:22 +0200 (CEST)", "from mga03.intel.com (mga03.intel.com [134.134.136.65])\n by mails.dpdk.org (Postfix) with ESMTP id 8D13540DDB;\n Thu, 25 May 2023 20:31:18 +0200 (CEST)", "from fmsmga005.fm.intel.com ([10.253.24.32])\n by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 25 May 2023 11:29:25 -0700", "from unknown (HELO csl-npg-qt0.la.intel.com) ([10.233.181.103])\n by fmsmga005.fm.intel.com with ESMTP; 25 May 2023 11:29:18 -0700" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1685039479; x=1716575479;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=aEWXBvCy0Kc7EtA8UAFV50eYLnYusCj33VtmSprBoyo=;\n b=l8ziXfbRmV6a2nXx/nMxE6SLZhvfsvqo34MunnbvgMj61XqbUort0RV6\n zX4BncyjdVuBWYSZWhtrFBmSN6vfMv3RUryfpG3HwxVTxQ5OuqkEF+Nt8\n PJOAskeuuagQXy6EoxwI6pfxhCi3ItJ5lT5FHRR+7tmOy+77sxB8XoVxO\n xUahiVcZAGzQogbqy+rDsCzHUpR4bIhekwng4QVl+Zdp/ocuKL55GK21U\n AA3LsNEIvnfbtBK7i7JE+jJRbCUJKxdvfvTm1Tyx9LDB2VGrgxhscb+55\n 2YGvB6J5FN3YOD74fhrRkFwYILVEE8hrY6DPTwZysqs1Gy72T2bWSgbZ/ Q==;", "X-IronPort-AV": [ "E=McAfee;i=\"6600,9927,10721\"; a=\"357236177\"", "E=Sophos;i=\"6.00,191,1681196400\"; d=\"scan'208\";a=\"357236177\"", "E=McAfee;i=\"6600,9927,10721\"; a=\"1035044099\"", "E=Sophos;i=\"6.00,191,1681196400\"; d=\"scan'208\";a=\"1035044099\"" ], "X-ExtLoop1": "1", "From": "Hernan Vargas <hernan.vargas@intel.com>", "To": "dev@dpdk.org, maxime.coquelin@redhat.com, gakhil@marvell.com,\n trix@redhat.com", "Cc": "nicolas.chautru@intel.com, qi.z.zhang@intel.com,\n Hernan Vargas <hernan.vargas@intel.com>, stable@dpdk.org", "Subject": "[PATCH v2 2/6] baseband/fpga_5gnr_fec: fix seg fault unconf queue", "Date": "Thu, 25 May 2023 11:28:08 -0700", "Message-Id": "<20230525182812.152907-3-hernan.vargas@intel.com>", "X-Mailer": "git-send-email 2.37.1", "In-Reply-To": "<20230525182812.152907-1-hernan.vargas@intel.com>", "References": "<20230525182812.152907-1-hernan.vargas@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Adding exception to prevent segmentation fault in case a queue is\nstarted which was not configured earlier.\n\nFixes: c58109a8871d (\"baseband/fpga_5gnr_fec: add queue configuration\")\nCc: stable@dpdk.org\n\nSigned-off-by: Hernan Vargas <hernan.vargas@intel.com>\nReviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>\n---\n drivers/baseband/fpga_5gnr_fec/rte_fpga_5gnr_fec.c | 14 +++++++++-----\n 1 file changed, 9 insertions(+), 5 deletions(-)", "diff": "diff --git a/drivers/baseband/fpga_5gnr_fec/rte_fpga_5gnr_fec.c b/drivers/baseband/fpga_5gnr_fec/rte_fpga_5gnr_fec.c\nindex 99390c48160c..6b0644ffc5d6 100644\n--- a/drivers/baseband/fpga_5gnr_fec/rte_fpga_5gnr_fec.c\n+++ b/drivers/baseband/fpga_5gnr_fec/rte_fpga_5gnr_fec.c\n@@ -567,17 +567,21 @@ static int\n fpga_queue_start(struct rte_bbdev *dev, uint16_t queue_id)\n {\n \tstruct fpga_5gnr_fec_device *d = dev->data->dev_private;\n+\tstruct fpga_queue *q = dev->data->queues[queue_id].queue_private;\n+\tuint32_t offset = FPGA_5GNR_FEC_RING_CTRL_REGS +\n+\t\t\t(sizeof(struct fpga_ring_ctrl_reg) * q->q_idx);\n+\tuint8_t enable = 0x01;\n+\tuint16_t zero = 0x0000;\n #ifdef RTE_LIBRTE_BBDEV_DEBUG\n \tif (d == NULL) {\n \t\trte_bbdev_log(ERR, \"Invalid device pointer\");\n \t\treturn -1;\n \t}\n #endif\n-\tstruct fpga_queue *q = dev->data->queues[queue_id].queue_private;\n-\tuint32_t offset = FPGA_5GNR_FEC_RING_CTRL_REGS +\n-\t\t\t(sizeof(struct fpga_ring_ctrl_reg) * q->q_idx);\n-\tuint8_t enable = 0x01;\n-\tuint16_t zero = 0x0000;\n+\tif (dev->data->queues[queue_id].queue_private == NULL) {\n+\t\trte_bbdev_log(ERR, \"Cannot start invalid queue %d\", queue_id);\n+\t\treturn -1;\n+\t}\n \n \t/* Clear queue head and tail variables */\n \tq->tail = q->head_free_desc = 0;\n", "prefixes": [ "v2", "2/6" ] }{ "id": 127501, "url": "