Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/127217/?format=api
{ "id": 127217, "url": "https://patches.dpdk.org/api/patches/127217/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/0f77ce4515ff074f997f0068635b328060322d5a.1684847165.git.anatoly.burakov@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<0f77ce4515ff074f997f0068635b328060322d5a.1684847165.git.anatoly.burakov@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/0f77ce4515ff074f997f0068635b328060322d5a.1684847165.git.anatoly.burakov@intel.com", "date": "2023-05-23T13:06:16", "name": "[v1,1/1] eal: warn user when lcore cpuset includes multiple sockets", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "ef911cd277becffbaa76b44a3d31344e37d2b5f6", "submitter": { "id": 4, "url": "https://patches.dpdk.org/api/people/4/?format=api", "name": "Anatoly Burakov", "email": "anatoly.burakov@intel.com" }, "delegate": { "id": 1, "url": "https://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/0f77ce4515ff074f997f0068635b328060322d5a.1684847165.git.anatoly.burakov@intel.com/mbox/", "series": [ { "id": 28133, "url": "https://patches.dpdk.org/api/series/28133/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=28133", "date": "2023-05-23T13:06:16", "name": "[v1,1/1] eal: warn user when lcore cpuset includes multiple sockets", "version": 1, "mbox": "https://patches.dpdk.org/series/28133/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/127217/comments/", "check": "warning", "checks": "https://patches.dpdk.org/api/patches/127217/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 8C2CB42B81;\n\tTue, 23 May 2023 15:06:24 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 1296E40A80;\n\tTue, 23 May 2023 15:06:24 +0200 (CEST)", "from mga17.intel.com (mga17.intel.com [192.55.52.151])\n by mails.dpdk.org (Postfix) with ESMTP id 6525D40689\n for <dev@dpdk.org>; Tue, 23 May 2023 15:06:22 +0200 (CEST)", "from fmsmga007.fm.intel.com ([10.253.24.52])\n by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 23 May 2023 06:06:18 -0700", "from silpixa00401191.ir.intel.com ([10.55.128.139])\n by fmsmga007.fm.intel.com with ESMTP; 23 May 2023 06:06:17 -0700" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1684847182; x=1716383182;\n h=from:to:cc:subject:date:message-id:mime-version:\n content-transfer-encoding;\n bh=u6SuAOsYHwztwaYm94LqGH8r0lyICwJv4pst21GuCH8=;\n b=Hd0edyzXSlUo+X1DxoN9TF8suYoGf49Adhj8phbJeVubLaZrtwIpo1tO\n ZMSO3C/+3zcHveVRkjSYjdxx3CxLUdOy/SI+M2k8Pvjyvalf0jtodVPhd\n MjyEKJIm5fJ7dZPoZOSTYwh8BNPGm76XLzxeQH7LjjbctDo8cIj96d/rh\n WeYyk3tAiMVvvs5PBjjz6O9t5u8z3IGaopqJfBwJstLi/QTtzm0Er4VBs\n PVkdGM594uL+DQvobjVSp8/XzXGSSBJ/YGpWRKs7dDJ6F4AytmHh5EL/l\n 9NfDuQJQ/NZAcAxCnAM1xHCIesJfg71BAVwlEEmCPTOuoGEUXGJ6XCT4r g==;", "X-IronPort-AV": [ "E=McAfee;i=\"6600,9927,10719\"; a=\"333592641\"", "E=Sophos;i=\"6.00,186,1681196400\"; d=\"scan'208\";a=\"333592641\"", "E=McAfee;i=\"6600,9927,10719\"; a=\"707001915\"", "E=Sophos;i=\"6.00,186,1681196400\"; d=\"scan'208\";a=\"707001915\"" ], "X-ExtLoop1": "1", "From": "Anatoly Burakov <anatoly.burakov@intel.com>", "To": "dev@dpdk.org", "Cc": "david.marchand@redhat.com,\n\tkaisenx.you@intel.com,\n\tthomas@monjalon.net", "Subject": "[PATCH v1 1/1] eal: warn user when lcore cpuset includes multiple\n sockets", "Date": "Tue, 23 May 2023 13:06:16 +0000", "Message-Id": "\n <0f77ce4515ff074f997f0068635b328060322d5a.1684847165.git.anatoly.burakov@intel.com>", "X-Mailer": "git-send-email 2.37.2", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Currently, it is allowed to specify a cpuset for lcores such that it\nwill include physical cores from different NUMA nodes. This has an\neffect of setting `rte_socket_id()` for that lcore to SOCKET_ID_ANY,\nso add a warning about it.\n\nSigned-off-by: Anatoly Burakov <anatoly.burakov@intel.com>\n---\n lib/eal/common/eal_common_thread.c | 20 +++++++++++++++++---\n 1 file changed, 17 insertions(+), 3 deletions(-)", "diff": "diff --git a/lib/eal/common/eal_common_thread.c b/lib/eal/common/eal_common_thread.c\nindex 079a385630..46fd2aca1e 100644\n--- a/lib/eal/common/eal_common_thread.c\n+++ b/lib/eal/common/eal_common_thread.c\n@@ -65,10 +65,13 @@ static void\n thread_update_affinity(rte_cpuset_t *cpusetp)\n {\n \tunsigned int lcore_id = rte_lcore_id();\n+\tint socket_id;\n+\n+\t/* find socket ID from cpuset */\n+\tsocket_id = eal_cpuset_socket_id(cpusetp);\n \n \t/* store socket_id in TLS for quick access */\n-\tRTE_PER_LCORE(_socket_id) =\n-\t\teal_cpuset_socket_id(cpusetp);\n+\tRTE_PER_LCORE(_socket_id) = socket_id;\n \n \t/* store cpuset in TLS for quick access */\n \tmemmove(&RTE_PER_LCORE(_cpuset), cpusetp,\n@@ -76,9 +79,20 @@ thread_update_affinity(rte_cpuset_t *cpusetp)\n \n \tif (lcore_id != (unsigned)LCORE_ID_ANY) {\n \t\t/* EAL thread will update lcore_config */\n-\t\tlcore_config[lcore_id].socket_id = RTE_PER_LCORE(_socket_id);\n+\t\tlcore_config[lcore_id].socket_id = socket_id;\n \t\tmemmove(&lcore_config[lcore_id].cpuset, cpusetp,\n \t\t\tsizeof(rte_cpuset_t));\n+\t\t\n+\t\t/*\n+\t\t * lcore_id is not LCORE_ID_ANY, meaning this is a DPDK lcore,\n+\t\t * so having a valid NUMA affinity for this lcore is important.\n+\t\t * However, if cpuset includes cores from multiple NUMA nodes,\n+\t\t * the socket ID will be set to SOCKET_ID_ANY. Notify the user\n+\t\t * about it if that happens.\n+\t\t */\n+\t\tif (socket_id == SOCKET_ID_ANY)\n+\t\t\tRTE_LOG(INFO, EAL, \"DPDK lcore %u has NUMA affinity set to SOCKET_ID_ANY\\n\",\n+\t\t\t\t\tlcore_id);\n \t}\n }\n \n", "prefixes": [ "v1", "1/1" ] }