Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/126657/?format=api
{ "id": 126657, "url": "https://patches.dpdk.org/api/patches/126657/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20230502095410.487696-1-sachin.saxena@oss.nxp.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230502095410.487696-1-sachin.saxena@oss.nxp.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20230502095410.487696-1-sachin.saxena@oss.nxp.com", "date": "2023-05-02T09:54:10", "name": "[v2,RFC] dpaa2: replace system(\"echo ...\") with file i/o", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "8ee3dde490cfebadd52403481e0a4e522d709808", "submitter": { "id": 1782, "url": "https://patches.dpdk.org/api/people/1782/?format=api", "name": "Sachin Saxena (OSS)", "email": "sachin.saxena@oss.nxp.com" }, "delegate": { "id": 1, "url": "https://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20230502095410.487696-1-sachin.saxena@oss.nxp.com/mbox/", "series": [ { "id": 27906, "url": "https://patches.dpdk.org/api/series/27906/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=27906", "date": "2023-05-02T09:54:10", "name": "[v2,RFC] dpaa2: replace system(\"echo ...\") with file i/o", "version": 2, "mbox": "https://patches.dpdk.org/series/27906/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/126657/comments/", "check": "warning", "checks": "https://patches.dpdk.org/api/patches/126657/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 6678642A3D;\n\tTue, 2 May 2023 11:54:34 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id EB59B40E2D;\n\tTue, 2 May 2023 11:54:33 +0200 (CEST)", "from EUR05-VI1-obe.outbound.protection.outlook.com\n (mail-vi1eur05on2086.outbound.protection.outlook.com [40.107.21.86])\n by mails.dpdk.org (Postfix) with ESMTP id B8958406A2\n for <dev@dpdk.org>; Tue, 2 May 2023 11:54:32 +0200 (CEST)", "from AS8PR04MB8562.eurprd04.prod.outlook.com (2603:10a6:20b:421::9)\n by VE1PR04MB7327.eurprd04.prod.outlook.com (2603:10a6:800:1ac::15)\n with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6340.30; Tue, 2 May\n 2023 09:54:29 +0000", "from AS8PR04MB8562.eurprd04.prod.outlook.com\n ([fe80::5787:8cca:9d7e:956c]) by AS8PR04MB8562.eurprd04.prod.outlook.com\n ([fe80::5787:8cca:9d7e:956c%5]) with mapi id 15.20.6340.029; Tue, 2 May 2023\n 09:54:29 +0000" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=NS4pwmwbkMVWf0oP14gY76UFHllXLw7XVciNMMhQib2/ZJZw6g72s9QOW0LX89xbdb/e1jb1hFCgTP7PQevd1gVUDMVHubCJi56XTcPmQ9/7GIRLTmer1ON0/q7CppWpRiw3rT53183b2ZzZYCflLN84lctm0Ek4BFmBydhv7njgiM2eBaOycno4jt1j6NfS6WxZxaEc6ffkb0xuNqY0K1lJl4LsjcTI5rm3uAEWcN1Wd17/cPxb7MXRJ5hJ9altlkT+kc1azjBHm1OkimM+dv8gA+tOVODYgX3c95JiEOhrSpo6mZ1Ki/6NPcc/8/HeyT5F3OiZ69QuggdcMckQgg==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=kR5nk+uzvG6R38EWpaUJ3zAtgpixvZ0sFVhQz4Mmab0=;\n b=GZSZWYbX4Zkc5uW6n2aUcAk6iWpsYnJhGIvwUj0GIOXCStxHP5UjzLSAMh5fNiOaNXLiOBVoGI6kXU9XcGhJURqJzSPxwyDYxqYui+qu1MzhppcS/SJKtbBxNfoe849SW7PWZMcyBFBi9DYnmSH+TDcbFngrylHD234d4AD2Kt7tfr51H9VOyHhG1+qPe7c0Wu0ls+je3hH1BZks8cAzMcBxk8aLQzL8RDjU95lS1LYLTdKwH5vhslcSq0QGZ7wbCvbE+1J20eepAejT1QhgDM/a1GU2aXKKPFhmD3DHFvHzuRa1pTHxEbA+CwdAMaOe0cChfRZIHgFjAAFdUDkVEA==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass\n smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com;\n dkim=pass header.d=oss.nxp.com; arc=none", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com;\n s=selector2-NXP1-onmicrosoft-com;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=kR5nk+uzvG6R38EWpaUJ3zAtgpixvZ0sFVhQz4Mmab0=;\n b=ghi2Ny1F1qvyGjrFlLhwCY3etJnQSZrC0buGvSJLUMD5IMKpFGbZw4MiiaYMEZJGsz3cB3432gOlhfqtqZbwswe1bjSgD0EkvaolRJQkdhYKYQQ90LFjZNUi//7FmnD2wYa+8CBzIoCDpGkivvngrvz/JNY1MrHomKiHVUDqMcw=", "Authentication-Results": "dkim=none (message not signed)\n header.d=none;dmarc=none action=none header.from=oss.nxp.com;", "From": "\"Sachin Saxena (OSS)\" <sachin.saxena@oss.nxp.com>", "To": "dev@dpdk.org,\n\tstephen@networkplumber.org", "Cc": "Sachin Saxena <sachin.saxena@oss.nxp.com>", "Subject": "[v2] [RFC] dpaa2: replace system(\"echo ...\") with file i/o", "Date": "Tue, 2 May 2023 15:24:10 +0530", "Message-Id": "<20230502095410.487696-1-sachin.saxena@oss.nxp.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20220602214957.150071-1-stephen@networkplumber.org>", "References": "<20220602214957.150071-1-stephen@networkplumber.org>", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-ClientProxiedBy": "SG2P153CA0014.APCP153.PROD.OUTLOOK.COM (2603:1096::24) To\n AS8PR04MB8562.eurprd04.prod.outlook.com (2603:10a6:20b:421::9)", "MIME-Version": "1.0", "X-MS-Exchange-MessageSentRepresentingType": "1", "X-MS-PublicTrafficType": "Email", "X-MS-TrafficTypeDiagnostic": "AS8PR04MB8562:EE_|VE1PR04MB7327:EE_", "X-MS-Office365-Filtering-Correlation-Id": "63d990fe-b7ad-42ef-d0de-08db4af33874", "X-MS-Exchange-SharedMailbox-RoutingAgent-Processed": "True", "X-MS-Exchange-SenderADCheck": "1", "X-MS-Exchange-AntiSpam-Relay": "0", "X-Microsoft-Antispam": "BCL:0;", "X-Microsoft-Antispam-Message-Info": "\n yALOn3fY2WJf4ad0CshUtfK17nEJ66pDRJ59gi6clECMIsoap/gwZiBBxjcDmiO7ylRN7DQInbr2WsmItUAb+2wot+vnNNFEGX8DUsuSAMtYuhJh3YdXkHSvz230ko3nXYUax1Nyv2yNiIvYm/DEzG8NtGoK4xqYmsIMxDkMCfmY6p73ZrE/l53yVLauGqAaO/F99h4uIcejTPmr06RXDjMzpkfQ7azoniqSPcuIUzFoDd5sn0bYRriHoWI5nfMhsp50r3x6xRx1m6gt5e1bCa0nLrT+1oDLkvHYNScV0jwLl2+TtCnlBe0QFFL3fpCVLcnDWGGyMmV5H2n6xr/oJwJo0XkGZXPA1ye3X+FFdDrh5qY0irUPMJY56haV3R4BfIMuUnoMYDw2niiEiRkANYGwiKB3e0wpX+q7sQb/1j0geuFsNbCYZ+aWCoUxPWVpVhRJdjnoF7P7D75iJNL7LUwO9VzwnvL1ViqpS2Kzk4yaT4nCzLXms4fgWKPD24bveE7WWP2/OWChGCU/w+FGS0/XBFUcAE0+8j4bbrVPYuZ+USApRk9pTErTnETg/ktpJY6XQvnWfowJzcRJXHnBacfqBXvpFEjnVBYMHXdvdsjM8p+hMs5hvkFG3d/f7KEk", "X-Forefront-Antispam-Report": "CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;\n IPV:NLI; SFV:NSPM; H:AS8PR04MB8562.eurprd04.prod.outlook.com; PTR:; CAT:NONE;\n SFS:(13230028)(4636009)(366004)(396003)(376002)(39860400002)(136003)(346002)(451199021)(2616005)(6666004)(52116002)(6486002)(6512007)(26005)(6506007)(1076003)(186003)(86362001)(5660300002)(83380400001)(8676002)(8936002)(38100700002)(2906002)(478600001)(38350700002)(66556008)(66476007)(66946007)(41300700001)(4326008)(316002);\n DIR:OUT; SFP:1101;", "X-MS-Exchange-AntiSpam-MessageData-ChunkCount": "1", "X-MS-Exchange-AntiSpam-MessageData-0": "\n zwVp3+O9+YD7nJ3RvT0buxEKAt6vYB+ZV16na7cG0zNbmEde66TL/rKR/l1eeJn8VcuSf/dfNArBZGKrB6u6qtZtYG8GhcVnJEgjGU6ktZ4jYzsftsTHJexR9aHZrIslNX/fM16uB3QhglDm5V6XglqB2mQCdy7pvfT2AsT2cQ3J3y8pKAQhrX1zie7SAqavMXJKi4QLJm/f+hxJD2gN5mg6imyyHAIf5ePzn8bz7cKxK3H4xwtPCVrBtONJBonYsIBCNWpQvPvfL6LV8ioS6j+7g0kQ4FMmwODRLK2Po7Wy48WGsjg7ECdB97U97lTuDPPKmFATbKx4dXiD7IqB68bPcS9ivz6D8pL/R1bZfTKWvO0PZlB+wyLnQcdu1THgKG3JYjyNu31JwW/7LwLP8tDAyXefn9BVIlhr7j55vQMfQPbipxWCvOpvmO7HrHmoN+0XNN9+ulwrmbDYb+hVV8rgVyGHRYCXMS647LMTZsm4xKfbMI2AD6Z7WL8QGMuSMsjJ3zOa/Fm6Kiat27ckb4pFrPqBFCJggPOv6IGUbkAXs0x7EjyERLUGXAegTA3pyu11rmMvAypD/cAheRKPJIIsk53iDSSzEc/86fAa0uiSkVP9/E/vYwEajanWPTEU3ofE5cEEk0whZSYDYLOzWGwC5uCORfYkAapkTNnccWCebftUwrOM7EoMbxifxvmpG31TrcXtbfgqhUegZGAfeGxRN7/1Bocfq7XPGmB6i5+ZBg1xlqCmgUHkR9i3aPmVR8bJ7hU+ZMT6OmKjYKU6gHDTZYXEEkkz4rwNAFhty9a5CvIY3+lyWtF8OgDO//oikmEARiODMTBwrCwZe32KD+pon/kCr6ijuGXxDRxcxeLZ0I193YYFfNBJnpvdUCccVlonkL6Pr00LWsiVMr3BGHl64hnU24sCdEMfq5Jveyq9HaoeuEWddJOqOnuETbL1F0tVVq66EWvzShmfDeHMr8Lc6uLzov4cLRI8E+w3Bv0uXK4ESYevI7ZT4uNN54D0yxQXM2t++xXwaIu90VwH/3DLGhoBFU+xHhnngpzkB2qPgHuMhIQYIfK2w5+6Q4isMmFieBdJ04hZonZNo8NkaxMVjMRdz433QapQ6FnJkr1o+yZ4NlVRzrugHQopcDiNmjCyluhPcvrdizvi+ahis17aFvXLP5UQgeI94DmDZcp7y3JzsDTtVlHoRjD+in8i9PxhNi5Ci+BUkBYOKBVMoDTs45BgKLh/KYtGlU/7oeebaH6NlIKNMrxnnX728OM2jsf8N1mJYhTuHnP+oKJwsMT3pV/CWHOL7mh+UC+Xc5cfKw86L1ZRFWEq/fl7V5WtqCROWQUKKiSBknFo0C+BqY4y61wMcGcA6EaZVMovdsBXG3YsG1xwflcQj5QjBxVEydza/7rdDVFua3LGgrmiAg4bzvdCF+2FWCrkzNj0uBVDNkFt7+hHv00rY4CCR9lvFPLKzLB0YvBSuUK8othbd98A/cVKoZ6rIyd/cy3i2tjiLQAnlFnHfUeqE7JF9e6UUUFuyUnVF89QV9TDO1BsC9ok2EGLkeG8zRjklEQFbofHEszI62xV29TbSs7OfQr9rdErM8dHz4PeoJuuqK4t1A==", "X-OriginatorOrg": "oss.nxp.com", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n 63d990fe-b7ad-42ef-d0de-08db4af33874", "X-MS-Exchange-CrossTenant-AuthSource": "AS8PR04MB8562.eurprd04.prod.outlook.com", "X-MS-Exchange-CrossTenant-AuthAs": "Internal", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "02 May 2023 09:54:29.2679 (UTC)", "X-MS-Exchange-CrossTenant-FromEntityHeader": "Hosted", "X-MS-Exchange-CrossTenant-Id": "686ea1d3-bc2b-4c6f-a92c-d99c5c301635", "X-MS-Exchange-CrossTenant-MailboxType": "HOSTED", "X-MS-Exchange-CrossTenant-UserPrincipalName": "\n f6ufWzHF44bczuhJzh1elkBSD2ziCf8j7V/EuKKZ+XcKPh71n3HYdvjT4gwLE8g2xV+tUR/iWFXST2GRpgqRng==", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "VE1PR04MB7327", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "From: Stephen Hemminger <stephen@networkplumber.org>\n\n Using system() is a bad idea in driver code because it introduces\n a number of potential security issues. The codeql analysis tool\n flags this a potential security issue.\n\n Instead just use normal stdio to do the same thing.\n\n Compile test only, do not have this hardware and therefore can\n not test this.\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\nReviewed-by: Sachin Saxena <sachin.saxena@oss.nxp.com>\n---\n drivers/bus/fslmc/portal/dpaa2_hw_dpio.c | 45 ++++++++++++++++--------\n 1 file changed, 31 insertions(+), 14 deletions(-)", "diff": "diff --git a/drivers/bus/fslmc/portal/dpaa2_hw_dpio.c b/drivers/bus/fslmc/portal/dpaa2_hw_dpio.c\nindex 4aec7b2cd8..990cfc5d3b 100644\n--- a/drivers/bus/fslmc/portal/dpaa2_hw_dpio.c\n+++ b/drivers/bus/fslmc/portal/dpaa2_hw_dpio.c\n@@ -125,14 +125,21 @@ static void\n dpaa2_affine_dpio_intr_to_respective_core(int32_t dpio_id, int cpu_id)\n {\n #define STRING_LEN\t28\n-#define COMMAND_LEN\t50\n+#define AFFINITY_LEN\t128\n+#define CMD_LEN\t300\n \tuint32_t cpu_mask = 1;\n-\tint ret;\n-\tsize_t len = 0;\n-\tchar *temp = NULL, *token = NULL;\n-\tchar string[STRING_LEN], command[COMMAND_LEN];\n+\tsize_t len = CMD_LEN;\n+\tchar *temp, *token = NULL;\n+\tchar string[STRING_LEN];\n+\tchar smp_affinity[AFFINITY_LEN];\n \tFILE *file;\n \n+\ttemp = (char *)malloc(len * sizeof(char));\n+\tif (temp == NULL) {\n+\t\tDPAA2_BUS_WARN(\"Unable to allocate temp buffer\");\n+\t\treturn;\n+\t}\n+\n \tsnprintf(string, STRING_LEN, \"dpio.%d\", dpio_id);\n \tfile = fopen(\"/proc/interrupts\", \"r\");\n \tif (!file) {\n@@ -155,17 +162,27 @@ dpaa2_affine_dpio_intr_to_respective_core(int32_t dpio_id, int cpu_id)\n \t}\n \n \tcpu_mask = cpu_mask << cpu_id;\n-\tsnprintf(command, COMMAND_LEN, \"echo %X > /proc/irq/%s/smp_affinity\",\n-\t\t cpu_mask, token);\n-\tret = system(command);\n-\tif (ret < 0)\n-\t\tDPAA2_BUS_DEBUG(\n-\t\t\t\"Failed to affine interrupts on respective core\");\n-\telse\n-\t\tDPAA2_BUS_DEBUG(\" %s command is executed\", command);\n-\n+\tsnprintf(smp_affinity, AFFINITY_LEN,\n+\t\t \"/proc/irq/%s/smp_affinity\", token);\n+\t/* Free 'temp' memory after using the substring 'token' */\n \tfree(temp);\n \tfclose(file);\n+\n+\tfile = fopen(smp_affinity, \"w\");\n+\tif (file == NULL) {\n+\t\tDPAA2_BUS_WARN(\"Failed to open %s\", smp_affinity);\n+\t\treturn;\n+\t}\n+\tfprintf(file, \"%X\\n\", cpu_mask);\n+\tfflush(file);\n+\n+\tif (ferror(file)) {\n+\t\tfclose(file);\n+\t\tDPAA2_BUS_WARN(\"Failed to write to %s\", smp_affinity);\n+\t\treturn;\n+\t}\n+\n+\tfclose(file);\n }\n \n static int dpaa2_dpio_intr_init(struct dpaa2_dpio_dev *dpio_dev)\n", "prefixes": [ "v2", "RFC" ] }