Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/126625/?format=api
{ "id": 126625, "url": "https://patches.dpdk.org/api/patches/126625/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20230428102728.51956-4-denis.pryazhennikov@arknetworks.am/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230428102728.51956-4-denis.pryazhennikov@arknetworks.am>", "list_archive_url": "https://inbox.dpdk.org/dev/20230428102728.51956-4-denis.pryazhennikov@arknetworks.am", "date": "2023-04-28T10:27:28", "name": "[RFC,3/3] ethdev: rename parameter in API to get FEC", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "282597fc7e852029a6000534d14507e7f71fdfa3", "submitter": { "id": 3057, "url": "https://patches.dpdk.org/api/people/3057/?format=api", "name": "Denis Pryazhennikov", "email": "denis.pryazhennikov@arknetworks.am" }, "delegate": { "id": 319, "url": "https://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20230428102728.51956-4-denis.pryazhennikov@arknetworks.am/mbox/", "series": [ { "id": 27899, "url": "https://patches.dpdk.org/api/series/27899/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=27899", "date": "2023-04-28T10:27:25", "name": "improve FEC API usage", "version": 1, "mbox": "https://patches.dpdk.org/series/27899/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/126625/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/126625/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 55FEA42A13;\n\tFri, 28 Apr 2023 12:27:51 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 26AD542F94;\n\tFri, 28 Apr 2023 12:27:37 +0200 (CEST)", "from agw.arknetworks.am (agw.arknetworks.am [79.141.165.80])\n by mails.dpdk.org (Postfix) with ESMTP id 9FEB542DAE\n for <dev@dpdk.org>; Fri, 28 Apr 2023 12:27:33 +0200 (CEST)", "from localhost.localdomain (unknown [37.252.90.108])\n (using TLSv1.3 with cipher TLS_CHACHA20_POLY1305_SHA256 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA512)\n (No client certificate requested)\n by agw.arknetworks.am (Postfix) with ESMTPSA id 6D7CEE1193;\n Fri, 28 Apr 2023 14:27:32 +0400 (+04)" ], "From": "Denis Pryazhennikov <denis.pryazhennikov@arknetworks.am>", "To": "dev@dpdk.org", "Cc": "Ivan Malov <ivan.malov@arknetworks.am>,\n Viacheslav Galaktionov <viacheslav.galaktionov@arknetworks.am>,\n Thomas Monjalon <thomas@monjalon.net>, Ferruh Yigit <ferruh.yigit@amd.com>,\n Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>", "Subject": "[RFC PATCH 3/3] ethdev: rename parameter in API to get FEC", "Date": "Fri, 28 Apr 2023 14:27:28 +0400", "Message-Id": "<20230428102728.51956-4-denis.pryazhennikov@arknetworks.am>", "X-Mailer": "git-send-email 2.37.0 (Apple Git-136)", "In-Reply-To": "<20230428102728.51956-1-denis.pryazhennikov@arknetworks.am>", "References": "<20230428102728.51956-1-denis.pryazhennikov@arknetworks.am>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Only one valid FEC mode can be get by rte_eth_fec_get().\nThe previous name implied that more than one FEC mode\ncan be obtained.\nDocumentation was updated accordingly.\n\nSigned-off-by: Denis Pryazhennikov <denis.pryazhennikov@arknetworks.am>\nAcked-by: Ivan Malov <ivan.malov@arknetworks.am>\nAcked-by: Viacheslav Galaktionov <viacheslav.galaktionov@arknetworks.am>\n---\n lib/ethdev/rte_ethdev.c | 8 ++++----\n lib/ethdev/rte_ethdev.h | 9 +++------\n 2 files changed, 7 insertions(+), 10 deletions(-)", "diff": "diff --git a/lib/ethdev/rte_ethdev.c b/lib/ethdev/rte_ethdev.c\nindex d02ee161cf6d..b046d4ea2f06 100644\n--- a/lib/ethdev/rte_ethdev.c\n+++ b/lib/ethdev/rte_ethdev.c\n@@ -4718,7 +4718,7 @@ rte_eth_fec_get_capability(uint16_t port_id,\n }\n \n int\n-rte_eth_fec_get(uint16_t port_id, uint32_t *fec_capa)\n+rte_eth_fec_get(uint16_t port_id, uint32_t *fec_mode)\n {\n \tstruct rte_eth_dev *dev;\n \tint ret;\n@@ -4726,7 +4726,7 @@ rte_eth_fec_get(uint16_t port_id, uint32_t *fec_capa)\n \tRTE_ETH_VALID_PORTID_OR_ERR_RET(port_id, -ENODEV);\n \tdev = &rte_eth_devices[port_id];\n \n-\tif (fec_capa == NULL) {\n+\tif (fec_mode == NULL) {\n \t\tRTE_ETHDEV_LOG(ERR,\n \t\t\t\"Cannot get ethdev port %u current FEC mode to NULL\\n\",\n \t\t\tport_id);\n@@ -4735,9 +4735,9 @@ rte_eth_fec_get(uint16_t port_id, uint32_t *fec_capa)\n \n \tif (*dev->dev_ops->fec_get == NULL)\n \t\treturn -ENOTSUP;\n-\tret = eth_err(port_id, (*dev->dev_ops->fec_get)(dev, fec_capa));\n+\tret = eth_err(port_id, (*dev->dev_ops->fec_get)(dev, fec_mode));\n \n-\trte_eth_trace_fec_get(port_id, fec_capa, ret);\n+\trte_eth_trace_fec_get(port_id, fec_mode, ret);\n \n \treturn ret;\n }\ndiff --git a/lib/ethdev/rte_ethdev.h b/lib/ethdev/rte_ethdev.h\nindex 0f10ac944061..aa71dbafc01f 100644\n--- a/lib/ethdev/rte_ethdev.h\n+++ b/lib/ethdev/rte_ethdev.h\n@@ -4203,11 +4203,8 @@ int rte_eth_fec_get_capability(uint16_t port_id,\n *\n * @param port_id\n * The port identifier of the Ethernet device.\n- * @param fec_capa\n- * A bitmask of enabled FEC modes. If AUTO bit is set, other\n- * bits specify FEC modes which may be negotiated. If AUTO\n- * bit is clear, specify FEC modes to be used (only one valid\n- * mode per speed may be set).\n+ * @param fec_mode\n+ * The current FEC mode.\n * @return\n * - (0) if successful.\n * - (-ENOTSUP) if underlying hardware OR driver doesn't support.\n@@ -4216,7 +4213,7 @@ int rte_eth_fec_get_capability(uint16_t port_id,\n * - (-ENODEV) if *port_id* invalid.\n */\n __rte_experimental\n-int rte_eth_fec_get(uint16_t port_id, uint32_t *fec_capa);\n+int rte_eth_fec_get(uint16_t port_id, uint32_t *fec_mode);\n \n /**\n * @warning\n", "prefixes": [ "RFC", "3/3" ] }