Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/126624/?format=api
{ "id": 126624, "url": "https://patches.dpdk.org/api/patches/126624/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20230428102728.51956-3-denis.pryazhennikov@arknetworks.am/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230428102728.51956-3-denis.pryazhennikov@arknetworks.am>", "list_archive_url": "https://inbox.dpdk.org/dev/20230428102728.51956-3-denis.pryazhennikov@arknetworks.am", "date": "2023-04-28T10:27:27", "name": "[RFC,2/3] ethdev: check that at least one FEC mode is specified", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "b4b7b9d340df002528588abc5494b932ef3d4941", "submitter": { "id": 3057, "url": "https://patches.dpdk.org/api/people/3057/?format=api", "name": "Denis Pryazhennikov", "email": "denis.pryazhennikov@arknetworks.am" }, "delegate": { "id": 319, "url": "https://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20230428102728.51956-3-denis.pryazhennikov@arknetworks.am/mbox/", "series": [ { "id": 27899, "url": "https://patches.dpdk.org/api/series/27899/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=27899", "date": "2023-04-28T10:27:25", "name": "improve FEC API usage", "version": 1, "mbox": "https://patches.dpdk.org/series/27899/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/126624/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/126624/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 96FF642A13;\n\tFri, 28 Apr 2023 12:27:43 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 8E68942DBF;\n\tFri, 28 Apr 2023 12:27:35 +0200 (CEST)", "from agw.arknetworks.am (agw.arknetworks.am [79.141.165.80])\n by mails.dpdk.org (Postfix) with ESMTP id 571DC42DAA\n for <dev@dpdk.org>; Fri, 28 Apr 2023 12:27:32 +0200 (CEST)", "from localhost.localdomain (unknown [37.252.90.108])\n (using TLSv1.3 with cipher TLS_CHACHA20_POLY1305_SHA256 (256/256 bits)\n key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest\n SHA512)\n (No client certificate requested)\n by agw.arknetworks.am (Postfix) with ESMTPSA id A2809E10B5;\n Fri, 28 Apr 2023 14:27:31 +0400 (+04)" ], "From": "Denis Pryazhennikov <denis.pryazhennikov@arknetworks.am>", "To": "dev@dpdk.org", "Cc": "Ivan Malov <ivan.malov@arknetworks.am>,\n Viacheslav Galaktionov <viacheslav.galaktionov@arknetworks.am>,\n Thomas Monjalon <thomas@monjalon.net>, Ferruh Yigit <ferruh.yigit@amd.com>,\n Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>", "Subject": "[RFC PATCH 2/3] ethdev: check that at least one FEC mode is specified", "Date": "Fri, 28 Apr 2023 14:27:27 +0400", "Message-Id": "<20230428102728.51956-3-denis.pryazhennikov@arknetworks.am>", "X-Mailer": "git-send-email 2.37.0 (Apple Git-136)", "In-Reply-To": "<20230428102728.51956-1-denis.pryazhennikov@arknetworks.am>", "References": "<20230428102728.51956-1-denis.pryazhennikov@arknetworks.am>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "The behaviour is undefined in the rte_eth_fec_set() function\nwhen the fec_capa parameter is equal to zero.\nAdd a check to handle this case.\n\nSigned-off-by: Denis Pryazhennikov <denis.pryazhennikov@arknetworks.am>\nAcked-by: Ivan Malov <ivan.malov@arknetworks.am>\nAcked-by: Viacheslav Galaktionov <viacheslav.galaktionov@arknetworks.am>\n---\n lib/ethdev/rte_ethdev.c | 5 +++++\n 1 file changed, 5 insertions(+)", "diff": "diff --git a/lib/ethdev/rte_ethdev.c b/lib/ethdev/rte_ethdev.c\nindex 4d0325568322..d02ee161cf6d 100644\n--- a/lib/ethdev/rte_ethdev.c\n+++ b/lib/ethdev/rte_ethdev.c\n@@ -4751,6 +4751,11 @@ rte_eth_fec_set(uint16_t port_id, uint32_t fec_capa)\n \tRTE_ETH_VALID_PORTID_OR_ERR_RET(port_id, -ENODEV);\n \tdev = &rte_eth_devices[port_id];\n \n+\tif (fec_capa == 0) {\n+\t\tRTE_ETHDEV_LOG(ERR, \"At least one FEC mode should be specified\\n\");\n+\t\treturn -EINVAL;\n+\t}\n+\n \tif (*dev->dev_ops->fec_set == NULL)\n \t\treturn -ENOTSUP;\n \tret = eth_err(port_id, (*dev->dev_ops->fec_set)(dev, fec_capa));\n", "prefixes": [ "RFC", "2/3" ] }