Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/126584/?format=api
{ "id": 126584, "url": "https://patches.dpdk.org/api/patches/126584/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20230427062001.478032-18-qiming.yang@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230427062001.478032-18-qiming.yang@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20230427062001.478032-18-qiming.yang@intel.com", "date": "2023-04-27T06:19:48", "name": "[17/30] net/ice/base: add C825X device support", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "48a4aab18ebe4d720156ce6a22ad6db7963850e7", "submitter": { "id": 522, "url": "https://patches.dpdk.org/api/people/522/?format=api", "name": "Qiming Yang", "email": "qiming.yang@intel.com" }, "delegate": { "id": 1540, "url": "https://patches.dpdk.org/api/users/1540/?format=api", "username": "qzhan15", "first_name": "Qi", "last_name": "Zhang", "email": "qi.z.zhang@intel.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20230427062001.478032-18-qiming.yang@intel.com/mbox/", "series": [ { "id": 27885, "url": "https://patches.dpdk.org/api/series/27885/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=27885", "date": "2023-04-27T06:19:31", "name": "net/ice/base: share code update", "version": 1, "mbox": "https://patches.dpdk.org/series/27885/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/126584/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/126584/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id DAFAB42A08;\n\tThu, 27 Apr 2023 08:39:53 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 4DF7042FA4;\n\tThu, 27 Apr 2023 08:38:19 +0200 (CEST)", "from mga01.intel.com (mga01.intel.com [192.55.52.88])\n by mails.dpdk.org (Postfix) with ESMTP id 5D05B42F8A\n for <dev@dpdk.org>; Thu, 27 Apr 2023 08:38:16 +0200 (CEST)", "from fmsmga002.fm.intel.com ([10.253.24.26])\n by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 26 Apr 2023 23:38:16 -0700", "from dpdk-qiming3.sh.intel.com ([10.67.111.4])\n by fmsmga002.fm.intel.com with ESMTP; 26 Apr 2023 23:38:13 -0700" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1682577496; x=1714113496;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=YsYMWydXYhkbrSfvrDMxrdtCK1lN1/a/OW0Pi/2Taog=;\n b=XF5d3qTIQLVnqFZvqGbOhHQFmzpfaUr8jdZ9EfdqJXneRU1eYlI9ZGVl\n QeBXOQXhN4LyvRnzKTZ8bdSVBY4UpRoSVg+2KEFRgEh7YMA676F4Ts2/Y\n 6mrv1TSkM2cIw0T0MGsYoKw0EL9ZjAJuD8A+s/IsAwBS803R9VwiCkrYV\n yYvNScruRU7VrgmPcFn5y80RZnZw3m6W5dZ1AbJ+N1IzGZE2Rvf5Dx9oF\n r+wyBMJxqq5+rU+oJQTW8L3CWd6V4m2IGE0SjIQQjQlY+DP6rkYGoSj6y\n ZLchC6Wt8+/f6Nj72Txs+hpcb6MW7mU2yeRsFadjHW5roZ9ZmDJfrspaA g==;", "X-IronPort-AV": [ "E=McAfee;i=\"6600,9927,10692\"; a=\"375324349\"", "E=Sophos;i=\"5.99,230,1677571200\"; d=\"scan'208\";a=\"375324349\"", "E=McAfee;i=\"6600,9927,10692\"; a=\"805845828\"", "E=Sophos;i=\"5.99,230,1677571200\"; d=\"scan'208\";a=\"805845828\"" ], "X-ExtLoop1": "1", "From": "Qiming Yang <qiming.yang@intel.com>", "To": "dev@dpdk.org", "Cc": "qi.z.zhang@intel.com, Qiming Yang <qiming.yang@intel.com>,\n Grzegorz Nitka <grzegorz.nitka@intel.com>", "Subject": "[PATCH 17/30] net/ice/base: add C825X device support", "Date": "Thu, 27 Apr 2023 06:19:48 +0000", "Message-Id": "<20230427062001.478032-18-qiming.yang@intel.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20230427062001.478032-1-qiming.yang@intel.com>", "References": "<20230427062001.478032-1-qiming.yang@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Use ICE_MAC_GENERIC_3K type for C825X devices and fix E825X\nname to C825X.\n\nSigned-off-by: Grzegorz Nitka <grzegorz.nitka@intel.com>\nSigned-off-by: Qiming Yang <qiming.yang@intel.com>\n---\n drivers/net/ice/base/ice_common.c | 13 +++++++++----\n drivers/net/ice/base/ice_ddp.c | 8 +++++++-\n drivers/net/ice/base/ice_ddp.h | 1 +\n drivers/net/ice/base/ice_devids.h | 11 ++++-------\n drivers/net/ice/base/ice_type.h | 1 +\n drivers/net/ice/ice_ethdev.c | 3 +--\n 6 files changed, 23 insertions(+), 14 deletions(-)", "diff": "diff --git a/drivers/net/ice/base/ice_common.c b/drivers/net/ice/base/ice_common.c\nindex ed822afc30..e4b25321db 100644\n--- a/drivers/net/ice/base/ice_common.c\n+++ b/drivers/net/ice/base/ice_common.c\n@@ -241,13 +241,17 @@ static enum ice_status ice_set_mac_type(struct ice_hw *hw)\n \tcase ICE_DEV_ID_E823C_QSFP:\n \tcase ICE_DEV_ID_E823C_SFP:\n \tcase ICE_DEV_ID_E823C_SGMII:\n+\t\thw->mac_type = ICE_MAC_GENERIC;\n+\t\tbreak;\n \tcase ICE_DEV_ID_E824S:\n+\t\thw->mac_type = ICE_MAC_GENERIC_3K;\n+\t\tbreak;\n \tcase ICE_DEV_ID_E825C_BACKPLANE:\n \tcase ICE_DEV_ID_E825C_QSFP:\n \tcase ICE_DEV_ID_E825C_SFP:\n-\tcase ICE_DEV_ID_E825C_1GBE:\n-\tcase ICE_DEV_ID_E825X:\n-\t\thw->mac_type = ICE_MAC_GENERIC;\n+\tcase ICE_DEV_ID_C825X:\n+\tcase ICE_DEV_ID_E825C_SGMII:\n+\t\thw->mac_type = ICE_MAC_GENERIC_3K_E825;\n \t\tbreak;\n \tcase ICE_DEV_ID_E830_BACKPLANE:\n \tcase ICE_DEV_ID_E830_QSFP56:\n@@ -273,7 +277,8 @@ static enum ice_status ice_set_mac_type(struct ice_hw *hw)\n bool ice_is_generic_mac(struct ice_hw *hw)\n {\n \treturn (hw->mac_type == ICE_MAC_GENERIC ||\n-\t\thw->mac_type == ICE_MAC_GENERIC_3K);\n+\t\thw->mac_type == ICE_MAC_GENERIC_3K ||\n+\t\thw->mac_type == ICE_MAC_GENERIC_3K_E825);\n }\n \n /**\ndiff --git a/drivers/net/ice/base/ice_ddp.c b/drivers/net/ice/base/ice_ddp.c\nindex e3c1f413dd..e43aab981d 100644\n--- a/drivers/net/ice/base/ice_ddp.c\n+++ b/drivers/net/ice/base/ice_ddp.c\n@@ -444,6 +444,7 @@ static u32 ice_get_pkg_segment_id(enum ice_mac_type mac_type)\n \t\tbreak;\n \tcase ICE_MAC_GENERIC:\n \tcase ICE_MAC_GENERIC_3K:\n+\tcase ICE_MAC_GENERIC_3K_E825:\n \tdefault:\n \t\tseg_id = SEGMENT_TYPE_ICE_E810;\n \t\tbreak;\n@@ -467,6 +468,9 @@ static u32 ice_get_pkg_sign_type(enum ice_mac_type mac_type)\n \tcase ICE_MAC_GENERIC_3K:\n \t\tsign_type = SEGMENT_SIGN_TYPE_RSA3K;\n \t\tbreak;\n+\tcase ICE_MAC_GENERIC_3K_E825:\n+\t\tsign_type = SEGMENT_SIGN_TYPE_RSA3K_E825;\n+\t\tbreak;\n \tcase ICE_MAC_GENERIC:\n \tdefault:\n \t\tsign_type = SEGMENT_SIGN_TYPE_RSA2K;\n@@ -1632,8 +1636,10 @@ ice_get_sw_fv_list(struct ice_hw *hw, struct ice_prot_lkup_ext *lkups,\n \t\t\t}\n \t\t}\n \t} while (fv);\n-\tif (LIST_EMPTY(fv_list))\n+\tif (LIST_EMPTY(fv_list)) {\n+\t\tice_warn(hw, \"Required profiles not found in currently loaded DDP package\");\n \t\treturn ICE_ERR_CFG;\n+\t}\n \treturn ICE_SUCCESS;\n \n err:\ndiff --git a/drivers/net/ice/base/ice_ddp.h b/drivers/net/ice/base/ice_ddp.h\nindex 57b39c72ca..6c87f11972 100644\n--- a/drivers/net/ice/base/ice_ddp.h\n+++ b/drivers/net/ice/base/ice_ddp.h\n@@ -99,6 +99,7 @@ struct ice_pkg_hdr {\n #define SEGMENT_SIGN_TYPE_RSA2K\t\t0x00000001\n #define SEGMENT_SIGN_TYPE_RSA3K\t\t0x00000002\n #define SEGMENT_SIGN_TYPE_RSA3K_SBB\t0x00000003 /* Secure Boot Block */\n+#define SEGMENT_SIGN_TYPE_RSA3K_E825\t0x00000005\n \n /* generic segment */\n struct ice_generic_seg_hdr {\ndiff --git a/drivers/net/ice/base/ice_devids.h b/drivers/net/ice/base/ice_devids.h\nindex 9ea915b967..0e0a20542b 100644\n--- a/drivers/net/ice/base/ice_devids.h\n+++ b/drivers/net/ice/base/ice_devids.h\n@@ -76,13 +76,10 @@\n /* Intel(R) Ethernet Connection E825-C for backplane */\n #define ICE_DEV_ID_E825C_BACKPLANE\t0x579C\n /* Intel(R) Ethernet Connection E825-C for QSFP */\n-#define ICE_DEV_ID_E825C_QSFP\t 0x579D\n+#define ICE_DEV_ID_E825C_QSFP\t\t0x579D\n /* Intel(R) Ethernet Connection E825-C for SFP */\n-#define ICE_DEV_ID_E825C_SFP\t 0x579E\n+#define ICE_DEV_ID_E825C_SFP\t\t0x579E\n /* Intel(R) Ethernet Connection E825-C 1GbE */\n-#define ICE_DEV_ID_E825C_1GBE\t 0x579F\n-/* Intel(R) Ethernet Connection E825-X */\n-#define ICE_DEV_ID_E825X\t 0x0DCD\n-\n-\n+#define ICE_DEV_ID_E825C_SGMII\t\t0x579F\n+#define ICE_DEV_ID_C825X\t\t0x0DCD\n #endif /* _ICE_DEVIDS_H_ */\ndiff --git a/drivers/net/ice/base/ice_type.h b/drivers/net/ice/base/ice_type.h\nindex d072b0bfe2..9651720470 100644\n--- a/drivers/net/ice/base/ice_type.h\n+++ b/drivers/net/ice/base/ice_type.h\n@@ -225,6 +225,7 @@ enum ice_mac_type {\n \tICE_MAC_E830,\n \tICE_MAC_GENERIC,\n \tICE_MAC_GENERIC_3K,\n+\tICE_MAC_GENERIC_3K_E825,\n };\n \n /* Media Types */\ndiff --git a/drivers/net/ice/ice_ethdev.c b/drivers/net/ice/ice_ethdev.c\nindex a5bf8317a7..2a4073c4d1 100644\n--- a/drivers/net/ice/ice_ethdev.c\n+++ b/drivers/net/ice/ice_ethdev.c\n@@ -196,8 +196,7 @@ static const struct rte_pci_id pci_id_ice_map[] = {\n \t{ RTE_PCI_DEVICE(ICE_INTEL_VENDOR_ID, ICE_DEV_ID_E825C_BACKPLANE) },\n \t{ RTE_PCI_DEVICE(ICE_INTEL_VENDOR_ID, ICE_DEV_ID_E825C_QSFP) },\n \t{ RTE_PCI_DEVICE(ICE_INTEL_VENDOR_ID, ICE_DEV_ID_E825C_SFP) },\n-\t{ RTE_PCI_DEVICE(ICE_INTEL_VENDOR_ID, ICE_DEV_ID_E825C_1GBE) },\n-\t{ RTE_PCI_DEVICE(ICE_INTEL_VENDOR_ID, ICE_DEV_ID_E825X) },\n+\t{ RTE_PCI_DEVICE(ICE_INTEL_VENDOR_ID, ICE_DEV_ID_C825X) },\n \t{ .vendor_id = 0, /* sentinel */ },\n };\n \n", "prefixes": [ "17/30" ] }