Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/126225/?format=api
{ "id": 126225, "url": "https://patches.dpdk.org/api/patches/126225/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20230418084613.52740-1-shaw.leon@gmail.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230418084613.52740-1-shaw.leon@gmail.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20230418084613.52740-1-shaw.leon@gmail.com", "date": "2023-04-18T08:46:13", "name": "ipsec: fix NAT-T length calculation", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "dbe8f73f7ae7a0c10d014ce21ad5d1cca309edcd", "submitter": { "id": 3046, "url": "https://patches.dpdk.org/api/people/3046/?format=api", "name": "Xiao Liang", "email": "shaw.leon@gmail.com" }, "delegate": { "id": 6690, "url": "https://patches.dpdk.org/api/users/6690/?format=api", "username": "akhil", "first_name": "akhil", "last_name": "goyal", "email": "gakhil@marvell.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20230418084613.52740-1-shaw.leon@gmail.com/mbox/", "series": [ { "id": 27754, "url": "https://patches.dpdk.org/api/series/27754/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=27754", "date": "2023-04-18T08:46:13", "name": "ipsec: fix NAT-T length calculation", "version": 1, "mbox": "https://patches.dpdk.org/series/27754/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/126225/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/126225/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id AAF0D4297B;\n\tTue, 18 Apr 2023 10:46:51 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 80FDD40EDF;\n\tTue, 18 Apr 2023 10:46:51 +0200 (CEST)", "from mail-pl1-f172.google.com (mail-pl1-f172.google.com\n [209.85.214.172])\n by mails.dpdk.org (Postfix) with ESMTP id 36DF940698\n for <dev@dpdk.org>; Tue, 18 Apr 2023 10:46:50 +0200 (CEST)", "by mail-pl1-f172.google.com with SMTP id lh8so14779465plb.1\n for <dev@dpdk.org>; Tue, 18 Apr 2023 01:46:50 -0700 (PDT)", "from nova-ws.. ([103.167.140.11]) by smtp.gmail.com with ESMTPSA id\n x2-20020a056a00270200b0062db34242aesm8857587pfv.167.2023.04.18.01.46.47\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Tue, 18 Apr 2023 01:46:49 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20221208; t=1681807609; x=1684399609;\n h=content-transfer-encoding:mime-version:message-id:date:subject:cc\n :to:from:from:to:cc:subject:date:message-id:reply-to;\n bh=9XkdXT56q8HGhvGHMyR9UN71Fem9TudcWF3jvNCz+QM=;\n b=Vk5SDUYW4D+x5RR4ed1412stVmff54/Hlxhi5McNiY+u7dghOCljn1uGK/MzIe53+j\n 8cHxjZ3mnSGs15EVqGt7ULgdF4wQNIJNv5MS9+gYnlZQm8APH9IkXMqHlO3f+0Z8/dUp\n VhgX71ZKAq4tgz1WJv+bIEAYO+MMM/14/DBqIM/mIBxwOMcvR/VAzE3XEDDyoSjrffEU\n U0P5wMQS6doVx6bjjrJ5TDrV4UK5T4rSpNYiDBgvo7d9VT3/3QtpknZJet7VqV8n+/LK\n SMB/3SrgZUm3I8CVcvQPy2LLU4NmiQp64Txle0mgfCvJEsHznq7fNEtozK7LQ2VW7XI2\n hJDQ==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20221208; t=1681807609; x=1684399609;\n h=content-transfer-encoding:mime-version:message-id:date:subject:cc\n :to:from:x-gm-message-state:from:to:cc:subject:date:message-id\n :reply-to;\n bh=9XkdXT56q8HGhvGHMyR9UN71Fem9TudcWF3jvNCz+QM=;\n b=k4EVVf9SpSbvVE2jU/7VUJuIdhuW1E1i5rf/rZEc0UBsgcOI9G6LqIBib8uLnZrSnC\n So4OMgRCZx9GURiCwCPaXwVzSMVqSY9tocbNPxLYw04Jarc1fpfZBKANMREeNN+bJ0uv\n neXJ5x7veGFR5PdgnBG1ozGjx4KHUfnqGs+6ejtgrSenvVSEA5+0Q4bHSFC5Sku/Dhh8\n fH6s8ONNmx7Y2ke9PJXto65CbnMmdCCU01vR2TRhRw+NuqljihcXy+hpH5LRRIPHUoh/\n 4A+gZWRhbgKxBFi4+Issw8g/jBhdkXwW9iinzuora4ZC1mqtNXZJ+AsRMD36YKrkp0Ft\n P94g==", "X-Gm-Message-State": "AAQBX9cX/AnDb2PQAmAR/UlXuhzhx+BcLuedH8v9aZnU5xHzTkWcfID/\n PMDLGx+dzBY2LN7b62KzP4k=", "X-Google-Smtp-Source": "\n AKy350bf4S5KdDfMLmGb4/h15Bw1vF65EEIe9iDPo4ocmjJ2AQ/VEKh2ZVauy9h9JsoS+LtqXw9p/Q==", "X-Received": "by 2002:a05:6a20:c701:b0:f0:942e:873b with SMTP id\n hi1-20020a056a20c70100b000f0942e873bmr1886916pzb.7.1681807609403;\n Tue, 18 Apr 2023 01:46:49 -0700 (PDT)", "From": "Xiao Liang <shaw.leon@gmail.com>", "To": "Konstantin Ananyev <konstantin.v.ananyev@yandex.ru>,\n Vladimir Medvedkin <vladimir.medvedkin@intel.com>", "Cc": "Xiao Liang <shaw.leon@gmail.com>,\n\tdev@dpdk.org", "Subject": "[PATCH] ipsec: fix NAT-T length calculation", "Date": "Tue, 18 Apr 2023 16:46:13 +0800", "Message-Id": "<20230418084613.52740-1-shaw.leon@gmail.com>", "X-Mailer": "git-send-email 2.40.0", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "UDP header length is included in sa->hdr_len. Take care of that in\nL3 header and pakcet length calculation.\n\nFixes: 01eef5907fc3 (\"ipsec: support NAT-T\")\n\nSigned-off-by: Xiao Liang <shaw.leon@gmail.com>\n---\n lib/ipsec/esp_outb.c | 2 +-\n lib/ipsec/sa.c | 2 +-\n 2 files changed, 2 insertions(+), 2 deletions(-)", "diff": "diff --git a/lib/ipsec/esp_outb.c b/lib/ipsec/esp_outb.c\nindex 9cbd9202f6..ec87b1dce2 100644\n--- a/lib/ipsec/esp_outb.c\n+++ b/lib/ipsec/esp_outb.c\n@@ -198,7 +198,7 @@ outb_tun_pkt_prepare(struct rte_ipsec_sa *sa, rte_be64_t sqc,\n \t\tstruct rte_udp_hdr *udph = (struct rte_udp_hdr *)\n \t\t\t(ph + sa->hdr_len - sizeof(struct rte_udp_hdr));\n \t\tudph->dgram_len = rte_cpu_to_be_16(mb->pkt_len - sqh_len -\n-\t\t\t\tsa->hdr_l3_off - sa->hdr_len);\n+\t\t\t\tsa->hdr_len + sizeof(struct rte_udp_hdr));\n \t}\n \n \t/* update original and new ip header fields */\ndiff --git a/lib/ipsec/sa.c b/lib/ipsec/sa.c\nindex 59a547637d..2297bd6d72 100644\n--- a/lib/ipsec/sa.c\n+++ b/lib/ipsec/sa.c\n@@ -371,7 +371,7 @@ esp_outb_tun_init(struct rte_ipsec_sa *sa, const struct rte_ipsec_sa_prm *prm)\n \n \t/* update l2_len and l3_len fields for outbound mbuf */\n \tsa->tx_offload.val = rte_mbuf_tx_offload(sa->hdr_l3_off,\n-\t\tsa->hdr_len - sa->hdr_l3_off, 0, 0, 0, 0, 0);\n+\t\tprm->tun.hdr_len - sa->hdr_l3_off, 0, 0, 0, 0, 0);\n \n \tesp_outb_init(sa, sa->hdr_len, prm->ipsec_xform.esn.value);\n }\n", "prefixes": [] }