Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/126140/?format=api
{ "id": 126140, "url": "https://patches.dpdk.org/api/patches/126140/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/3bec4e84b0dc406887e9df08ddfd91ad@huawei.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<3bec4e84b0dc406887e9df08ddfd91ad@huawei.com>", "list_archive_url": "https://inbox.dpdk.org/dev/3bec4e84b0dc406887e9df08ddfd91ad@huawei.com", "date": "2023-04-15T14:45:39", "name": "[GRO] check whether ip_id continuity needs to be checked when two TCP packets are merged.", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "fbfa440abc44918fa9dd5ed056be91fda07dcb3c", "submitter": { "id": 2863, "url": "https://patches.dpdk.org/api/people/2863/?format=api", "name": "jiangheng (G)", "email": "jiangheng14@huawei.com" }, "delegate": { "id": 1, "url": "https://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/3bec4e84b0dc406887e9df08ddfd91ad@huawei.com/mbox/", "series": [ { "id": 27726, "url": "https://patches.dpdk.org/api/series/27726/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=27726", "date": "2023-04-15T14:45:39", "name": "[GRO] check whether ip_id continuity needs to be checked when two TCP packets are merged.", "version": 1, "mbox": "https://patches.dpdk.org/series/27726/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/126140/comments/", "check": "warning", "checks": "https://patches.dpdk.org/api/patches/126140/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 6EBBD42950;\n\tSat, 15 Apr 2023 16:45:47 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 00A01410F1;\n\tSat, 15 Apr 2023 16:45:47 +0200 (CEST)", "from szxga08-in.huawei.com (szxga08-in.huawei.com [45.249.212.255])\n by mails.dpdk.org (Postfix) with ESMTP id A0D5240A7A;\n Sat, 15 Apr 2023 16:45:45 +0200 (CEST)", "from kwepemm600002.china.huawei.com (unknown [172.30.72.54])\n by szxga08-in.huawei.com (SkyGuard) with ESMTP id 4PzGHG2BT4z17KLQ;\n Sat, 15 Apr 2023 22:42:02 +0800 (CST)", "from dggpeml500020.china.huawei.com (7.185.36.88) by\n kwepemm600002.china.huawei.com (7.193.23.29) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id\n 15.1.2507.23; Sat, 15 Apr 2023 22:45:40 +0800", "from dggpeml500020.china.huawei.com ([7.185.36.88]) by\n dggpeml500020.china.huawei.com ([7.185.36.88]) with mapi id 15.01.2507.023;\n Sat, 15 Apr 2023 22:45:40 +0800" ], "From": "\"jiangheng (G)\" <jiangheng14@huawei.com>", "To": "\"users@dpdk.org\" <users@dpdk.org>, \"jiayu.hu@intel.com\"\n <jiayu.hu@intel.com>, \"dev@dpdk.org\" <dev@dpdk.org>", "Subject": "[GRO] check whether ip_id continuity needs to be checked when two TCP\n packets are merged.", "Thread-Topic": "[GRO] check whether ip_id continuity needs to be checked when\n two TCP packets are merged.", "Thread-Index": "AdlvqIcRh1F/iP8VTjaqZ0Fg9f9SKQ==", "Date": "Sat, 15 Apr 2023 14:45:39 +0000", "Message-ID": "<3bec4e84b0dc406887e9df08ddfd91ad@huawei.com>", "Accept-Language": "zh-CN, en-US", "Content-Language": "zh-CN", "X-MS-Has-Attach": "", "X-MS-TNEF-Correlator": "", "x-originating-ip": "[10.136.117.195]", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "quoted-printable", "MIME-Version": "1.0", "X-CFilter-Loop": "Reflected", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Hi jiayu.hu\n\nIt cannot be guaranteed that 16bit identification field of ip packets in the same tcp stream will be continuous.\nPlease help check whether ip_id continuity needs to be checked when two TCP packets are merged?\nSeems to modify the following code, gro will aggregate better, and work better:", "diff": "diff --git a/lib/gro/gro_tcp4.h b/lib/gro/gro_tcp4.h\nindex 212f97a042..06faead7b5 100644\n--- a/lib/gro/gro_tcp4.h\n+++ b/lib/gro/gro_tcp4.h\n@@ -291,12 +291,10 @@ check_seq_option(struct gro_tcp4_item *item,\n /* check if the two packets are neighbors */\n len = pkt_orig->pkt_len - l2_offset - pkt_orig->l2_len -\n pkt_orig->l3_len - tcp_hl_orig;\n- if ((sent_seq == item->sent_seq + len) && (is_atomic ||\n- (ip_id == item->ip_id + 1)))\n+ if (sent_seq == item->sent_seq + len)\n /* append the new packet */\n return 1;\n- else if ((sent_seq + tcp_dl == item->sent_seq) && (is_atomic ||\n- (ip_id + item->nb_merged == item->ip_id)))\n+ else if (sent_seq + tcp_dl == item->sent_seq)\n /* pre-pend the new packet */\n return -1;\n\n", "prefixes": [ "GRO" ] }