Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/126118/?format=api
{ "id": 126118, "url": "https://patches.dpdk.org/api/patches/126118/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20230414174512.642-19-anoobj@marvell.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230414174512.642-19-anoobj@marvell.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20230414174512.642-19-anoobj@marvell.com", "date": "2023-04-14T17:45:08", "name": "[v2,18/22] test/pdcp: add timer restart case", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "29c261cc36f6aab5c4bd1ff6eb0364f5e1be00c3", "submitter": { "id": 1205, "url": "https://patches.dpdk.org/api/people/1205/?format=api", "name": "Anoob Joseph", "email": "anoobj@marvell.com" }, "delegate": { "id": 6690, "url": "https://patches.dpdk.org/api/users/6690/?format=api", "username": "akhil", "first_name": "akhil", "last_name": "goyal", "email": "gakhil@marvell.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20230414174512.642-19-anoobj@marvell.com/mbox/", "series": [ { "id": 27723, "url": "https://patches.dpdk.org/api/series/27723/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=27723", "date": "2023-04-14T17:44:50", "name": "lib: add pdcp protocol", "version": 2, "mbox": "https://patches.dpdk.org/series/27723/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/126118/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/126118/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id E87B142943;\n\tFri, 14 Apr 2023 19:47:59 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id AC6D942D48;\n\tFri, 14 Apr 2023 19:47:53 +0200 (CEST)", "from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com\n [67.231.156.173])\n by mails.dpdk.org (Postfix) with ESMTP id D099F42D43\n for <dev@dpdk.org>; Fri, 14 Apr 2023 19:47:52 +0200 (CEST)", "from pps.filterd (m0045851.ppops.net [127.0.0.1])\n by mx0b-0016f401.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id\n 33EGNfcJ012935; Fri, 14 Apr 2023 10:47:51 -0700", "from dc5-exch02.marvell.com ([199.233.59.182])\n by mx0b-0016f401.pphosted.com (PPS) with ESMTPS id 3py646s6vh-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT);\n Fri, 14 Apr 2023 10:47:51 -0700", "from DC5-EXCH01.marvell.com (10.69.176.38) by DC5-EXCH02.marvell.com\n (10.69.176.39) with Microsoft SMTP Server (TLS) id 15.0.1497.48;\n Fri, 14 Apr 2023 10:47:49 -0700", "from maili.marvell.com (10.69.176.80) by DC5-EXCH01.marvell.com\n (10.69.176.38) with Microsoft SMTP Server id 15.0.1497.48 via Frontend\n Transport; Fri, 14 Apr 2023 10:47:49 -0700", "from BG-LT92004.corp.innovium.com (unknown [10.28.161.183])\n by maili.marvell.com (Postfix) with ESMTP id 72BE43F707F;\n Fri, 14 Apr 2023 10:47:43 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com;\n h=from : to : cc :\n subject : date : message-id : in-reply-to : references : mime-version :\n content-transfer-encoding : content-type; s=pfpt0220;\n bh=phZCDUZCFSui8XKp0E2yByPqaOlyeLr2kz2UB8HC6U4=;\n b=EGwISUofFKz3/lKemHz/VOTUaPmANIY31X/iBBXvKXVzH2ognWvrF2zXrg36VOUs0Mfx\n 14IhwKQLo44oLsK1FbL2BcJmABU1yZSxi695yPkhoeLIEzQ22zJJRA9mDze5gKd+it9s\n RR+KcORuycHGfWJjXY0sp7FW+xQXK0fbyjJnvH6VWE4hLQZI5qmZCh/wvACN/XogD6EO\n SL3nkKuV13Ds7jtqwQz5Pl5kBUoeXa0rm4USojnnyU1g1t6kOtsGGXZj0UQftGhUSQlK\n G1beqsMQRWb4OcvKdOZsceh3Nvz/Ih3RGGmCzgHCQDfftuEEOAavTMPXTb9Wt+EkvnJh kQ==", "From": "Anoob Joseph <anoobj@marvell.com>", "To": "Thomas Monjalon <thomas@monjalon.net>, Akhil Goyal <gakhil@marvell.com>,\n Jerin Jacob <jerinj@marvell.com>, Konstantin Ananyev\n <konstantin.v.ananyev@yandex.ru>, Bernard Iremonger\n <bernard.iremonger@intel.com>", "CC": "Volodymyr Fialko <vfialko@marvell.com>,\n Hemant Agrawal <hemant.agrawal@nxp.com>,\n =?utf-8?q?Mattias_R=C3=B6nnblom?= <mattias.ronnblom@ericsson.com>,\n Kiran Kumar K <kirankumark@marvell.com>, <dev@dpdk.org>,\n Olivier Matz <olivier.matz@6wind.com>", "Subject": "[PATCH v2 18/22] test/pdcp: add timer restart case", "Date": "Fri, 14 Apr 2023 23:15:08 +0530", "Message-ID": "<20230414174512.642-19-anoobj@marvell.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20230414174512.642-1-anoobj@marvell.com>", "References": "<20221222092522.1628-1-anoobj@marvell.com>\n <20230414174512.642-1-anoobj@marvell.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Proofpoint-GUID": "diBaiJtOwkIa7O0jMViwKXZdkSyObM6s", "X-Proofpoint-ORIG-GUID": "diBaiJtOwkIa7O0jMViwKXZdkSyObM6s", "X-Proofpoint-Virus-Version": "vendor=baseguard\n engine=ICAP:2.0.254,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22\n definitions=2023-04-14_10,2023-04-14_01,2023-02-09_01", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "From: Volodymyr Fialko <vfialko@marvell.com>\n\nAdd test to cover the case when t-reordering timer should be restarted on\nthe same packet.\n\nSigned-off-by: Anoob Joseph <anoobj@marvell.com>\nSigned-off-by: Volodymyr Fialko <vfialko@marvell.com>\n---\n app/test/test_pdcp.c | 67 ++++++++++++++++++++++++++++++++++++++++++++\n 1 file changed, 67 insertions(+)", "diff": "diff --git a/app/test/test_pdcp.c b/app/test/test_pdcp.c\nindex a0e982777d..de3375bb22 100644\n--- a/app/test/test_pdcp.c\n+++ b/app/test/test_pdcp.c\n@@ -1072,6 +1072,70 @@ test_reorder_gap_fill(struct pdcp_test_conf *ul_conf)\n \treturn ret;\n }\n \n+static int\n+test_reorder_gap_in_reorder_buffer(const struct pdcp_test_conf *ul_conf)\n+{\n+\tstruct rte_mbuf *m = NULL, *out_mb[2] = {0};\n+\tuint16_t nb_success = 0, nb_err = 0;\n+\tstruct rte_pdcp_entity *pdcp_entity;\n+\tint ret = TEST_FAILED, nb_out, i;\n+\tstruct pdcp_test_conf dl_conf;\n+\tuint8_t cdev_id;\n+\n+\tconst int start_count = 0;\n+\n+\tif (ul_conf->entity.pdcp_xfrm.pkt_dir == RTE_SECURITY_PDCP_DOWNLINK)\n+\t\treturn TEST_SKIPPED;\n+\n+\t/* Create configuration for actual testing */\n+\tuplink_to_downlink_convert(ul_conf, &dl_conf);\n+\tdl_conf.entity.count = start_count;\n+\tpdcp_entity = test_entity_create(&dl_conf, &ret);\n+\tif (pdcp_entity == NULL)\n+\t\treturn ret;\n+\n+\tconst uint32_t sn_size = dl_conf.entity.pdcp_xfrm.sn_size;\n+\tcdev_id = dl_conf.entity.dev_id;\n+\n+\t/* Create two gaps [NULL, m1, NULL, m3]*/\n+\tfor (i = 0; i < 2; i++) {\n+\t\tm = generate_packet_for_dl_with_sn(*ul_conf, start_count + 2 * i + 1);\n+\t\tASSERT_TRUE_OR_GOTO(m != NULL, exit, \"Could not allocate buffer for packet\\n\");\n+\t\tnb_success = test_process_packets(pdcp_entity, cdev_id, &m, 1, out_mb, &nb_err);\n+\t\tASSERT_TRUE_OR_GOTO(nb_err == 0, exit, \"Error occurred during packet process\\n\");\n+\t\tASSERT_TRUE_OR_GOTO(nb_success == 0, exit, \"Packet was not buffered as expected\\n\");\n+\t\tm = NULL; /* Packet was moved to PDCP lib */\n+\t}\n+\n+\t/* Generate packet to fill the first gap */\n+\tm = generate_packet_for_dl_with_sn(*ul_conf, start_count);\n+\tASSERT_TRUE_OR_GOTO(m != NULL, exit, \"Could not allocate buffer for packet\\n\");\n+\n+\t/*\n+\t * Buffered packets after insert [m0, m1, NULL, m3]\n+\t * Only first gap should be filled, timer should be restarted for second gap\n+\t */\n+\tnb_success = test_process_packets(pdcp_entity, cdev_id, &m, 1, out_mb, &nb_err);\n+\tASSERT_TRUE_OR_GOTO(nb_err == 0, exit, \"Error occurred during packet process\\n\");\n+\tASSERT_TRUE_OR_GOTO(nb_success == 2, exit,\n+\t\t\t\"Packet count mismatch (received: %i, expected: 2)\\n\", nb_success);\n+\tm = NULL;\n+\t/* Check that packets in correct order */\n+\tASSERT_TRUE_OR_GOTO(array_asc_sorted_check(out_mb, nb_success, sn_size),\n+\t\t\texit, \"Error occurred during packet drain\\n\");\n+\tASSERT_TRUE_OR_GOTO(testsuite_params.timer_is_running == true, exit,\n+\t\t\t\"Timer should be restarted after partial drain\");\n+\n+\n+\tret = TEST_SUCCESS;\n+exit:\n+\trte_pktmbuf_free(m);\n+\trte_pktmbuf_free_bulk(out_mb, nb_success);\n+\tnb_out = rte_pdcp_entity_release(pdcp_entity, out_mb);\n+\trte_pktmbuf_free_bulk(out_mb, nb_out);\n+\treturn ret;\n+}\n+\n static int\n test_reorder_buffer_full_window_size_sn_12(const struct pdcp_test_conf *ul_conf)\n {\n@@ -1472,6 +1536,9 @@ static struct unit_test_suite reorder_test_cases = {\n \t\tTEST_CASE_NAMED_WITH_DATA(\"test_reorder_gap_fill\",\n \t\t\tut_setup_pdcp, ut_teardown_pdcp,\n \t\t\trun_test_with_all_known_vec, test_reorder_gap_fill),\n+\t\tTEST_CASE_NAMED_WITH_DATA(\"test_reorder_gap_in_reorder_buffer\",\n+\t\t\tut_setup_pdcp, ut_teardown_pdcp,\n+\t\t\trun_test_with_all_known_vec, test_reorder_gap_in_reorder_buffer),\n \t\tTEST_CASE_NAMED_WITH_DATA(\"test_reorder_buffer_full_window_size_sn_12\",\n \t\t\tut_setup_pdcp, ut_teardown_pdcp,\n \t\t\trun_test_with_all_known_vec_until_first_pass,\n", "prefixes": [ "v2", "18/22" ] }