Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1260/?format=api
{ "id": 1260, "url": "https://patches.dpdk.org/api/patches/1260/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1415773476-31004-6-git-send-email-cunming.liang@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1415773476-31004-6-git-send-email-cunming.liang@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1415773476-31004-6-git-send-email-cunming.liang@intel.com", "date": "2014-11-12T06:24:34", "name": "[dpdk-dev,v7,5/7] examples: cleanup eth_addr print", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "e32c92b5460c64ec41c20efb6e3f77544c658644", "submitter": { "id": 46, "url": "https://patches.dpdk.org/api/people/46/?format=api", "name": "Cunming Liang", "email": "cunming.liang@intel.com" }, "delegate": null, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1415773476-31004-6-git-send-email-cunming.liang@intel.com/mbox/", "series": [], "comments": "https://patches.dpdk.org/api/patches/1260/comments/", "check": "pending", "checks": "https://patches.dpdk.org/api/patches/1260/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id AED677F74;\n\tWed, 12 Nov 2014 07:15:48 +0100 (CET)", "from mga02.intel.com (mga02.intel.com [134.134.136.20])\n\tby dpdk.org (Postfix) with ESMTP id 161707F6D\n\tfor <dev@dpdk.org>; Wed, 12 Nov 2014 07:15:23 +0100 (CET)", "from orsmga001.jf.intel.com ([10.7.209.18])\n\tby orsmga101.jf.intel.com with ESMTP; 11 Nov 2014 22:25:10 -0800", "from shvmail01.sh.intel.com ([10.239.29.42])\n\tby orsmga001.jf.intel.com with ESMTP; 11 Nov 2014 22:25:09 -0800", "from shecgisg004.sh.intel.com (shecgisg004.sh.intel.com\n\t[10.239.29.89])\n\tby shvmail01.sh.intel.com with ESMTP id sAC6P6GA020477;\n\tWed, 12 Nov 2014 14:25:06 +0800", "from shecgisg004.sh.intel.com (localhost [127.0.0.1])\n\tby shecgisg004.sh.intel.com (8.13.6/8.13.6/SuSE Linux 0.8) with ESMTP\n\tid sAC6P4cn031219; Wed, 12 Nov 2014 14:25:06 +0800", "(from cliang18@localhost)\n\tby shecgisg004.sh.intel.com (8.13.6/8.13.6/Submit) id sAC6P4oI031215; \n\tWed, 12 Nov 2014 14:25:04 +0800" ], "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.07,367,1413270000\"; d=\"scan'208\";a=\"606393436\"", "From": "Cunming Liang <cunming.liang@intel.com>", "To": "dev@dpdk.org", "Date": "Wed, 12 Nov 2014 14:24:34 +0800", "Message-Id": "<1415773476-31004-6-git-send-email-cunming.liang@intel.com>", "X-Mailer": "git-send-email 1.7.4.1", "In-Reply-To": "<1415773476-31004-1-git-send-email-cunming.liang@intel.com>", "References": "<1414372809-14044-1-git-send-email-cunming.liang@intel.com>\n\t<1415773476-31004-1-git-send-email-cunming.liang@intel.com>", "Subject": "[dpdk-dev] [PATCH v7 5/7] examples: cleanup eth_addr print", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Signed-off-by: Cunming Liang <cunming.liang@intel.com>\n---\n examples/dpdk_qat/main.c | 10 +++-------\n examples/ip_fragmentation/main.c | 10 +++-------\n examples/ip_reassembly/main.c | 10 +++-------\n examples/ipv4_multicast/main.c | 10 +++-------\n examples/l3fwd-acl/main.c | 10 +++-------\n examples/l3fwd-power/main.c | 10 +++-------\n examples/l3fwd-vf/main.c | 10 +++-------\n examples/l3fwd/main.c | 10 +++-------\n 8 files changed, 24 insertions(+), 56 deletions(-)", "diff": "diff --git a/examples/dpdk_qat/main.c b/examples/dpdk_qat/main.c\nindex 59a97bc..127ee40 100644\n--- a/examples/dpdk_qat/main.c\n+++ b/examples/dpdk_qat/main.c\n@@ -592,13 +592,9 @@ parse_args(int argc, char **argv)\n static void\n print_ethaddr(const char *name, const struct ether_addr *eth_addr)\n {\n-\tprintf (\"%s%02X:%02X:%02X:%02X:%02X:%02X\", name,\n-\t\teth_addr->addr_bytes[0],\n-\t\teth_addr->addr_bytes[1],\n-\t\teth_addr->addr_bytes[2],\n-\t\teth_addr->addr_bytes[3],\n-\t\teth_addr->addr_bytes[4],\n-\t\teth_addr->addr_bytes[5]);\n+\tchar buf[ETHER_ADDR_FMT_SIZE];\n+\tether_format_addr(buf, ETHER_ADDR_FMT_SIZE, eth_addr);\n+\tprintf(\"%s%s\", name, buf);\n }\n \n static int\ndiff --git a/examples/ip_fragmentation/main.c b/examples/ip_fragmentation/main.c\nindex 65c4cf6..0ad8fca 100644\n--- a/examples/ip_fragmentation/main.c\n+++ b/examples/ip_fragmentation/main.c\n@@ -600,13 +600,9 @@ parse_args(int argc, char **argv)\n static void\n print_ethaddr(const char *name, struct ether_addr *eth_addr)\n {\n-\tprintf(\"%s%02X:%02X:%02X:%02X:%02X:%02X\", name,\n-\t eth_addr->addr_bytes[0],\n-\t eth_addr->addr_bytes[1],\n-\t eth_addr->addr_bytes[2],\n-\t eth_addr->addr_bytes[3],\n-\t eth_addr->addr_bytes[4],\n-\t eth_addr->addr_bytes[5]);\n+\tchar buf[ETHER_ADDR_FMT_SIZE];\n+\tether_format_addr(buf, ETHER_ADDR_FMT_SIZE, eth_addr);\n+\tprintf(\"%s%s\", name, buf);\n }\n \n /* Check the link status of all ports in up to 9s, and print them finally */\ndiff --git a/examples/ip_reassembly/main.c b/examples/ip_reassembly/main.c\nindex 0d92b3c..39d60ec 100644\n--- a/examples/ip_reassembly/main.c\n+++ b/examples/ip_reassembly/main.c\n@@ -729,13 +729,9 @@ parse_args(int argc, char **argv)\n static void\n print_ethaddr(const char *name, const struct ether_addr *eth_addr)\n {\n-\tprintf (\"%s%02X:%02X:%02X:%02X:%02X:%02X\", name,\n-\t\teth_addr->addr_bytes[0],\n-\t\teth_addr->addr_bytes[1],\n-\t\teth_addr->addr_bytes[2],\n-\t\teth_addr->addr_bytes[3],\n-\t\teth_addr->addr_bytes[4],\n-\t\teth_addr->addr_bytes[5]);\n+\tchar buf[ETHER_ADDR_FMT_SIZE];\n+\tether_format_addr(buf, ETHER_ADDR_FMT_SIZE, eth_addr);\n+\tprintf(\"%s%s\", name, buf);\n }\n \n /* Check the link status of all ports in up to 9s, and print them finally */\ndiff --git a/examples/ipv4_multicast/main.c b/examples/ipv4_multicast/main.c\nindex de5e6be..590d11a 100644\n--- a/examples/ipv4_multicast/main.c\n+++ b/examples/ipv4_multicast/main.c\n@@ -586,13 +586,9 @@ parse_args(int argc, char **argv)\n static void\n print_ethaddr(const char *name, struct ether_addr *eth_addr)\n {\n-\tprintf(\"%s%02X:%02X:%02X:%02X:%02X:%02X\", name,\n-\t eth_addr->addr_bytes[0],\n-\t eth_addr->addr_bytes[1],\n-\t eth_addr->addr_bytes[2],\n-\t eth_addr->addr_bytes[3],\n-\t eth_addr->addr_bytes[4],\n-\t eth_addr->addr_bytes[5]);\n+\tchar buf[ETHER_ADDR_FMT_SIZE];\n+\tether_format_addr(buf, ETHER_ADDR_FMT_SIZE, eth_addr);\n+\tprintf(\"%s%s\", name, buf);\n }\n \n static int\ndiff --git a/examples/l3fwd-acl/main.c b/examples/l3fwd-acl/main.c\nindex e31a7d7..f12e5bb 100644\n--- a/examples/l3fwd-acl/main.c\n+++ b/examples/l3fwd-acl/main.c\n@@ -1820,13 +1820,9 @@ parse_args(int argc, char **argv)\n static void\n print_ethaddr(const char *name, const struct ether_addr *eth_addr)\n {\n-\tprintf(\"%s%02X:%02X:%02X:%02X:%02X:%02X\", name,\n-\t\teth_addr->addr_bytes[0],\n-\t\teth_addr->addr_bytes[1],\n-\t\teth_addr->addr_bytes[2],\n-\t\teth_addr->addr_bytes[3],\n-\t\teth_addr->addr_bytes[4],\n-\t\teth_addr->addr_bytes[5]);\n+\tchar buf[ETHER_ADDR_FMT_SIZE];\n+\tether_format_addr(buf, ETHER_ADDR_FMT_SIZE, eth_addr);\n+\tprintf(\"%s%s\", name, buf);\n }\n \n static int\ndiff --git a/examples/l3fwd-power/main.c b/examples/l3fwd-power/main.c\nindex 12e4fd6..76a512b 100644\n--- a/examples/l3fwd-power/main.c\n+++ b/examples/l3fwd-power/main.c\n@@ -1240,13 +1240,9 @@ parse_args(int argc, char **argv)\n static void\n print_ethaddr(const char *name, const struct ether_addr *eth_addr)\n {\n-\tprintf (\"%s%02X:%02X:%02X:%02X:%02X:%02X\", name,\n-\t\teth_addr->addr_bytes[0],\n-\t\teth_addr->addr_bytes[1],\n-\t\teth_addr->addr_bytes[2],\n-\t\teth_addr->addr_bytes[3],\n-\t\teth_addr->addr_bytes[4],\n-\t\teth_addr->addr_bytes[5]);\n+\tchar buf[ETHER_ADDR_FMT_SIZE];\n+\tether_format_addr(buf, ETHER_ADDR_FMT_SIZE, eth_addr);\n+\tprintf(\"%s%s\", name, buf);\n }\n \n #if (APP_LOOKUP_METHOD == APP_LOOKUP_EXACT_MATCH)\ndiff --git a/examples/l3fwd-vf/main.c b/examples/l3fwd-vf/main.c\nindex 0288d99..b560b7d 100644\n--- a/examples/l3fwd-vf/main.c\n+++ b/examples/l3fwd-vf/main.c\n@@ -826,13 +826,9 @@ parse_args(int argc, char **argv)\n static void\n print_ethaddr(const char *name, const struct ether_addr *eth_addr)\n {\n-\tprintf (\"%s%02X:%02X:%02X:%02X:%02X:%02X\", name,\n-\t\teth_addr->addr_bytes[0],\n-\t\teth_addr->addr_bytes[1],\n-\t\teth_addr->addr_bytes[2],\n-\t\teth_addr->addr_bytes[3],\n-\t\teth_addr->addr_bytes[4],\n-\t\teth_addr->addr_bytes[5]);\n+\tchar buf[ETHER_ADDR_FMT_SIZE];\n+\tether_format_addr(buf, ETHER_ADDR_FMT_SIZE, eth_addr);\n+\tprintf(\"%s%s\", name, buf);\n }\n \n #if (APP_LOOKUP_METHOD == APP_LOOKUP_EXACT_MATCH)\ndiff --git a/examples/l3fwd/main.c b/examples/l3fwd/main.c\nindex 181d682..46ac68e 100644\n--- a/examples/l3fwd/main.c\n+++ b/examples/l3fwd/main.c\n@@ -1976,13 +1976,9 @@ parse_args(int argc, char **argv)\n static void\n print_ethaddr(const char *name, const struct ether_addr *eth_addr)\n {\n-\tprintf (\"%s%02X:%02X:%02X:%02X:%02X:%02X\", name,\n-\t\teth_addr->addr_bytes[0],\n-\t\teth_addr->addr_bytes[1],\n-\t\teth_addr->addr_bytes[2],\n-\t\teth_addr->addr_bytes[3],\n-\t\teth_addr->addr_bytes[4],\n-\t\teth_addr->addr_bytes[5]);\n+\tchar buf[ETHER_ADDR_FMT_SIZE];\n+\tether_format_addr(buf, ETHER_ADDR_FMT_SIZE, eth_addr);\n+\tprintf(\"%s%s\", name, buf);\n }\n \n #if (APP_LOOKUP_METHOD == APP_LOOKUP_EXACT_MATCH)\n", "prefixes": [ "dpdk-dev", "v7", "5/7" ] }