Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/125987/?format=api
{ "id": 125987, "url": "https://patches.dpdk.org/api/patches/125987/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20230413061650.796940-8-junfeng.guo@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230413061650.796940-8-junfeng.guo@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20230413061650.796940-8-junfeng.guo@intel.com", "date": "2023-04-13T06:16:47", "name": "[07/10] net/gve: support basic stats for DQO", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "bae9a509ccb57fb52bf7ef350eefe96d248c2ea2", "submitter": { "id": 1785, "url": "https://patches.dpdk.org/api/people/1785/?format=api", "name": "Junfeng Guo", "email": "junfeng.guo@intel.com" }, "delegate": { "id": 319, "url": "https://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20230413061650.796940-8-junfeng.guo@intel.com/mbox/", "series": [ { "id": 27687, "url": "https://patches.dpdk.org/api/series/27687/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=27687", "date": "2023-04-13T06:16:40", "name": "gve PMD enhancement", "version": 1, "mbox": "https://patches.dpdk.org/series/27687/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/125987/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/125987/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id A93684292F;\n\tThu, 13 Apr 2023 08:17:55 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 2EFD142D31;\n\tThu, 13 Apr 2023 08:17:32 +0200 (CEST)", "from mga11.intel.com (mga11.intel.com [192.55.52.93])\n by mails.dpdk.org (Postfix) with ESMTP id AB4E442D31\n for <dev@dpdk.org>; Thu, 13 Apr 2023 08:17:30 +0200 (CEST)", "from fmsmga007.fm.intel.com ([10.253.24.52])\n by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 12 Apr 2023 23:17:30 -0700", "from dpdk-jf-ntb-one.sh.intel.com ([10.67.111.104])\n by fmsmga007.fm.intel.com with ESMTP; 12 Apr 2023 23:17:27 -0700" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1681366650; x=1712902650;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=eATX7Vyrl0jFsLsEHqazHHkFPgveqgXRPsGFYiBgccY=;\n b=FDiOPSYFmjF+ORdu4sADcEEBPPREJ6iceoRHGGe9+buU1Iq4eXPjUnbL\n iK66tTFvO0vi5jFyyHEy97dJzpn5mG3SgES0xbeDiOwbEWJpVWiVYqcQI\n aIcyQG49grQaePy1JJyl+M3QHIDgkBLg8HeHBfUkZ2rxefigSGnjt1uNL\n V7po8juzaQ9NBReda4NDP28PFwdeG1kxwrGoI83+gXK1r+DOLAF/2Qqa8\n UeBAEbwPXKZhFGMdlcokvS+bhLfhqqXVrKAm5cCGrwR1WuzfDyNByWohJ\n Ja+K0fj7EhGk49qf9JQwnJN38+7UlE5Gu6E90RIAaIMQ7KrLUC5AuOSvU w==;", "X-IronPort-AV": [ "E=McAfee;i=\"6600,9927,10678\"; a=\"341595383\"", "E=Sophos;i=\"5.98,339,1673942400\"; d=\"scan'208\";a=\"341595383\"", "E=McAfee;i=\"6600,9927,10678\"; a=\"691824300\"", "E=Sophos;i=\"5.98,339,1673942400\"; d=\"scan'208\";a=\"691824300\"" ], "X-ExtLoop1": "1", "From": "Junfeng Guo <junfeng.guo@intel.com>", "To": "qi.z.zhang@intel.com, jingjing.wu@intel.com, ferruh.yigit@amd.com,\n beilei.xing@intel.com", "Cc": "dev@dpdk.org, Junfeng Guo <junfeng.guo@intel.com>,\n Rushil Gupta <rushilg@google.com>, Joshua Washington <joshwash@google.com>,\n Jeroen de Borst <jeroendb@google.com>", "Subject": "[PATCH 07/10] net/gve: support basic stats for DQO", "Date": "Thu, 13 Apr 2023 14:16:47 +0800", "Message-Id": "<20230413061650.796940-8-junfeng.guo@intel.com>", "X-Mailer": "git-send-email 2.34.1", "In-Reply-To": "<20230413061650.796940-1-junfeng.guo@intel.com>", "References": "<20230413061650.796940-1-junfeng.guo@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Add basic stats support for DQO.\n\nSigned-off-by: Junfeng Guo <junfeng.guo@intel.com>\nSigned-off-by: Rushil Gupta <rushilg@google.com>\nSigned-off-by: Joshua Washington <joshwash@google.com>\nSigned-off-by: Jeroen de Borst <jeroendb@google.com>\n---\n drivers/net/gve/gve_ethdev.c | 5 ++++-\n drivers/net/gve/gve_rx_dqo.c | 14 +++++++++++++-\n drivers/net/gve/gve_tx_dqo.c | 7 +++++++\n 3 files changed, 24 insertions(+), 2 deletions(-)", "diff": "diff --git a/drivers/net/gve/gve_ethdev.c b/drivers/net/gve/gve_ethdev.c\nindex a532b8a93a..8b6861a24f 100644\n--- a/drivers/net/gve/gve_ethdev.c\n+++ b/drivers/net/gve/gve_ethdev.c\n@@ -150,14 +150,17 @@ gve_refill_dqo(struct gve_rx_queue *rxq)\n \n \tdiag = rte_pktmbuf_alloc_bulk(rxq->mpool, &rxq->sw_ring[0], rxq->nb_rx_desc);\n \tif (diag < 0) {\n+\t\trxq->stats.no_mbufs_bulk++;\n \t\tfor (i = 0; i < rxq->nb_rx_desc - 1; i++) {\n \t\t\tnmb = rte_pktmbuf_alloc(rxq->mpool);\n \t\t\tif (!nmb)\n \t\t\t\tbreak;\n \t\t\trxq->sw_ring[i] = nmb;\n \t\t}\n-\t\tif (i < rxq->nb_rx_desc - 1)\n+\t\tif (i < rxq->nb_rx_desc - 1) {\n+\t\t\trxq->stats.no_mbufs += rxq->nb_rx_desc - 1 - i;\n \t\t\treturn -ENOMEM;\n+\t\t}\n \t}\n \n \tfor (i = 0; i < rxq->nb_rx_desc; i++) {\ndiff --git a/drivers/net/gve/gve_rx_dqo.c b/drivers/net/gve/gve_rx_dqo.c\nindex d0eaea9c24..1d6b21359c 100644\n--- a/drivers/net/gve/gve_rx_dqo.c\n+++ b/drivers/net/gve/gve_rx_dqo.c\n@@ -39,6 +39,8 @@ gve_rx_refill_dqo(struct gve_rx_queue *rxq)\n \t\t\tnext_avail = 0;\n \t\t\trxq->nb_rx_hold -= delta;\n \t\t} else {\n+\t\t\trxq->stats.no_mbufs_bulk++;\n+\t\t\trxq->stats.no_mbufs += nb_desc - next_avail;\n \t\t\tdev = &rte_eth_devices[rxq->port_id];\n \t\t\tdev->data->rx_mbuf_alloc_failed += nb_desc - next_avail;\n \t\t\tPMD_DRV_LOG(DEBUG, \"RX mbuf alloc failed port_id=%u queue_id=%u\",\n@@ -59,6 +61,8 @@ gve_rx_refill_dqo(struct gve_rx_queue *rxq)\n \t\t\tnext_avail += nb_refill;\n \t\t\trxq->nb_rx_hold -= nb_refill;\n \t\t} else {\n+\t\t\trxq->stats.no_mbufs_bulk++;\n+\t\t\trxq->stats.no_mbufs += nb_desc - next_avail;\n \t\t\tdev = &rte_eth_devices[rxq->port_id];\n \t\t\tdev->data->rx_mbuf_alloc_failed += nb_desc - next_avail;\n \t\t\tPMD_DRV_LOG(DEBUG, \"RX mbuf alloc failed port_id=%u queue_id=%u\",\n@@ -82,7 +86,9 @@ gve_rx_burst_dqo(void *rx_queue, struct rte_mbuf **rx_pkts, uint16_t nb_pkts)\n \tuint16_t pkt_len;\n \tuint16_t rx_id;\n \tuint16_t nb_rx;\n+\tuint64_t bytes;\n \n+\tbytes = 0;\n \tnb_rx = 0;\n \trxq = rx_queue;\n \trx_id = rxq->rx_tail;\n@@ -96,8 +102,10 @@ gve_rx_burst_dqo(void *rx_queue, struct rte_mbuf **rx_pkts, uint16_t nb_pkts)\n \t\tif (rx_desc->generation != rxq->cur_gen_bit)\n \t\t\tbreak;\n \n-\t\tif (unlikely(rx_desc->rx_error))\n+\t\tif (unlikely(rx_desc->rx_error)) {\n+\t\t\trxq->stats.errors++;\n \t\t\tcontinue;\n+\t\t}\n \n \t\tpkt_len = rx_desc->packet_len;\n \n@@ -122,6 +130,7 @@ gve_rx_burst_dqo(void *rx_queue, struct rte_mbuf **rx_pkts, uint16_t nb_pkts)\n \t\trxm->hash.rss = rte_be_to_cpu_32(rx_desc->hash);\n \n \t\trx_pkts[nb_rx++] = rxm;\n+\t\tbytes += pkt_len;\n \t}\n \n \tif (nb_rx > 0) {\n@@ -130,6 +139,9 @@ gve_rx_burst_dqo(void *rx_queue, struct rte_mbuf **rx_pkts, uint16_t nb_pkts)\n \t\t\trxq->next_avail = rx_id_bufq;\n \n \t\tgve_rx_refill_dqo(rxq);\n+\n+\t\trxq->stats.packets += nb_rx;\n+\t\trxq->stats.bytes += bytes;\n \t}\n \n \treturn nb_rx;\ndiff --git a/drivers/net/gve/gve_tx_dqo.c b/drivers/net/gve/gve_tx_dqo.c\nindex 2ea38a8f8e..578a409616 100644\n--- a/drivers/net/gve/gve_tx_dqo.c\n+++ b/drivers/net/gve/gve_tx_dqo.c\n@@ -81,10 +81,12 @@ gve_tx_burst_dqo(void *tx_queue, struct rte_mbuf **tx_pkts, uint16_t nb_pkts)\n \tuint16_t nb_used;\n \tuint16_t tx_id;\n \tuint16_t sw_id;\n+\tuint64_t bytes;\n \n \tsw_ring = txq->sw_ring;\n \ttxr = txq->tx_ring;\n \n+\tbytes = 0;\n \tmask = txq->nb_tx_desc - 1;\n \tsw_mask = txq->sw_size - 1;\n \ttx_id = txq->tx_tail;\n@@ -119,6 +121,7 @@ gve_tx_burst_dqo(void *tx_queue, struct rte_mbuf **tx_pkts, uint16_t nb_pkts)\n \t\t\ttx_id = (tx_id + 1) & mask;\n \t\t\tsw_id = (sw_id + 1) & sw_mask;\n \n+\t\t\tbytes += tx_pkt->pkt_len;\n \t\t\ttx_pkt = tx_pkt->next;\n \t\t} while (tx_pkt);\n \n@@ -142,6 +145,10 @@ gve_tx_burst_dqo(void *tx_queue, struct rte_mbuf **tx_pkts, uint16_t nb_pkts)\n \t\trte_write32(tx_id, txq->qtx_tail);\n \t\ttxq->tx_tail = tx_id;\n \t\ttxq->sw_tail = sw_id;\n+\n+\t\ttxq->stats.packets += nb_tx;\n+\t\ttxq->stats.bytes += bytes;\n+\t\ttxq->stats.errors += nb_pkts - nb_tx;\n \t}\n \n \treturn nb_tx;\n", "prefixes": [ "07/10" ] }