Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1259/?format=api
{ "id": 1259, "url": "https://patches.dpdk.org/api/patches/1259/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1415773476-31004-8-git-send-email-cunming.liang@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1415773476-31004-8-git-send-email-cunming.liang@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1415773476-31004-8-git-send-email-cunming.liang@intel.com", "date": "2014-11-12T06:24:36", "name": "[dpdk-dev,v7,7/7] ethdev: fix wrong error return refere to API definition", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "d9a16bd5c349249be3676a4de6d8723b3ce1e0e0", "submitter": { "id": 46, "url": "https://patches.dpdk.org/api/people/46/?format=api", "name": "Cunming Liang", "email": "cunming.liang@intel.com" }, "delegate": null, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1415773476-31004-8-git-send-email-cunming.liang@intel.com/mbox/", "series": [], "comments": "https://patches.dpdk.org/api/patches/1259/comments/", "check": "pending", "checks": "https://patches.dpdk.org/api/patches/1259/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 0330E7F79;\n\tWed, 12 Nov 2014 07:15:31 +0100 (CET)", "from mga03.intel.com (mga03.intel.com [134.134.136.65])\n\tby dpdk.org (Postfix) with ESMTP id B15A97FA4\n\tfor <dev@dpdk.org>; Wed, 12 Nov 2014 07:15:24 +0100 (CET)", "from orsmga001.jf.intel.com ([10.7.209.18])\n\tby orsmga103.jf.intel.com with ESMTP; 11 Nov 2014 22:22:54 -0800", "from shvmail01.sh.intel.com ([10.239.29.42])\n\tby orsmga001.jf.intel.com with ESMTP; 11 Nov 2014 22:25:15 -0800", "from shecgisg004.sh.intel.com (shecgisg004.sh.intel.com\n\t[10.239.29.89])\n\tby shvmail01.sh.intel.com with ESMTP id sAC6PDH8020486;\n\tWed, 12 Nov 2014 14:25:13 +0800", "from shecgisg004.sh.intel.com (localhost [127.0.0.1])\n\tby shecgisg004.sh.intel.com (8.13.6/8.13.6/SuSE Linux 0.8) with ESMTP\n\tid sAC6PBeW031233; Wed, 12 Nov 2014 14:25:13 +0800", "(from cliang18@localhost)\n\tby shecgisg004.sh.intel.com (8.13.6/8.13.6/Submit) id sAC6PBE4031229; \n\tWed, 12 Nov 2014 14:25:11 +0800" ], "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.07,367,1413270000\"; d=\"scan'208\";a=\"606393475\"", "From": "Cunming Liang <cunming.liang@intel.com>", "To": "dev@dpdk.org", "Date": "Wed, 12 Nov 2014 14:24:36 +0800", "Message-Id": "<1415773476-31004-8-git-send-email-cunming.liang@intel.com>", "X-Mailer": "git-send-email 1.7.4.1", "In-Reply-To": "<1415773476-31004-1-git-send-email-cunming.liang@intel.com>", "References": "<1414372809-14044-1-git-send-email-cunming.liang@intel.com>\n\t<1415773476-31004-1-git-send-email-cunming.liang@intel.com>", "Subject": "[dpdk-dev] [PATCH v7 7/7] ethdev: fix wrong error return refere to\n\tAPI definition", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Per definition, rte_eth_rx_burst/rte_eth_tx_burst/rte_eth_rx_queue_count returns the packet number\nWhen RTE_LIBRTE_ETHDEV_DEBUG turns on, retval of FUNC_PTR_OR_ERR_RTE was set to -ENOTSUP.\nIt makes confusing.\nThe patch always return 0 no matter no packet or there's error.\n\nSigned-off-by: Cunming Liang <cunming.liang@intel.com>\n---\n lib/librte_ether/rte_ethdev.c | 6 +++---\n 1 files changed, 3 insertions(+), 3 deletions(-)", "diff": "diff --git a/lib/librte_ether/rte_ethdev.c b/lib/librte_ether/rte_ethdev.c\nindex 5e9d576..8c65d72 100644\n--- a/lib/librte_ether/rte_ethdev.c\n+++ b/lib/librte_ether/rte_ethdev.c\n@@ -2586,7 +2586,7 @@ rte_eth_rx_burst(uint8_t port_id, uint16_t queue_id,\n \t\treturn 0;\n \t}\n \tdev = &rte_eth_devices[port_id];\n-\tFUNC_PTR_OR_ERR_RET(*dev->rx_pkt_burst, -ENOTSUP);\n+\tFUNC_PTR_OR_ERR_RET(*dev->rx_pkt_burst, 0);\n \tif (queue_id >= dev->data->nb_rx_queues) {\n \t\tPMD_DEBUG_TRACE(\"Invalid RX queue_id=%d\\n\", queue_id);\n \t\treturn 0;\n@@ -2607,7 +2607,7 @@ rte_eth_tx_burst(uint8_t port_id, uint16_t queue_id,\n \t}\n \tdev = &rte_eth_devices[port_id];\n \n-\tFUNC_PTR_OR_ERR_RET(*dev->tx_pkt_burst, -ENOTSUP);\n+\tFUNC_PTR_OR_ERR_RET(*dev->tx_pkt_burst, 0);\n \tif (queue_id >= dev->data->nb_tx_queues) {\n \t\tPMD_DEBUG_TRACE(\"Invalid TX queue_id=%d\\n\", queue_id);\n \t\treturn 0;\n@@ -2626,7 +2626,7 @@ rte_eth_rx_queue_count(uint8_t port_id, uint16_t queue_id)\n \t\treturn 0;\n \t}\n \tdev = &rte_eth_devices[port_id];\n-\tFUNC_PTR_OR_ERR_RET(*dev->dev_ops->rx_queue_count, -ENOTSUP);\n+\tFUNC_PTR_OR_ERR_RET(*dev->dev_ops->rx_queue_count, 0);\n \treturn (*dev->dev_ops->rx_queue_count)(dev, queue_id);\n }\n \n", "prefixes": [ "dpdk-dev", "v7", "7/7" ] }