Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1257/?format=api
{ "id": 1257, "url": "https://patches.dpdk.org/api/patches/1257/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1415773476-31004-5-git-send-email-cunming.liang@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1415773476-31004-5-git-send-email-cunming.liang@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1415773476-31004-5-git-send-email-cunming.liang@intel.com", "date": "2014-11-12T06:24:33", "name": "[dpdk-dev,v7,4/7] app/testpmd: cleanup eth_addr print", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "3cfc94e1b70625c75932af7a4dcc0351c8ac2d5f", "submitter": { "id": 46, "url": "https://patches.dpdk.org/api/people/46/?format=api", "name": "Cunming Liang", "email": "cunming.liang@intel.com" }, "delegate": null, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1415773476-31004-5-git-send-email-cunming.liang@intel.com/mbox/", "series": [], "comments": "https://patches.dpdk.org/api/patches/1257/comments/", "check": "pending", "checks": "https://patches.dpdk.org/api/patches/1257/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 7EFB37F69;\n\tWed, 12 Nov 2014 07:15:22 +0100 (CET)", "from mga03.intel.com (mga03.intel.com [134.134.136.65])\n\tby dpdk.org (Postfix) with ESMTP id BAF9D7F6D\n\tfor <dev@dpdk.org>; Wed, 12 Nov 2014 07:15:13 +0100 (CET)", "from orsmga002.jf.intel.com ([10.7.209.21])\n\tby orsmga103.jf.intel.com with ESMTP; 11 Nov 2014 22:22:44 -0800", "from shvmail01.sh.intel.com ([10.239.29.42])\n\tby orsmga002.jf.intel.com with ESMTP; 11 Nov 2014 22:25:05 -0800", "from shecgisg004.sh.intel.com (shecgisg004.sh.intel.com\n\t[10.239.29.89])\n\tby shvmail01.sh.intel.com with ESMTP id sAC6P3Oo020474;\n\tWed, 12 Nov 2014 14:25:03 +0800", "from shecgisg004.sh.intel.com (localhost [127.0.0.1])\n\tby shecgisg004.sh.intel.com (8.13.6/8.13.6/SuSE Linux 0.8) with ESMTP\n\tid sAC6P0fR031210; Wed, 12 Nov 2014 14:25:03 +0800", "(from cliang18@localhost)\n\tby shecgisg004.sh.intel.com (8.13.6/8.13.6/Submit) id sAC6P0Rh031206; \n\tWed, 12 Nov 2014 14:25:00 +0800" ], "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.07,367,1413270000\"; d=\"scan'208\";a=\"635505409\"", "From": "Cunming Liang <cunming.liang@intel.com>", "To": "dev@dpdk.org", "Date": "Wed, 12 Nov 2014 14:24:33 +0800", "Message-Id": "<1415773476-31004-5-git-send-email-cunming.liang@intel.com>", "X-Mailer": "git-send-email 1.7.4.1", "In-Reply-To": "<1415773476-31004-1-git-send-email-cunming.liang@intel.com>", "References": "<1414372809-14044-1-git-send-email-cunming.liang@intel.com>\n\t<1415773476-31004-1-git-send-email-cunming.liang@intel.com>", "Subject": "[dpdk-dev] [PATCH v7 4/7] app/testpmd: cleanup eth_addr print", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Signed-off-by: Cunming Liang <cunming.liang@intel.com>\n---\n app/test-pmd/config.c | 10 +++-------\n app/test-pmd/icmpecho.c | 16 ++--------------\n app/test-pmd/rxonly.c | 11 +++--------\n 3 files changed, 8 insertions(+), 29 deletions(-)", "diff": "diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c\nindex 9bc08f4..b102b72 100644\n--- a/app/test-pmd/config.c\n+++ b/app/test-pmd/config.c\n@@ -99,13 +99,9 @@\n static void\n print_ethaddr(const char *name, struct ether_addr *eth_addr)\n {\n-\tprintf(\"%s%02X:%02X:%02X:%02X:%02X:%02X\", name,\n-\t (unsigned int)eth_addr->addr_bytes[0],\n-\t (unsigned int)eth_addr->addr_bytes[1],\n-\t (unsigned int)eth_addr->addr_bytes[2],\n-\t (unsigned int)eth_addr->addr_bytes[3],\n-\t (unsigned int)eth_addr->addr_bytes[4],\n-\t (unsigned int)eth_addr->addr_bytes[5]);\n+\tchar buf[ETHER_ADDR_FMT_SIZE];\n+\tether_format_addr(buf, ETHER_ADDR_FMT_SIZE, eth_addr);\n+\tprintf(\"%s%s\", name, buf);\n }\n \n void\ndiff --git a/app/test-pmd/icmpecho.c b/app/test-pmd/icmpecho.c\nindex 7fd4b6d..774924e 100644\n--- a/app/test-pmd/icmpecho.c\n+++ b/app/test-pmd/icmpecho.c\n@@ -236,18 +236,6 @@ ip_proto_name(uint8_t ip_proto)\n }\n \n static void\n-ether_addr_to_hexa(const struct ether_addr *ea, char *buf)\n-{\n-\tsprintf(buf, \"%02x:%02x:%02x:%02x:%02x:%02x\",\n-\t\tea->addr_bytes[0],\n-\t\tea->addr_bytes[1],\n-\t\tea->addr_bytes[2],\n-\t\tea->addr_bytes[3],\n-\t\tea->addr_bytes[4],\n-\t\tea->addr_bytes[5]);\n-}\n-\n-static void\n ipv4_addr_to_dot(uint32_t be_ipv4_addr, char *buf)\n {\n \tuint32_t ipv4_addr;\n@@ -261,9 +249,9 @@ ipv4_addr_to_dot(uint32_t be_ipv4_addr, char *buf)\n static void\n ether_addr_dump(const char *what, const struct ether_addr *ea)\n {\n-\tchar buf[18];\n+\tchar buf[ETHER_ADDR_FMT_SIZE];\n \n-\tether_addr_to_hexa(ea, buf);\n+\tether_format_addr(buf, ETHER_ADDR_FMT_SIZE, ea);\n \tif (what)\n \t\tprintf(\"%s\", what);\n \tprintf(\"%s\", buf);\ndiff --git a/app/test-pmd/rxonly.c b/app/test-pmd/rxonly.c\nindex 4410c3d..9ad1df6 100644\n--- a/app/test-pmd/rxonly.c\n+++ b/app/test-pmd/rxonly.c\n@@ -94,14 +94,9 @@ static const char *pkt_rx_flag_names[MAX_PKT_RX_FLAGS] = {\n static inline void\n print_ether_addr(const char *what, struct ether_addr *eth_addr)\n {\n-\tprintf(\"%s%02X:%02X:%02X:%02X:%02X:%02X\",\n-\t what,\n-\t eth_addr->addr_bytes[0],\n-\t eth_addr->addr_bytes[1],\n-\t eth_addr->addr_bytes[2],\n-\t eth_addr->addr_bytes[3],\n-\t eth_addr->addr_bytes[4],\n-\t eth_addr->addr_bytes[5]);\n+\tchar buf[ETHER_ADDR_FMT_SIZE];\n+\tether_format_addr(buf, ETHER_ADDR_FMT_SIZE, eth_addr);\n+\tprintf(\"%s%s\", what, buf);\n }\n \n /*\n", "prefixes": [ "dpdk-dev", "v7", "4/7" ] }