Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/125467/?format=api
{ "id": 125467, "url": "https://patches.dpdk.org/api/patches/125467/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1679610881-25997-2-git-send-email-roretzla@linux.microsoft.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1679610881-25997-2-git-send-email-roretzla@linux.microsoft.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1679610881-25997-2-git-send-email-roretzla@linux.microsoft.com", "date": "2023-03-23T22:34:35", "name": "[v2,1/7] ring: replace rte atomics with GCC builtin atomics", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "3029d85ccb3ed1ad40704674d7a3465639e6c93e", "submitter": { "id": 2077, "url": "https://patches.dpdk.org/api/people/2077/?format=api", "name": "Tyler Retzlaff", "email": "roretzla@linux.microsoft.com" }, "delegate": { "id": 1, "url": "https://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1679610881-25997-2-git-send-email-roretzla@linux.microsoft.com/mbox/", "series": [ { "id": 27529, "url": "https://patches.dpdk.org/api/series/27529/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=27529", "date": "2023-03-23T22:34:35", "name": "replace rte atomics with GCC builtin atomics", "version": 2, "mbox": "https://patches.dpdk.org/series/27529/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/125467/comments/", "check": "warning", "checks": "https://patches.dpdk.org/api/patches/125467/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id B7AF342829;\n\tThu, 23 Mar 2023 23:34:44 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 8E4F64161A;\n\tThu, 23 Mar 2023 23:34:44 +0100 (CET)", "from linux.microsoft.com (linux.microsoft.com [13.77.154.182])\n by mails.dpdk.org (Postfix) with ESMTP id 8AC5540E09\n for <dev@dpdk.org>; Thu, 23 Mar 2023 23:34:43 +0100 (CET)", "by linux.microsoft.com (Postfix, from userid 1086)\n id DA92220DEE39; Thu, 23 Mar 2023 15:34:42 -0700 (PDT)" ], "DKIM-Filter": "OpenDKIM Filter v2.11.0 linux.microsoft.com DA92220DEE39", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com;\n s=default; t=1679610882;\n bh=QDZ173vXnv0+sWe7FNjO42Kygh5EkFKz+2z4o/ZJHgg=;\n h=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n b=iLeZw7BChEpgzqNlKGQbVOxRjMH+nzOfpfrBUyzpULwmtQ/bAgTdWPZEJVSx3T45t\n +obNAZDyxJhL4dyooc2HA2zIzzajELr5G468Ez+EOcfkXlmzY6M0B5hniT+YMGxqSq\n ERYeTfc3th1twKwWRgcwPurIIDnu1f6Zr2vO00II=", "From": "Tyler Retzlaff <roretzla@linux.microsoft.com>", "To": "dev@dpdk.org", "Cc": "Honnappa.Nagarahalli@arm.com, Ruifeng.Wang@arm.com, thomas@monjalon.net,\n stephen@networkplumber.org, mb@smartsharesystems.com,\n Tyler Retzlaff <roretzla@linux.microsoft.com>", "Subject": "[PATCH v2 1/7] ring: replace rte atomics with GCC builtin atomics", "Date": "Thu, 23 Mar 2023 15:34:35 -0700", "Message-Id": "<1679610881-25997-2-git-send-email-roretzla@linux.microsoft.com>", "X-Mailer": "git-send-email 1.8.3.1", "In-Reply-To": "<1679610881-25997-1-git-send-email-roretzla@linux.microsoft.com>", "References": "<1679084388-19267-1-git-send-email-roretzla@linux.microsoft.com>\n <1679610881-25997-1-git-send-email-roretzla@linux.microsoft.com>", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Replace the use of rte_atomic.h types and functions, instead use GCC\nsupplied C++11 memory model builtins.\n\nSigned-off-by: Tyler Retzlaff <roretzla@linux.microsoft.com>\n---\n lib/ring/rte_ring_core.h | 1 -\n lib/ring/rte_ring_generic_pvt.h | 12 ++++++++----\n 2 files changed, 8 insertions(+), 5 deletions(-)", "diff": "diff --git a/lib/ring/rte_ring_core.h b/lib/ring/rte_ring_core.h\nindex 82b2370..b9c7860 100644\n--- a/lib/ring/rte_ring_core.h\n+++ b/lib/ring/rte_ring_core.h\n@@ -31,7 +31,6 @@\n #include <rte_config.h>\n #include <rte_memory.h>\n #include <rte_lcore.h>\n-#include <rte_atomic.h>\n #include <rte_branch_prediction.h>\n #include <rte_memzone.h>\n #include <rte_pause.h>\ndiff --git a/lib/ring/rte_ring_generic_pvt.h b/lib/ring/rte_ring_generic_pvt.h\nindex 5acb6e5..c284040 100644\n--- a/lib/ring/rte_ring_generic_pvt.h\n+++ b/lib/ring/rte_ring_generic_pvt.h\n@@ -92,8 +92,10 @@\n \t\tif (is_sp)\n \t\t\tr->prod.head = *new_head, success = 1;\n \t\telse\n-\t\t\tsuccess = rte_atomic32_cmpset(&r->prod.head,\n-\t\t\t\t\t*old_head, *new_head);\n+\t\t\t// NOTE: review for potential ordering optimization\n+\t\t\tsuccess = __atomic_compare_exchange_n(&r->prod.head,\n+\t\t\t\t\told_head, *new_head, 0,\n+\t\t\t\t\t__ATOMIC_SEQ_CST, __ATOMIC_SEQ_CST);\n \t} while (unlikely(success == 0));\n \treturn n;\n }\n@@ -162,8 +164,10 @@\n \t\t\trte_smp_rmb();\n \t\t\tsuccess = 1;\n \t\t} else {\n-\t\t\tsuccess = rte_atomic32_cmpset(&r->cons.head, *old_head,\n-\t\t\t\t\t*new_head);\n+\t\t\t// NOTE: review for potential ordering optimization\n+\t\t\tsuccess = __atomic_compare_exchange_n(&r->cons.head,\n+\t\t\t\t\told_head, *new_head, 0,\n+\t\t\t\t\t__ATOMIC_SEQ_CST, __ATOMIC_SEQ_CST);\n \t\t}\n \t} while (unlikely(success == 0));\n \treturn n;\n", "prefixes": [ "v2", "1/7" ] }