Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 125321,
    "url": "https://patches.dpdk.org/api/patches/125321/?format=api",
    "web_url": "https://patches.dpdk.org/project/dpdk/patch/20230320145343.449023-2-erezsh@nvidia.com/",
    "project": {
        "id": 1,
        "url": "https://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20230320145343.449023-2-erezsh@nvidia.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20230320145343.449023-2-erezsh@nvidia.com",
    "date": "2023-03-20T14:53:41",
    "name": "[2/4] net/mlx5/hws: shared context uses defaults from local context",
    "commit_ref": null,
    "pull_url": null,
    "state": "superseded",
    "archived": true,
    "hash": "6eae2a60acf29a04cdc6f95bb5ae75b1794107f3",
    "submitter": {
        "id": 2911,
        "url": "https://patches.dpdk.org/api/people/2911/?format=api",
        "name": "Erez Shitrit",
        "email": "erezsh@nvidia.com"
    },
    "delegate": {
        "id": 3268,
        "url": "https://patches.dpdk.org/api/users/3268/?format=api",
        "username": "rasland",
        "first_name": "Raslan",
        "last_name": "Darawsheh",
        "email": "rasland@nvidia.com"
    },
    "mbox": "https://patches.dpdk.org/project/dpdk/patch/20230320145343.449023-2-erezsh@nvidia.com/mbox/",
    "series": [
        {
            "id": 27465,
            "url": "https://patches.dpdk.org/api/series/27465/?format=api",
            "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=27465",
            "date": "2023-03-20T14:53:40",
            "name": "[1/4] net/mlx5/hws: fix bug in pattern creation",
            "version": 1,
            "mbox": "https://patches.dpdk.org/series/27465/mbox/"
        }
    ],
    "comments": "https://patches.dpdk.org/api/patches/125321/comments/",
    "check": "success",
    "checks": "https://patches.dpdk.org/api/patches/125321/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@inbox.dpdk.org",
        "Delivered-To": "patchwork@inbox.dpdk.org",
        "Received": [
            "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 4D45D427E2;\n\tMon, 20 Mar 2023 15:54:36 +0100 (CET)",
            "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 1D1BE41141;\n\tMon, 20 Mar 2023 15:54:33 +0100 (CET)",
            "from NAM12-DM6-obe.outbound.protection.outlook.com\n (mail-dm6nam12on2041.outbound.protection.outlook.com [40.107.243.41])\n by mails.dpdk.org (Postfix) with ESMTP id 49BC7410F3\n for <dev@dpdk.org>; Mon, 20 Mar 2023 15:54:32 +0100 (CET)",
            "from MW4PR03CA0248.namprd03.prod.outlook.com (2603:10b6:303:b4::13)\n by SJ0PR12MB8613.namprd12.prod.outlook.com (2603:10b6:a03:44d::20)\n with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6178.37; Mon, 20 Mar\n 2023 14:54:30 +0000",
            "from CO1NAM11FT095.eop-nam11.prod.protection.outlook.com\n (2603:10b6:303:b4:cafe::d7) by MW4PR03CA0248.outlook.office365.com\n (2603:10b6:303:b4::13) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6178.37 via Frontend\n Transport; Mon, 20 Mar 2023 14:54:30 +0000",
            "from mail.nvidia.com (216.228.117.161) by\n CO1NAM11FT095.mail.protection.outlook.com (10.13.174.179) with Microsoft SMTP\n Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.20.6222.15 via Frontend Transport; Mon, 20 Mar 2023 14:54:30 +0000",
            "from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com\n (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.5; Mon, 20 Mar 2023\n 07:54:16 -0700",
            "from nvidia.com (10.126.231.37) by rnnvmail201.nvidia.com\n (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.37; Mon, 20 Mar\n 2023 07:54:14 -0700"
        ],
        "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=BPajCmy3TRrWKaT0G/oidWalEDFIIzRDQmctHq73VOXaeVAVt/lu7WJH5XpYznPuGWi8RnA1Kyg537e0DB1KT0EMPLDnXiklhFdUNwmmKuo83jZlEZfrkuIYnGYDb/VUtpzJGvdxkG+FuhsFamoz4PuWcuuthJhsPow3PrS64phapKUt7b6XUxHrhoTmf6eyASHqVUuZitkA+uIsM0WNkTS8q9zRJyri0hNGRVzI5qEuXbNffDwGNEI/hf3Z7D8apF9fvQAnOLOGk5uD5tFtR/TkrmVGM4Z3wigLxBo0wlPQEc9mD4IjwhxDkzO3+DhjPmVy1TGFeLVxPZvsW4POcg==",
        "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=l2jCM1B6ibpccGCSJdjcTE6xhukWCOoSFVpgujADW10=;\n b=bjK4kXkBIh82neqByWQIrBD4LXves4vXK5ZsMNQnV2c27Q+poSg71mli5jqt3GtLu62sMEkO1A5i3A5hsxIbosPBpjIzz7Lip6MBosDKsShjkCA+ny4dh18/wNSIz2S/XDWDauIKUO4zNQWS8F7UA5b3muOC1r8dF973AgkD9sfeLNGmpzMt8Ft5jgDh7Tr9PMG4RBePZHmU2ef2/ENJVqw297fvly5xRkiStAM0ZnuvM5PJhWXC/zL4JgLZk+JXrE87aRZaeAQFC7UwscfnQCsnZZCz/BhE6ZymmkLrPK83RCY15Qa7WwS0h0IlmmPHxvfUEll3UjC+2cLftMgmrQ==",
        "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass (sender ip is\n 216.228.117.161) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com;\n dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com;\n dkim=none (message not signed); arc=none",
        "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com;\n s=selector2;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=l2jCM1B6ibpccGCSJdjcTE6xhukWCOoSFVpgujADW10=;\n b=tXlDa12wCDTGYApHjtKJOM16GBHNVRG9TL6XTiTew06VWNeQuyU6uEpy9fcDrpK2qUFGkWw83cTYBCdDS0wM9GPblo5IBTenylagnKJLZWLlbw3xLGsa+dk+sM4eTxj/7PzD8EqlXqziMK7UUW9hGeV8xJ6g3yL2rbT2U3NxHuApBBY91brsLrTvNgnbJr2pMpBCayMUs5mGB44QCPQ/xic54VkN6w4UTHWfhZfdJs4BkOK4fEIYegy2QLHMt1H7cW6t34/MASQN2FEwJNqikeBbKKHIeVAkj8CO4qq+kR4GUWhxLxPyUwzBhuxvez2pF153QN0izQsxx6Brt2pLGw==",
        "X-MS-Exchange-Authentication-Results": "spf=pass (sender IP is 216.228.117.161)\n smtp.mailfrom=nvidia.com;\n dkim=none (message not signed)\n header.d=none;dmarc=pass action=none header.from=nvidia.com;",
        "Received-SPF": "Pass (protection.outlook.com: domain of nvidia.com designates\n 216.228.117.161 as permitted sender) receiver=protection.outlook.com;\n client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C",
        "From": "Erez Shitrit <erezsh@nvidia.com>",
        "To": "<dev@dpdk.org>",
        "CC": "<valex@nvidia.com>, Matan Azrad <matan@nvidia.com>, Viacheslav Ovsiienko\n <viacheslavo@nvidia.com>",
        "Subject": "[PATCH 2/4] net/mlx5/hws: shared context uses defaults from local\n context",
        "Date": "Mon, 20 Mar 2023 16:53:41 +0200",
        "Message-ID": "<20230320145343.449023-2-erezsh@nvidia.com>",
        "X-Mailer": "git-send-email 2.18.2",
        "In-Reply-To": "<20230320145343.449023-1-erezsh@nvidia.com>",
        "References": "<20230320145343.449023-1-erezsh@nvidia.com>",
        "MIME-Version": "1.0",
        "Content-Type": "text/plain",
        "X-Originating-IP": "[10.126.231.37]",
        "X-ClientProxiedBy": "rnnvmail202.nvidia.com (10.129.68.7) To\n rnnvmail201.nvidia.com (10.129.68.8)",
        "X-EOPAttributedMessage": "0",
        "X-MS-PublicTrafficType": "Email",
        "X-MS-TrafficTypeDiagnostic": "CO1NAM11FT095:EE_|SJ0PR12MB8613:EE_",
        "X-MS-Office365-Filtering-Correlation-Id": "232f5ca0-efb2-4e21-e737-08db2953026f",
        "X-MS-Exchange-SenderADCheck": "1",
        "X-MS-Exchange-AntiSpam-Relay": "0",
        "X-Microsoft-Antispam": "BCL:0;",
        "X-Microsoft-Antispam-Message-Info": "\n rJgR41s26q3xf3kMoqTUQ1PS9A3jazbvbJywRqfLE2VRARVw7IXeUJGyL8m9pBOLEA895VuTAbRvWrgzp0HlLCchKu2QFVHoXD2usoa2Xt0KRlCwz0PUnPZUaf9awnEtsBplafpRBPktwq0zTEZY9Q9jXmt3hkl9yVcoM7DyT0iIDVclEALJ9IyfRcNMf4aDnhGiAMH4Q3Y5PA7K3VfyrAh77Vcnv2LIaKtLrfTIEdikqhCcNzjNg9CaU3zi+RWWvDXld8ScIhTgmz/27cktvsGAczoVFUjn21GrC6EtV8CbY+y5Qm4gsZ9JKN1etrM17Id+HYjq3+QMWxZ33UwOdYkr497spG1O7NQ+SayDxmGl+5TUjGZ1uUQ2uDTTQNwORdKxcnneWRIMe8mN9l0PEFpL88Y4ZJVj2b+PNG6FdV1HRIoUp18JRc9v13Gqe6ykLXRwZU10fR2WfbcOFxek+S9AOn4YIvmvEKuTsNSAXYcPDfBx1pCVSY5ZYVF2FEVxdvwMq3ByA9NC5F8MF1i05CXPioR19SQhvfIJ8mMRhABgXi14JsaVuQg9J81G5knUdMxGOV2k4IvA+IuMMA7lQBcwBCe5Wy+JZ+JlNLH57YSU+/eepy7Eo0QD5rKwiEdWAco6cIg29M+a7tX5FGop+klZCz5fms0P/9QpbvLiNE2z9dDdsxc6AU8QFQp9M529nxdvoBK5Ztw0dSYfvTibjzsLkRUw0/w46gFLg4BZ9xRSOdMBp0UV+1Pg+Z2g17s2",
        "X-Forefront-Antispam-Report": "CIP:216.228.117.161; CTRY:US; LANG:en; SCL:1;\n SRV:;\n IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge2.nvidia.com; CAT:NONE;\n SFS:(13230025)(4636009)(136003)(346002)(376002)(39860400002)(396003)(451199018)(46966006)(40470700004)(36840700001)(426003)(47076005)(2616005)(107886003)(6666004)(336012)(1076003)(26005)(40460700003)(5660300002)(86362001)(7696005)(70206006)(478600001)(316002)(186003)(6286002)(16526019)(82310400005)(83380400001)(54906003)(70586007)(36756003)(4326008)(8676002)(6916009)(41300700001)(356005)(36860700001)(8936002)(82740400003)(40480700001)(2906002)(7636003)(55016003);\n DIR:OUT; SFP:1101;",
        "X-OriginatorOrg": "Nvidia.com",
        "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "20 Mar 2023 14:54:30.1407 (UTC)",
        "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n 232f5ca0-efb2-4e21-e737-08db2953026f",
        "X-MS-Exchange-CrossTenant-Id": "43083d15-7273-40c1-b7db-39efd9ccc17a",
        "X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp": "\n TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.161];\n Helo=[mail.nvidia.com]",
        "X-MS-Exchange-CrossTenant-AuthSource": "\n CO1NAM11FT095.eop-nam11.prod.protection.outlook.com",
        "X-MS-Exchange-CrossTenant-AuthAs": "Anonymous",
        "X-MS-Exchange-CrossTenant-FromEntityHeader": "HybridOnPrem",
        "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "SJ0PR12MB8613",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.29",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org"
    },
    "content": "Fix default miss behavior for shared resources, the problem\ncould happen in two cases:\nWhen the table created, the default miss should go to the alias ft\nthat will direct it back to local context.\n\nWhen the rule is without specific hit address and we are in a shared\nRTC from here it should be redirected back to the local context.\n\nFixes: ce946c7d3999 (\"net/mlx5/hws: support ibv context shared with local one\")\nReviewed-by: Alex Vesker <valex@nvidia.com>\nSigned-off-by: Erez Shitrit <erezsh@nvidia.com>\n---\n drivers/net/mlx5/hws/mlx5dr_action.c |  9 ++++++++-\n drivers/net/mlx5/hws/mlx5dr_table.c  | 29 ++++++++++++++++++++++------\n 2 files changed, 31 insertions(+), 7 deletions(-)",
    "diff": "diff --git a/drivers/net/mlx5/hws/mlx5dr_action.c b/drivers/net/mlx5/hws/mlx5dr_action.c\nindex 2db62635c1..77cf1f5132 100644\n--- a/drivers/net/mlx5/hws/mlx5dr_action.c\n+++ b/drivers/net/mlx5/hws/mlx5dr_action.c\n@@ -1751,8 +1751,15 @@ int mlx5dr_action_get_default_stc(struct mlx5dr_context *ctx,\n \t\tgoto free_nop_dw6;\n \t}\n \n-\tstc_attr.action_type = MLX5_IFC_STC_ACTION_TYPE_ALLOW;\n \tstc_attr.action_offset = MLX5DR_ACTION_OFFSET_HIT;\n+\tif (!mlx5dr_context_shared_gvmi_used(ctx)) {\n+\t\tstc_attr.action_type = MLX5_IFC_STC_ACTION_TYPE_ALLOW;\n+\t} else {\n+\t\t/* On shared gvmi the default hit behavior is jump to alias end ft */\n+\t\tstc_attr.action_type = MLX5_IFC_STC_ACTION_TYPE_JUMP_TO_FT;\n+\t\tstc_attr.dest_table_id = ctx->gvmi_res[tbl_type].aliased_end_ft->id;\n+\t}\n+\n \tret = mlx5dr_action_alloc_single_stc(ctx, &stc_attr, tbl_type,\n \t\t\t\t\t     &default_stc->default_hit);\n \tif (ret) {\ndiff --git a/drivers/net/mlx5/hws/mlx5dr_table.c b/drivers/net/mlx5/hws/mlx5dr_table.c\nindex 327e2ec710..0e5e9b49ab 100644\n--- a/drivers/net/mlx5/hws/mlx5dr_table.c\n+++ b/drivers/net/mlx5/hws/mlx5dr_table.c\n@@ -272,6 +272,9 @@ static void mlx5dr_table_uninit_shared_ctx_res(struct mlx5dr_table *tbl)\n /* called under spin_lock ctx->ctrl_lock */\n static int mlx5dr_table_init_shared_ctx_res(struct mlx5dr_context *ctx, struct mlx5dr_table *tbl)\n {\n+\tstruct mlx5dr_cmd_ft_modify_attr ft_attr = {0};\n+\tint ret;\n+\n \tif (!mlx5dr_context_shared_gvmi_used(ctx))\n \t\treturn 0;\n \n@@ -288,8 +291,22 @@ static int mlx5dr_table_init_shared_ctx_res(struct mlx5dr_context *ctx, struct m\n \t\tgoto clean_local_ft;\n \t}\n \n+\t/* On shared gvmi the default behavior is jump to alias end ft */\n+\tmlx5dr_cmd_set_attr_connect_miss_tbl(tbl->ctx,\n+\t\t\t\t\t     tbl->fw_ft_type,\n+\t\t\t\t\t     tbl->type,\n+\t\t\t\t\t     &ft_attr);\n+\n+\tret = mlx5dr_cmd_flow_table_modify(tbl->ft, &ft_attr);\n+\tif (ret) {\n+\t\tDR_LOG(ERR, \"Failed to point table to its default miss\");\n+\t\tgoto clean_shared_res;\n+\t}\n+\n \treturn 0;\n \n+clean_shared_res:\n+\tmlx5dr_table_put_shared_gvmi_res(tbl);\n clean_local_ft:\n \tmlx5dr_table_destroy_default_ft(tbl, tbl->local_ft);\n \treturn rte_errno;\n@@ -337,20 +354,20 @@ static int mlx5dr_table_init(struct mlx5dr_table *tbl)\n \t\treturn rte_errno;\n \t}\n \n-\tret = mlx5dr_action_get_default_stc(ctx, tbl->type);\n+\tret = mlx5dr_table_init_shared_ctx_res(ctx, tbl);\n \tif (ret)\n \t\tgoto tbl_destroy;\n \n-\tret = mlx5dr_table_init_shared_ctx_res(ctx, tbl);\n+\tret = mlx5dr_action_get_default_stc(ctx, tbl->type);\n \tif (ret)\n-\t\tgoto put_stc;\n+\t\tgoto free_shared_ctx;\n \n \tpthread_spin_unlock(&ctx->ctrl_lock);\n \n \treturn 0;\n \n-put_stc:\n-\tmlx5dr_action_put_default_stc(ctx, tbl->type);\n+free_shared_ctx:\n+\tmlx5dr_table_uninit_shared_ctx_res(tbl);\n tbl_destroy:\n \tmlx5dr_table_destroy_default_ft(tbl, tbl->ft);\n \tpthread_spin_unlock(&ctx->ctrl_lock);\n@@ -363,8 +380,8 @@ static void mlx5dr_table_uninit(struct mlx5dr_table *tbl)\n \t\treturn;\n \tpthread_spin_lock(&tbl->ctx->ctrl_lock);\n \tmlx5dr_action_put_default_stc(tbl->ctx, tbl->type);\n-\tmlx5dr_table_destroy_default_ft(tbl, tbl->ft);\n \tmlx5dr_table_uninit_shared_ctx_res(tbl);\n+\tmlx5dr_table_destroy_default_ft(tbl, tbl->ft);\n \tpthread_spin_unlock(&tbl->ctx->ctrl_lock);\n }\n \n",
    "prefixes": [
        "2/4"
    ]
}