Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/125320/?format=api
{ "id": 125320, "url": "https://patches.dpdk.org/api/patches/125320/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20230320145343.449023-1-erezsh@nvidia.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230320145343.449023-1-erezsh@nvidia.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20230320145343.449023-1-erezsh@nvidia.com", "date": "2023-03-20T14:53:40", "name": "[1/4] net/mlx5/hws: fix bug in pattern creation", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "e19b0d22c4eae583c836f39cb171df2ea4f02e94", "submitter": { "id": 2911, "url": "https://patches.dpdk.org/api/people/2911/?format=api", "name": "Erez Shitrit", "email": "erezsh@nvidia.com" }, "delegate": { "id": 3268, "url": "https://patches.dpdk.org/api/users/3268/?format=api", "username": "rasland", "first_name": "Raslan", "last_name": "Darawsheh", "email": "rasland@nvidia.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20230320145343.449023-1-erezsh@nvidia.com/mbox/", "series": [ { "id": 27465, "url": "https://patches.dpdk.org/api/series/27465/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=27465", "date": "2023-03-20T14:53:40", "name": "[1/4] net/mlx5/hws: fix bug in pattern creation", "version": 1, "mbox": "https://patches.dpdk.org/series/27465/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/125320/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/125320/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 36691427E2;\n\tMon, 20 Mar 2023 15:54:31 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 15FA940A7F;\n\tMon, 20 Mar 2023 15:54:31 +0100 (CET)", "from NAM10-BN7-obe.outbound.protection.outlook.com\n (mail-bn7nam10on2065.outbound.protection.outlook.com [40.107.92.65])\n by mails.dpdk.org (Postfix) with ESMTP id 139F7406BC\n for <dev@dpdk.org>; Mon, 20 Mar 2023 15:54:30 +0100 (CET)", "from MW4PR03CA0066.namprd03.prod.outlook.com (2603:10b6:303:b6::11)\n by CY8PR12MB7756.namprd12.prod.outlook.com (2603:10b6:930:85::19)\n with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6178.37; Mon, 20 Mar\n 2023 14:54:28 +0000", "from CO1NAM11FT100.eop-nam11.prod.protection.outlook.com\n (2603:10b6:303:b6:cafe::d9) by MW4PR03CA0066.outlook.office365.com\n (2603:10b6:303:b6::11) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6178.37 via Frontend\n Transport; Mon, 20 Mar 2023 14:54:28 +0000", "from mail.nvidia.com (216.228.117.161) by\n CO1NAM11FT100.mail.protection.outlook.com (10.13.175.133) with Microsoft SMTP\n Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.20.6222.15 via Frontend Transport; Mon, 20 Mar 2023 14:54:28 +0000", "from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com\n (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.5; Mon, 20 Mar 2023\n 07:54:14 -0700", "from nvidia.com (10.126.231.37) by rnnvmail201.nvidia.com\n (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.37; Mon, 20 Mar\n 2023 07:54:13 -0700" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=FiF47gumHT61ZKPHLQACO7YKo/kZ/hd5sUMP+CS7ifIrW3aXldH5JvdUZpiL52FqjT6MWPph6dwbe6rBIQDwO7rp++VknOW5x1ujsgnhTtb2MblkdViVU+0u/hjFw/6YQNTRDs8NWr8L61xY7CiAwdjdCss67fKoqapmGC0nD7MxUaE4GO66nb4neECMHQzHYHXZMxlymYUPMjRyj7aBBM4pDPve+B79exRX41bTVbjkdtDXzQs1nIYfIoUHKTejqsCf39SpjaZeJweagyXPuhE7EPNSLj9FWaCKGrjASD2Cr/YXOiChUC20oxi80mRfwaNrSG9DDREMPOKppXxR9Q==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=XmAHIGG5ABb7aF3h9kGc48C9NGzjK6tzwVcUltIHigE=;\n b=Y5MIr91/iq4p3s1y4Nzodeh+M/YDbpVWdXGYeOQjFxOK60rrXvHtRmqjIz4Q/2MqAN/tR7qbfwt0yYBM2dCt2Zbd2ELvRNBI9ST+ZnnCCA0JpFGjUOh3mn7N5foNgmfXh9RiuMa3pe2NS7WRWbk6ljtGqYewovESarwN/mIeJE8Sdu1tTHS5u18LgEpvqoqIYSgb99duQ7PxrX1iY1xoVsnl9mPZ9NiboBKwEfjBEwBYzq09IdntPae44Cs7Q4zAGXP0olVMQw2q3/EEqACWDkpHxt2ygzFFyv17PesL/e2R7jQkzb5AqH8I258HSNSdzMoGYk9OeNWZjcTYgdtRIg==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass (sender ip is\n 216.228.117.161) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com;\n dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com;\n dkim=none (message not signed); arc=none", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com;\n s=selector2;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=XmAHIGG5ABb7aF3h9kGc48C9NGzjK6tzwVcUltIHigE=;\n b=LbqXpGOHuZHahTa5QFeGiaoQxjDnFm1tyi1lW2lPxfsuL6JVqCHuX72yi7s5J+sSkXSgAgHT+rjfZV+wiLBugAPzSLYGzYppF0Yn9yJxGACSa3Nbos7sDLzF7NzvYSypr86rpcy470yVvQr+RW7Aoci1kyzR6X7mIjRg3ksDYR0m8HRAE1/JIjl4sOY7bBH6IcggSfdaG5O7qZaasn5F5hBa4r1VBOThAj8ewaXjA3OUizeJdapC8s+cuT4LDwI1XxFD09/R8S2ADLombC52G5drNZ/YfWrDaMKBOL7sPgcj4M5iIV2XWO1HlKlN08YxtbWWc1kBXCVYGiUZcGxJMg==", "X-MS-Exchange-Authentication-Results": "spf=pass (sender IP is 216.228.117.161)\n smtp.mailfrom=nvidia.com;\n dkim=none (message not signed)\n header.d=none;dmarc=pass action=none header.from=nvidia.com;", "Received-SPF": "Pass (protection.outlook.com: domain of nvidia.com designates\n 216.228.117.161 as permitted sender) receiver=protection.outlook.com;\n client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C", "From": "Erez Shitrit <erezsh@nvidia.com>", "To": "<dev@dpdk.org>", "CC": "<valex@nvidia.com>, Matan Azrad <matan@nvidia.com>, Viacheslav Ovsiienko\n <viacheslavo@nvidia.com>", "Subject": "[PATCH 1/4] net/mlx5/hws: fix bug in pattern creation", "Date": "Mon, 20 Mar 2023 16:53:40 +0200", "Message-ID": "<20230320145343.449023-1-erezsh@nvidia.com>", "X-Mailer": "git-send-email 2.18.2", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-Originating-IP": "[10.126.231.37]", "X-ClientProxiedBy": "rnnvmail202.nvidia.com (10.129.68.7) To\n rnnvmail201.nvidia.com (10.129.68.8)", "X-EOPAttributedMessage": "0", "X-MS-PublicTrafficType": "Email", "X-MS-TrafficTypeDiagnostic": "CO1NAM11FT100:EE_|CY8PR12MB7756:EE_", "X-MS-Office365-Filtering-Correlation-Id": "89480434-88a1-40ea-ea7b-08db29530159", "X-MS-Exchange-SenderADCheck": "1", "X-MS-Exchange-AntiSpam-Relay": "0", "X-Microsoft-Antispam": "BCL:0;", "X-Microsoft-Antispam-Message-Info": "\n THWxeJcdT3cE40dqlzm1zGsZxNGHbpzGJMrbCIoMcODc+i2KqS4Piy5atSEsGrZAGh7cvbZNwlogmqX5fhTKXdmW3dzOrGtvFIxlF/o/dIn4MH3IA2dD9DfMs3n+v8O9dnJdZNttBuse6PgXPF5KeZ4DgbYPuH+FG7edq8HOq/JCXBwEU28zSmhAQwcN6ihxnNGZmkXsXvBuwDaW7YfWPKahdH5rw4OVAJX9hJoo7T1v2ALT3fpBGZs+CR3ntWRQwLDShV5LCLfYiGtfyViNgXwNRBfMnbBYQaJ09Bc3zgJASwgiui+x9N+iP+GuHZ/Im1yNglQkjBGoaWCQSe3FV2Fl7QlHf20b0O99cL6HvtYilEJN1zxpv2GMjl/3Zh5fUJeHjHa3sZuODdm/HpwN/zSsjKFKVytWTe17y8lTfMM4odw7EO+ZNbr8vqoloc7pcr3XY5yzYmxLQsfbRnX418UAxWihyZ0jHOjL2yuUhQGJ0zLdminpu5krLAgOG56tvyjEjGZLPFiUnXZS705jtpfU/8r+almn1iFTSSKLyPENavPKy0zxTLXxhh7/rUp0Q4R43HG7qKUgFfxr/3XuqCFk9Arhgx/b8zUI+XnK1TEAjGCtDXoSwNvG2YRhNlePCtk4wYuThrKHbPpBYJ7y8o4927+AkNi1DAQO18pnARsIXOeE/ab0U2ZsYUQkDHdg+B+8SijwIBX5GfLennC7ktquKSKAnb79OAQ2ZSGIy8IPU4lS1V6sAzTlDuHavYvD", "X-Forefront-Antispam-Report": "CIP:216.228.117.161; CTRY:US; LANG:en; SCL:1;\n SRV:;\n IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge2.nvidia.com; CAT:NONE;\n SFS:(13230025)(4636009)(396003)(346002)(39860400002)(376002)(136003)(451199018)(46966006)(36840700001)(40470700004)(2616005)(7696005)(107886003)(16526019)(186003)(6286002)(426003)(4326008)(47076005)(83380400001)(478600001)(6666004)(336012)(316002)(54906003)(6916009)(70586007)(70206006)(26005)(1076003)(8676002)(36860700001)(41300700001)(8936002)(5660300002)(7636003)(40460700003)(82740400003)(2906002)(356005)(55016003)(86362001)(82310400005)(36756003)(40480700001);\n DIR:OUT; SFP:1101;", "X-OriginatorOrg": "Nvidia.com", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "20 Mar 2023 14:54:28.3032 (UTC)", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n 89480434-88a1-40ea-ea7b-08db29530159", "X-MS-Exchange-CrossTenant-Id": "43083d15-7273-40c1-b7db-39efd9ccc17a", "X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp": "\n TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.161];\n Helo=[mail.nvidia.com]", "X-MS-Exchange-CrossTenant-AuthSource": "\n CO1NAM11FT100.eop-nam11.prod.protection.outlook.com", "X-MS-Exchange-CrossTenant-AuthAs": "Anonymous", "X-MS-Exchange-CrossTenant-FromEntityHeader": "HybridOnPrem", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "CY8PR12MB7756", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "When creating a new pattern the data area should be clean, otherwise\nwhen the data will come from the arg object it will do OR operation on\nthe data part in the pattern.\n\nFixes: f8c8a6d8440d (\"net/mlx5/hws: add action object\")\nReviewed-by: Alex Vesker <valex@nvidia.com>\nSigned-off-by: Erez Shitrit <erezsh@nvidia.com>\n---\n drivers/net/mlx5/hws/mlx5dr_cmd.c | 16 ++++++++++++++--\n 1 file changed, 14 insertions(+), 2 deletions(-)", "diff": "diff --git a/drivers/net/mlx5/hws/mlx5dr_cmd.c b/drivers/net/mlx5/hws/mlx5dr_cmd.c\nindex a444fb4438..0adcedd9c9 100644\n--- a/drivers/net/mlx5/hws/mlx5dr_cmd.c\n+++ b/drivers/net/mlx5/hws/mlx5dr_cmd.c\n@@ -523,9 +523,11 @@ mlx5dr_cmd_header_modify_pattern_create(struct ibv_context *ctx,\n \tuint32_t in[MLX5_ST_SZ_DW(create_header_modify_pattern_in)] = {0};\n \tuint32_t out[MLX5_ST_SZ_DW(general_obj_out_cmd_hdr)] = {0};\n \tstruct mlx5dr_devx_obj *devx_obj;\n-\tvoid *pattern_data;\n+\tuint64_t *pattern_data;\n+\tint num_of_actions;\n \tvoid *pattern;\n \tvoid *attr;\n+\tint i;\n \n \tif (pattern_length > MAX_ACTIONS_DATA_IN_HEADER_MODIFY) {\n \t\tDR_LOG(ERR, \"Pattern length %d exceeds limit %d\",\n@@ -551,9 +553,19 @@ mlx5dr_cmd_header_modify_pattern_create(struct ibv_context *ctx,\n \t/* Pattern_length is in ddwords */\n \tMLX5_SET(header_modify_pattern_in, pattern, pattern_length, pattern_length / (2 * DW_SIZE));\n \n-\tpattern_data = MLX5_ADDR_OF(header_modify_pattern_in, pattern, pattern_data);\n+\tpattern_data = (uint64_t *)MLX5_ADDR_OF(header_modify_pattern_in, pattern, pattern_data);\n \tmemcpy(pattern_data, actions, pattern_length);\n \n+\tnum_of_actions = pattern_length / MLX5DR_MODIFY_ACTION_SIZE;\n+\tfor (i = 0; i < num_of_actions; i++) {\n+\t\tint type;\n+\n+\t\ttype = MLX5_GET(set_action_in, &pattern_data[i], action_type);\n+\t\tif (type != MLX5_MODIFICATION_TYPE_COPY)\n+\t\t\t/* Action typ-copy use all bytes for control */\n+\t\t\tMLX5_SET(set_action_in, &pattern_data[i], data, 0);\n+\t}\n+\n \tdevx_obj->obj = mlx5_glue->devx_obj_create(ctx, in, sizeof(in), out, sizeof(out));\n \tif (!devx_obj->obj) {\n \t\tDR_LOG(ERR, \"Failed to create header_modify_pattern\");\n", "prefixes": [ "1/4" ] }