Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/125212/?format=api
{ "id": 125212, "url": "https://patches.dpdk.org/api/patches/125212/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20230316212904.9318-2-syalavarthi@marvell.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230316212904.9318-2-syalavarthi@marvell.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20230316212904.9318-2-syalavarthi@marvell.com", "date": "2023-03-16T21:28:57", "name": "[v3,1/8] ml/cnxk: fix evaluation order violation issues", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "4813fdd8170c2361d5a9e98865bf897f9d93bdbf", "submitter": { "id": 2480, "url": "https://patches.dpdk.org/api/people/2480/?format=api", "name": "Srikanth Yalavarthi", "email": "syalavarthi@marvell.com" }, "delegate": { "id": 1, "url": "https://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20230316212904.9318-2-syalavarthi@marvell.com/mbox/", "series": [ { "id": 27429, "url": "https://patches.dpdk.org/api/series/27429/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=27429", "date": "2023-03-16T21:28:56", "name": "Fixes to ml/cnxk driver", "version": 3, "mbox": "https://patches.dpdk.org/series/27429/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/125212/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/125212/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 3EE8D41EB5;\n\tThu, 16 Mar 2023 22:29:49 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id AD44C42F86;\n\tThu, 16 Mar 2023 22:29:42 +0100 (CET)", "from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com\n [67.231.148.174])\n by mails.dpdk.org (Postfix) with ESMTP id 7292E42DB5\n for <dev@dpdk.org>; Thu, 16 Mar 2023 22:29:38 +0100 (CET)", "from pps.filterd (m0045849.ppops.net [127.0.0.1])\n by mx0a-0016f401.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id\n 32GFtBbb005959 for <dev@dpdk.org>; Thu, 16 Mar 2023 14:29:37 -0700", "from dc5-exch01.marvell.com ([199.233.59.181])\n by mx0a-0016f401.pphosted.com (PPS) with ESMTPS id 3pbxq2ucrk-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT)\n for <dev@dpdk.org>; Thu, 16 Mar 2023 14:29:37 -0700", "from DC5-EXCH01.marvell.com (10.69.176.38) by DC5-EXCH01.marvell.com\n (10.69.176.38) with Microsoft SMTP Server (TLS) id 15.0.1497.42;\n Thu, 16 Mar 2023 14:29:35 -0700", "from maili.marvell.com (10.69.176.80) by DC5-EXCH01.marvell.com\n (10.69.176.38) with Microsoft SMTP Server id 15.0.1497.42 via Frontend\n Transport; Thu, 16 Mar 2023 14:29:35 -0700", "from ml-host-33.caveonetworks.com (unknown [10.110.143.233])\n by maili.marvell.com (Postfix) with ESMTP id 3F3083F707A;\n Thu, 16 Mar 2023 14:29:35 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com;\n h=from : to : cc :\n subject : date : message-id : in-reply-to : references : mime-version :\n content-type; s=pfpt0220; bh=J6MTgAbnGcyy1KtLWbJRfU+I0nOyP/tgPBfISmIakiA=;\n b=TMczeWOQfcH4548yQaytlPYYTJUmv094PVgX62JWF4bJYOhASt0PHkKOk8o6+TZGCwJb\n GsOPpIFoZqQ0qYeL/a+bBwjPd6xLUiB2UDZZFr0MnV+T7UCrZkFjb7nEwvfpcJbjbCv8\n Y1hJMwvvKbA3+EFytJw2hTwDPSTPLZDD80ckUBVYWMJPO1oL4oItRtEqsOHuTYBDY/U7\n s3whTVGxS3396rJ0ndjhKSyLcQKBwlI98lc1pya3xwkBOdMgQ8aBurESBptfZvlFf9W0\n gy9DYgW1Qews4hpgZVb4oDkBK+IPqSCbYAqUx2nsj1WLoTDNNH3pnKigNtxcHe9Xwomj GA==", "From": "Srikanth Yalavarthi <syalavarthi@marvell.com>", "To": "Srikanth Yalavarthi <syalavarthi@marvell.com>, Prince Takkar\n <ptakkar@marvell.com>", "CC": "<dev@dpdk.org>, <sshankarnara@marvell.com>, <aprabhu@marvell.com>,\n <pshukla@marvell.com>", "Subject": "[PATCH v3 1/8] ml/cnxk: fix evaluation order violation issues", "Date": "Thu, 16 Mar 2023 14:28:57 -0700", "Message-ID": "<20230316212904.9318-2-syalavarthi@marvell.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20230316212904.9318-1-syalavarthi@marvell.com>", "References": "<20230315135427.11489-1-syalavarthi@marvell.com>\n <20230316212904.9318-1-syalavarthi@marvell.com>", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-Proofpoint-GUID": "AMapL0YtjeRUnvV7VJbp5UTj-t26yy9U", "X-Proofpoint-ORIG-GUID": "AMapL0YtjeRUnvV7VJbp5UTj-t26yy9U", "X-Proofpoint-Virus-Version": "vendor=baseguard\n engine=ICAP:2.0.254,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22\n definitions=2023-03-16_14,2023-03-16_02,2023-02-09_01", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Fix evaluation order violation issues reported by coverity\ntool. ocm_mask variable is being written twice with the\nsame value.\n\nCoverity issue: 383659\nFixes: b7d0650ebce0 (\"ml/cnxk: reserve and free OCM pages\")\n\nSigned-off-by: Srikanth Yalavarthi <syalavarthi@marvell.com>\n---\n drivers/ml/cnxk/cn10k_ml_ocm.c | 13 +++++--------\n 1 file changed, 5 insertions(+), 8 deletions(-)", "diff": "diff --git a/drivers/ml/cnxk/cn10k_ml_ocm.c b/drivers/ml/cnxk/cn10k_ml_ocm.c\nindex d8d2c71a3c..1ea45b5b60 100644\n--- a/drivers/ml/cnxk/cn10k_ml_ocm.c\n+++ b/drivers/ml/cnxk/cn10k_ml_ocm.c\n@@ -423,10 +423,8 @@ cn10k_ml_ocm_free_pages(struct rte_ml_dev *dev, uint16_t model_id)\n \twb_page_end = wb_page_start + model->model_mem_map.wb_pages - 1;\n \tfor (tile_id = model->addr.tile_start; tile_id <= model->addr.tile_end; tile_id++) {\n \t\tfor (page_id = wb_page_start; page_id <= wb_page_end; page_id++) {\n-\t\t\tocm->tile_ocm_info[tile_id].ocm_mask[page_id / OCM_MAP_WORD_SIZE] =\n-\t\t\t\tCLEAR_BIT(ocm->tile_ocm_info[tile_id]\n-\t\t\t\t\t\t .ocm_mask[page_id / OCM_MAP_WORD_SIZE],\n-\t\t\t\t\t page_id % OCM_MAP_WORD_SIZE);\n+\t\t\tCLEAR_BIT(ocm->tile_ocm_info[tile_id].ocm_mask[page_id / OCM_MAP_WORD_SIZE],\n+\t\t\t\t page_id % OCM_MAP_WORD_SIZE);\n \t\t}\n \n \t\t/* Update last_wb_page size */\n@@ -452,10 +450,9 @@ cn10k_ml_ocm_free_pages(struct rte_ml_dev *dev, uint16_t model_id)\n \t\t\tprev_start = ocm->num_pages - ocm->tile_ocm_info[tile_id].scratch_pages;\n \t\t\tcurr_start = ocm->num_pages - scratch_resize_pages;\n \t\t\tfor (page_id = prev_start; page_id < curr_start; page_id++) {\n-\t\t\t\tocm->tile_ocm_info[tile_id].ocm_mask[page_id / OCM_MAP_WORD_SIZE] =\n-\t\t\t\t\tCLEAR_BIT(ocm->tile_ocm_info[tile_id]\n-\t\t\t\t\t\t\t .ocm_mask[page_id / OCM_MAP_WORD_SIZE],\n-\t\t\t\t\t\t page_id % OCM_MAP_WORD_SIZE);\n+\t\t\t\tCLEAR_BIT(ocm->tile_ocm_info[tile_id]\n+\t\t\t\t\t\t .ocm_mask[page_id / OCM_MAP_WORD_SIZE],\n+\t\t\t\t\t page_id % OCM_MAP_WORD_SIZE);\n \t\t\t}\n \t\t\tocm->tile_ocm_info[tile_id].scratch_pages = scratch_resize_pages;\n \t\t}\n", "prefixes": [ "v3", "1/8" ] }