Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/125144/?format=api
{ "id": 125144, "url": "https://patches.dpdk.org/api/patches/125144/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20230315113158.442632-1-maxime.coquelin@redhat.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230315113158.442632-1-maxime.coquelin@redhat.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20230315113158.442632-1-maxime.coquelin@redhat.com", "date": "2023-03-15T11:31:58", "name": "vhost: fix madvise IOTLB entries pages overlap check", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "42ae67ee0e62e0c231f13495b81ba68ef17e2aba", "submitter": { "id": 512, "url": "https://patches.dpdk.org/api/people/512/?format=api", "name": "Maxime Coquelin", "email": "maxime.coquelin@redhat.com" }, "delegate": { "id": 2642, "url": "https://patches.dpdk.org/api/users/2642/?format=api", "username": "mcoquelin", "first_name": "Maxime", "last_name": "Coquelin", "email": "maxime.coquelin@redhat.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20230315113158.442632-1-maxime.coquelin@redhat.com/mbox/", "series": [ { "id": 27401, "url": "https://patches.dpdk.org/api/series/27401/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=27401", "date": "2023-03-15T11:31:58", "name": "vhost: fix madvise IOTLB entries pages overlap check", "version": 1, "mbox": "https://patches.dpdk.org/series/27401/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/125144/comments/", "check": "fail", "checks": "https://patches.dpdk.org/api/patches/125144/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id EC65041E9F;\n\tWed, 15 Mar 2023 12:32:08 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 7ACA740A7A;\n\tWed, 15 Mar 2023 12:32:08 +0100 (CET)", "from us-smtp-delivery-124.mimecast.com\n (us-smtp-delivery-124.mimecast.com [170.10.129.124])\n by mails.dpdk.org (Postfix) with ESMTP id 42AF840141\n for <dev@dpdk.org>; Wed, 15 Mar 2023 12:32:06 +0100 (CET)", "from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com\n [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS\n (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n us-mta-617-oHTr-krJM4qAL3saLoefEg-1; Wed, 15 Mar 2023 07:32:04 -0400", "from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com\n [10.11.54.9])\n (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n (No client certificate requested)\n by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 0DB511C07581;\n Wed, 15 Mar 2023 11:32:04 +0000 (UTC)", "from max-t490s.redhat.com (unknown [10.39.208.23])\n by smtp.corp.redhat.com (Postfix) with ESMTP id D903D492B00;\n Wed, 15 Mar 2023 11:32:02 +0000 (UTC)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1678879925;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding;\n bh=FhAW0H9sZiloVJnXHuvDQ+ux8W3lXyQF0+YbOPx+SSw=;\n b=cQMKoAaBCaG00Clq9IXGYaD6dwX4/un1hOHvKZLN+aKb7t3OP9K7qJYMy1PeCvXGT7sb6M\n f6e+t2XFIwNjsYn55nfJUd46MRm0RaVVA8tFkbvm+cHbwrsi+/o7PI6Lvj/tut/gBj65uC\n tr8mcp81p4oXZOfYaaKH3ATfeRSlINU=", "X-MC-Unique": "oHTr-krJM4qAL3saLoefEg-1", "From": "Maxime Coquelin <maxime.coquelin@redhat.com>", "To": "dev@dpdk.org, mkp@redhat.com, chenbo.xia@intel.com,\n david.marchand@redhat.com", "Cc": "Maxime Coquelin <maxime.coquelin@redhat.com>", "Subject": "[PATCH] vhost: fix madvise IOTLB entries pages overlap check", "Date": "Wed, 15 Mar 2023 12:31:58 +0100", "Message-Id": "<20230315113158.442632-1-maxime.coquelin@redhat.com>", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 3.1 on 10.11.54.9", "X-Mimecast-Spam-Score": "0", "X-Mimecast-Originator": "redhat.com", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain; charset=\"US-ASCII\"; x-default=true", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "At removal time, when testing whether the IOTLB entry has\nshared pages with the previous and next entries in the\ncache, it checks whether the start address of the entry to\nbe removed is on the same page as the start address of the\nnext entry in the cache.\n\nThis is not correct, as an entry could cover several page\nso the end address of the entry to be remove should be\nused. This patch address this issue.\n\nFixes: dea092d0addb (\"vhost: fix madvise arguments alignment\")\n\nSigned-off-by: Maxime Coquelin <maxime.coquelin@redhat.com>\n---\n lib/vhost/iotlb.c | 8 ++++----\n 1 file changed, 4 insertions(+), 4 deletions(-)", "diff": "diff --git a/lib/vhost/iotlb.c b/lib/vhost/iotlb.c\nindex 11785392ac..bfa04a0439 100644\n--- a/lib/vhost/iotlb.c\n+++ b/lib/vhost/iotlb.c\n@@ -182,8 +182,8 @@ vhost_user_iotlb_cache_random_evict(struct virtio_net *dev, struct vhost_virtque\n \t\t\t\t\t(node->uaddr & mask) != (prev_node->uaddr & mask)) {\n \t\t\t\tnext_node = RTE_TAILQ_NEXT(node, next);\n \t\t\t\t/* Don't disable coredump if the next node is in the same page */\n-\t\t\t\tif (next_node == NULL ||\n-\t\t\t\t\t\t(node->uaddr & mask) != (next_node->uaddr & mask))\n+\t\t\t\tif (next_node == NULL || ((node->uaddr + node->size) & mask) !=\n+\t\t\t\t\t\t(next_node->uaddr & mask))\n \t\t\t\t\tmem_set_dump((void *)(uintptr_t)node->uaddr, node->size,\n \t\t\t\t\t\t\tfalse, alignment);\n \t\t\t}\n@@ -287,8 +287,8 @@ vhost_user_iotlb_cache_remove(struct virtio_net *dev, struct vhost_virtqueue *vq\n \t\t\t\t\t(node->uaddr & mask) != (prev_node->uaddr & mask)) {\n \t\t\t\tnext_node = RTE_TAILQ_NEXT(node, next);\n \t\t\t\t/* Don't disable coredump if the next node is in the same page */\n-\t\t\t\tif (next_node == NULL ||\n-\t\t\t\t\t\t(node->uaddr & mask) != (next_node->uaddr & mask))\n+\t\t\t\tif (next_node == NULL || ((node->uaddr + node->size) & mask) !=\n+\t\t\t\t\t\t(next_node->uaddr & mask))\n \t\t\t\t\tmem_set_dump((void *)(uintptr_t)node->uaddr, node->size,\n \t\t\t\t\t\t\tfalse, alignment);\n \t\t\t}\n", "prefixes": [] }