Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/125062/?format=api
{ "id": 125062, "url": "https://patches.dpdk.org/api/patches/125062/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20230313093450.2560058-1-vfialko@marvell.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230313093450.2560058-1-vfialko@marvell.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20230313093450.2560058-1-vfialko@marvell.com", "date": "2023-03-13T09:34:50", "name": "reorder: fix registration of dynamic field in mbuf", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "c1f7045db86cafcc0ab63c18392a615c2a83739c", "submitter": { "id": 2390, "url": "https://patches.dpdk.org/api/people/2390/?format=api", "name": "Volodymyr Fialko", "email": "vfialko@marvell.com" }, "delegate": { "id": 24651, "url": "https://patches.dpdk.org/api/users/24651/?format=api", "username": "dmarchand", "first_name": "David", "last_name": "Marchand", "email": "david.marchand@redhat.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20230313093450.2560058-1-vfialko@marvell.com/mbox/", "series": [ { "id": 27354, "url": "https://patches.dpdk.org/api/series/27354/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=27354", "date": "2023-03-13T09:34:50", "name": "reorder: fix registration of dynamic field in mbuf", "version": 1, "mbox": "https://patches.dpdk.org/series/27354/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/125062/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/125062/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 7C0FB41E86;\n\tMon, 13 Mar 2023 10:35:03 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 102F0406BC;\n\tMon, 13 Mar 2023 10:35:03 +0100 (CET)", "from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com\n [67.231.148.174])\n by mails.dpdk.org (Postfix) with ESMTP id 642A240151\n for <dev@dpdk.org>; Mon, 13 Mar 2023 10:35:01 +0100 (CET)", "from pps.filterd (m0045849.ppops.net [127.0.0.1])\n by mx0a-0016f401.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id\n 32D6ud2r015475; Mon, 13 Mar 2023 02:35:00 -0700", "from dc5-exch01.marvell.com ([199.233.59.181])\n by mx0a-0016f401.pphosted.com (PPS) with ESMTPS id 3p9xxmrjdk-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT);\n Mon, 13 Mar 2023 02:35:00 -0700", "from DC5-EXCH02.marvell.com (10.69.176.39) by DC5-EXCH01.marvell.com\n (10.69.176.38) with Microsoft SMTP Server (TLS) id 15.0.1497.42;\n Mon, 13 Mar 2023 02:34:58 -0700", "from maili.marvell.com (10.69.176.80) by DC5-EXCH02.marvell.com\n (10.69.176.39) with Microsoft SMTP Server id 15.0.1497.42 via Frontend\n Transport; Mon, 13 Mar 2023 02:34:58 -0700", "from cavium-DT10.. (unknown [10.28.34.39])\n by maili.marvell.com (Postfix) with ESMTP id 4C52C3F704A;\n Mon, 13 Mar 2023 02:34:55 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com;\n h=from : to : cc :\n subject : date : message-id : mime-version : content-transfer-encoding :\n content-type; s=pfpt0220; bh=h4+r0/kj4POMc6/GFjUSpTPGz0bI4CZF/ofp1fhr4Dw=;\n b=cAYkhWqfJwZpZ6tf2AGmalrSM4KeWe6Nx8tEG4yD0sTm9owAubSTUh2UQ493XacPPaqm\n ccLwCMQ7QhsIcqAtOq6sNhsp0fWe7mUqTWxhgPeca24xzPKjasXNYLOP5Y6ykim0y43h\n HtkkfZW6NTAYTWfTTqDkByY+VoKzZ1uX6JwOHzcYeO8SKuJNRdE3NsmzcmkeLjZUeHwE\n D9+s4umZ7eM0CYt5N+KCm8bpGf4tMUzJhZZB9DSS+wIuOamVjlQdprzjCMFrYxYPegn5\n sLNbtW0s7sGhXIXp3WIsU6UB5tlAZiok/cTymPZOBqDoluuJiwv0QmnbPN7Gy95EOezw xA==", "From": "Volodymyr Fialko <vfialko@marvell.com>", "To": "<dev@dpdk.org>, Reshma Pattan <reshma.pattan@intel.com>, David Marchand\n <david.marchand@redhat.com>,\n Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>", "CC": "<jerinj@marvell.com>, <anoobj@marvell.com>, Volodymyr Fialko\n <vfialko@marvell.com>", "Subject": "[PATCH] reorder: fix registration of dynamic field in mbuf", "Date": "Mon, 13 Mar 2023 10:34:50 +0100", "Message-ID": "<20230313093450.2560058-1-vfialko@marvell.com>", "X-Mailer": "git-send-email 2.34.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Proofpoint-GUID": "rQS1QLbV8OtgClb1nhj9k5ehfN8UxU-W", "X-Proofpoint-ORIG-GUID": "rQS1QLbV8OtgClb1nhj9k5ehfN8UxU-W", "X-Proofpoint-Virus-Version": "vendor=baseguard\n engine=ICAP:2.0.254,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22\n definitions=2023-03-13_02,2023-03-10_01,2023-02-09_01", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "It's possible to initialize reorder buffer with user allocated memory via\nrte_reorder_init() function. In such case rte_reorder_create() not required\nand reorder dynamic field in rte_mbuf will be not registered.\n\nFixes: 01f3496695b5 (\"reorder: switch sequence number to dynamic mbuf field\")\n\nSigned-off-by: Volodymyr Fialko <vfialko@marvell.com>\n---\n lib/reorder/rte_reorder.c | 40 ++++++++++++++++++++++++++++++---------\n 1 file changed, 31 insertions(+), 9 deletions(-)", "diff": "diff --git a/lib/reorder/rte_reorder.c b/lib/reorder/rte_reorder.c\nindex 6e029c9e02..a759a9c434 100644\n--- a/lib/reorder/rte_reorder.c\n+++ b/lib/reorder/rte_reorder.c\n@@ -54,6 +54,28 @@ struct rte_reorder_buffer {\n static void\n rte_reorder_free_mbufs(struct rte_reorder_buffer *b);\n \n+static int\n+rte_reorder_dynf_register(void)\n+{\n+\tint ret;\n+\n+\tstatic const struct rte_mbuf_dynfield reorder_seqn_dynfield_desc = {\n+\t\t.name = RTE_REORDER_SEQN_DYNFIELD_NAME,\n+\t\t.size = sizeof(rte_reorder_seqn_t),\n+\t\t.align = __alignof__(rte_reorder_seqn_t),\n+\t};\n+\n+\tif (rte_reorder_seqn_dynfield_offset > 0)\n+\t\treturn 0;\n+\n+\tret = rte_mbuf_dynfield_register(&reorder_seqn_dynfield_desc);\n+\tif (ret < 0)\n+\t\treturn ret;\n+\trte_reorder_seqn_dynfield_offset = ret;\n+\n+\treturn 0;\n+}\n+\n struct rte_reorder_buffer *\n rte_reorder_init(struct rte_reorder_buffer *b, unsigned int bufsize,\n \t\tconst char *name, unsigned int size)\n@@ -85,6 +107,12 @@ rte_reorder_init(struct rte_reorder_buffer *b, unsigned int bufsize,\n \t\trte_errno = EINVAL;\n \t\treturn NULL;\n \t}\n+\tif (rte_reorder_dynf_register()) {\n+\t\tRTE_LOG(ERR, REORDER, \"Failed to register mbuf field for reorder sequence\"\n+\t\t\t\t \" number\\n\");\n+\t\trte_errno = ENOMEM;\n+\t\treturn NULL;\n+\t}\n \n \tmemset(b, 0, bufsize);\n \tstrlcpy(b->name, name, sizeof(b->name));\n@@ -106,11 +134,6 @@ rte_reorder_create(const char *name, unsigned socket_id, unsigned int size)\n \tstruct rte_reorder_list *reorder_list;\n \tconst unsigned int bufsize = sizeof(struct rte_reorder_buffer) +\n \t\t\t\t\t(2 * size * sizeof(struct rte_mbuf *));\n-\tstatic const struct rte_mbuf_dynfield reorder_seqn_dynfield_desc = {\n-\t\t.name = RTE_REORDER_SEQN_DYNFIELD_NAME,\n-\t\t.size = sizeof(rte_reorder_seqn_t),\n-\t\t.align = __alignof__(rte_reorder_seqn_t),\n-\t};\n \n \treorder_list = RTE_TAILQ_CAST(rte_reorder_tailq.head, rte_reorder_list);\n \n@@ -128,10 +151,9 @@ rte_reorder_create(const char *name, unsigned socket_id, unsigned int size)\n \t\treturn NULL;\n \t}\n \n-\trte_reorder_seqn_dynfield_offset =\n-\t\trte_mbuf_dynfield_register(&reorder_seqn_dynfield_desc);\n-\tif (rte_reorder_seqn_dynfield_offset < 0) {\n-\t\tRTE_LOG(ERR, REORDER, \"Failed to register mbuf field for reorder sequence number\\n\");\n+\tif (rte_reorder_dynf_register()) {\n+\t\tRTE_LOG(ERR, REORDER, \"Failed to register mbuf field for reorder sequence\"\n+\t\t\t\t \" number\\n\");\n \t\trte_errno = ENOMEM;\n \t\treturn NULL;\n \t}\n", "prefixes": [] }