Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/125050/?format=api
{ "id": 125050, "url": "https://patches.dpdk.org/api/patches/125050/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20230312020009.288-1-baymaxhuang@gmail.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230312020009.288-1-baymaxhuang@gmail.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20230312020009.288-1-baymaxhuang@gmail.com", "date": "2023-03-12T02:00:09", "name": "app/flow-perf: replace RTE_BE32/16 with rte_cpu_to_be_32/16 for variables", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "155bc08ca6dcd127c298c7d583ccf3729f1e6216", "submitter": { "id": 2435, "url": "https://patches.dpdk.org/api/people/2435/?format=api", "name": "Harold Huang", "email": "baymaxhuang@gmail.com" }, "delegate": { "id": 1, "url": "https://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20230312020009.288-1-baymaxhuang@gmail.com/mbox/", "series": [ { "id": 27343, "url": "https://patches.dpdk.org/api/series/27343/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=27343", "date": "2023-03-12T02:00:09", "name": "app/flow-perf: replace RTE_BE32/16 with rte_cpu_to_be_32/16 for variables", "version": 1, "mbox": "https://patches.dpdk.org/series/27343/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/125050/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/125050/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 2D28C41E78;\n\tSun, 12 Mar 2023 03:00:40 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id C7D63406A2;\n\tSun, 12 Mar 2023 03:00:39 +0100 (CET)", "from mail-pf1-f171.google.com (mail-pf1-f171.google.com\n [209.85.210.171])\n by mails.dpdk.org (Postfix) with ESMTP id 6F1ED40395\n for <dev@dpdk.org>; Sun, 12 Mar 2023 03:00:38 +0100 (CET)", "by mail-pf1-f171.google.com with SMTP id bd34so5810983pfb.3\n for <dev@dpdk.org>; Sat, 11 Mar 2023 18:00:38 -0800 (PST)", "from localhost.localdomain ([111.196.243.64])\n by smtp.gmail.com with ESMTPSA id\n i14-20020aa787ce000000b00580d25a2bb2sm1977297pfo.108.2023.03.11.18.00.33\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Sat, 11 Mar 2023 18:00:34 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20210112; t=1678586437;\n h=content-transfer-encoding:mime-version:message-id:date:subject:cc\n :to:from:from:to:cc:subject:date:message-id:reply-to;\n bh=gYX+582dDtXZyaEc8upN9y2EQPwpWtAQkYbds9zWqQM=;\n b=gPFIeN48cifC2r/cp34rJJTjRxtTAIRx4KzBqqZd6wZkEd7LONlF1vLjZ13Y/pg8Ry\n /l/aXJrN6ycd6+42v7fFy8CYS8/6gE2xJUkC2nO1wQxrIsjPo8sH8iq5L/8CHxvkDkFA\n u5zY62mF7B2B4Gb/QLiylKbKiC0zEPHIlRtkjT8grqC1TzX7wU64UIm9IUmHwzw4cp14\n 6f5b56RQxL2vsYFhxW6wggZXvKN1H1vwWRb/lTAhzxol1VMxhNveooIqt/D/fPFaGoa0\n CX5NqiFhdHGZN8AXGwW0Hsql1oYtszSH/YpsLwsaxOFhZF5JQz93qUMBw4xN5AkzvoiK\n MECQ==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20210112; t=1678586437;\n h=content-transfer-encoding:mime-version:message-id:date:subject:cc\n :to:from:x-gm-message-state:from:to:cc:subject:date:message-id\n :reply-to;\n bh=gYX+582dDtXZyaEc8upN9y2EQPwpWtAQkYbds9zWqQM=;\n b=eyttMJCyZeNKBh/j1wk6D9F4tD4IYqGRCFuGNjP6yhqNvLOQSgi6pTadyJ5uvxFruF\n KKiR8802NmPFpcCUtjex8h39GLRxoVpHhXy+PGONU46cG8+jnQyjE3REUIc/psRSs3FH\n Kl/AZbpenEy6HuzFcD2/X72OHVQ6QLuTvXVAEbjwZLSqg14Gn39cgaYr7MP+v24s/aIV\n Iu4yIH6qfcciX0EYnX8JedBfWPdc27HE8fYyVfvJ56MZFsAeEJKiyUR9R5JWEcwKgkby\n mK+h6GIxJSuxRP0D6ja6KHli5PEaOYiV05+0zZZKVTSr0hk7XOVL++QU/+nfm7H3L95f\n HYmQ==", "X-Gm-Message-State": "AO0yUKWoweZSmNdAjiSUZQZNgwt6w2yjvWUqSNBnnGvAbvHEjW6v00TM\n 8IJ+m9TRFKLhs6FHRCS24iy2WUn6AGiZYLll", "X-Google-Smtp-Source": "\n AK7set/qos2fO6xPkdhTYBmowRxzQqTWtaUo6ecXbDpocvNtT+NHD2XgiZmTS7OJdIOp7Ea1lMBPaw==", "X-Received": "by 2002:aa7:9ad0:0:b0:5b6:c62e:7d4f with SMTP id\n x16-20020aa79ad0000000b005b6c62e7d4fmr24719656pfp.8.1678586437372;\n Sat, 11 Mar 2023 18:00:37 -0800 (PST)", "From": "Harold Huang <baymaxhuang@gmail.com>", "To": "dev@dpdk.org", "Cc": "Harold Huang <baymaxhuang@gmail.com>,\n\tWisam Jaddo <wisamm@nvidia.com>", "Subject": "[PATCH] app/flow-perf: replace RTE_BE32/16 with rte_cpu_to_be_32/16\n for variables", "Date": "Sun, 12 Mar 2023 02:00:09 +0000", "Message-Id": "<20230312020009.288-1-baymaxhuang@gmail.com>", "X-Mailer": "git-send-email 2.27.0", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "In DPDK, the macros RTE_BE32 or RTE_BE16 are usually used for\nconstant values. And functions such as rte_cpu_to_be_32 or\nrte_cpu_to_be_16 are optimized for variables.\n\nSigned-off-by: Harold Huang <baymaxhuang@gmail.com>\n---\n app/test-flow-perf/actions_gen.c | 28 ++++++++++++++--------------\n app/test-flow-perf/items_gen.c | 2 +-\n 2 files changed, 15 insertions(+), 15 deletions(-)", "diff": "diff --git a/app/test-flow-perf/actions_gen.c b/app/test-flow-perf/actions_gen.c\nindex f1d5931325..c2499ad2d0 100644\n--- a/app/test-flow-perf/actions_gen.c\n+++ b/app/test-flow-perf/actions_gen.c\n@@ -262,7 +262,7 @@ add_set_src_ipv4(struct rte_flow_action *actions,\n \t\tip = 1;\n \n \t/* IPv4 value to be set is random each time */\n-\tset_ipv4[para.core_idx].ipv4_addr = RTE_BE32(ip + 1);\n+\tset_ipv4[para.core_idx].ipv4_addr = rte_cpu_to_be_32(ip + 1);\n \n \tactions[actions_counter].type = RTE_FLOW_ACTION_TYPE_SET_IPV4_SRC;\n \tactions[actions_counter].conf = &set_ipv4[para.core_idx];\n@@ -281,7 +281,7 @@ add_set_dst_ipv4(struct rte_flow_action *actions,\n \t\tip = 1;\n \n \t/* IPv4 value to be set is random each time */\n-\tset_ipv4[para.core_idx].ipv4_addr = RTE_BE32(ip + 1);\n+\tset_ipv4[para.core_idx].ipv4_addr = rte_cpu_to_be_32(ip + 1);\n \n \tactions[actions_counter].type = RTE_FLOW_ACTION_TYPE_SET_IPV4_DST;\n \tactions[actions_counter].conf = &set_ipv4[para.core_idx];\n@@ -348,7 +348,7 @@ add_set_src_tp(struct rte_flow_action *actions,\n \t/* TP src port is random each time */\n \ttp = tp % 0xffff;\n \n-\tset_tp[para.core_idx].port = RTE_BE16(tp & 0xffff);\n+\tset_tp[para.core_idx].port = rte_cpu_to_be_16(tp & 0xffff);\n \n \tactions[actions_counter].type = RTE_FLOW_ACTION_TYPE_SET_TP_SRC;\n \tactions[actions_counter].conf = &set_tp[para.core_idx];\n@@ -370,7 +370,7 @@ add_set_dst_tp(struct rte_flow_action *actions,\n \tif (tp > 0xffff)\n \t\ttp = tp >> 16;\n \n-\tset_tp[para.core_idx].port = RTE_BE16(tp & 0xffff);\n+\tset_tp[para.core_idx].port = rte_cpu_to_be_16(tp & 0xffff);\n \n \tactions[actions_counter].type = RTE_FLOW_ACTION_TYPE_SET_TP_DST;\n \tactions[actions_counter].conf = &set_tp[para.core_idx];\n@@ -388,7 +388,7 @@ add_inc_tcp_ack(struct rte_flow_action *actions,\n \tif (!para.unique_data)\n \t\tack_value = 1;\n \n-\tvalue[para.core_idx] = RTE_BE32(ack_value);\n+\tvalue[para.core_idx] = rte_cpu_to_be_32(ack_value);\n \n \tactions[actions_counter].type = RTE_FLOW_ACTION_TYPE_INC_TCP_ACK;\n \tactions[actions_counter].conf = &value[para.core_idx];\n@@ -406,7 +406,7 @@ add_dec_tcp_ack(struct rte_flow_action *actions,\n \tif (!para.unique_data)\n \t\tack_value = 1;\n \n-\tvalue[para.core_idx] = RTE_BE32(ack_value);\n+\tvalue[para.core_idx] = rte_cpu_to_be_32(ack_value);\n \n \tactions[actions_counter].type = RTE_FLOW_ACTION_TYPE_DEC_TCP_ACK;\n \tactions[actions_counter].conf = &value[para.core_idx];\n@@ -424,7 +424,7 @@ add_inc_tcp_seq(struct rte_flow_action *actions,\n \tif (!para.unique_data)\n \t\tseq_value = 1;\n \n-\tvalue[para.core_idx] = RTE_BE32(seq_value);\n+\tvalue[para.core_idx] = rte_cpu_to_be_32(seq_value);\n \n \tactions[actions_counter].type = RTE_FLOW_ACTION_TYPE_INC_TCP_SEQ;\n \tactions[actions_counter].conf = &value[para.core_idx];\n@@ -442,7 +442,7 @@ add_dec_tcp_seq(struct rte_flow_action *actions,\n \tif (!para.unique_data)\n \t\tseq_value = 1;\n \n-\tvalue[para.core_idx] = RTE_BE32(seq_value);\n+\tvalue[para.core_idx] = rte_cpu_to_be_32(seq_value);\n \n \tactions[actions_counter].type = RTE_FLOW_ACTION_TYPE_DEC_TCP_SEQ;\n \tactions[actions_counter].conf = &value[para.core_idx];\n@@ -560,7 +560,7 @@ add_vlan_header(uint8_t **header, uint64_t data,\n \tvlan_value = VLAN_VALUE;\n \n \tmemset(&vlan_hdr, 0, sizeof(struct rte_vlan_hdr));\n-\tvlan_hdr.vlan_tci = RTE_BE16(vlan_value);\n+\tvlan_hdr.vlan_tci = rte_cpu_to_be_16(vlan_value);\n \n \tif (data & FLOW_ITEM_MASK(RTE_FLOW_ITEM_TYPE_IPV4))\n \t\tvlan_hdr.eth_proto = RTE_BE16(RTE_ETHER_TYPE_IPV4);\n@@ -586,7 +586,7 @@ add_ipv4_header(uint8_t **header, uint64_t data,\n \n \tmemset(&ipv4_hdr, 0, sizeof(struct rte_ipv4_hdr));\n \tipv4_hdr.src_addr = RTE_IPV4(127, 0, 0, 1);\n-\tipv4_hdr.dst_addr = RTE_BE32(ip_dst);\n+\tipv4_hdr.dst_addr = rte_cpu_to_be_32(ip_dst);\n \tipv4_hdr.version_ihl = RTE_IPV4_VHL_DEF;\n \tif (data & FLOW_ITEM_MASK(RTE_FLOW_ITEM_TYPE_UDP))\n \t\tipv4_hdr.next_proto_id = RTE_IP_TYPE_UDP;\n@@ -652,7 +652,7 @@ add_vxlan_header(uint8_t **header, uint64_t data,\n \n \tmemset(&vxlan_hdr, 0, sizeof(struct rte_vxlan_hdr));\n \n-\tvxlan_hdr.vx_vni = (RTE_BE32(vni_value)) >> 16;\n+\tvxlan_hdr.vx_vni = (rte_cpu_to_be_32(vni_value)) >> 16;\n \tvxlan_hdr.vx_flags = 0x8;\n \n \tmemcpy(*header, &vxlan_hdr, sizeof(vxlan_hdr));\n@@ -675,7 +675,7 @@ add_vxlan_gpe_header(uint8_t **header, uint64_t data,\n \n \tmemset(&vxlan_gpe_hdr, 0, sizeof(struct rte_vxlan_gpe_hdr));\n \n-\tvxlan_gpe_hdr.vx_vni = (RTE_BE32(vni_value)) >> 16;\n+\tvxlan_gpe_hdr.vx_vni = (rte_cpu_to_be_32(vni_value)) >> 16;\n \tvxlan_gpe_hdr.vx_flags = 0x0c;\n \n \tmemcpy(*header, &vxlan_gpe_hdr, sizeof(vxlan_gpe_hdr));\n@@ -739,7 +739,7 @@ add_gtp_header(uint8_t **header, uint64_t data,\n \n \tmemset(>p_hdr, 0, sizeof(struct rte_flow_item_gtp));\n \n-\tgtp_hdr.teid = RTE_BE32(teid_value);\n+\tgtp_hdr.teid = rte_cpu_to_be_32(teid_value);\n \tgtp_hdr.msg_type = 255;\n \n \tmemcpy(*header, >p_hdr, sizeof(gtp_hdr));\n@@ -861,7 +861,7 @@ add_vxlan_encap(struct rte_flow_action *actions,\n \titems[0].type = RTE_FLOW_ITEM_TYPE_ETH;\n \n \titem_ipv4.hdr.src_addr = RTE_IPV4(127, 0, 0, 1);\n-\titem_ipv4.hdr.dst_addr = RTE_BE32(ip_dst);\n+\titem_ipv4.hdr.dst_addr = rte_cpu_to_be_32(ip_dst);\n \titem_ipv4.hdr.version_ihl = RTE_IPV4_VHL_DEF;\n \titems[1].spec = &item_ipv4;\n \titems[1].mask = &item_ipv4;\ndiff --git a/app/test-flow-perf/items_gen.c b/app/test-flow-perf/items_gen.c\nindex 85928349ee..b4aa1cfc9c 100644\n--- a/app/test-flow-perf/items_gen.c\n+++ b/app/test-flow-perf/items_gen.c\n@@ -56,7 +56,7 @@ add_ipv4(struct rte_flow_item *items,\n \tstatic struct rte_flow_item_ipv4 ipv4_masks[RTE_MAX_LCORE] __rte_cache_aligned;\n \tuint8_t ti = para.core_idx;\n \n-\tipv4_specs[ti].hdr.src_addr = RTE_BE32(para.src_ip);\n+\tipv4_specs[ti].hdr.src_addr = rte_cpu_to_be_32(para.src_ip);\n \tipv4_masks[ti].hdr.src_addr = RTE_BE32(0xffffffff);\n \n \titems[items_counter].type = RTE_FLOW_ITEM_TYPE_IPV4;\n", "prefixes": [] }