Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/124985/?format=api
{ "id": 124985, "url": "https://patches.dpdk.org/api/patches/124985/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20230310082015.20200-34-syalavarthi@marvell.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230310082015.20200-34-syalavarthi@marvell.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20230310082015.20200-34-syalavarthi@marvell.com", "date": "2023-03-10T08:20:09", "name": "[v6,33/39] ml/cnxk: add support to report DPE FW warnings", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "74bf81212b06eb6c54d0cc1f254beb83fad7608a", "submitter": { "id": 2480, "url": "https://patches.dpdk.org/api/people/2480/?format=api", "name": "Srikanth Yalavarthi", "email": "syalavarthi@marvell.com" }, "delegate": { "id": 310, "url": "https://patches.dpdk.org/api/users/310/?format=api", "username": "jerin", "first_name": "Jerin", "last_name": "Jacob", "email": "jerinj@marvell.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20230310082015.20200-34-syalavarthi@marvell.com/mbox/", "series": [ { "id": 27325, "url": "https://patches.dpdk.org/api/series/27325/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=27325", "date": "2023-03-10T08:19:36", "name": "Implementation of ML CNXK driver", "version": 6, "mbox": "https://patches.dpdk.org/series/27325/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/124985/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/124985/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 3836041DD0;\n\tFri, 10 Mar 2023 09:24:30 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 4A68842FD6;\n\tFri, 10 Mar 2023 09:21:15 +0100 (CET)", "from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com\n [67.231.148.174])\n by mails.dpdk.org (Postfix) with ESMTP id 57C2542D2C\n for <dev@dpdk.org>; Fri, 10 Mar 2023 09:20:38 +0100 (CET)", "from pps.filterd (m0045849.ppops.net [127.0.0.1])\n by mx0a-0016f401.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id\n 32A7WbXJ003211 for <dev@dpdk.org>; Fri, 10 Mar 2023 00:20:37 -0800", "from dc5-exch01.marvell.com ([199.233.59.181])\n by mx0a-0016f401.pphosted.com (PPS) with ESMTPS id 3p7n7dj0bf-4\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT)\n for <dev@dpdk.org>; Fri, 10 Mar 2023 00:20:37 -0800", "from DC5-EXCH01.marvell.com (10.69.176.38) by DC5-EXCH01.marvell.com\n (10.69.176.38) with Microsoft SMTP Server (TLS) id 15.0.1497.42;\n Fri, 10 Mar 2023 00:20:25 -0800", "from maili.marvell.com (10.69.176.80) by DC5-EXCH01.marvell.com\n (10.69.176.38) with Microsoft SMTP Server id 15.0.1497.42 via Frontend\n Transport; Fri, 10 Mar 2023 00:20:25 -0800", "from ml-host-33.caveonetworks.com (unknown [10.110.143.233])\n by maili.marvell.com (Postfix) with ESMTP id CC4785C68ED;\n Fri, 10 Mar 2023 00:20:23 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com;\n h=from : to : cc :\n subject : date : message-id : in-reply-to : references : mime-version :\n content-type; s=pfpt0220; bh=bQid8g7/TgRhAVCXeUZsdULRHG2l4aU4Wt668oxEs5I=;\n b=E+nGD/RRaxIU+HeQ/AryVLbTKmpwUC8siOxyRQBbz8aEDmQn+5FciQe5plbZXOYDWVIk\n HcONSOzBju6MmDuqt2aW+VeQZdZYwP5tphuDU3g3kVbXq5O3YAllehguXkfBr4a+vzV0\n yNVpqbpISNS7RaFjBaHjpK8iLPzYKoShhL4qY1hS+9UoGWZMai2I3CBnxXCIXtxfdMXO\n 02D3mBQnaG2fOJFVxM0GiXaldV0oFDuO+fOgrupNMBNzjEBFPbToPad6/6nTidA+oL0o\n EdnnIM/CyE4VQ6usLtCgyRWWkdNKi+VqMJFE+jS2MxtkSbA7r5h5Tx5hegOj/c/+llOL Aw==", "From": "Srikanth Yalavarthi <syalavarthi@marvell.com>", "To": "Srikanth Yalavarthi <syalavarthi@marvell.com>", "CC": "<dev@dpdk.org>, <sshankarnara@marvell.com>, <jerinj@marvell.com>,\n <aprabhu@marvell.com>, <ptakkar@marvell.com>, <pshukla@marvell.com>", "Subject": "[PATCH v6 33/39] ml/cnxk: add support to report DPE FW warnings", "Date": "Fri, 10 Mar 2023 00:20:09 -0800", "Message-ID": "<20230310082015.20200-34-syalavarthi@marvell.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20230310082015.20200-1-syalavarthi@marvell.com>", "References": "<20221208200220.20267-1-syalavarthi@marvell.com>\n <20230310082015.20200-1-syalavarthi@marvell.com>", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-Proofpoint-GUID": "Xx6ojhQLZO_2TeFD0G9FMtSHDAmys9mq", "X-Proofpoint-ORIG-GUID": "Xx6ojhQLZO_2TeFD0G9FMtSHDAmys9mq", "X-Proofpoint-Virus-Version": "vendor=baseguard\n engine=ICAP:2.0.254,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22\n definitions=2023-03-10_02,2023-03-09_01,2023-02-09_01", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Enabled support to enable and report DPE warnings from ML\nfirmware. Configure firmware load flags based on the device\narguments.\n\nDefault values:\n\tenable_dpe_errors = 1\n\treport_dpe_errors = 0\n\nSigned-off-by: Srikanth Yalavarthi <syalavarthi@marvell.com>\n---\n drivers/ml/cnxk/cn10k_ml_dev.c | 94 +++++++++++++++++++++++++++++++---\n drivers/ml/cnxk/cn10k_ml_dev.h | 6 +++\n 2 files changed, 93 insertions(+), 7 deletions(-)", "diff": "diff --git a/drivers/ml/cnxk/cn10k_ml_dev.c b/drivers/ml/cnxk/cn10k_ml_dev.c\nindex 76ed853a3c..ac6592891b 100644\n--- a/drivers/ml/cnxk/cn10k_ml_dev.c\n+++ b/drivers/ml/cnxk/cn10k_ml_dev.c\n@@ -17,9 +17,13 @@\n #include \"cn10k_ml_dev.h\"\n #include \"cn10k_ml_ops.h\"\n \n-#define CN10K_ML_FW_PATH \"fw_path\"\n+#define CN10K_ML_FW_PATH\t\t\"fw_path\"\n+#define CN10K_ML_FW_ENABLE_DPE_WARNINGS \"enable_dpe_warnings\"\n+#define CN10K_ML_FW_REPORT_DPE_WARNINGS \"report_dpe_warnings\"\n \n-#define CN10K_ML_FW_PATH_DEFAULT \"/lib/firmware/mlip-fw.bin\"\n+#define CN10K_ML_FW_PATH_DEFAULT\t\t\"/lib/firmware/mlip-fw.bin\"\n+#define CN10K_ML_FW_ENABLE_DPE_WARNINGS_DEFAULT 1\n+#define CN10K_ML_FW_REPORT_DPE_WARNINGS_DEFAULT 0\n \n /* ML firmware macros */\n #define FW_MEMZONE_NAME\t\t \"ml_cn10k_fw_mz\"\n@@ -28,9 +32,13 @@\n #define FW_EXCEPTION_BUFFER_SIZE 0x400\n #define FW_LINKER_OFFSET\t 0x80000\n #define FW_WAIT_CYCLES\t\t 100\n-#define FW_LOAD_FLAGS\t\t 0x1\n \n-static const char *const valid_args[] = {CN10K_ML_FW_PATH, NULL};\n+/* Firmware flags */\n+#define FW_ENABLE_DPE_WARNING_BITMASK BIT(0)\n+#define FW_REPORT_DPE_WARNING_BITMASK BIT(1)\n+\n+static const char *const valid_args[] = {CN10K_ML_FW_PATH, CN10K_ML_FW_ENABLE_DPE_WARNINGS,\n+\t\t\t\t\t CN10K_ML_FW_REPORT_DPE_WARNINGS, NULL};\n \n /* Dummy operations for ML device */\n struct rte_ml_dev_ops ml_dev_dummy_ops = {0};\n@@ -49,9 +57,25 @@ parse_string_arg(const char *key __rte_unused, const char *value, void *extra_ar\n \treturn 0;\n }\n \n+static int\n+parse_integer_arg(const char *key __rte_unused, const char *value, void *extra_args)\n+{\n+\tint *i = (int *)extra_args;\n+\n+\t*i = atoi(value);\n+\tif (*i < 0) {\n+\t\tplt_err(\"Argument has to be positive.\");\n+\t\treturn -EINVAL;\n+\t}\n+\n+\treturn 0;\n+}\n+\n static int\n cn10k_mldev_parse_devargs(struct rte_devargs *devargs, struct cn10k_ml_dev *mldev)\n {\n+\tbool enable_dpe_warnings_set = false;\n+\tbool report_dpe_warnings_set = false;\n \tstruct rte_kvargs *kvlist = NULL;\n \tbool fw_path_set = false;\n \tchar *fw_path = NULL;\n@@ -76,6 +100,30 @@ cn10k_mldev_parse_devargs(struct rte_devargs *devargs, struct cn10k_ml_dev *mlde\n \t\tfw_path_set = true;\n \t}\n \n+\tif (rte_kvargs_count(kvlist, CN10K_ML_FW_ENABLE_DPE_WARNINGS) == 1) {\n+\t\tret = rte_kvargs_process(kvlist, CN10K_ML_FW_ENABLE_DPE_WARNINGS,\n+\t\t\t\t\t &parse_integer_arg, &mldev->fw.enable_dpe_warnings);\n+\t\tif (ret < 0) {\n+\t\t\tplt_err(\"Error processing arguments, key = %s\\n\",\n+\t\t\t\tCN10K_ML_FW_ENABLE_DPE_WARNINGS);\n+\t\t\tret = -EINVAL;\n+\t\t\tgoto exit;\n+\t\t}\n+\t\tenable_dpe_warnings_set = true;\n+\t}\n+\n+\tif (rte_kvargs_count(kvlist, CN10K_ML_FW_REPORT_DPE_WARNINGS) == 1) {\n+\t\tret = rte_kvargs_process(kvlist, CN10K_ML_FW_REPORT_DPE_WARNINGS,\n+\t\t\t\t\t &parse_integer_arg, &mldev->fw.report_dpe_warnings);\n+\t\tif (ret < 0) {\n+\t\t\tplt_err(\"Error processing arguments, key = %s\\n\",\n+\t\t\t\tCN10K_ML_FW_REPORT_DPE_WARNINGS);\n+\t\t\tret = -EINVAL;\n+\t\t\tgoto exit;\n+\t\t}\n+\t\treport_dpe_warnings_set = true;\n+\t}\n+\n check_args:\n \tif (!fw_path_set)\n \t\tmldev->fw.path = CN10K_ML_FW_PATH_DEFAULT;\n@@ -83,6 +131,30 @@ cn10k_mldev_parse_devargs(struct rte_devargs *devargs, struct cn10k_ml_dev *mlde\n \t\tmldev->fw.path = fw_path;\n \tplt_info(\"ML: %s = %s\", CN10K_ML_FW_PATH, mldev->fw.path);\n \n+\tif (!enable_dpe_warnings_set) {\n+\t\tmldev->fw.enable_dpe_warnings = CN10K_ML_FW_ENABLE_DPE_WARNINGS_DEFAULT;\n+\t} else {\n+\t\tif ((mldev->fw.enable_dpe_warnings < 0) || (mldev->fw.enable_dpe_warnings > 1)) {\n+\t\t\tplt_err(\"Invalid argument, %s = %d\\n\", CN10K_ML_FW_ENABLE_DPE_WARNINGS,\n+\t\t\t\tmldev->fw.enable_dpe_warnings);\n+\t\t\tret = -EINVAL;\n+\t\t\tgoto exit;\n+\t\t}\n+\t}\n+\tplt_info(\"ML: %s = %d\", CN10K_ML_FW_ENABLE_DPE_WARNINGS, mldev->fw.enable_dpe_warnings);\n+\n+\tif (!report_dpe_warnings_set) {\n+\t\tmldev->fw.report_dpe_warnings = CN10K_ML_FW_REPORT_DPE_WARNINGS_DEFAULT;\n+\t} else {\n+\t\tif ((mldev->fw.report_dpe_warnings < 0) || (mldev->fw.report_dpe_warnings > 1)) {\n+\t\t\tplt_err(\"Invalid argument, %s = %d\\n\", CN10K_ML_FW_REPORT_DPE_WARNINGS,\n+\t\t\t\tmldev->fw.report_dpe_warnings);\n+\t\t\tret = -EINVAL;\n+\t\t\tgoto exit;\n+\t\t}\n+\t}\n+\tplt_info(\"ML: %s = %d\", CN10K_ML_FW_REPORT_DPE_WARNINGS, mldev->fw.report_dpe_warnings);\n+\n exit:\n \tif (kvlist)\n \t\trte_kvargs_free(kvlist);\n@@ -208,9 +280,15 @@ cn10k_ml_fw_print_info(struct cn10k_ml_fw *fw)\n uint64_t\n cn10k_ml_fw_flags_get(struct cn10k_ml_fw *fw)\n {\n-\tPLT_SET_USED(fw);\n+\tuint64_t flags = 0x0;\n+\n+\tif (fw->enable_dpe_warnings)\n+\t\tflags = flags | FW_ENABLE_DPE_WARNING_BITMASK;\n+\n+\tif (fw->report_dpe_warnings)\n+\t\tflags = flags | FW_REPORT_DPE_WARNING_BITMASK;\n \n-\treturn FW_LOAD_FLAGS;\n+\treturn flags;\n }\n \n static int\n@@ -614,4 +692,6 @@ RTE_PMD_REGISTER_PCI(MLDEV_NAME_CN10K_PMD, cn10k_mldev_pmd);\n RTE_PMD_REGISTER_PCI_TABLE(MLDEV_NAME_CN10K_PMD, pci_id_ml_table);\n RTE_PMD_REGISTER_KMOD_DEP(MLDEV_NAME_CN10K_PMD, \"vfio-pci\");\n \n-RTE_PMD_REGISTER_PARAM_STRING(MLDEV_NAME_CN10K_PMD, CN10K_ML_FW_PATH \"=<path>\");\n+RTE_PMD_REGISTER_PARAM_STRING(MLDEV_NAME_CN10K_PMD,\n+\t\t\t CN10K_ML_FW_PATH \"=<path>\" CN10K_ML_FW_ENABLE_DPE_WARNINGS\n+\t\t\t\t\t \"=<0|1>\" CN10K_ML_FW_REPORT_DPE_WARNINGS \"=<0|1>\");\ndiff --git a/drivers/ml/cnxk/cn10k_ml_dev.h b/drivers/ml/cnxk/cn10k_ml_dev.h\nindex b7ff369ba8..9ba56ffba6 100644\n--- a/drivers/ml/cnxk/cn10k_ml_dev.h\n+++ b/drivers/ml/cnxk/cn10k_ml_dev.h\n@@ -349,6 +349,12 @@ struct cn10k_ml_fw {\n \t/* Firmware file path */\n \tconst char *path;\n \n+\t/* Enable DPE warnings */\n+\tint enable_dpe_warnings;\n+\n+\t/* Report DPE warnings */\n+\tint report_dpe_warnings;\n+\n \t/* Data buffer */\n \tuint8_t *data;\n \n", "prefixes": [ "v6", "33/39" ] }