Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/124885/?format=api
https://patches.dpdk.org/api/patches/124885/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20230309045738.1261000-5-honnappa.nagarahalli@arm.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230309045738.1261000-5-honnappa.nagarahalli@arm.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20230309045738.1261000-5-honnappa.nagarahalli@arm.com", "date": "2023-03-09T04:57:38", "name": "[4/4] mempool: use lcore API to check if lcore ID is valid", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": false, "hash": "e36d1893b2208b904441e5bcc5c30a2ec94f9a52", "submitter": { "id": 1045, "url": "https://patches.dpdk.org/api/people/1045/?format=api", "name": "Honnappa Nagarahalli", "email": "honnappa.nagarahalli@arm.com" }, "delegate": { "id": 1, "url": "https://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20230309045738.1261000-5-honnappa.nagarahalli@arm.com/mbox/", "series": [ { "id": 27298, "url": "https://patches.dpdk.org/api/series/27298/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=27298", "date": "2023-03-09T04:57:34", "name": "Small corrections in mempool", "version": 1, "mbox": "https://patches.dpdk.org/series/27298/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/124885/comments/", "check": "fail", "checks": "https://patches.dpdk.org/api/patches/124885/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 86B7141E2F;\n\tThu, 9 Mar 2023 05:58:14 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id D7C4C42C76;\n\tThu, 9 Mar 2023 05:58:02 +0100 (CET)", "from foss.arm.com (foss.arm.com [217.140.110.172])\n by mails.dpdk.org (Postfix) with ESMTP id 20D844161A\n for <dev@dpdk.org>; Thu, 9 Mar 2023 05:57:58 +0100 (CET)", "from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])\n by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 231FF1756;\n Wed, 8 Mar 2023 20:58:41 -0800 (PST)", "from 2p2660v4-1.austin.arm.com (2p2660v4-1.austin.arm.com\n [10.118.14.10])\n by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 850D93F67D;\n Wed, 8 Mar 2023 20:57:57 -0800 (PST)" ], "From": "Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>", "To": "mb@smartsharesystems.com, olivier.matz@6wind.com,\n konstantin.v.ananyev@yandex.ru", "Cc": "dev@dpdk.org, honnappa.nagarahalli@arm.com, ruifeng.wang@arm.com,\n kamalakshitha.aligeri@arm.com, wathsala.vithanage@arm.com, nd@arm.com", "Subject": "[PATCH 4/4] mempool: use lcore API to check if lcore ID is valid", "Date": "Wed, 8 Mar 2023 22:57:38 -0600", "Message-Id": "<20230309045738.1261000-5-honnappa.nagarahalli@arm.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20230309045738.1261000-1-honnappa.nagarahalli@arm.com>", "References": "<20230309045738.1261000-1-honnappa.nagarahalli@arm.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Use lcore API to check if the lcore ID is valid. The runtime\ncheck does not add much value. Hence use assert to validate\nthe lcore ID.\n\nSigned-off-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>\nReviewed-by: Wathsala Vithanage <wathsala.vithanage@arm.com>\nReviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>\n---\n lib/mempool/rte_mempool.h | 5 ++---\n 1 file changed, 2 insertions(+), 3 deletions(-)", "diff": "diff --git a/lib/mempool/rte_mempool.h b/lib/mempool/rte_mempool.h\nindex 009bd10215..00c5aa961b 100644\n--- a/lib/mempool/rte_mempool.h\n+++ b/lib/mempool/rte_mempool.h\n@@ -1314,10 +1314,9 @@ rte_mempool_cache_free(struct rte_mempool_cache *cache);\n static __rte_always_inline struct rte_mempool_cache *\n rte_mempool_default_cache(struct rte_mempool *mp, unsigned lcore_id)\n {\n-\tif (mp->cache_size == 0)\n-\t\treturn NULL;\n+\tRTE_ASSERT(rte_lcore_id_is_valid(lcore_id));\n \n-\tif (lcore_id >= RTE_MAX_LCORE)\n+\tif (mp->cache_size == 0)\n \t\treturn NULL;\n \n \trte_mempool_trace_default_cache(mp, lcore_id,\n", "prefixes": [ "4/4" ] }{ "id": 124885, "url": "