Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/124757/?format=api
{ "id": 124757, "url": "https://patches.dpdk.org/api/patches/124757/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20230303045226.1927885-1-kaiwenx.deng@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230303045226.1927885-1-kaiwenx.deng@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20230303045226.1927885-1-kaiwenx.deng@intel.com", "date": "2023-03-03T04:52:26", "name": "net/ixgbe: fix IPv6 mask in fdir", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "c419084ff38790b3c8d5e450d1671edb8410b29a", "submitter": { "id": 2886, "url": "https://patches.dpdk.org/api/people/2886/?format=api", "name": "Kaiwen Deng", "email": "kaiwenx.deng@intel.com" }, "delegate": { "id": 1540, "url": "https://patches.dpdk.org/api/users/1540/?format=api", "username": "qzhan15", "first_name": "Qi", "last_name": "Zhang", "email": "qi.z.zhang@intel.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20230303045226.1927885-1-kaiwenx.deng@intel.com/mbox/", "series": [ { "id": 27236, "url": "https://patches.dpdk.org/api/series/27236/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=27236", "date": "2023-03-03T04:52:26", "name": "net/ixgbe: fix IPv6 mask in fdir", "version": 1, "mbox": "https://patches.dpdk.org/series/27236/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/124757/comments/", "check": "fail", "checks": "https://patches.dpdk.org/api/patches/124757/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 6AFEF41DBF;\n\tFri, 3 Mar 2023 06:24:39 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 460E1410D0;\n\tFri, 3 Mar 2023 06:24:39 +0100 (CET)", "from mga18.intel.com (mga18.intel.com [134.134.136.126])\n by mails.dpdk.org (Postfix) with ESMTP id 9078640687;\n Fri, 3 Mar 2023 06:24:37 +0100 (CET)", "from fmsmga008.fm.intel.com ([10.253.24.58])\n by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 02 Mar 2023 21:24:36 -0800", "from shwdenpg561.ccr.corp.intel.com (HELO dpdk..) ([10.239.252.3])\n by fmsmga008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 02 Mar 2023 21:24:33 -0800" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1677821077; x=1709357077;\n h=from:to:cc:subject:date:message-id:mime-version:\n content-transfer-encoding;\n bh=V3SbR+wWZVEHkqIG5fU0zAl8l5tDELxSvnuGZbSfmAQ=;\n b=Rfv9Emq9ZltFXYSuvZ2+boTSQCYZQzxxjcBiJ9zZzXj9chZBJdUFPYZH\n 7Vr/b2SnC6Wy1luY20n/DtKFCcPuKDJdwJjSH4BhHZhM0VbnFIsm2DN6B\n SNhzJvHbLadKQDbAAE7Hxa4xPr/lM9w1z1j724HLzLRLmFoG6rASY6Pxo\n 3Qus+BDmfYvSFXMbIyC395W4YiEEghbX9mHbGpPjH+RqBBrguYdpfju73\n Y/ojRNLS/u9FOorMrhAuV475Duc0Kt0qmNEsijIfHOcAug1eJkfvD7xvY\n wlMeXudtiWFmuhV7DlgdglZc54fCSuhMOkJ5/AypyS726CC6K/iaPGcbM Q==;", "X-IronPort-AV": [ "E=McAfee;i=\"6500,9779,10637\"; a=\"318781975\"", "E=Sophos;i=\"5.98,229,1673942400\"; d=\"scan'208\";a=\"318781975\"", "E=McAfee;i=\"6500,9779,10637\"; a=\"739373886\"", "E=Sophos;i=\"5.98,229,1673942400\"; d=\"scan'208\";a=\"739373886\"" ], "X-ExtLoop1": "1", "From": "Kaiwen Deng <kaiwenx.deng@intel.com>", "To": "dev@dpdk.org", "Cc": "stable@dpdk.org, qiming.yang@intel.com, yidingx.zhou@intel.com,\n Kaiwen Deng <kaiwenx.deng@intel.com>, Wenjun Wu <wenjun1.wu@intel.com>,\n Qi Zhang <qi.z.zhang@intel.com>, Wenzhuo Lu <wenzhuo.lu@intel.com>", "Subject": "[PATCH] net/ixgbe: fix IPv6 mask in fdir", "Date": "Fri, 3 Mar 2023 12:52:26 +0800", "Message-Id": "<20230303045226.1927885-1-kaiwenx.deng@intel.com>", "X-Mailer": "git-send-email 2.34.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Rules without addr mask cannot be created together in ixgbe\nwhen setting IPv6 addr mask to default value as 0.\n\nThis commit is to change the default value of IPv6 addr mask as '0xFF'.\n\nFixes: cba954b7beda (\"net/ixgbe: enable IPv6 mask in flow rules\")\nFixes: 7d629cacedee (\"net/ixgbe: enable IPv6 for consistent API\")\nCc: stable@dpdk.org\n\nSigned-off-by: Kaiwen Deng <kaiwenx.deng@intel.com>\n---\n drivers/net/ixgbe/ixgbe_flow.c | 16 ++++++----------\n 1 file changed, 6 insertions(+), 10 deletions(-)", "diff": "diff --git a/drivers/net/ixgbe/ixgbe_flow.c b/drivers/net/ixgbe/ixgbe_flow.c\nindex 79c84044af..eac81ee489 100644\n--- a/drivers/net/ixgbe/ixgbe_flow.c\n+++ b/drivers/net/ixgbe/ixgbe_flow.c\n@@ -1645,10 +1645,6 @@ ixgbe_parse_fdir_filter_normal(struct rte_eth_dev *dev,\n \tmemset(&rule->mask, 0xFF, sizeof(struct ixgbe_hw_fdir_mask));\n \trule->mask.vlan_tci_mask = 0;\n \trule->mask.flex_bytes_mask = 0;\n-\trule->mask.dst_port_mask = 0;\n-\trule->mask.src_port_mask = 0;\n-\trule->mask.src_ipv6_mask = 0;\n-\trule->mask.dst_ipv6_mask = 0;\n \n \t/**\n \t * The first not void item should be\n@@ -1922,9 +1918,9 @@ ixgbe_parse_fdir_filter_normal(struct rte_eth_dev *dev,\n \n \t\t/* check src addr mask */\n \t\tfor (j = 0; j < 16; j++) {\n-\t\t\tif (ipv6_mask->hdr.src_addr[j] == UINT8_MAX) {\n-\t\t\t\trule->mask.src_ipv6_mask |= 1 << j;\n-\t\t\t} else if (ipv6_mask->hdr.src_addr[j] != 0) {\n+\t\t\tif (ipv6_mask->hdr.src_addr[j] == 0) {\n+\t\t\t\trule->mask.src_ipv6_mask &= ~(1 << j);\n+\t\t\t} else if (ipv6_mask->hdr.src_addr[j] != UINT8_MAX) {\n \t\t\t\tmemset(rule, 0, sizeof(struct ixgbe_fdir_rule));\n \t\t\t\trte_flow_error_set(error, EINVAL,\n \t\t\t\t\tRTE_FLOW_ERROR_TYPE_ITEM,\n@@ -1935,9 +1931,9 @@ ixgbe_parse_fdir_filter_normal(struct rte_eth_dev *dev,\n \n \t\t/* check dst addr mask */\n \t\tfor (j = 0; j < 16; j++) {\n-\t\t\tif (ipv6_mask->hdr.dst_addr[j] == UINT8_MAX) {\n-\t\t\t\trule->mask.dst_ipv6_mask |= 1 << j;\n-\t\t\t} else if (ipv6_mask->hdr.dst_addr[j] != 0) {\n+\t\t\tif (ipv6_mask->hdr.dst_addr[j] == 0) {\n+\t\t\t\trule->mask.dst_ipv6_mask &= ~(1 << j);\n+\t\t\t} else if (ipv6_mask->hdr.dst_addr[j] != UINT8_MAX) {\n \t\t\t\tmemset(rule, 0, sizeof(struct ixgbe_fdir_rule));\n \t\t\t\trte_flow_error_set(error, EINVAL,\n \t\t\t\t\tRTE_FLOW_ERROR_TYPE_ITEM,\n", "prefixes": [] }