Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/124644/?format=api
{ "id": 124644, "url": "https://patches.dpdk.org/api/patches/124644/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20230302103527.931071-7-mingxia.liu@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230302103527.931071-7-mingxia.liu@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20230302103527.931071-7-mingxia.liu@intel.com", "date": "2023-03-02T10:35:12", "name": "[v8,06/21] net/cpfl: support queue stop", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "26e4833e21e277a2578fc0f28956f1167e02efde", "submitter": { "id": 2514, "url": "https://patches.dpdk.org/api/people/2514/?format=api", "name": "Liu, Mingxia", "email": "mingxia.liu@intel.com" }, "delegate": { "id": 319, "url": "https://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20230302103527.931071-7-mingxia.liu@intel.com/mbox/", "series": [ { "id": 27215, "url": "https://patches.dpdk.org/api/series/27215/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=27215", "date": "2023-03-02T10:35:06", "name": "add support for cpfl PMD in DPDK", "version": 8, "mbox": "https://patches.dpdk.org/series/27215/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/124644/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/124644/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id B7CD041DB0;\n\tThu, 2 Mar 2023 03:21:21 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id DD18442D16;\n\tThu, 2 Mar 2023 03:20:46 +0100 (CET)", "from mga17.intel.com (mga17.intel.com [192.55.52.151])\n by mails.dpdk.org (Postfix) with ESMTP id 95CD442D0B\n for <dev@dpdk.org>; Thu, 2 Mar 2023 03:20:45 +0100 (CET)", "from fmsmga002.fm.intel.com ([10.253.24.26])\n by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 01 Mar 2023 18:20:45 -0800", "from dpdk-mingxial-ice.sh.intel.com ([10.67.110.191])\n by fmsmga002.fm.intel.com with ESMTP; 01 Mar 2023 18:20:43 -0800" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1677723645; x=1709259645;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=KwwHexi44aEamDtbJ8B9i/g7P5Q8n3P039BlHfaclfM=;\n b=U5FLNsNqtQk9u0AUMAmiEKoNwVujMt5pD458cRioC8ATOqGMu8YMRYsC\n shcGKrToCSw2kItAy5HxipfZdXf191arihQYB4JO/tgKwMHwajS3kVQyJ\n glqNHPwkADd34G6K/YgF/ppSOUGYqMYR8lqxcNz8cq8bApYUaVqXUGI5w\n oH//22NuIGmQ4dgReVndZ6FRWfwu4fMiKlYOn/JRvTayy4MYhMBBJphz/\n WRmCZcUCBUrRxuLPjOEUoBhAnSOMyU69TXl1aDnwCPWVydlGhnn01XDZa\n 8xt0xofrQ3HzOL2D0p56bdE3h5tEBGNRbkw1K8f77vvn0AeoqFQHf8s16 w==;", "X-IronPort-AV": [ "E=McAfee;i=\"6500,9779,10636\"; a=\"315013536\"", "E=Sophos;i=\"5.98,226,1673942400\"; d=\"scan'208\";a=\"315013536\"", "E=McAfee;i=\"6500,9779,10636\"; a=\"784607480\"", "E=Sophos;i=\"5.98,226,1673942400\"; d=\"scan'208\";a=\"784607480\"" ], "X-ExtLoop1": "1", "From": "Mingxia Liu <mingxia.liu@intel.com>", "To": "dev@dpdk.org,\n\tbeilei.xing@intel.com,\n\tyuying.zhang@intel.com", "Cc": "Mingxia Liu <mingxia.liu@intel.com>", "Subject": "[PATCH v8 06/21] net/cpfl: support queue stop", "Date": "Thu, 2 Mar 2023 10:35:12 +0000", "Message-Id": "<20230302103527.931071-7-mingxia.liu@intel.com>", "X-Mailer": "git-send-email 2.34.1", "In-Reply-To": "<20230302103527.931071-1-mingxia.liu@intel.com>", "References": "<20230216003010.3439881-1-mingxia.liu@intel.com>\n <20230302103527.931071-1-mingxia.liu@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Add support for these device ops:\n - rx_queue_stop\n - tx_queue_stop\n\nSigned-off-by: Mingxia Liu <mingxia.liu@intel.com>\n---\n drivers/net/cpfl/cpfl_ethdev.c | 10 +++-\n drivers/net/cpfl/cpfl_rxtx.c | 98 ++++++++++++++++++++++++++++++++++\n drivers/net/cpfl/cpfl_rxtx.h | 3 ++\n 3 files changed, 110 insertions(+), 1 deletion(-)", "diff": "diff --git a/drivers/net/cpfl/cpfl_ethdev.c b/drivers/net/cpfl/cpfl_ethdev.c\nindex 3248d22d2f..00672142e3 100644\n--- a/drivers/net/cpfl/cpfl_ethdev.c\n+++ b/drivers/net/cpfl/cpfl_ethdev.c\n@@ -229,12 +229,16 @@ cpfl_dev_start(struct rte_eth_dev *dev)\n \tret = idpf_vc_vport_ena_dis(vport, true);\n \tif (ret != 0) {\n \t\tPMD_DRV_LOG(ERR, \"Failed to enable vport\");\n-\t\treturn ret;\n+\t\tgoto err_vport;\n \t}\n \n \tvport->stopped = 0;\n \n \treturn 0;\n+\n+err_vport:\n+\tcpfl_stop_queues(dev);\n+\treturn ret;\n }\n \n static int\n@@ -247,6 +251,8 @@ cpfl_dev_stop(struct rte_eth_dev *dev)\n \n \tidpf_vc_vport_ena_dis(vport, false);\n \n+\tcpfl_stop_queues(dev);\n+\n \tvport->stopped = 1;\n \n \treturn 0;\n@@ -281,6 +287,8 @@ static const struct eth_dev_ops cpfl_eth_dev_ops = {\n \t.link_update\t\t\t= cpfl_dev_link_update,\n \t.rx_queue_start\t\t\t= cpfl_rx_queue_start,\n \t.tx_queue_start\t\t\t= cpfl_tx_queue_start,\n+\t.rx_queue_stop\t\t\t= cpfl_rx_queue_stop,\n+\t.tx_queue_stop\t\t\t= cpfl_tx_queue_stop,\n \t.dev_supported_ptypes_get\t= cpfl_dev_supported_ptypes_get,\n };\n \ndiff --git a/drivers/net/cpfl/cpfl_rxtx.c b/drivers/net/cpfl/cpfl_rxtx.c\nindex c13166b63c..08db01412e 100644\n--- a/drivers/net/cpfl/cpfl_rxtx.c\n+++ b/drivers/net/cpfl/cpfl_rxtx.c\n@@ -49,6 +49,14 @@ cpfl_tx_offload_convert(uint64_t offload)\n \treturn ol;\n }\n \n+static const struct idpf_rxq_ops def_rxq_ops = {\n+\t.release_mbufs = idpf_qc_rxq_mbufs_release,\n+};\n+\n+static const struct idpf_txq_ops def_txq_ops = {\n+\t.release_mbufs = idpf_qc_txq_mbufs_release,\n+};\n+\n static const struct rte_memzone *\n cpfl_dma_zone_reserve(struct rte_eth_dev *dev, uint16_t queue_idx,\n \t\t uint16_t len, uint16_t queue_type,\n@@ -177,6 +185,7 @@ cpfl_rx_split_bufq_setup(struct rte_eth_dev *dev, struct idpf_rx_queue *rxq,\n \tidpf_qc_split_rx_bufq_reset(bufq);\n \tbufq->qrx_tail = hw->hw_addr + (vport->chunks_info.rx_buf_qtail_start +\n \t\t\t queue_idx * vport->chunks_info.rx_buf_qtail_spacing);\n+\tbufq->ops = &def_rxq_ops;\n \tbufq->q_set = true;\n \n \tif (bufq_id == IDPF_RX_SPLIT_BUFQ1_ID) {\n@@ -287,6 +296,7 @@ cpfl_rx_queue_setup(struct rte_eth_dev *dev, uint16_t queue_idx,\n \t\tidpf_qc_single_rx_queue_reset(rxq);\n \t\trxq->qrx_tail = hw->hw_addr + (vport->chunks_info.rx_qtail_start +\n \t\t\t\tqueue_idx * vport->chunks_info.rx_qtail_spacing);\n+\t\trxq->ops = &def_rxq_ops;\n \t} else {\n \t\tidpf_qc_split_rx_descq_reset(rxq);\n \n@@ -461,6 +471,7 @@ cpfl_tx_queue_setup(struct rte_eth_dev *dev, uint16_t queue_idx,\n \n \ttxq->qtx_tail = hw->hw_addr + (vport->chunks_info.tx_qtail_start +\n \t\t\tqueue_idx * vport->chunks_info.tx_qtail_spacing);\n+\ttxq->ops = &def_txq_ops;\n \ttxq->q_set = true;\n \tdev->data->tx_queues[queue_idx] = txq;\n \n@@ -612,3 +623,90 @@ cpfl_tx_queue_start(struct rte_eth_dev *dev, uint16_t tx_queue_id)\n \n \treturn err;\n }\n+\n+int\n+cpfl_rx_queue_stop(struct rte_eth_dev *dev, uint16_t rx_queue_id)\n+{\n+\tstruct idpf_vport *vport = dev->data->dev_private;\n+\tstruct idpf_rx_queue *rxq;\n+\tint err;\n+\n+\tif (rx_queue_id >= dev->data->nb_rx_queues)\n+\t\treturn -EINVAL;\n+\n+\terr = idpf_vc_queue_switch(vport, rx_queue_id, true, false);\n+\tif (err != 0) {\n+\t\tPMD_DRV_LOG(ERR, \"Failed to switch RX queue %u off\",\n+\t\t\t rx_queue_id);\n+\t\treturn err;\n+\t}\n+\n+\trxq = dev->data->rx_queues[rx_queue_id];\n+\tif (vport->rxq_model == VIRTCHNL2_QUEUE_MODEL_SINGLE) {\n+\t\trxq->ops->release_mbufs(rxq);\n+\t\tidpf_qc_single_rx_queue_reset(rxq);\n+\t} else {\n+\t\trxq->bufq1->ops->release_mbufs(rxq->bufq1);\n+\t\trxq->bufq2->ops->release_mbufs(rxq->bufq2);\n+\t\tidpf_qc_split_rx_queue_reset(rxq);\n+\t}\n+\tdev->data->rx_queue_state[rx_queue_id] = RTE_ETH_QUEUE_STATE_STOPPED;\n+\n+\treturn 0;\n+}\n+\n+int\n+cpfl_tx_queue_stop(struct rte_eth_dev *dev, uint16_t tx_queue_id)\n+{\n+\tstruct idpf_vport *vport = dev->data->dev_private;\n+\tstruct idpf_tx_queue *txq;\n+\tint err;\n+\n+\tif (tx_queue_id >= dev->data->nb_tx_queues)\n+\t\treturn -EINVAL;\n+\n+\terr = idpf_vc_queue_switch(vport, tx_queue_id, false, false);\n+\tif (err != 0) {\n+\t\tPMD_DRV_LOG(ERR, \"Failed to switch TX queue %u off\",\n+\t\t\t tx_queue_id);\n+\t\treturn err;\n+\t}\n+\n+\ttxq = dev->data->tx_queues[tx_queue_id];\n+\ttxq->ops->release_mbufs(txq);\n+\tif (vport->txq_model == VIRTCHNL2_QUEUE_MODEL_SINGLE) {\n+\t\tidpf_qc_single_tx_queue_reset(txq);\n+\t} else {\n+\t\tidpf_qc_split_tx_descq_reset(txq);\n+\t\tidpf_qc_split_tx_complq_reset(txq->complq);\n+\t}\n+\tdev->data->tx_queue_state[tx_queue_id] = RTE_ETH_QUEUE_STATE_STOPPED;\n+\n+\treturn 0;\n+}\n+\n+void\n+cpfl_stop_queues(struct rte_eth_dev *dev)\n+{\n+\tstruct idpf_rx_queue *rxq;\n+\tstruct idpf_tx_queue *txq;\n+\tint i;\n+\n+\tfor (i = 0; i < dev->data->nb_rx_queues; i++) {\n+\t\trxq = dev->data->rx_queues[i];\n+\t\tif (rxq == NULL)\n+\t\t\tcontinue;\n+\n+\t\tif (cpfl_rx_queue_stop(dev, i) != 0)\n+\t\t\tPMD_DRV_LOG(WARNING, \"Fail to stop Rx queue %d\", i);\n+\t}\n+\n+\tfor (i = 0; i < dev->data->nb_tx_queues; i++) {\n+\t\ttxq = dev->data->tx_queues[i];\n+\t\tif (txq == NULL)\n+\t\t\tcontinue;\n+\n+\t\tif (cpfl_tx_queue_stop(dev, i) != 0)\n+\t\t\tPMD_DRV_LOG(WARNING, \"Fail to stop Tx queue %d\", i);\n+\t}\n+}\ndiff --git a/drivers/net/cpfl/cpfl_rxtx.h b/drivers/net/cpfl/cpfl_rxtx.h\nindex 716b2fefa4..e9b810deaa 100644\n--- a/drivers/net/cpfl/cpfl_rxtx.h\n+++ b/drivers/net/cpfl/cpfl_rxtx.h\n@@ -32,4 +32,7 @@ int cpfl_rx_queue_init(struct rte_eth_dev *dev, uint16_t rx_queue_id);\n int cpfl_rx_queue_start(struct rte_eth_dev *dev, uint16_t rx_queue_id);\n int cpfl_tx_queue_init(struct rte_eth_dev *dev, uint16_t tx_queue_id);\n int cpfl_tx_queue_start(struct rte_eth_dev *dev, uint16_t tx_queue_id);\n+void cpfl_stop_queues(struct rte_eth_dev *dev);\n+int cpfl_tx_queue_stop(struct rte_eth_dev *dev, uint16_t tx_queue_id);\n+int cpfl_rx_queue_stop(struct rte_eth_dev *dev, uint16_t rx_queue_id);\n #endif /* _CPFL_RXTX_H_ */\n", "prefixes": [ "v8", "06/21" ] }