Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/124504/?format=api
{ "id": 124504, "url": "https://patches.dpdk.org/api/patches/124504/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20230224081642.2566619-15-david.marchand@redhat.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230224081642.2566619-15-david.marchand@redhat.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20230224081642.2566619-15-david.marchand@redhat.com", "date": "2023-02-24T08:16:42", "name": "[14/14] enable lock check", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "adbdd29b8874e9d5c5de199c437680f845a45b13", "submitter": { "id": 1173, "url": "https://patches.dpdk.org/api/people/1173/?format=api", "name": "David Marchand", "email": "david.marchand@redhat.com" }, "delegate": { "id": 1, "url": "https://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20230224081642.2566619-15-david.marchand@redhat.com/mbox/", "series": [ { "id": 27167, "url": "https://patches.dpdk.org/api/series/27167/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=27167", "date": "2023-02-24T08:16:28", "name": "Enable lock annotations on most libraries and drivers", "version": 1, "mbox": "https://patches.dpdk.org/series/27167/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/124504/comments/", "check": "fail", "checks": "https://patches.dpdk.org/api/patches/124504/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id B23B441D5D;\n\tFri, 24 Feb 2023 09:18:24 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 844CB40697;\n\tFri, 24 Feb 2023 09:17:43 +0100 (CET)", "from us-smtp-delivery-124.mimecast.com\n (us-smtp-delivery-124.mimecast.com [170.10.129.124])\n by mails.dpdk.org (Postfix) with ESMTP id 4B7EC4113D\n for <dev@dpdk.org>; Fri, 24 Feb 2023 09:17:42 +0100 (CET)", "from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com\n [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS\n (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n us-mta-47-xrhyPvTRPAWGJ1oj3WRmtQ-1; Fri, 24 Feb 2023 03:17:38 -0500", "from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com\n [10.11.54.3])\n (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n (No client certificate requested)\n by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 8E26E1C05AFB;\n Fri, 24 Feb 2023 08:17:36 +0000 (UTC)", "from dmarchan.redhat.com (unknown [10.45.224.55])\n by smtp.corp.redhat.com (Postfix) with ESMTP id 278201121315;\n Fri, 24 Feb 2023 08:17:32 +0000 (UTC)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1677226661;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=zTdKAsfU6rHWPaDywfC6VbQKozW84Mrn5zWEqJ/zf7o=;\n b=cyUOL38FKL36V1Jp8EPUT41X+HXl36Ea85whCuzUYJHmvpSqAsxyl7LpiFqbTiCH+Ql501\n fzAw1l4Xu7zyp3uIMA9GMaJd01XrULkHShW/JtGyLwCafaakBlBR7ANLM98PPSZbzqhYWd\n myhzX+C5WPadgg5VukNFdLrNzl4J19k=", "X-MC-Unique": "xrhyPvTRPAWGJ1oj3WRmtQ-1", "From": "David Marchand <david.marchand@redhat.com>", "To": "dev@dpdk.org", "Cc": "thomas@monjalon.net, Anatoly Burakov <anatoly.burakov@intel.com>,\n Hemant Agrawal <hemant.agrawal@nxp.com>,\n Sachin Saxena <sachin.saxena@nxp.com>,\n Nithin Dabilpuram <ndabilpuram@marvell.com>,\n Kiran Kumar K <kirankumark@marvell.com>,\n Sunil Kumar Kori <skori@marvell.com>, Satha Rao <skoteshwar@marvell.com>,\n Matan Azrad <matan@nvidia.com>,\n Viacheslav Ovsiienko <viacheslavo@nvidia.com>,\n Pavan Nikhilesh <pbhagavatula@marvell.com>,\n Shijith Thotton <sthotton@marvell.com>, Rasesh Mody <rmody@marvell.com>,\n Shahed Shaikh <shshaikh@marvell.com>,\n Ajit Khaparde <ajit.khaparde@broadcom.com>,\n Somnath Kotur <somnath.kotur@broadcom.com>,\n John Daley <johndale@cisco.com>, Hyong Youb Kim <hyonkim@cisco.com>,\n Dongdong Liu <liudongdong3@huawei.com>,\n Yisen Zhuang <yisen.zhuang@huawei.com>,\n Konstantin Ananyev <konstantin.v.ananyev@yandex.ru>,\n Vladimir Medvedkin <vladimir.medvedkin@intel.com>,\n Erik Gabriel Carrillo <erik.g.carrillo@intel.com>,\n Maxime Coquelin <maxime.coquelin@redhat.com>,\n Chenbo Xia <chenbo.xia@intel.com>", "Subject": "[PATCH 14/14] enable lock check", "Date": "Fri, 24 Feb 2023 09:16:42 +0100", "Message-Id": "<20230224081642.2566619-15-david.marchand@redhat.com>", "In-Reply-To": "<20230224081642.2566619-1-david.marchand@redhat.com>", "References": "<20230224081642.2566619-1-david.marchand@redhat.com>", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 3.1 on 10.11.54.3", "X-Mimecast-Spam-Score": "0", "X-Mimecast-Originator": "redhat.com", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain; charset=\"US-ASCII\"; x-default=true", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Now that a lot of components can be compiled with the lock checks,\ninvert the logic and opt out for components not ready yet:\n- drivers/bus/dpaa,\n- drivers/common/cnxk,\n- drivers/common/mlx5,\n- drivers/event/cnxk,\n- drivers/net/bnx2x,\n- drivers/net/bnxt,\n- drivers/net/cnxk,\n- drivers/net/enic,\n- drivers/net/hns3,\n- drivers/net/mlx5,\n- lib/ipsec,\n- lib/timer,\n\nSigned-off-by: David Marchand <david.marchand@redhat.com>\n---\n doc/guides/prog_guide/env_abstraction_layer.rst | 5 +++--\n drivers/bus/dpaa/meson.build | 1 +\n drivers/common/cnxk/meson.build | 1 +\n drivers/common/mlx5/meson.build | 1 +\n drivers/event/cnxk/meson.build | 1 +\n drivers/meson.build | 2 +-\n drivers/net/bnx2x/meson.build | 1 +\n drivers/net/bnxt/meson.build | 1 +\n drivers/net/cnxk/meson.build | 1 +\n drivers/net/enic/meson.build | 1 +\n drivers/net/hns3/meson.build | 1 +\n drivers/net/mlx5/meson.build | 1 +\n lib/ipsec/meson.build | 1 +\n lib/meson.build | 2 +-\n lib/timer/meson.build | 1 +\n lib/vhost/meson.build | 1 -\n 16 files changed, 17 insertions(+), 5 deletions(-)", "diff": "diff --git a/doc/guides/prog_guide/env_abstraction_layer.rst b/doc/guides/prog_guide/env_abstraction_layer.rst\nindex 3f33621e05..93c8a031be 100644\n--- a/doc/guides/prog_guide/env_abstraction_layer.rst\n+++ b/doc/guides/prog_guide/env_abstraction_layer.rst\n@@ -550,8 +550,9 @@ Some general comments:\n waiving checks with ``__rte_no_thread_safety_analysis`` in your code, please\n discuss it on the mailing list,\n \n-A DPDK library/driver can enable/disable the checks by setting\n-``annotate_locks`` accordingly in its ``meson.build`` file.\n+The checks are enabled by default for libraries and drivers.\n+They can be disabled by setting ``annotate_locks`` to ``false`` in\n+the concerned library/driver ``meson.build``.\n \n IOVA Mode Detection\n ~~~~~~~~~~~~~~~~~~~\ndiff --git a/drivers/bus/dpaa/meson.build b/drivers/bus/dpaa/meson.build\nindex 5506f2bffc..183b251459 100644\n--- a/drivers/bus/dpaa/meson.build\n+++ b/drivers/bus/dpaa/meson.build\n@@ -29,3 +29,4 @@ if cc.has_argument('-Wno-pointer-arith')\n endif\n \n includes += include_directories('include', 'base/qbman')\n+annotate_locks = false\ndiff --git a/drivers/common/cnxk/meson.build b/drivers/common/cnxk/meson.build\nindex 849735921c..9beb1cddba 100644\n--- a/drivers/common/cnxk/meson.build\n+++ b/drivers/common/cnxk/meson.build\n@@ -88,3 +88,4 @@ sources += files('cnxk_telemetry_bphy.c',\n \n deps += ['bus_pci', 'net', 'telemetry']\n pmd_supports_disable_iova_as_pa = true\n+annotate_locks = false\ndiff --git a/drivers/common/mlx5/meson.build b/drivers/common/mlx5/meson.build\nindex 60ccd95cbc..d38255dc82 100644\n--- a/drivers/common/mlx5/meson.build\n+++ b/drivers/common/mlx5/meson.build\n@@ -40,3 +40,4 @@ endif\n mlx5_config = configuration_data()\n subdir(exec_env)\n configure_file(output: 'mlx5_autoconf.h', configuration: mlx5_config)\n+annotate_locks = false\ndiff --git a/drivers/event/cnxk/meson.build b/drivers/event/cnxk/meson.build\nindex aa42ab3a90..20c6a0484a 100644\n--- a/drivers/event/cnxk/meson.build\n+++ b/drivers/event/cnxk/meson.build\n@@ -480,3 +480,4 @@ endforeach\n \n deps += ['bus_pci', 'common_cnxk', 'net_cnxk', 'crypto_cnxk']\n pmd_supports_disable_iova_as_pa = true\n+annotate_locks = false\ndiff --git a/drivers/meson.build b/drivers/meson.build\nindex 0618c31a69..d529980fc5 100644\n--- a/drivers/meson.build\n+++ b/drivers/meson.build\n@@ -91,7 +91,7 @@ foreach subpath:subdirs\n build = true # set to false to disable, e.g. missing deps\n reason = '<unknown reason>' # set if build == false to explain\n name = drv\n- annotate_locks = false\n+ annotate_locks = true\n sources = []\n headers = []\n driver_sdk_headers = [] # public headers included by drivers\ndiff --git a/drivers/net/bnx2x/meson.build b/drivers/net/bnx2x/meson.build\nindex 156f97d31f..dbf9c7225d 100644\n--- a/drivers/net/bnx2x/meson.build\n+++ b/drivers/net/bnx2x/meson.build\n@@ -21,3 +21,4 @@ sources = files(\n 'ecore_sp.c',\n 'elink.c',\n )\n+annotate_locks = false\ndiff --git a/drivers/net/bnxt/meson.build b/drivers/net/bnxt/meson.build\nindex 09d494e90f..f43dbfc445 100644\n--- a/drivers/net/bnxt/meson.build\n+++ b/drivers/net/bnxt/meson.build\n@@ -68,3 +68,4 @@ if arch_subdir == 'x86'\n elif arch_subdir == 'arm' and dpdk_conf.get('RTE_ARCH_64')\n sources += files('bnxt_rxtx_vec_neon.c')\n endif\n+annotate_locks = false\ndiff --git a/drivers/net/cnxk/meson.build b/drivers/net/cnxk/meson.build\nindex c7ca24d437..86ed2d13dd 100644\n--- a/drivers/net/cnxk/meson.build\n+++ b/drivers/net/cnxk/meson.build\n@@ -196,3 +196,4 @@ endforeach\n \n headers = files('rte_pmd_cnxk.h')\n pmd_supports_disable_iova_as_pa = true\n+annotate_locks = false\ndiff --git a/drivers/net/enic/meson.build b/drivers/net/enic/meson.build\nindex 7131a25f09..1523511ba5 100644\n--- a/drivers/net/enic/meson.build\n+++ b/drivers/net/enic/meson.build\n@@ -39,3 +39,4 @@ elif cc.has_argument('-mavx2') and dpdk_conf.get('RTE_ARCH_64')\n c_args: [cflags, '-mavx2'])\n objs += enic_avx2_lib.extract_objects('enic_rxtx_vec_avx2.c')\n endif\n+annotate_locks = false\ndiff --git a/drivers/net/hns3/meson.build b/drivers/net/hns3/meson.build\nindex e1a5afa2ec..43e52e6107 100644\n--- a/drivers/net/hns3/meson.build\n+++ b/drivers/net/hns3/meson.build\n@@ -38,6 +38,7 @@ sources = files(\n 'hns3_common.c',\n 'hns3_dump.c',\n )\n+annotate_locks = false\n \n deps += ['hash']\n \ndiff --git a/drivers/net/mlx5/meson.build b/drivers/net/mlx5/meson.build\nindex abd507bd88..5e7d0d4e1a 100644\n--- a/drivers/net/mlx5/meson.build\n+++ b/drivers/net/mlx5/meson.build\n@@ -79,3 +79,4 @@ testpmd_sources += files('mlx5_testpmd.c')\n subdir(exec_env)\n \n subdir('hws')\n+annotate_locks = false\ndiff --git a/lib/ipsec/meson.build b/lib/ipsec/meson.build\nindex 0b8b935cd2..ff44d6fbdf 100644\n--- a/lib/ipsec/meson.build\n+++ b/lib/ipsec/meson.build\n@@ -13,5 +13,6 @@ sources = files('esp_inb.c', 'esp_outb.c',\n \n headers = files('rte_ipsec.h', 'rte_ipsec_sa.h', 'rte_ipsec_sad.h')\n indirect_headers += files('rte_ipsec_group.h')\n+annotate_locks = false\n \n deps += ['mbuf', 'net', 'cryptodev', 'security', 'hash', 'telemetry']\ndiff --git a/lib/meson.build b/lib/meson.build\nindex 2bc0932ad5..9b5e412454 100644\n--- a/lib/meson.build\n+++ b/lib/meson.build\n@@ -120,7 +120,7 @@ foreach l:libraries\n reason = '<unknown reason>' # set if build == false to explain why\n name = l\n use_function_versioning = false\n- annotate_locks = false\n+ annotate_locks = true\n sources = []\n headers = []\n indirect_headers = [] # public headers not directly included by apps\ndiff --git a/lib/timer/meson.build b/lib/timer/meson.build\nindex 89b17e0397..87bbb10592 100644\n--- a/lib/timer/meson.build\n+++ b/lib/timer/meson.build\n@@ -3,3 +3,4 @@\n \n sources = files('rte_timer.c')\n headers = files('rte_timer.h')\n+annotate_locks = false\ndiff --git a/lib/vhost/meson.build b/lib/vhost/meson.build\nindex 197a51d936..0d1abf6283 100644\n--- a/lib/vhost/meson.build\n+++ b/lib/vhost/meson.build\n@@ -18,7 +18,6 @@ endif\n dpdk_conf.set('RTE_LIBRTE_VHOST_POSTCOPY', cc.has_header('linux/userfaultfd.h'))\n cflags += '-fno-strict-aliasing'\n \n-annotate_locks = true\n sources = files(\n 'fd_man.c',\n 'iotlb.c',\n", "prefixes": [ "14/14" ] }