Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/124192/?format=api
{ "id": 124192, "url": "https://patches.dpdk.org/api/patches/124192/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20230220164103.3041538-4-david.marchand@redhat.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230220164103.3041538-4-david.marchand@redhat.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20230220164103.3041538-4-david.marchand@redhat.com", "date": "2023-02-20T16:40:57", "name": "[v2,3/9] app/testpmd: rework ieee1588 engine fwd configuration", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "e4dd961a4dfcca9bcb7145a5526ae5208461159d", "submitter": { "id": 1173, "url": "https://patches.dpdk.org/api/people/1173/?format=api", "name": "David Marchand", "email": "david.marchand@redhat.com" }, "delegate": { "id": 319, "url": "https://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20230220164103.3041538-4-david.marchand@redhat.com/mbox/", "series": [ { "id": 27089, "url": "https://patches.dpdk.org/api/series/27089/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=27089", "date": "2023-02-20T16:40:54", "name": "Testpmd code cleanup", "version": 2, "mbox": "https://patches.dpdk.org/series/27089/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/124192/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/124192/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 9465C41CEC;\n\tMon, 20 Feb 2023 17:41:49 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 7EF5F430B1;\n\tMon, 20 Feb 2023 17:41:45 +0100 (CET)", "from us-smtp-delivery-124.mimecast.com\n (us-smtp-delivery-124.mimecast.com [170.10.129.124])\n by mails.dpdk.org (Postfix) with ESMTP id CE380430AE\n for <dev@dpdk.org>; Mon, 20 Feb 2023 17:41:43 +0100 (CET)", "from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com\n [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS\n (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n us-mta-433-3iuF3qoCMIO9NoW96ayOjQ-1; Mon, 20 Feb 2023 11:41:40 -0500", "from smtp.corp.redhat.com (int-mx10.intmail.prod.int.rdu2.redhat.com\n [10.11.54.10])\n (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))\n (No client certificate requested)\n by mimecast-mx02.redhat.com (Postfix) with ESMTPS id DE84538123A3;\n Mon, 20 Feb 2023 16:41:39 +0000 (UTC)", "from dmarchan.redhat.com (unknown [10.45.224.55])\n by smtp.corp.redhat.com (Postfix) with ESMTP id D7A3A492B00;\n Mon, 20 Feb 2023 16:41:38 +0000 (UTC)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1676911303;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=fWiSG1Ux7y6BujLhoys+3EZU3EOHRDJZThF41O4yP9s=;\n b=cYf7oC/3YEQ+5Rb5MWompv56yJJZDYClLKg3t1dePDzol0/clvM2qgW+CFUmhNJlutoh2i\n HJVN9+YTndJvbKrYTqNPoHEPc4Lm6/XmaqojmxUlDKe86UNhvBi9g5+xmAy0YzAOp268uB\n RBt0DYRQ2havqTFuPZi8IG/Vh0fLasU=", "X-MC-Unique": "3iuF3qoCMIO9NoW96ayOjQ-1", "From": "David Marchand <david.marchand@redhat.com>", "To": "dev@dpdk.org", "Cc": "Ferruh Yigit <ferruh.yigit@amd.com>,\n Aman Singh <aman.deep.singh@intel.com>,\n Yuying Zhang <yuying.zhang@intel.com>, Robin Jarry <rjarry@redhat.com>", "Subject": "[PATCH v2 3/9] app/testpmd: rework ieee1588 engine fwd configuration", "Date": "Mon, 20 Feb 2023 17:40:57 +0100", "Message-Id": "<20230220164103.3041538-4-david.marchand@redhat.com>", "In-Reply-To": "<20230220164103.3041538-1-david.marchand@redhat.com>", "References": "<20230124104742.1265439-1-david.marchand@redhat.com>\n <20230220164103.3041538-1-david.marchand@redhat.com>", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 3.1 on 10.11.54.10", "X-Mimecast-Spam-Score": "0", "X-Mimecast-Originator": "redhat.com", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain; charset=\"US-ASCII\"; x-default=true", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "This fwd engine currently ignores the forwarding configuration.\nForce it explicitly when initialising the stream.\nThe code is then more consistent with other fwd engines (i.e. receiving\non fs->rx_port, transmitting on fs->tx_port).\n\nSigned-off-by: David Marchand <david.marchand@redhat.com>\n---\n app/test-pmd/ieee1588fwd.c | 9 ++++++---\n 1 file changed, 6 insertions(+), 3 deletions(-)", "diff": "diff --git a/app/test-pmd/ieee1588fwd.c b/app/test-pmd/ieee1588fwd.c\nindex 896d5ef26a..242d272948 100644\n--- a/app/test-pmd/ieee1588fwd.c\n+++ b/app/test-pmd/ieee1588fwd.c\n@@ -184,8 +184,8 @@ ieee1588_packet_fwd(struct fwd_stream *fs)\n \n \t/* Forward PTP packet with hardware TX timestamp */\n \tmb->ol_flags |= RTE_MBUF_F_TX_IEEE1588_TMST;\n-\tif (rte_eth_tx_burst(fs->rx_port, fs->tx_queue, &mb, 1) == 0) {\n-\t\tprintf(\"Port %u sent PTP packet dropped\\n\", fs->rx_port);\n+\tif (rte_eth_tx_burst(fs->tx_port, fs->tx_queue, &mb, 1) == 0) {\n+\t\tprintf(\"Port %u sent PTP packet dropped\\n\", fs->tx_port);\n \t\tfs->fwd_dropped += 1;\n \t\trte_pktmbuf_free(mb);\n \t\treturn;\n@@ -195,7 +195,7 @@ ieee1588_packet_fwd(struct fwd_stream *fs)\n \t/*\n \t * Check the TX timestamp.\n \t */\n-\tport_ieee1588_tx_timestamp_check(fs->rx_port);\n+\tport_ieee1588_tx_timestamp_check(fs->tx_port);\n }\n \n static int\n@@ -216,6 +216,9 @@ port_ieee1588_stream_init(struct fwd_stream *fs)\n {\n \tbool rx_stopped, tx_stopped;\n \n+\t/* Force transmission on reception port */\n+\tfs->tx_port = fs->rx_port;\n+\n \trx_stopped = ports[fs->rx_port].rxq[fs->rx_queue].state ==\n \t\t\t\t\t\tRTE_ETH_QUEUE_STATE_STOPPED;\n \ttx_stopped = ports[fs->tx_port].txq[fs->tx_queue].state ==\n", "prefixes": [ "v2", "3/9" ] }