Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/124182/?format=api
{ "id": 124182, "url": "https://patches.dpdk.org/api/patches/124182/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20230220090049.54088-1-fengchengwen@huawei.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230220090049.54088-1-fengchengwen@huawei.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20230220090049.54088-1-fengchengwen@huawei.com", "date": "2023-02-20T09:00:49", "name": "[v2] net/hns3: support IOVA as VA", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "40b3e8996ef2249d0208d0dd501443bae2f1d446", "submitter": { "id": 2146, "url": "https://patches.dpdk.org/api/people/2146/?format=api", "name": "fengchengwen", "email": "fengchengwen@huawei.com" }, "delegate": { "id": 1, "url": "https://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20230220090049.54088-1-fengchengwen@huawei.com/mbox/", "series": [ { "id": 27084, "url": "https://patches.dpdk.org/api/series/27084/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=27084", "date": "2023-02-20T09:00:49", "name": "[v2] net/hns3: support IOVA as VA", "version": 2, "mbox": "https://patches.dpdk.org/series/27084/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/124182/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/124182/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id E8B0E41CE5;\n\tMon, 20 Feb 2023 10:07:18 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id CFD2B42FC6;\n\tMon, 20 Feb 2023 10:07:18 +0100 (CET)", "from szxga08-in.huawei.com (szxga08-in.huawei.com [45.249.212.255])\n by mails.dpdk.org (Postfix) with ESMTP id CD23242FBA\n for <dev@dpdk.org>; Mon, 20 Feb 2023 10:07:17 +0100 (CET)", "from dggpeml500024.china.huawei.com (unknown [172.30.72.54])\n by szxga08-in.huawei.com (SkyGuard) with ESMTP id 4PKxM44kvnz16Nt7;\n Mon, 20 Feb 2023 17:04:48 +0800 (CST)", "from localhost.localdomain (10.50.163.32) by\n dggpeml500024.china.huawei.com (7.185.36.10) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id\n 15.1.2507.17; Mon, 20 Feb 2023 17:07:15 +0800" ], "From": "Chengwen Feng <fengchengwen@huawei.com>", "To": "<thomas@monjalon.net>, <ferruh.yigit@amd.com>, Ruifeng Wang\n <ruifeng.wang@arm.com>, Dongdong Liu <liudongdong3@huawei.com>, Yisen Zhuang\n <yisen.zhuang@huawei.com>", "CC": "<dev@dpdk.org>, Chengwen Feng <fengchengwen@huawei.com>", "Subject": "[PATCH v2] net/hns3: support IOVA as VA", "Date": "Mon, 20 Feb 2023 09:00:49 +0000", "Message-ID": "<20230220090049.54088-1-fengchengwen@huawei.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20230214071141.50155-1-fengchengwen@huawei.com>", "References": "<20230214071141.50155-1-fengchengwen@huawei.com>", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-Originating-IP": "[10.50.163.32]", "X-ClientProxiedBy": "dggems706-chm.china.huawei.com (10.3.19.183) To\n dggpeml500024.china.huawei.com (7.185.36.10)", "X-CFilter-Loop": "Reflected", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Claim PMD supports pmd_supports_disable_iova_as_pa.\n\nSigned-off-by: Chengwen Feng <fengchengwen@huawei.com>\nReviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>\nAcked-by: Dongdong Liu <liudongdong3@huawei.com>\n\n---\nv2: modify commit head which address Thomas's comment\n add reviewed and acked by of v1.\n\n---\n drivers/net/hns3/hns3_rxtx_vec_neon.h | 2 +-\n drivers/net/hns3/hns3_rxtx_vec_sve.c | 13 +++++++++----\n drivers/net/hns3/meson.build | 7 +------\n 3 files changed, 11 insertions(+), 11 deletions(-)", "diff": "diff --git a/drivers/net/hns3/hns3_rxtx_vec_neon.h b/drivers/net/hns3/hns3_rxtx_vec_neon.h\nindex 55d9bf817d..6c49c70fc7 100644\n--- a/drivers/net/hns3/hns3_rxtx_vec_neon.h\n+++ b/drivers/net/hns3/hns3_rxtx_vec_neon.h\n@@ -13,7 +13,7 @@ static inline void\n hns3_vec_tx(volatile struct hns3_desc *desc, struct rte_mbuf *pkt)\n {\n \tuint64x2_t val1 = {\n-\t\tpkt->buf_iova + pkt->data_off,\n+\t\trte_pktmbuf_iova(pkt),\n \t\t((uint64_t)pkt->data_len) << HNS3_TXD_SEND_SIZE_SHIFT\n \t};\n \tuint64x2_t val2 = {\ndiff --git a/drivers/net/hns3/hns3_rxtx_vec_sve.c b/drivers/net/hns3/hns3_rxtx_vec_sve.c\nindex 6f23ba674d..4bf933882a 100644\n--- a/drivers/net/hns3/hns3_rxtx_vec_sve.c\n+++ b/drivers/net/hns3/hns3_rxtx_vec_sve.c\n@@ -261,10 +261,10 @@ hns3_rxq_rearm_mbuf_sve(struct hns3_rx_queue *rxq)\n \tfor (i = 0; i < HNS3_DEFAULT_RXQ_REARM_THRESH; i += REARM_LOOP_STEP_NUM,\n \t\trxep += REARM_LOOP_STEP_NUM, rxdp += REARM_LOOP_STEP_NUM) {\n \t\tuint64_t iova[REARM_LOOP_STEP_NUM];\n-\t\tiova[0] = rxep[0].mbuf->buf_iova;\n-\t\tiova[1] = rxep[1].mbuf->buf_iova;\n-\t\tiova[2] = rxep[2].mbuf->buf_iova;\n-\t\tiova[3] = rxep[3].mbuf->buf_iova;\n+\t\tiova[0] = rte_mbuf_iova_get(rxep[0].mbuf);\n+\t\tiova[1] = rte_mbuf_iova_get(rxep[1].mbuf);\n+\t\tiova[2] = rte_mbuf_iova_get(rxep[2].mbuf);\n+\t\tiova[3] = rte_mbuf_iova_get(rxep[3].mbuf);\n \t\tsvuint64_t siova = svld1_u64(PG64_256BIT, iova);\n \t\tsiova = svadd_n_u64_z(PG64_256BIT, siova, RTE_PKTMBUF_HEADROOM);\n \t\tsvuint64_t ol_base = svdup_n_u64(0);\n@@ -397,8 +397,13 @@ hns3_tx_fill_hw_ring_sve(struct hns3_tx_queue *txq,\n \t\tpg = svwhilelt_b64_u32(i, nb_pkts);\n \t\tbase_addr = svld1_u64(pg, (uint64_t *)pkts);\n \t\t/* calc mbuf's field buf_iova address */\n+#if RTE_IOVA_AS_PA\n \t\tbuf_iova = svadd_n_u64_z(pg, base_addr,\n \t\t\t\t\t offsetof(struct rte_mbuf, buf_iova));\n+#else\n+\t\tbuf_iova = svadd_n_u64_z(pg, base_addr,\n+\t\t\t\t\t offsetof(struct rte_mbuf, buf_addr));\n+#endif\n \t\t/* calc mbuf's field data_off address */\n \t\tdata_off = svadd_n_u64_z(pg, base_addr,\n \t\t\t\t\t offsetof(struct rte_mbuf, data_off));\ndiff --git a/drivers/net/hns3/meson.build b/drivers/net/hns3/meson.build\nindex e1a5afa2ec..b8c0f80a20 100644\n--- a/drivers/net/hns3/meson.build\n+++ b/drivers/net/hns3/meson.build\n@@ -13,12 +13,6 @@ if arch_subdir != 'x86' and arch_subdir != 'arm' or not dpdk_conf.get('RTE_ARCH_\n subdir_done()\n endif\n \n-if dpdk_conf.get('RTE_IOVA_AS_PA') == 0\n- build = false\n- reason = 'driver does not support disabling IOVA as PA mode'\n- subdir_done()\n-endif\n-\n sources = files(\n 'hns3_cmd.c',\n 'hns3_dcb.c',\n@@ -38,6 +32,7 @@ sources = files(\n 'hns3_common.c',\n 'hns3_dump.c',\n )\n+pmd_supports_disable_iova_as_pa = true\n \n deps += ['hash']\n \n", "prefixes": [ "v2" ] }